From 83759b9a4aeb5a9ce3aade515c3c676d2ef5f1bb Mon Sep 17 00:00:00 2001 From: bymyself Date: Sun, 2 Feb 2025 19:02:48 -0700 Subject: [PATCH] Use command label as header text in change keybinding dialog (#2404) --- browser_tests/dialog.spec.ts | 2 +- src/components/dialog/content/setting/KeybindingPanel.vue | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/browser_tests/dialog.spec.ts b/browser_tests/dialog.spec.ts index e17234c62..9479a0917 100644 --- a/browser_tests/dialog.spec.ts +++ b/browser_tests/dialog.spec.ts @@ -253,7 +253,7 @@ test.describe('Settings', () => { // Save keybinding const saveButton = comfyPage.page - .getByLabel('Comfy.NewBlankWorkflow') + .getByLabel('New Blank Workflow') .getByLabel('Save') await saveButton.click() diff --git a/src/components/dialog/content/setting/KeybindingPanel.vue b/src/components/dialog/content/setting/KeybindingPanel.vue index fbad90535..70387c699 100644 --- a/src/components/dialog/content/setting/KeybindingPanel.vue +++ b/src/components/dialog/content/setting/KeybindingPanel.vue @@ -68,7 +68,7 @@ class="min-w-96" v-model:visible="editDialogVisible" modal - :header="currentEditingCommand?.id" + :header="currentEditingCommand?.label" @hide="cancelEdit" >
@@ -151,6 +151,7 @@ const { t } = useI18n() interface ICommandData { id: string keybinding: KeybindingImpl | null + label: string } const commandsData = computed(() => {