From 83ea8d4e8a2c9b208c49a6ff4fccfc05196ea14e Mon Sep 17 00:00:00 2001
From: pythongosssss <125205205+pythongosssss@users.noreply.github.com>
Date: Fri, 10 Jul 2026 05:39:48 -0700
Subject: [PATCH] fix: mark live warnings seen reliably while panel is open

markAllSeen inside a watchEffect mutates its own dependency; the
recursion guard drops the subscription after a mount-time clear, so
warnings arriving while the panel was open stayed unseen. Use an
immediate watch instead and pin the regression in the component test
---
 .../sidebar/tabs/DeprecationWarningsTab.test.ts   |  1 +
 .../sidebar/tabs/DeprecationWarningsTab.vue       | 15 +++++++++++----
 2 files changed, 12 insertions(+), 4 deletions(-)

diff --git a/src/components/sidebar/tabs/DeprecationWarningsTab.test.ts b/src/components/sidebar/tabs/DeprecationWarningsTab.test.ts
index 6356e0f660..b597f9cb11 100644
--- a/src/components/sidebar/tabs/DeprecationWarningsTab.test.ts
+++ b/src/components/sidebar/tabs/DeprecationWarningsTab.test.ts
@@ -266,6 +266,7 @@ describe('DeprecationWarningsTab', () => {
 
   it('marks warnings seen as they arrive while the panel is open', async () => {
     const store = useDeprecationWarningsStore()
+    store.report({ message: 'before mount' })
     renderTab()
 
     store.report({ message: 'arrived while open' })
diff --git a/src/components/sidebar/tabs/DeprecationWarningsTab.vue b/src/components/sidebar/tabs/DeprecationWarningsTab.vue
index ce38114320..ecc24f1978 100644
--- a/src/components/sidebar/tabs/DeprecationWarningsTab.vue
+++ b/src/components/sidebar/tabs/DeprecationWarningsTab.vue
@@ -139,7 +139,7 @@
 <script setup lang="ts">
 import { useIntervalFn } from '@vueuse/core'
 import type { MenuItem } from 'primevue/menuitem'
-import { computed, ref, watch, watchEffect } from 'vue'
+import { computed, ref, watch } from 'vue'
 import { useI18n } from 'vue-i18n'
 
 import Badge from '@/components/common/Badge.vue'
@@ -231,7 +231,14 @@ function warningMenuItems(warning: { key: string }): MenuItem[] {
   ]
 }
 
-watchEffect(() => {
-  if (store.unseenCount > 0) store.markAllSeen()
-})
+// watch, not watchEffect: markAllSeen mutates the watched source, and a
+// watchEffect's recursion guard drops the subscription after a mount-time
+// clear, leaving warnings that arrive while the panel is open unseen forever.
+watch(
+  () => store.unseenCount,
+  (count) => {
+    if (count > 0) store.markAllSeen()
+  },
+  { immediate: true }
+)
 </script>