From 51f0f111ea122cd28bedf1665ef4d4af9439c1e8 Mon Sep 17 00:00:00 2001 From: Simula_r <18093452+simula-r@users.noreply.github.com> Date: Mon, 6 Oct 2025 14:45:53 -0700 Subject: [PATCH 01/18] refactor: remove unused tooltip appendTo code (#5943) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ## Summary Remove unused tooltip appendTo positioning code. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-5943-refactor-remove-unused-tooltip-appendTo-code-2846d73d365081d99c00cd41e35eb496) by [Unito](https://www.unito.io) --------- Co-authored-by: Jake Schroeder --- .../vueNodes/components/InputSlot.vue | 7 +--- .../vueNodes/components/LGraphNode.vue | 3 +- .../vueNodes/components/NodeHeader.test.ts | 3 -- .../vueNodes/components/NodeHeader.vue | 7 +--- .../vueNodes/components/NodeWidgets.vue | 7 +--- .../vueNodes/components/OutputSlot.vue | 7 +--- .../vueNodes/composables/useNodeTooltips.ts | 41 ++++++------------- 7 files changed, 20 insertions(+), 55 deletions(-) diff --git a/src/renderer/extensions/vueNodes/components/InputSlot.vue b/src/renderer/extensions/vueNodes/components/InputSlot.vue index e74688181..e0e01c9ca 100644 --- a/src/renderer/extensions/vueNodes/components/InputSlot.vue +++ b/src/renderer/extensions/vueNodes/components/InputSlot.vue @@ -27,9 +27,7 @@ diff --git a/src/renderer/extensions/vueNodes/components/NodeHeader.test.ts b/src/renderer/extensions/vueNodes/components/NodeHeader.test.ts index 472427e8f..c00b898e0 100644 --- a/src/renderer/extensions/vueNodes/components/NodeHeader.test.ts +++ b/src/renderer/extensions/vueNodes/components/NodeHeader.test.ts @@ -101,9 +101,6 @@ const createMountConfig = () => { updated: vi.fn(), unmounted: vi.fn() } - }, - provide: { - tooltipContainer: { value: document.createElement('div') } } } } diff --git a/src/renderer/extensions/vueNodes/components/NodeHeader.vue b/src/renderer/extensions/vueNodes/components/NodeHeader.vue index b48a54b53..51aae33cc 100644 --- a/src/renderer/extensions/vueNodes/components/NodeHeader.vue +++ b/src/renderer/extensions/vueNodes/components/NodeHeader.vue @@ -62,7 +62,7 @@ diff --git a/src/components/graph/selectionToolbox/InfoButton.vue b/src/components/graph/selectionToolbox/InfoButton.vue index 3fd159d89..3b50c016f 100644 --- a/src/components/graph/selectionToolbox/InfoButton.vue +++ b/src/components/graph/selectionToolbox/InfoButton.vue @@ -9,7 +9,7 @@ severity="secondary" @click="toggleHelp" > - + diff --git a/src/components/graph/selectionToolbox/MenuOptionItem.vue b/src/components/graph/selectionToolbox/MenuOptionItem.vue index ee88a47d9..3c059a4d1 100644 --- a/src/components/graph/selectionToolbox/MenuOptionItem.vue +++ b/src/components/graph/selectionToolbox/MenuOptionItem.vue @@ -14,10 +14,10 @@ {{ option.shortcut }} - - + diff --git a/src/components/graph/selectionToolbox/RefreshSelectionButton.vue b/src/components/graph/selectionToolbox/RefreshSelectionButton.vue index 0da7364a0..57d29d707 100644 --- a/src/components/graph/selectionToolbox/RefreshSelectionButton.vue +++ b/src/components/graph/selectionToolbox/RefreshSelectionButton.vue @@ -7,7 +7,7 @@ data-testid="refresh-button" @click="refreshSelected" > - + diff --git a/src/components/graph/selectionToolbox/SaveToSubgraphLibrary.vue b/src/components/graph/selectionToolbox/SaveToSubgraphLibrary.vue index 7f76d2eab..3fb876a02 100644 --- a/src/components/graph/selectionToolbox/SaveToSubgraphLibrary.vue +++ b/src/components/graph/selectionToolbox/SaveToSubgraphLibrary.vue @@ -10,7 +10,7 @@ @click="() => commandStore.execute('Comfy.PublishSubgraph')" > diff --git a/src/components/graph/selectionToolbox/SubmenuPopover.vue b/src/components/graph/selectionToolbox/SubmenuPopover.vue index 2f1e25229..653c950b8 100644 --- a/src/components/graph/selectionToolbox/SubmenuPopover.vue +++ b/src/components/graph/selectionToolbox/SubmenuPopover.vue @@ -32,9 +32,9 @@ :style="{ backgroundColor: subOption.color }" /> diff --git a/src/components/sidebar/SidebarShortcutsToggleButton.vue b/src/components/sidebar/SidebarShortcutsToggleButton.vue index cbe558008..6fb6e66bf 100644 --- a/src/components/sidebar/SidebarShortcutsToggleButton.vue +++ b/src/components/sidebar/SidebarShortcutsToggleButton.vue @@ -5,7 +5,7 @@ @click="toggleShortcutsPanel" > diff --git a/src/components/sidebar/tabs/nodeLibrary/NodeTreeLeaf.vue b/src/components/sidebar/tabs/nodeLibrary/NodeTreeLeaf.vue index b0f64f196..fb52d8c85 100644 --- a/src/components/sidebar/tabs/nodeLibrary/NodeTreeLeaf.vue +++ b/src/components/sidebar/tabs/nodeLibrary/NodeTreeLeaf.vue @@ -32,7 +32,7 @@ @click.stop="editBlueprint" > diff --git a/src/components/widget/SampleModelSelector.vue b/src/components/widget/SampleModelSelector.vue index a9d9f35bb..b17074c73 100644 --- a/src/components/widget/SampleModelSelector.vue +++ b/src/components/widget/SampleModelSelector.vue @@ -3,7 +3,7 @@ diff --git a/src/components/widget/layout/BaseModalLayout.vue b/src/components/widget/layout/BaseModalLayout.vue index 023e3be43..f88535279 100644 --- a/src/components/widget/layout/BaseModalLayout.vue +++ b/src/components/widget/layout/BaseModalLayout.vue @@ -5,7 +5,7 @@ :class="rightPanelButtonClasses" @click="toggleRightPanel" > - + @@ -29,8 +29,11 @@
- - + +
@@ -40,7 +43,7 @@ v-if="isRightPanelOpen && hasRightPanel" @click="toggleRightPanel" > - +
diff --git a/src/components/widget/nav/NavItem.vue b/src/components/widget/nav/NavItem.vue index f5bd09431..d334260fa 100644 --- a/src/components/widget/nav/NavItem.vue +++ b/src/components/widget/nav/NavItem.vue @@ -10,7 +10,7 @@ @click="onClick" > - + diff --git a/src/components/widget/panel/PanelHeader.vue b/src/components/widget/panel/PanelHeader.vue index 9f00ed9e7..13df123f4 100644 --- a/src/components/widget/panel/PanelHeader.vue +++ b/src/components/widget/panel/PanelHeader.vue @@ -2,7 +2,7 @@
- +

diff --git a/src/platform/assets/components/AssetCard.vue b/src/platform/assets/components/AssetCard.vue index 90b8734bc..765323bf6 100644 --- a/src/platform/assets/components/AssetCard.vue +++ b/src/platform/assets/components/AssetCard.vue @@ -66,15 +66,15 @@ " > - + {{ asset.stats.stars }} - + {{ asset.stats.downloadCount }} - + {{ asset.stats.formattedDate }}

diff --git a/src/platform/assets/components/AssetFilterBar.vue b/src/platform/assets/components/AssetFilterBar.vue index 1d3fb0e7f..5ffb5d0af 100644 --- a/src/platform/assets/components/AssetFilterBar.vue +++ b/src/platform/assets/components/AssetFilterBar.vue @@ -32,7 +32,7 @@ @update:model-value="handleFilterChange" > diff --git a/src/platform/assets/components/AssetGrid.vue b/src/platform/assets/components/AssetGrid.vue index 35122fd52..cbc44054b 100644 --- a/src/platform/assets/components/AssetGrid.vue +++ b/src/platform/assets/components/AssetGrid.vue @@ -27,7 +27,7 @@ ) " > - +

{{ $t('assetBrowser.noAssetsFound') }}

@@ -39,7 +39,8 @@ v-if="loading" class="col-span-full flex items-center justify-center py-16" > -

{{ commandLineArgs }}

diff --git a/src/renderer/extensions/minimap/MiniMap.vue b/src/renderer/extensions/minimap/MiniMap.vue index 40f23bc27..db38e697b 100644 --- a/src/renderer/extensions/minimap/MiniMap.vue +++ b/src/renderer/extensions/minimap/MiniMap.vue @@ -28,7 +28,7 @@ @click.stop="toggleOptionsPanel" > diff --git a/src/renderer/extensions/minimap/MiniMapPanel.vue b/src/renderer/extensions/minimap/MiniMapPanel.vue index 378e1f69d..5458deab8 100644 --- a/src/renderer/extensions/minimap/MiniMapPanel.vue +++ b/src/renderer/extensions/minimap/MiniMapPanel.vue @@ -13,7 +13,7 @@ (value) => $emit('updateOption', 'Comfy.Minimap.NodeColors', value) " /> - +
@@ -27,7 +27,7 @@ (value) => $emit('updateOption', 'Comfy.Minimap.ShowLinks', value) " /> - + @@ -41,7 +41,7 @@ (value) => $emit('updateOption', 'Comfy.Minimap.ShowGroups', value) " /> - + @@ -56,7 +56,7 @@ $emit('updateOption', 'Comfy.Minimap.RenderBypassState', value) " /> - + @@ -71,7 +71,7 @@ $emit('updateOption', 'Comfy.Minimap.RenderErrorState', value) " /> - + diff --git a/src/renderer/extensions/vueNodes/VideoPreview.vue b/src/renderer/extensions/vueNodes/VideoPreview.vue index 334ac55c6..5c95fdaa6 100644 --- a/src/renderer/extensions/vueNodes/VideoPreview.vue +++ b/src/renderer/extensions/vueNodes/VideoPreview.vue @@ -19,7 +19,7 @@ v-if="videoError" class="w-full h-[352px] flex flex-col items-center justify-center text-white text-center bg-gray-800/50" > - +

{{ $t('g.videoFailedToLoad') }}

{{ getVideoFilename(currentVideoUrl) }} @@ -54,7 +54,7 @@ :aria-label="$t('g.downloadVideo')" @click="handleDownload" > - + @@ -64,7 +64,7 @@ :aria-label="$t('g.removeVideo')" @click="handleRemove" > - + diff --git a/src/renderer/extensions/vueNodes/components/ImagePreview.vue b/src/renderer/extensions/vueNodes/components/ImagePreview.vue index 7bc05d437..a31c3633b 100644 --- a/src/renderer/extensions/vueNodes/components/ImagePreview.vue +++ b/src/renderer/extensions/vueNodes/components/ImagePreview.vue @@ -19,7 +19,7 @@ v-if="imageError" class="w-full h-[352px] flex flex-col items-center justify-center text-white text-center bg-gray-800/50" > - +

{{ $t('g.imageFailedToLoad') }}

{{ getImageFilename(currentImageUrl) }} @@ -53,7 +53,7 @@ :aria-label="$t('g.editOrMaskImage')" @click="handleEditMask" > - + @@ -63,7 +63,7 @@ :aria-label="$t('g.downloadImage')" @click="handleDownload" > - + @@ -73,7 +73,7 @@ :aria-label="$t('g.removeImage')" @click="handleRemove" > - + diff --git a/src/renderer/extensions/vueNodes/components/NodeHeader.vue b/src/renderer/extensions/vueNodes/components/NodeHeader.vue index 7b4332a8c..5f0cc03ab 100644 --- a/src/renderer/extensions/vueNodes/components/NodeHeader.vue +++ b/src/renderer/extensions/vueNodes/components/NodeHeader.vue @@ -50,9 +50,9 @@ @edit="handleTitleEdit" @cancel="handleTitleCancel" /> - diff --git a/src/renderer/extensions/vueNodes/widgets/components/form/dropdown/FormDropdownInput.vue b/src/renderer/extensions/vueNodes/widgets/components/form/dropdown/FormDropdownInput.vue index b8ea74fd3..b27cc705a 100644 --- a/src/renderer/extensions/vueNodes/widgets/components/form/dropdown/FormDropdownInput.vue +++ b/src/renderer/extensions/vueNodes/widgets/components/form/dropdown/FormDropdownInput.vue @@ -73,7 +73,7 @@ const theButtonStyle = computed(() => {{ selectedItems.map((item) => (item as any)?.name).join(', ') }} - +