mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-01-26 19:09:52 +00:00
docs: require design approval for notable UI changes (#7629)
Clarify design-team approval requirement for notable UI changes. - Add a Design Team Approval section in CONTRIBUTING that states notable UI changes must be requested by or approved by the design team and applies to OSS contributors. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7629-docs-require-design-approval-for-notable-UI-changes-2ce6d73d36508151a894d683dda85c2e) by [Unito](https://www.unito.io)
This commit is contained in:
@@ -181,6 +181,10 @@ pnpm format
|
||||
- Use Tailwind CSS classes instead of custom CSS
|
||||
- NEVER use `dark:` or `dark-theme:` tailwind variants. Instead use a semantic value from the [style.css](packages/design-system/src/css/style.css) like `bg-node-component-surface`
|
||||
|
||||
## Design Team Approval (Required for Notable UI Changes)
|
||||
|
||||
Changes that materially affect the default UI must be approved or requested by our design team before they can be merged. This is generally a blocking requirement and applies to internal contributors and OSS contributors alike.
|
||||
|
||||
### Internationalization
|
||||
|
||||
- All user-facing strings must use vue-i18n
|
||||
|
||||
Reference in New Issue
Block a user