diff --git a/.github/workflows/i18n.yaml b/.github/workflows/i18n.yaml index d7df815ff..6a5f7de50 100644 --- a/.github/workflows/i18n.yaml +++ b/.github/workflows/i18n.yaml @@ -11,7 +11,8 @@ on: jobs: update-locales: # Branch detection: Only run for manual dispatch or version-bump-* branches from main repo - if: github.event_name == 'workflow_dispatch' || (github.event.pull_request.head.repo.full_name == github.repository && startsWith(github.head_ref, 'version-bump-')) + # note(sno): && startsWith(github.head_ref, 'sno-fix-playwright') allows this workflow to run in bug-fixing PR + if: github.event_name == 'workflow_dispatch' || (github.event.pull_request.head.repo.full_name == github.repository && startsWith(github.head_ref, 'version-bump-')) && startsWith(github.head_ref, 'sno-fix-playwright') runs-on: ubuntu-latest steps: - uses: Comfy-Org/ComfyUI_frontend_setup_action@v3 diff --git a/browser_tests/globalSetupWithI18n.ts b/browser_tests/globalSetupWithI18n.ts index 4837ba4f4..7a6a0b293 100644 --- a/browser_tests/globalSetupWithI18n.ts +++ b/browser_tests/globalSetupWithI18n.ts @@ -1,30 +1,5 @@ -/** - * Combined global setup for i18n collection tests - * Includes both regular setup and litegraph preprocessing - */ -import globalSetup from './globalSetup' import { preprocessLitegraph } from './i18nSetup' export default async function globalSetupWithI18n() { - // First preprocess litegraph files await preprocessLitegraph() - - // Then run regular global setup - await globalSetup() - - // Register cleanup handlers - const cleanup = async () => { - const { restoreLitegraph } = await import('./i18nSetup') - await restoreLitegraph() - } - - process.on('exit', cleanup) - process.on('SIGINT', async () => { - await cleanup() - process.exit(0) - }) - process.on('SIGTERM', async () => { - await cleanup() - process.exit(0) - }) } diff --git a/browser_tests/globalTeardownWithI18n.ts b/browser_tests/globalTeardownWithI18n.ts index 22e29711d..a8960695b 100644 --- a/browser_tests/globalTeardownWithI18n.ts +++ b/browser_tests/globalTeardownWithI18n.ts @@ -1,14 +1,5 @@ -/** - * Combined global teardown for i18n collection tests - * Includes both regular teardown and litegraph restoration - */ -import globalTeardown from './globalTeardown' import { restoreLitegraph } from './i18nSetup' export default async function globalTeardownWithI18n() { - // First run regular teardown - await globalTeardown() - - // Then restore litegraph files await restoreLitegraph() } diff --git a/browser_tests/i18nSetup.ts b/browser_tests/i18nSetup.ts index 10b374b93..97ba69e6a 100644 --- a/browser_tests/i18nSetup.ts +++ b/browser_tests/i18nSetup.ts @@ -15,6 +15,7 @@ const backupMap = new Map() /** * Find all TypeScript files in litegraph that contain 'declare' keywords + * perf: this fn reads about 90+ files and costs 70ms */ async function findFilesWithDeclare(): Promise { // Search for all .ts files in litegraph src directory @@ -22,7 +23,6 @@ async function findFilesWithDeclare(): Promise { const files = await glob(pattern, { ignore: ['**/*.test.ts', '**/*.spec.ts', '**/node_modules/**'] }) - // Filter to only files that actually contain 'declare' keyword const filesWithDeclare = await Promise.all( files.map(async (filePath) => { diff --git a/src/locales/en/settings.json b/src/locales/en/settings.json index 15e57ff0e..4b42417bc 100644 --- a/src/locales/en/settings.json +++ b/src/locales/en/settings.json @@ -388,13 +388,10 @@ "Topbar (2nd-row)": "Topbar (2nd-row)" } }, -<<<<<<< Updated upstream "LiteGraph_Canvas_LowQualityRenderingZoomThreshold": { "name": "Low quality rendering zoom threshold", "tooltip": "Zoom level threshold for performance mode. Lower values (0.1) = quality at all zoom levels. Higher values (1.0) = performance mode even when zoomed in. Performance mode simplifies rendering by hiding text labels, shadows, and details." }, -======= ->>>>>>> Stashed changes "LiteGraph_Canvas_MaximumFps": { "name": "Maximum FPS", "tooltip": "The maximum frames per second that the canvas is allowed to render. Caps GPU usage at the cost of smoothness. If 0, the screen refresh rate is used. Default: 0"