From 8f7ee4e9a33d8c8ce51a214d1e1d8fed302a8500 Mon Sep 17 00:00:00 2001 From: Johnpaul Chiwetelu <49923152+Myestery@users.noreply.github.com> Date: Tue, 2 Sep 2025 19:02:15 +0100 Subject: [PATCH] Re-Route Support to Zendesk (#5259) * refactor: replace feedback command with contact support in Help Center menu * refactor: replace feedback dialog with external support link in Help menu * refactor: simplify error reporting UI by removing send report functionality * refactor: remove issue report dialog and update support contact method * refactor: remove IssueReportDialog and associated components * refactor: remove unused issue report schema * refactor: remove unused issue report types * refactor: remove unused issue report fields from localization files --- browser_tests/tests/dialog.spec.ts | 49 +-- .../dialog/content/ErrorDialogContent.vue | 38 +- .../content/IssueReportDialogContent.vue | 33 -- .../content/error/ReportIssuePanel.spec.ts | 338 ----------------- .../dialog/content/error/ReportIssuePanel.vue | 348 ------------------ .../dialog/content/setting/CreditsPanel.vue | 15 +- .../helpcenter/HelpCenterMenuContent.vue | 2 +- src/composables/useCoreCommands.ts | 25 +- src/constants/coreMenuCommands.ts | 5 +- src/locales/ar/main.json | 32 +- src/locales/en/main.json | 32 +- src/locales/es/main.json | 32 +- src/locales/fr/main.json | 32 +- src/locales/ja/main.json | 32 +- src/locales/ko/main.json | 32 +- src/locales/ru/main.json | 32 +- src/locales/zh-TW/main.json | 32 +- src/locales/zh/main.json | 32 +- src/schemas/issueReportSchema.ts | 28 -- src/services/dialogService.ts | 12 - src/types/issueReportTypes.ts | 51 --- 21 files changed, 25 insertions(+), 1207 deletions(-) delete mode 100644 src/components/dialog/content/IssueReportDialogContent.vue delete mode 100644 src/components/dialog/content/error/ReportIssuePanel.spec.ts delete mode 100644 src/components/dialog/content/error/ReportIssuePanel.vue delete mode 100644 src/schemas/issueReportSchema.ts delete mode 100644 src/types/issueReportTypes.ts diff --git a/browser_tests/tests/dialog.spec.ts b/browser_tests/tests/dialog.spec.ts index bdfcd392f..8ac7449f4 100644 --- a/browser_tests/tests/dialog.spec.ts +++ b/browser_tests/tests/dialog.spec.ts @@ -59,18 +59,6 @@ test.describe('Execution error', () => { const executionError = comfyPage.page.locator('.comfy-error-report') await expect(executionError).toBeVisible() }) - - test('Can display Issue Report form', async ({ comfyPage }) => { - await comfyPage.loadWorkflow('nodes/execution_error') - await comfyPage.queueButton.click() - await comfyPage.nextFrame() - - await comfyPage.page.getByLabel('Help Fix This').click() - const issueReportForm = comfyPage.page.getByText( - 'Submit Error Report (Optional)' - ) - await expect(issueReportForm).toBeVisible() - }) }) test.describe('Missing models warning', () => { @@ -303,37 +291,16 @@ test.describe('Settings', () => { }) }) -test.describe('Feedback dialog', () => { - test('Should open from topmenu help command', async ({ comfyPage }) => { - // Open feedback dialog from top menu +test.describe('Support', () => { + test('Should open external zendesk link', async ({ comfyPage }) => { await comfyPage.setSetting('Comfy.UseNewMenu', 'Top') - await comfyPage.menu.topbar.triggerTopbarCommand(['Help', 'Feedback']) + const pagePromise = comfyPage.page.context().waitForEvent('page') + await comfyPage.menu.topbar.triggerTopbarCommand(['Help', 'Support']) + const newPage = await pagePromise - // Verify feedback dialog content is visible - const feedbackHeader = comfyPage.page.getByRole('heading', { - name: 'Feedback' - }) - await expect(feedbackHeader).toBeVisible() - }) - - test('Should close when close button clicked', async ({ comfyPage }) => { - // Open feedback dialog - await comfyPage.setSetting('Comfy.UseNewMenu', 'Top') - await comfyPage.menu.topbar.triggerTopbarCommand(['Help', 'Feedback']) - - const feedbackHeader = comfyPage.page.getByRole('heading', { - name: 'Feedback' - }) - - // Close feedback dialog - await comfyPage.page - .getByLabel('', { exact: true }) - .getByLabel('Close') - .click() - await feedbackHeader.waitFor({ state: 'hidden' }) - - // Verify dialog is closed - await expect(feedbackHeader).not.toBeVisible() + await newPage.waitForLoadState('networkidle') + await expect(newPage).toHaveURL(/.*support\.comfy\.org.*/) + await newPage.close() }) }) diff --git a/src/components/dialog/content/ErrorDialogContent.vue b/src/components/dialog/content/ErrorDialogContent.vue index bdf10482a..4f35511cf 100644 --- a/src/components/dialog/content/ErrorDialogContent.vue +++ b/src/components/dialog/content/ErrorDialogContent.vue @@ -21,16 +21,9 @@ @click="showReport" />