From 80013bcd5c7e45249083e328a2f7c1ba9d1a6a1c Mon Sep 17 00:00:00 2001 From: sno Date: Tue, 21 Oct 2025 05:11:22 +0900 Subject: [PATCH 01/17] [bugfix] Fix i18n linting errors (#6170) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ## Summary - Fix i18n linting errors by adding missing locale keys to `src/locales/en/main.json` - Update all affected components to use `$t()` for internationalization ## Changes Added the following locale keys: - `comfyOrgLogoAlt`: "ComfyOrg Logo" - `comfy`: "Comfy" - `pressKeysForNewBinding`: "Press keys for new binding" - `defaultBanner`: "default banner" - `enableOrDisablePack`: "Enable or disable pack" - `openManager`: "Open Manager" - `graphNavigation`: "Graph navigation" Updated components to use i18n keys: - `ComfyOrgHeader.vue` - `KeybindingPanel.vue` - `PackBanner.vue` - `PackIcon.vue` - `PackEnableToggle.vue` - `LoadWorkflowWarning.vue` - `SubgraphBreadcrumb.vue` - `SignInContent.vue` ## Test plan - [x] Run `pnpm lint` - all i18n linting errors resolved - [x] Pre-commit hooks pass Aim to make #5625 CI/CD pass. 🤖 Generated with [Claude Code](https://claude.com/claude-code) ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-6170-bugfix-Fix-i18n-linting-errors-2926d73d365081c3b7fbcbbf4a8e03d6) by [Unito](https://www.unito.io) Co-authored-by: Claude --- src/components/breadcrumb/SubgraphBreadcrumb.vue | 2 +- src/components/dialog/content/LoadWorkflowWarning.vue | 7 ++++++- src/components/dialog/content/SignInContent.vue | 2 +- src/components/dialog/content/setting/KeybindingPanel.vue | 2 +- src/components/dialog/header/ComfyOrgHeader.vue | 2 +- src/locales/en/main.json | 7 +++++++ .../manager/components/manager/button/PackEnableToggle.vue | 4 ++-- .../manager/components/manager/packBanner/PackBanner.vue | 2 +- .../manager/components/manager/packIcon/PackIcon.vue | 2 +- 9 files changed, 21 insertions(+), 9 deletions(-) diff --git a/src/components/breadcrumb/SubgraphBreadcrumb.vue b/src/components/breadcrumb/SubgraphBreadcrumb.vue index 4d6c826718..c5ee7ab71b 100644 --- a/src/components/breadcrumb/SubgraphBreadcrumb.vue +++ b/src/components/breadcrumb/SubgraphBreadcrumb.vue @@ -18,7 +18,7 @@ class="w-fit rounded-lg p-0" :model="items" :pt="{ item: { class: 'pointer-events-auto' } }" - aria-label="Graph navigation" + :aria-label="$t('g.graphNavigation')" > diff --git a/src/components/dialog/content/SignInContent.vue b/src/components/dialog/content/SignInContent.vue index a6bb0e890b..19da831252 100644 --- a/src/components/dialog/content/SignInContent.vue +++ b/src/components/dialog/content/SignInContent.vue @@ -89,7 +89,7 @@ Comfy {{ t('auth.login.useApiKey') }} diff --git a/src/components/dialog/content/setting/KeybindingPanel.vue b/src/components/dialog/content/setting/KeybindingPanel.vue index 6117d5ea8f..861ec9bc6d 100644 --- a/src/components/dialog/content/setting/KeybindingPanel.vue +++ b/src/components/dialog/content/setting/KeybindingPanel.vue @@ -89,7 +89,7 @@ ref="keybindingInput" class="mb-2 text-center" :model-value="newBindingKeyCombo?.toString() ?? ''" - placeholder="Press keys for new binding" + :placeholder="$t('g.pressKeysForNewBinding')" autocomplete="off" fluid @keydown.stop.prevent="captureKeybinding" diff --git a/src/components/dialog/header/ComfyOrgHeader.vue b/src/components/dialog/header/ComfyOrgHeader.vue index 8a8a0afa2c..d4fc3a4589 100644 --- a/src/components/dialog/header/ComfyOrgHeader.vue +++ b/src/components/dialog/header/ComfyOrgHeader.vue @@ -3,7 +3,7 @@
ComfyOrg Logo diff --git a/src/locales/en/main.json b/src/locales/en/main.json index b23d889028..210468449a 100644 --- a/src/locales/en/main.json +++ b/src/locales/en/main.json @@ -36,6 +36,8 @@ "import": "Import", "loadAllFolders": "Load All Folders", "logoAlt": "ComfyUI Logo", + "comfyOrgLogoAlt": "ComfyOrg Logo", + "comfy": "Comfy", "refresh": "Refresh", "refreshNode": "Refresh Node", "terminal": "Terminal", @@ -88,6 +90,11 @@ "no": "No", "cancel": "Cancel", "close": "Close", + "pressKeysForNewBinding": "Press keys for new binding", + "defaultBanner": "default banner", + "enableOrDisablePack": "Enable or disable pack", + "openManager": "Open Manager", + "graphNavigation": "Graph navigation", "dropYourFileOr": "Drop your file or", "back": "Back", "next": "Next", diff --git a/src/workbench/extensions/manager/components/manager/button/PackEnableToggle.vue b/src/workbench/extensions/manager/components/manager/button/PackEnableToggle.vue index be162c5715..c032f5ba93 100644 --- a/src/workbench/extensions/manager/components/manager/button/PackEnableToggle.vue +++ b/src/workbench/extensions/manager/components/manager/button/PackEnableToggle.vue @@ -16,14 +16,14 @@ :model-value="isEnabled" :disabled="isLoading" :readonly="!canToggleDirectly" - aria-label="Enable or disable pack" + :aria-label="$t('g.enableOrDisablePack')" @focus="handleToggleInteraction" />
diff --git a/src/workbench/extensions/manager/components/manager/packBanner/PackBanner.vue b/src/workbench/extensions/manager/components/manager/packBanner/PackBanner.vue index ffb158fa11..cce839e226 100644 --- a/src/workbench/extensions/manager/components/manager/packBanner/PackBanner.vue +++ b/src/workbench/extensions/manager/components/manager/packBanner/PackBanner.vue @@ -4,7 +4,7 @@
default banner
diff --git a/src/workbench/extensions/manager/components/manager/packIcon/PackIcon.vue b/src/workbench/extensions/manager/components/manager/packIcon/PackIcon.vue index 0d753267a0..d1375ff2fb 100644 --- a/src/workbench/extensions/manager/components/manager/packIcon/PackIcon.vue +++ b/src/workbench/extensions/manager/components/manager/packIcon/PackIcon.vue @@ -4,7 +4,7 @@
default banner
From 9ae66c778d86ba93673afc56f3ca0f0c37966780 Mon Sep 17 00:00:00 2001 From: AustinMroz Date: Mon, 20 Oct 2025 20:22:30 -0700 Subject: [PATCH 02/17] Fix nodeDef resolution for virtual nodes. (#6175) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit image Virtual nodes (like primitives) don't have a nodeData. As a result, the existing call to attempt lookup from a node instance fails. This is fixed by adding `node.type` as a fallback ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-6175-Fix-nodeDef-resolution-for-virtual-nodes-2936d73d365081b0abfcfe8532a50f8e) by [Unito](https://www.unito.io) --- src/stores/nodeDefStore.ts | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/stores/nodeDefStore.ts b/src/stores/nodeDefStore.ts index 25e82a93c1..232bba7fbf 100644 --- a/src/stores/nodeDefStore.ts +++ b/src/stores/nodeDefStore.ts @@ -342,8 +342,7 @@ export const useNodeDefStore = defineStore('nodeDef', () => { nodeDefsByDisplayName.value[nodeDef.display_name] = nodeDefImpl } function fromLGraphNode(node: LGraphNode): ComfyNodeDefImpl | null { - // Frontend-only nodes don't have nodeDef - const nodeTypeName = node.constructor?.nodeData?.name + const nodeTypeName = node.constructor?.nodeData?.name ?? node.type if (!nodeTypeName) return null const nodeDef = nodeDefsByName.value[nodeTypeName] ?? null return nodeDef From 6f8789b9aad0f74b7e8a711b505bf4ba05c10ed7 Mon Sep 17 00:00:00 2001 From: filtered <176114999+webfiltered@users.noreply.github.com> Date: Wed, 22 Oct 2025 04:30:52 +1100 Subject: [PATCH 03/17] Fix asset path resolution in desktop GPU picker (#6178) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ## Summary Fixes regression where desktop UI GPU picker images failed to load due to incorrect absolute path resolution. ## Changes - **What**: Converts absolute image paths to relative paths with `./` prefix in GpuPicker component - **Breaking**: None ## Review Focus ESLint rule incorrectly flagged relative paths as errors, leading to use of absolute paths that don't resolve correctly in desktop app context. The change is just adding `.` to the start of two lines. ESLint rules reorganised the rest. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-6178-Fix-asset-path-resolution-in-desktop-GPU-picker-2936d73d3650814e9d0df9faf8e28733) by [Unito](https://www.unito.io) --- .../src/components/install/GpuPicker.vue | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/apps/desktop-ui/src/components/install/GpuPicker.vue b/apps/desktop-ui/src/components/install/GpuPicker.vue index 0a8cac0a95..98dddb7621 100644 --- a/apps/desktop-ui/src/components/install/GpuPicker.vue +++ b/apps/desktop-ui/src/components/install/GpuPicker.vue @@ -1,17 +1,17 @@