Merge branch 'main' into bl-selective-snapshot-update

Resolved conflicts in update-playwright-expectations.yaml by:
- Keeping main's improvements: concurrency control, comment reactions, better branch checkout
- Keeping our selective snapshot update logic with validation
- Keeping our workflow summary generation
- Combined both sets of improvements for a robust solution

Fixed eslint configuration issue where vite.config.mts was in both allowDefaultProject and tsconfig.json

.github/workflows/update-playwright-expectations.yaml

@@ -15,12 +15,16 @@ on:
   issue_comment:
     types: [created]
 
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: true
+
 jobs:
   test:
     runs-on: ubuntu-latest
     if: >
       ( github.event_name == 'pull_request' && github.event.label.name == 'New Browser Test Expectations' ) ||
-      ( github.event.issue.pull_request && 
+      ( github.event.issue.pull_request &&
         github.event_name == 'issue_comment' &&
         (
           github.event.comment.author_association == 'OWNER' ||
@@ -29,17 +33,46 @@ jobs:
         ) &&
         startsWith(github.event.comment.body, '/update-playwright') )
     steps:
+      - name: Find Update Comment
+        uses: peter-evans/find-comment@b30e6a3c0ed37e7c023ccd3f1db5c6c0b0c23aad
+        id: "find-update-comment"
+        with:
+          issue-number: ${{ github.event.number || github.event.issue.number }}
+          comment-author: "github-actions[bot]"
+          body-includes: "Updating Playwright Expectations"
+
+      - name: Add Starting Reaction
+        uses: peter-evans/create-or-update-comment@e8674b075228eee787fea43ef493e45ece1004c9
+        with:
+          comment-id: ${{ steps.find-update-comment.outputs.comment-id }}
+          issue-number: ${{ github.event.number || github.event.issue.number }}
+          body: |
+            Updating Playwright Expectations
+          edit-mode: replace
+          reactions: eyes
+
+      - name: Get Branch SHA
+        id: "get-branch"
+        run: echo ::set-output name=branch::$(gh pr view $PR_NO --repo $REPO --json headRefName --jq '.headRefName')
+        env:
+          REPO: ${{ github.repository }}
+          PR_NO: ${{ github.event.number || github.event.issue.number }}
+          GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+
       - name: Initial Checkout
         uses: actions/checkout@v5
-
-      - name: Pull Request Checkout
-        if: github.event.issue.pull_request && github.event_name == 'issue_comment'
-        run: gh pr checkout ${{ github.event.issue.number }}
-        env:
-          GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        with:
+          ref: ${{ steps.get-branch.outputs.branch }}
 
       - name: Setup Frontend
         uses: ./.github/actions/setup-frontend
+        with:
+          include_build_step: true
+
+      - name: Setup ComfyUI Server
+        uses: ./.github/actions/setup-comfyui-server
+        with:
+          launch_server: true
 
       - name: Setup Playwright
         uses: ./.github/actions/setup-playwright
@@ -96,12 +129,10 @@ jobs:
         with:
           run-id: ${{ steps.locate-manifest.outputs.run_id }}
           name: failed-screenshot-tests
-          path: ComfyUI_frontend/ci-rerun
+          path: ci-rerun
 
       - name: Re-run failed screenshot tests and update snapshots
         id: playwright-tests
-        shell: bash
-        working-directory: ComfyUI_frontend
         continue-on-error: true
         run: |
           set -euo pipefail
@@ -183,27 +214,20 @@ jobs:
         if: always()
         with:
           name: playwright-report
-          path: ComfyUI_frontend/playwright-report/
+          path: ./playwright-report/
           retention-days: 30
 
       - name: Debugging info
-        working-directory: ComfyUI_frontend
         run: |
-          echo "Branch: ${{ github.head_ref }}"
+          echo "PR: ${{ github.event.issue.number }}"
+          echo "Branch: ${{ steps.get-branch.outputs.branch }}"
           git status
 
       - name: Commit updated expectations
         id: commit
-        working-directory: ComfyUI_frontend
         run: |
           git config --global user.name 'github-actions'
           git config --global user.email 'github-actions@github.com'
-          if [ "${{ github.event_name }}" = "issue_comment" ]; then
-            true
-          else
-            git fetch origin ${{ github.head_ref }}
-            git checkout -B ${{ github.head_ref }} origin/${{ github.head_ref }}
-          fi
           git add browser_tests
           if git diff --cached --quiet; then
             echo "No expectation updates detected; skipping commit."
@@ -215,16 +239,11 @@ jobs:
             echo "count=$changed_count" >> $GITHUB_OUTPUT
 
             git commit -m "[automated] Update test expectations"
-            if [ "${{ github.event_name }}" = "issue_comment" ]; then
-              git push
-            else
-              git push origin HEAD:${{ github.head_ref }}
-            fi
+            git push origin ${{ steps.get-branch.outputs.branch }}
           fi
 
       - name: Generate workflow summary
         if: always()
-        working-directory: ComfyUI_frontend
         run: |
           echo "## Snapshot Update Summary" >> $GITHUB_STEP_SUMMARY
           echo "" >> $GITHUB_STEP_SUMMARY
@@ -248,3 +267,18 @@ jobs:
           echo "---" >> $GITHUB_STEP_SUMMARY
           echo "" >> $GITHUB_STEP_SUMMARY
           echo "**Strategy:** Selective snapshot update (only failed tests re-run)" >> $GITHUB_STEP_SUMMARY
+
+      - name: Add Done Reaction
+        uses: peter-evans/create-or-update-comment@e8674b075228eee787fea43ef493e45ece1004c9
+        if: github.event_name == 'issue_comment'
+        with:
+          comment-id: ${{ steps.find-update-comment.outputs.comment-id }}
+          issue-number: ${{ github.event.number || github.event.issue.number }}
+          reactions: +1
+          reactions-edit-mode: replace
+
+      - name: Remove New Browser Test Expectations label
+        if: always() && github.event_name == 'pull_request'
+        run: gh pr edit ${{ github.event.pull_request.number }} --remove-label "New Browser Test Expectations"
+        env:
+          GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}