test: replace expect() with waitFor() in fixture files

Per Playwright best practices, assertions belong in tests, not fixtures.
Fixture methods should use waitFor() for preconditions instead.

- vueNodeFixtures.ts: setTitle(), cancelTitleEdit() use waitFor()
- Topbar.ts: closeTopbarMenu() uses waitFor({ state: 'hidden' })
- ComfyPage.ts: ConfirmDialog.click(), closeDialog(), clickDialogButton(),
  closeToasts() all converted to waitFor()
- templates.ts: renamed waitForMinimumCardCount to expectMinimumCardCount
  to clarify it contains an assertion (uses expect().toPass() pattern)

Amp-Thread-ID: https://ampcode.com/threads/T-019c11f8-acd2-7429-8bec-525ad47a47c4
Co-authored-by: Amp <amp@ampcode.com>

browser_tests/fixtures/ComfyPage.ts

@@ -125,7 +125,7 @@ class ConfirmDialog {
 
   async click(locator: KeysOfType<ConfirmDialog, Locator>) {
     const loc = this[locator]
-    await expect(loc).toBeVisible()
+    await loc.waitFor({ state: 'visible' })
     await loc.click()
 
     // Wait for the dialog mask to disappear after confirming
@@ -514,7 +514,11 @@ export class ComfyPage {
   }
 
   async closeToasts(requireCount = 0) {
-    if (requireCount) await expect(this.visibleToasts).toHaveCount(requireCount)
+    if (requireCount) {
+      await this.visibleToasts
+        .nth(requireCount - 1)
+        .waitFor({ state: 'visible' })
+    }
 
     // Clear all toasts
     const toastCloseButtons = await this.page
@@ -523,7 +527,12 @@ export class ComfyPage {
     for (const button of toastCloseButtons) {
       await button.click()
     }
-    await expect(this.visibleToasts).toHaveCount(0)
+
+    // Wait for toasts to disappear
+    await this.visibleToasts
+      .first()
+      .waitFor({ state: 'hidden', timeout: 1000 })
+      .catch(() => {})
   }
 
   async clickTextEncodeNode1() {
@@ -1447,7 +1456,7 @@ export class ComfyPage {
 
   async closeDialog() {
     await this.page.locator('.p-dialog-close-button').click({ force: true })
-    await expect(this.page.locator('.p-dialog')).toBeHidden()
+    await this.page.locator('.p-dialog').waitFor({ state: 'hidden' })
   }
 
   async resizeNode(
@@ -1547,13 +1556,13 @@ export class ComfyPage {
     const modal = this.page.locator(
       `.comfy-modal-content:has-text("${prompt}")`
     )
-    await expect(modal).toBeVisible()
+    await modal.waitFor({ state: 'visible' })
     await modal
       .locator('.comfyui-button', {
         hasText: buttonText
       })
       .click()
-    await expect(modal).toBeHidden()
+    await modal.waitFor({ state: 'hidden' })
   }
 
   async convertAllNodesToGroupNode(groupNodeName: string) {

browser_tests/fixtures/components/Topbar.ts

@@ -1,5 +1,4 @@
 import type { Locator, Page } from '@playwright/test'
-import { expect } from '@playwright/test'
 
 export class Topbar {
   private readonly menuLocator: Locator
@@ -122,7 +121,7 @@ export class Topbar {
    */
   async closeTopbarMenu() {
     await this.page.locator('body').click({ position: { x: 300, y: 10 } })
-    await expect(this.menuLocator).not.toBeVisible()
+    await this.menuLocator.waitFor({ state: 'hidden' })
   }
 
   /**

browser_tests/fixtures/utils/vueNodeFixtures.ts

@@ -1,4 +1,3 @@
-import { expect } from '@playwright/test'
 import type { Locator } from '@playwright/test'
 
 /** DOM-centric helper for a single Vue-rendered node on the canvas. */
@@ -40,7 +39,7 @@ export class VueNodeFixture {
   async setTitle(value: string): Promise<void> {
     await this.header.dblclick()
     const input = this.titleInput
-    await expect(input).toBeVisible()
+    await input.waitFor({ state: 'visible' })
     await input.fill(value)
     await input.press('Enter')
   }
@@ -48,7 +47,7 @@ export class VueNodeFixture {
   async cancelTitleEdit(): Promise<void> {
     await this.header.dblclick()
     const input = this.titleInput
-    await expect(input).toBeVisible()
+    await input.waitFor({ state: 'visible' })
     await input.press('Escape')
   }
 

browser_tests/helpers/templates.ts

@@ -16,8 +16,8 @@ export class ComfyTemplates {
     this.allTemplateCards = page.locator('[data-testid^="template-workflow-"]')
   }
 
-  async waitForMinimumCardCount(count: number) {
-    return await expect(async () => {
+  async expectMinimumCardCount(count: number) {
+    await expect(async () => {
       const cardCount = await this.allTemplateCards.count()
       expect(cardCount).toBeGreaterThanOrEqual(count)
     }).toPass({

browser_tests/tests/templates.spec.ts

@@ -189,20 +189,20 @@ test.describe('Templates', { tag: ['@slow', '@workflow'] }, () => {
     )
     const nav = comfyPage.page.locator('header', { hasText: 'Templates' })
 
-    await comfyPage.templates.waitForMinimumCardCount(1)
+    await comfyPage.templates.expectMinimumCardCount(1)
     await expect(templateGrid).toBeVisible()
     await expect(nav).toBeVisible() // Nav should be visible at desktop size
 
     const mobileSize = { width: 640, height: 800 }
     await comfyPage.page.setViewportSize(mobileSize)
-    await comfyPage.templates.waitForMinimumCardCount(1)
+    await comfyPage.templates.expectMinimumCardCount(1)
     await expect(templateGrid).toBeVisible()
     // Nav header is clipped by overflow-hidden parent at mobile size
     await expect(nav).not.toBeInViewport()
 
     const tabletSize = { width: 1024, height: 800 }
     await comfyPage.page.setViewportSize(tabletSize)
-    await comfyPage.templates.waitForMinimumCardCount(1)
+    await comfyPage.templates.expectMinimumCardCount(1)
     await expect(templateGrid).toBeVisible()
     await expect(nav).toBeVisible() // Nav should be visible at tablet size
   })