Comfy-Org/ComfyUI_frontend
1
0
Fork 0
mirror of https://github.com/Comfy-Org/ComfyUI_frontend.git synced 2026-04-30 11:11:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: enhance snapshot update process to include untracked files (#7422)

Browse Source 
This pull request improves the snapshot staging process in the
Playwright expectations update workflow. The main focus is to ensure
both modified and newly added snapshot files are correctly detected and
handled, and to avoid errors when files have been deleted.

**Snapshot file detection and handling improvements:**

* The workflow now detects both modified and untracked (new) snapshot
files by combining output from `git diff` and `git ls-files --others`,
ensuring all relevant snapshot changes are staged.

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-7422-fix-enhance-snapshot-update-process-to-include-untracked-files-2c76d73d365081cc8023d9ed29b8781f)
by [Unito](https://www.unito.io)
This commit is contained in:
Johnpaul Chiwetelu
2025-12-13 00:04:32 +01:00
committed by GitHub
parent a7c694f248
commit a1a507ed09
1 changed files with 10 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
.github/workflows/pr-update-playwright-expectations.yaml vendored
View File

@@ -128,8 +128,11 @@ jobs:
echo "STAGING CHANGED SNAPSHOTS (Shard ${{ matrix.shardIndex }})" echo "STAGING CHANGED SNAPSHOTS (Shard ${{ matrix.shardIndex }})"
echo "==========================================" echo "=========================================="
# Get list of changed snapshot files # Get list of changed snapshot files (including untracked/new files)
changed_files=$(git diff --name-only browser_tests/ 2>/dev/null | grep -E '\-snapshots/' || echo "") changed_files=$( (
git diff --name-only browser_tests/ 2>/dev/null || true
git ls-files --others --exclude-standard browser_tests/ 2>/dev/null || true
) | sort -u | grep -E '\-snapshots/' || true )
if [ -z "$changed_files" ]; then if [ -z "$changed_files" ]; then
echo "No snapshot changes in this shard" echo "No snapshot changes in this shard"
@@ -151,6 +154,11 @@ jobs:
# Strip 'browser_tests/' prefix to avoid double nesting # Strip 'browser_tests/' prefix to avoid double nesting
echo "Copying changed files to staging directory..." echo "Copying changed files to staging directory..."
while IFS= read -r file; do while IFS= read -r file; do
# Skip paths that no longer exist (e.g. deletions)
if [ ! -f "$file" ]; then
echo " → (skipped; not a file) $file"
continue
fi
# Remove 'browser_tests/' prefix # Remove 'browser_tests/' prefix
file_without_prefix="${file#browser_tests/}" file_without_prefix="${file#browser_tests/}"
# Create parent directories # Create parent directories