From a34b807acd19d8bf85e412e4fd8bd3e078a70ad2 Mon Sep 17 00:00:00 2001 From: Connor Byrne Date: Wed, 13 May 2026 13:50:28 -0700 Subject: [PATCH] fix: remove unnecessary `as any` casts for nullable assignments - `node.widgets = undefined` works since widgets is `IBaseWidget[] | undefined` - `node.graph = null` works since graph is `LGraph | Subgraph | null` Addresses review feedback: https://github.com/Comfy-Org/ComfyUI_frontend/pull/11149#discussion_r3187561906 --- src/extensions/core/widgetInputs.test.ts | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/extensions/core/widgetInputs.test.ts b/src/extensions/core/widgetInputs.test.ts index e550a0f96f..ffc81ac4ba 100644 --- a/src/extensions/core/widgetInputs.test.ts +++ b/src/extensions/core/widgetInputs.test.ts @@ -476,7 +476,7 @@ describe('PrimitiveNode', () => { const node = createPrimitiveNode() const targetNode = createTargetNode('seed', 42) setupGraphWithLink(node, targetNode) - node.widgets = undefined as any + node.widgets = undefined node.onAfterGraphConfigured() @@ -488,7 +488,7 @@ describe('PrimitiveNode', () => { const node = createPrimitiveNode() const targetNode = createTargetNode('seed', 42) setupGraphWithLink(node, targetNode) - node.widgets = undefined as any + node.widgets = undefined node.widgets_values = ['restored_value'] node.onAfterGraphConfigured() @@ -505,7 +505,7 @@ describe('PrimitiveNode', () => { widgets: [] }) setupGraphWithLink(node, targetNode) - node.widgets = undefined as any + node.widgets = undefined node.onAfterGraphConfigured() @@ -516,8 +516,8 @@ describe('PrimitiveNode', () => { const node = createPrimitiveNode() node.outputs[0].links = [1] node.outputs[0].type = 'INT' - ;(node as any).graph = undefined - node.widgets = undefined as any + node.graph = null + node.widgets = undefined node.onConnectionsChange(2, 0, true) @@ -532,7 +532,7 @@ describe('PrimitiveNode', () => { getNodeById: vi.fn(() => undefined) } as any node.outputs[0].links = [1] - node.widgets = undefined as any + node.widgets = undefined node.onAfterGraphConfigured() @@ -546,7 +546,7 @@ describe('PrimitiveNode', () => { getNodeById: vi.fn() } as any node.outputs[0].links = [99] - node.widgets = undefined as any + node.widgets = undefined node.onAfterGraphConfigured() @@ -577,7 +577,7 @@ describe('PrimitiveNode', () => { widgets: [{ name: 'ckpt_name', value: 'model1.safetensors' }] }) setupGraphWithLink(node, targetNode) - node.widgets = undefined as any + node.widgets = undefined node.onAfterGraphConfigured()