diff --git a/browser_tests/interaction.spec.ts b/browser_tests/interaction.spec.ts index dcad92097..7554cc8ba 100644 --- a/browser_tests/interaction.spec.ts +++ b/browser_tests/interaction.spec.ts @@ -103,9 +103,7 @@ test.describe('Node Interaction', () => { }) }) - // Chromium 2x cannot move link. - // See https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/10876381315/job/30176211513 - test.skip('Can move link', async ({ comfyPage }) => { + test('Can move link', async ({ comfyPage }) => { await comfyPage.dragAndDrop( comfyPage.clipTextEncodeNode1InputSlot, comfyPage.emptySpace @@ -118,10 +116,7 @@ test.describe('Node Interaction', () => { await expect(comfyPage.canvas).toHaveScreenshot('moved-link.png') }) - // Copy link is not working on CI at all - // Chromium 2x recognize it as dragging canvas. - // Chromium triggers search box after link release. The link is indeed copied. - // See https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/10876381315/job/30176211513 + // Shift drag copy link regressed. See https://github.com/Comfy-Org/ComfyUI_frontend/issues/2941 test.skip('Can copy link by shift-drag existing link', async ({ comfyPage }) => { @@ -324,16 +319,12 @@ test.describe('Node Interaction', () => { await expect(comfyPage.canvas).toHaveScreenshot('group-fit-to-contents.png') }) - // Somehow this test fails on GitHub Actions. It works locally. - // https://github.com/Comfy-Org/ComfyUI_frontend/pull/736 - test.skip('Can pin/unpin nodes with keyboard shortcut', async ({ - comfyPage - }) => { + test('Can pin/unpin nodes', async ({ comfyPage }) => { await comfyPage.select2Nodes() - await comfyPage.canvas.press('KeyP') + await comfyPage.executeCommand('Comfy.Canvas.ToggleSelectedNodes.Pin') await comfyPage.nextFrame() await expect(comfyPage.canvas).toHaveScreenshot('nodes-pinned.png') - await comfyPage.canvas.press('KeyP') + await comfyPage.executeCommand('Comfy.Canvas.ToggleSelectedNodes.Pin') await comfyPage.nextFrame() await expect(comfyPage.canvas).toHaveScreenshot('nodes-unpinned.png') }) diff --git a/browser_tests/interaction.spec.ts-snapshots/moved-link-chromium-linux.png b/browser_tests/interaction.spec.ts-snapshots/moved-link-chromium-linux.png new file mode 100644 index 000000000..f2fb37b9c Binary files /dev/null and b/browser_tests/interaction.spec.ts-snapshots/moved-link-chromium-linux.png differ diff --git a/browser_tests/interaction.spec.ts-snapshots/nodes-pinned-chromium-linux.png b/browser_tests/interaction.spec.ts-snapshots/nodes-pinned-chromium-linux.png new file mode 100644 index 000000000..a5ce9a040 Binary files /dev/null and b/browser_tests/interaction.spec.ts-snapshots/nodes-pinned-chromium-linux.png differ diff --git a/browser_tests/interaction.spec.ts-snapshots/nodes-unpinned-chromium-linux.png b/browser_tests/interaction.spec.ts-snapshots/nodes-unpinned-chromium-linux.png new file mode 100644 index 000000000..2b558e4b6 Binary files /dev/null and b/browser_tests/interaction.spec.ts-snapshots/nodes-unpinned-chromium-linux.png differ diff --git a/browser_tests/menu.spec.ts b/browser_tests/menu.spec.ts index a05ee6995..fa4015989 100644 --- a/browser_tests/menu.spec.ts +++ b/browser_tests/menu.spec.ts @@ -7,25 +7,6 @@ test.describe('Menu', () => { await comfyPage.setSetting('Comfy.UseNewMenu', 'Top') }) - // Skip reason: Flaky. - test.skip('Toggle theme', async ({ comfyPage }) => { - test.setTimeout(30000) - - expect(await comfyPage.menu.getThemeId()).toBe('dark') - - await comfyPage.menu.toggleTheme() - - expect(await comfyPage.menu.getThemeId()).toBe('light') - - // Theme id should persist after reload. - await comfyPage.setup() - expect(await comfyPage.menu.getThemeId()).toBe('light') - - await comfyPage.menu.toggleTheme() - - expect(await comfyPage.menu.getThemeId()).toBe('dark') - }) - test('Can register sidebar tab', async ({ comfyPage }) => { const initialChildrenCount = await comfyPage.menu.sideToolbar.evaluate( (el) => el.children.length diff --git a/browser_tests/propertiesPanel.spec.ts b/browser_tests/propertiesPanel.spec.ts deleted file mode 100644 index 866ae0015..000000000 --- a/browser_tests/propertiesPanel.spec.ts +++ /dev/null @@ -1,28 +0,0 @@ -import { expect } from '@playwright/test' - -import { comfyPageFixture as test } from './fixtures/ComfyPage' - -test.describe('Properties Panel', () => { - test.beforeEach(async ({ comfyPage }) => { - await comfyPage.setSetting('Comfy.UseNewMenu', 'Top') - }) - - // TODO: Update expectation after new menu dropdown is added. - test.skip('Can change property value', async ({ comfyPage }) => { - await comfyPage.rightClickEmptyLatentNode() - await comfyPage.page.getByText('Properties Panel').click() - await comfyPage.nextFrame() - await expect(comfyPage.canvas).toHaveScreenshot( - 'right-click-node-properties-panel.png' - ) - const propertyInput = comfyPage.page.locator('span.property_value').first() - - // Ensure no keybinds are triggered while typing - await propertyInput.pressSequentially('abcdefghijklmnopqrstuvwxyz') - await expect(comfyPage.canvas).toHaveScreenshot( - 'right-click-node-properties-panel-property-changed.png' - ) - - await propertyInput.fill('Empty Latent Image') - }) -}) diff --git a/browser_tests/propertiesPanel.spec.ts-snapshots/right-click-node-properties-panel-chromium-linux.png b/browser_tests/propertiesPanel.spec.ts-snapshots/right-click-node-properties-panel-chromium-linux.png deleted file mode 100644 index c94e14424..000000000 Binary files a/browser_tests/propertiesPanel.spec.ts-snapshots/right-click-node-properties-panel-chromium-linux.png and /dev/null differ diff --git a/browser_tests/propertiesPanel.spec.ts-snapshots/right-click-node-properties-panel-property-changed-chromium-linux.png b/browser_tests/propertiesPanel.spec.ts-snapshots/right-click-node-properties-panel-property-changed-chromium-linux.png deleted file mode 100644 index 169439eb9..000000000 Binary files a/browser_tests/propertiesPanel.spec.ts-snapshots/right-click-node-properties-panel-property-changed-chromium-linux.png and /dev/null differ