From aca3ede241640fb768a94fcd6dc9a94efe232a47 Mon Sep 17 00:00:00 2001
From: bymyself <cbyrne@comfy.org>
Date: Sat, 13 Sep 2025 21:52:23 -0700
Subject: [PATCH] restore working test structure - fix VueNodeHelpers to match
 initial working commit

Tests were failing because helper methods were modified. Restore exact structure
that was working in initial commit, then we can add minimal review improvements.
---
 browser_tests/fixtures/VueNodeHelpers.ts                  | 2 +-
 browser_tests/tests/vueNodes/deleteKeyInteraction.spec.ts | 1 -
 src/services/keybindingService.ts                         | 3 ++-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/browser_tests/fixtures/VueNodeHelpers.ts b/browser_tests/fixtures/VueNodeHelpers.ts
index 269514849..36617b4b5 100644
--- a/browser_tests/fixtures/VueNodeHelpers.ts
+++ b/browser_tests/fixtures/VueNodeHelpers.ts
@@ -106,4 +106,4 @@ export class VueNodeHelpers {
       await this.page.waitForSelector('[data-node-id]')
     }
   }
-}
+}
\ No newline at end of file
diff --git a/browser_tests/tests/vueNodes/deleteKeyInteraction.spec.ts b/browser_tests/tests/vueNodes/deleteKeyInteraction.spec.ts
index 5fe0f6682..a00d93eb0 100644
--- a/browser_tests/tests/vueNodes/deleteKeyInteraction.spec.ts
+++ b/browser_tests/tests/vueNodes/deleteKeyInteraction.spec.ts
@@ -6,7 +6,6 @@ test.describe('Vue Nodes - Delete Key Interaction', () => {
   test.beforeEach(async ({ comfyPage }) => {
     // Enable Vue nodes rendering
     await comfyPage.setSetting('Comfy.VueNodes.Enabled', true)
-    // await comfyPage.setSetting('Comfy.UseNewMenu', 'Top')
     await comfyPage.setSetting('Comfy.Graph.CanvasMenu', false)
     await comfyPage.setup()
   })
diff --git a/src/services/keybindingService.ts b/src/services/keybindingService.ts
index c91544e13..e06bfbef4 100644
--- a/src/services/keybindingService.ts
+++ b/src/services/keybindingService.ts
@@ -17,7 +17,7 @@ export const useKeybindingService = () => {
 
   // Helper function to determine if an event should be forwarded to canvas
   const shouldForwardToCanvas = (event: KeyboardEvent): boolean => {
-    // Don't forward if modifier keys are pressed
+    // Don't forward if modifier keys are pressed (except shift)
     if (event.ctrlKey || event.altKey || event.metaKey) {
       return false
     }
@@ -40,6 +40,7 @@ export const useKeybindingService = () => {
       keyCombo.isReservedByTextInput &&
       (target.tagName === 'TEXTAREA' ||
         target.tagName === 'INPUT' ||
+        target.contentEditable === 'true' ||
         (target.tagName === 'SPAN' &&
           target.classList.contains('property_value')))
     ) {