Comfy-Org/ComfyUI_frontend
1
0
Fork 0
mirror of https://github.com/Comfy-Org/ComfyUI_frontend.git synced 2026-05-04 13:12:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: centralize display_name || name into getAssetDisplayName (#9641)

Browse Source 
## Summary

Centralize the inline `display_name || name` pattern into
`getAssetDisplayName`, adding `display_name` to the existing metadata
fallback chain.

## Changes

- **What**: Update `getAssetDisplayName` fallback chain to
`user_metadata.name → metadata.name → display_name → name`. Replace all
6 inline `asset.display_name || asset.name` call sites with the shared
utility. Remove duplicate local function in `AssetsSidebarListView.vue`.

## Review Focus

The fallback order preserves user_metadata overrides while incorporating
the `display_name` field added in #9626. All callers now go through a
single code path.

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-9641-refactor-centralize-display_name-name-into-getAssetDisplayName-31e6d73d365081e09e5de85486583443)
by [Unito](https://www.unito.io)

---------

Co-authored-by: Amp <amp@ampcode.com>
Co-authored-by: GitHub Action <action@github.com>
This commit is contained in:
Alexander Brown
2026-03-12 09:13:20 -07:00
committed by GitHub
parent c85a15547b
commit adf81fcd73
8 changed files with 35 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
src/platform/assets/utils/assetMetadataUtils.test.ts
View File

@@ -70,20 +70,35 @@ describe('assetMetadataUtils', () => {
{
name: 'returns name from user_metadata when present',
user_metadata: { name: 'My Custom Name' },
display_name: 'ComfyUI_00001_.png',
expected: 'My Custom Name'
},
{
name: 'falls back to asset name for non-string',
user_metadata: { name: 123 },
name: 'returns display_name when user_metadata.name is absent',
user_metadata: undefined,
display_name: 'ComfyUI_00001_.png',
expected: 'ComfyUI_00001_.png'
},
{
name: 'falls back to asset name when both are absent',
user_metadata: undefined,
display_name: undefined,
expected: 'test-model'
},
{
name: 'falls back to asset name for undefined',
name: 'skips non-string user_metadata.name',
user_metadata: { name: 123 },
display_name: 'ComfyUI_00001_.png',
expected: 'ComfyUI_00001_.png'
},
{
name: 'falls back to asset name when display_name is empty',
user_metadata: undefined,
display_name: '',
expected: 'test-model'
}
])('$name', ({ user_metadata, expected }) => {
const asset = { ...mockAsset, user_metadata }
])('$name', ({ user_metadata, display_name, expected }) => {
const asset = { ...mockAsset, user_metadata, display_name }
expect(getAssetDisplayName(asset)).toBe(expected)
})
})