From b0e424dd7deb088f435841f35f37de0d3cdb8600 Mon Sep 17 00:00:00 2001 From: Richard Yu Date: Wed, 10 Dec 2025 12:16:36 -0800 Subject: [PATCH] fix: properly type extractWorkflow return value MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Changed return type from `unknown` to `ComfyWorkflowJSON | undefined` so callers don't need type assertions. Validation still happens downstream in loadGraphData when the setting is enabled. Addresses DrJKL's review comment on PR 7170. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude --- src/platform/remote/comfyui/jobs/fetchJobs.ts | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/src/platform/remote/comfyui/jobs/fetchJobs.ts b/src/platform/remote/comfyui/jobs/fetchJobs.ts index 5d8859d3b..c34fc0959 100644 --- a/src/platform/remote/comfyui/jobs/fetchJobs.ts +++ b/src/platform/remote/comfyui/jobs/fetchJobs.ts @@ -1,3 +1,4 @@ +import type { ComfyWorkflowJSON } from '@/platform/workflow/validation/schemas/workflowSchema' import type { PromptId } from '@/schemas/apiSchema' import type { @@ -126,8 +127,13 @@ export async function fetchJobDetail( } } -/** Extracts workflow from job detail response */ -export function extractWorkflow(job: JobDetail | undefined): unknown { +/** + * Extracts workflow from job detail response. + * Validation happens downstream in loadGraphData when the setting is enabled. + */ +export function extractWorkflow( + job: JobDetail | undefined +): ComfyWorkflowJSON | undefined { const workflow = job?.workflow if (!workflow || typeof workflow !== 'object') return undefined const container = workflow as Record @@ -135,5 +141,7 @@ export function extractWorkflow(job: JobDetail | undefined): unknown { if (!extraData || typeof extraData !== 'object') return undefined const pnginfo = (extraData as Record).extra_pnginfo if (!pnginfo || typeof pnginfo !== 'object') return undefined - return (pnginfo as Record).workflow + return (pnginfo as Record).workflow as + | ComfyWorkflowJSON + | undefined }