From b3eee54abb4ee1336612275e07d9a5d77a4d5340 Mon Sep 17 00:00:00 2001 From: Christian Byrne Date: Sun, 26 Oct 2025 20:39:18 -0700 Subject: [PATCH] fix: claude-review bails on cancelled and skipped checks (#6316) ## Summary Expands the wait step in `pr-claude-review.yaml` so the `lewagon/wait-on-check-action` accepts every terminal GitHub conclusion instead of failing on outcomes like cancelled or failure. After the wait completes, the `check-status` script still inspects those check runs and only marks `should-proceed=true` when the tracked jobs finished successfully. Fixes what happened here: https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/18828179272/job/53714488799?pr=6298 --- .github/workflows/pr-claude-review.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/pr-claude-review.yaml b/.github/workflows/pr-claude-review.yaml index b09fde14f..16eaecfc1 100644 --- a/.github/workflows/pr-claude-review.yaml +++ b/.github/workflows/pr-claude-review.yaml @@ -28,6 +28,7 @@ jobs: with: ref: ${{ github.event.pull_request.head.sha }} check-regexp: '^(lint-and-format|test|playwright-tests)' + allowed-conclusions: success,skipped,failure,cancelled,neutral,action_required,timed_out,stale wait-interval: 30 repo-token: ${{ secrets.GITHUB_TOKEN }}