From b67f34e7f335ddc5609d99daf43dd486d08a00c1 Mon Sep 17 00:00:00 2001
From: filtered <176114999+webfiltered@users.noreply.github.com>
Date: Thu, 20 Feb 2025 11:17:35 +1100
Subject: [PATCH] [Cleanup] Remove lint bypass, remove unused vars (#554)

---
 eslint.config.js          |  4 +---
 src/ContextMenu.ts        |  1 -
 src/LGraph.ts             |  2 --
 src/LGraphCanvas.ts       | 15 ++++-----------
 src/LGraphNode.ts         |  4 ++--
 src/widgets/BaseWidget.ts |  8 ++++----
 6 files changed, 11 insertions(+), 23 deletions(-)

diff --git a/eslint.config.js b/eslint.config.js
index afa4bde27..504600c1a 100644
--- a/eslint.config.js
+++ b/eslint.config.js
@@ -63,7 +63,6 @@ export default tseslint.config(
       "@typescript-eslint/no-empty-object-type": "off",
 
       // "@typescript-eslint/prefer-readonly-parameter-types": "error",
-      "@typescript-eslint/no-unused-vars": "off",
       // "@typescript-eslint/no-unsafe-function-type": "off",
 
       "@stylistic/max-len": [
@@ -167,10 +166,9 @@ export default tseslint.config(
       "unused-imports": unusedImports,
     },
     rules: {
-      "@typescript-eslint/no-explicit-any": "off",
       "@typescript-eslint/no-unused-vars": "off",
-      "@typescript-eslint/prefer-as-const": "off",
       "unused-imports/no-unused-imports": "error",
+      "unused-imports/no-unused-vars": "warn",
     },
   },
 )
diff --git a/src/ContextMenu.ts b/src/ContextMenu.ts
index e78e17b70..211adb56e 100644
--- a/src/ContextMenu.ts
+++ b/src/ContextMenu.ts
@@ -346,7 +346,6 @@ export class ContextMenu {
     element: HTMLDivElement,
     event_name: string,
     params: MouseEvent,
-    origin?: unknown,
   ): CustomEvent {
     const evt = document.createEvent("CustomEvent")
     evt.initCustomEvent(event_name, true, true, params) // canBubble, cancelable, detail
diff --git a/src/LGraph.ts b/src/LGraph.ts
index 896633e73..a5a09b687 100644
--- a/src/LGraph.ts
+++ b/src/LGraph.ts
@@ -584,8 +584,6 @@ export class LGraph implements LinkNetwork, Serialisable<SerialisableGraph> {
     if (L.length != this._nodes.length && LiteGraph.debug)
       console.warn("something went wrong, nodes missing")
 
-    const l = L.length
-
     /** Ensure type is set */
     type OrderedLGraphNode = LGraphNode & { order: number }
 
diff --git a/src/LGraphCanvas.ts b/src/LGraphCanvas.ts
index 3f94a9571..30135d000 100644
--- a/src/LGraphCanvas.ts
+++ b/src/LGraphCanvas.ts
@@ -785,7 +785,6 @@ export class LGraphCanvas implements ConnectionColorContext {
     options: IContextMenuOptions,
     event: MouseEvent,
     prev_menu: ContextMenu,
-    node: LGraphNode,
   ): void {
     new LiteGraph.ContextMenu(["Vertically", "Horizontally"], {
       event,
@@ -1347,13 +1346,7 @@ export class LGraphCanvas implements ConnectionColorContext {
     node.graph.afterChange(/* ? */)
   }
 
-  static onMenuNodePin(
-    value: IContextMenuValue,
-    options: IContextMenuOptions,
-    e: MouseEvent,
-    menu: ContextMenu,
-    node: LGraphNode,
-  ): void {}
+  static onMenuNodePin(): void {}
 
   static onMenuNodeMode(
     value: IContextMenuValue,
@@ -2367,7 +2360,7 @@ export class LGraphCanvas implements ConnectionColorContext {
           this.#dirty()
         }
 
-        pointer.onDragEnd = (upEvent) => {
+        pointer.onDragEnd = () => {
           this.#dirty()
           graph.afterChange(this.resizing_node)
         }
@@ -3158,7 +3151,7 @@ export class LGraphCanvas implements ConnectionColorContext {
     this.updateMouseOverNodes(null, e)
   }
 
-  processMouseCancel(e: PointerEvent): void {
+  processMouseCancel(): void {
     console.warn("Pointer cancel!")
     this.pointer.reset()
   }
@@ -5881,7 +5874,7 @@ export class LGraphCanvas implements ConnectionColorContext {
       default: {
         // check for defaults nodes for this slottype
 
-        const nodeCreated = that.createDefaultNodeForSlot(Object.assign<ICreateNodeOptions, ICreateNodeOptions>(opts, {
+        that.createDefaultNodeForSlot(Object.assign<ICreateNodeOptions, ICreateNodeOptions>(opts, {
           position: [opts.e.canvasX, opts.e.canvasY],
           nodeType: v,
           afterRerouteId,
diff --git a/src/LGraphNode.ts b/src/LGraphNode.ts
index dbd20c4c6..7b0c82064 100644
--- a/src/LGraphNode.ts
+++ b/src/LGraphNode.ts
@@ -1064,7 +1064,7 @@ export class LGraphNode implements Positionable, IPinnable, IColorable {
     const trigS = this.findInputSlot("onTrigger")
     // !trigS ||
     if (trigS == -1) {
-      const input = this.addInput("onTrigger", LiteGraph.EVENT, {
+      this.addInput("onTrigger", LiteGraph.EVENT, {
         optional: true,
         nameLocked: true,
       })
@@ -1077,7 +1077,7 @@ export class LGraphNode implements Positionable, IPinnable, IColorable {
     const trigS = this.findOutputSlot("onExecuted")
     // !trigS ||
     if (trigS == -1) {
-      const output = this.addOutput("onExecuted", LiteGraph.ACTION, {
+      this.addOutput("onExecuted", LiteGraph.ACTION, {
         optional: true,
         nameLocked: true,
       })
diff --git a/src/widgets/BaseWidget.ts b/src/widgets/BaseWidget.ts
index af3f0258b..8659e2047 100644
--- a/src/widgets/BaseWidget.ts
+++ b/src/widgets/BaseWidget.ts
@@ -83,21 +83,21 @@ export abstract class BaseWidget implements IBaseWidget {
    * Handles the click event for the widget
    * @param options - The options for handling the click event
    */
-  onClick(options: {
+  abstract onClick(options: {
     e: CanvasMouseEvent
     node: LGraphNode
     canvas: LGraphCanvas
-  }): void {}
+  }): void
 
   /**
    * Handles the drag event for the widget
    * @param options - The options for handling the drag event
    */
-  onDrag(options: {
+  onDrag?(options: {
     e: CanvasMouseEvent
     node: LGraphNode
     canvas: LGraphCanvas
-  }): void {}
+  }): void
 
   /**
    * Sets the value of the widget