[bugfix] Filter model metadata by current widget selection (#4021)

Co-authored-by: filtered <176114999+webfiltered@users.noreply.github.com>
This commit is contained in:
Christian Byrne
2025-05-31 19:43:00 -07:00
committed by GitHub
parent 6289ac9182
commit b81c2f7cd2
5 changed files with 377 additions and 4 deletions

View File

@@ -0,0 +1,248 @@
import { describe, expect, it } from 'vitest'
import { getSelectedModelsMetadata } from '@/utils/modelMetadataUtil'
describe('modelMetadataUtil', () => {
describe('filterModelsByCurrentSelection', () => {
it('should filter models to only include those selected in widget values', () => {
const node = {
type: 'CheckpointLoaderSimple',
widgets_values: ['model_a.safetensors'],
properties: {
models: [
{
name: 'model_a.safetensors',
url: 'https://example.com/model_a.safetensors',
directory: 'checkpoints'
},
{
name: 'model_b.safetensors',
url: 'https://example.com/model_b.safetensors',
directory: 'checkpoints'
}
]
}
}
const result = getSelectedModelsMetadata(node)
expect(result).toHaveLength(1)
expect(result![0].name).toBe('model_a.safetensors')
})
it('should return empty array when no models match selection', () => {
const node = {
type: 'SomeNode',
widgets_values: ['unmatched_model.safetensors'],
properties: {
models: [
{
name: 'model_a.safetensors',
url: 'https://example.com/model_a.safetensors',
directory: 'checkpoints'
}
]
}
}
const result = getSelectedModelsMetadata(node)
expect(result).toHaveLength(0)
})
it('should handle multiple widget values', () => {
const node = {
type: 'SomeNode',
widgets_values: ['model_a.safetensors', 42, 'model_c.ckpt'],
properties: {
models: [
{
name: 'model_a.safetensors',
url: 'https://example.com/model_a.safetensors',
directory: 'checkpoints'
},
{
name: 'model_b.safetensors',
url: 'https://example.com/model_b.safetensors',
directory: 'checkpoints'
},
{
name: 'model_c.ckpt',
url: 'https://example.com/model_c.ckpt',
directory: 'checkpoints'
}
]
}
}
const result = getSelectedModelsMetadata(node)
expect(result).toHaveLength(2)
expect(result!.map((m) => m.name)).toEqual([
'model_a.safetensors',
'model_c.ckpt'
])
})
it('should ignore non-string widget values', () => {
const node = {
type: 'SomeNode',
widgets_values: [42, true, null, undefined, 'model_a.safetensors'],
properties: {
models: [
{
name: 'model_a.safetensors',
url: 'https://example.com/model_a.safetensors',
directory: 'checkpoints'
}
]
}
}
const result = getSelectedModelsMetadata(node)
expect(result).toHaveLength(1)
expect(result![0].name).toBe('model_a.safetensors')
})
it('should ignore empty strings', () => {
const node = {
type: 'SomeNode',
widgets_values: ['', ' ', 'model_a.safetensors'],
properties: {
models: [
{
name: 'model_a.safetensors',
url: 'https://example.com/model_a.safetensors',
directory: 'checkpoints'
}
]
}
}
const result = getSelectedModelsMetadata(node)
expect(result).toHaveLength(1)
expect(result![0].name).toBe('model_a.safetensors')
})
it('should return undefined for nodes without model metadata', () => {
const node = {
type: 'SomeNode',
widgets_values: ['model_a.safetensors']
}
const result = getSelectedModelsMetadata(node)
expect(result).toBeUndefined()
})
it('should return undefined for nodes without widgets_values', () => {
const node = {
type: 'SomeNode',
properties: {
models: [
{
name: 'model_a.safetensors',
url: 'https://example.com/model_a.safetensors',
directory: 'checkpoints'
}
]
}
}
const result = getSelectedModelsMetadata(node)
expect(result).toBeUndefined()
})
it('should return undefined for nodes with empty widgets_values', () => {
const node = {
type: 'SomeNode',
widgets_values: [],
properties: {
models: [
{
name: 'model_a.safetensors',
url: 'https://example.com/model_a.safetensors',
directory: 'checkpoints'
}
]
}
}
const result = getSelectedModelsMetadata(node)
expect(result).toBeUndefined()
})
it('should return undefined for nodes with empty models array', () => {
const node = {
type: 'SomeNode',
widgets_values: ['model_a.safetensors'],
properties: {
models: []
}
}
const result = getSelectedModelsMetadata(node)
expect(result).toBeUndefined()
})
it('should handle object widget values', () => {
const node = {
type: 'SomeNode',
widgets_values: {
ckpt_name: 'model_a.safetensors',
seed: 42
},
properties: {
models: [
{
name: 'model_a.safetensors',
url: 'https://example.com/model_a.safetensors',
directory: 'checkpoints'
},
{
name: 'model_b.safetensors',
url: 'https://example.com/model_b.safetensors',
directory: 'checkpoints'
}
]
}
}
const result = getSelectedModelsMetadata(node)
expect(result).toHaveLength(1)
expect(result![0].name).toBe('model_a.safetensors')
})
it('should work end-to-end to filter outdated metadata', () => {
const node = {
type: 'CheckpointLoaderSimple',
widgets_values: ['current_model.safetensors'],
properties: {
models: [
{
name: 'current_model.safetensors',
url: 'https://example.com/current_model.safetensors',
directory: 'checkpoints'
},
{
name: 'old_model.safetensors',
url: 'https://example.com/old_model.safetensors',
directory: 'checkpoints'
}
]
}
}
const result = getSelectedModelsMetadata(node)
expect(result).toHaveLength(1)
expect(result![0].name).toBe('current_model.safetensors')
})
})
})