Comfy-Org/ComfyUI_frontend
1
0
Fork 0
mirror of https://github.com/Comfy-Org/ComfyUI_frontend.git synced 2026-04-30 11:11:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

Replace canvas "action" magic strings (#271)

Browse Source
This commit is contained in:
filtered
2024-11-04 10:30:19 +11:00
committed by GitHub
parent ce8d39f650
commit ba52402851
2 changed files with 18 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
src/LGraph.ts
View File

@@ -192,7 +192,7 @@ export class LGraph {
//notify canvas to redraw //notify canvas to redraw
this.change() this.change()
this.sendActionToCanvas("clear") this.canvasAction(c => c.clear())
} }
get nodes() { get nodes() {
@@ -630,6 +630,16 @@ export class LGraph {
} }
} }
} }
/**
* Runs an action on every canvas registered to this graph.
* @param action Action to run for every canvas
*/
canvasAction(action: (canvas: LGraphCanvas) => void): void {
this.list_of_graphcanvas?.forEach(action)
}
/** @deprecated See {@link LGraph.canvasAction} */
sendActionToCanvas<T extends MethodNames<LGraphCanvas>>(action: T, params?: ParamsArray<LGraphCanvas, T>): void { sendActionToCanvas<T extends MethodNames<LGraphCanvas>>(action: T, params?: ParamsArray<LGraphCanvas, T>): void {
if (!this.list_of_graphcanvas) return if (!this.list_of_graphcanvas) return
@@ -776,7 +786,7 @@ export class LGraph {
this.onNodeRemoved?.(node) this.onNodeRemoved?.(node)
//close panels //close panels
this.sendActionToCanvas("checkPanels") this.canvasAction(c => c.checkPanels())
this.setDirtyCanvas(true, true) this.setDirtyCanvas(true, true)
this.afterChange() //sure? - almost sure is wrong this.afterChange() //sure? - almost sure is wrong
@@ -1117,12 +1127,12 @@ export class LGraph {
//used for undo, called before any change is made to the graph //used for undo, called before any change is made to the graph
beforeChange(info?: LGraphNode): void { beforeChange(info?: LGraphNode): void {
this.onBeforeChange?.(this, info) this.onBeforeChange?.(this, info)
this.sendActionToCanvas("onBeforeChange", this) this.canvasAction(c => c.onBeforeChange?.(this))
} }
//used to resend actions, called after any change is made to the graph //used to resend actions, called after any change is made to the graph
afterChange(info?: LGraphNode): void { afterChange(info?: LGraphNode): void {
this.onAfterChange?.(this, info) this.onAfterChange?.(this, info)
this.sendActionToCanvas("onAfterChange", this) this.canvasAction(c => c.onAfterChange?.(this))
} }
connectionChange(node: LGraphNode): void { connectionChange(node: LGraphNode): void {
this.updateExecutionOrder() this.updateExecutionOrder()
@@ -1130,7 +1140,7 @@ export class LGraph {
this._version++ this._version++
// TODO: Interface never implemented - any consumers? // TODO: Interface never implemented - any consumers?
// @ts-expect-error // @ts-expect-error
this.sendActionToCanvas("onConnectionChange") this.canvasAction(c => c.onConnectionChange?.())
} }
/** /**
* returns if the graph is in live mode * returns if the graph is in live mode
@@ -1160,11 +1170,11 @@ export class LGraph {
if (LiteGraph.debug) { if (LiteGraph.debug) {
console.log("Graph changed") console.log("Graph changed")
} }
this.sendActionToCanvas("setDirty", [true, true]) this.canvasAction(c => c.setDirty(true, true))
this.on_change?.(this) this.on_change?.(this)
} }
setDirtyCanvas(fg: boolean, bg?: boolean): void { setDirtyCanvas(fg: boolean, bg?: boolean): void {
this.sendActionToCanvas("setDirty", [fg, bg]) this.canvasAction(c => c.setDirty(fg, bg))
} }
/** /**
* Destroys a link * Destroys a link

5
src/LGraphNode.ts
View File

@@ -2255,10 +2255,7 @@ export class LGraphNode implements Positionable {
/* Forces to redraw or the main canvas (LGraphNode) or the bg canvas (links) */ /* Forces to redraw or the main canvas (LGraphNode) or the bg canvas (links) */
setDirtyCanvas(dirty_foreground: boolean, dirty_background?: boolean): void { setDirtyCanvas(dirty_foreground: boolean, dirty_background?: boolean): void {
this.graph?.sendActionToCanvas("setDirty", [ this.graph?.canvasAction(c => c.setDirty(dirty_foreground, dirty_background))
dirty_foreground,
dirty_background
])
} }
loadImage(url: string): HTMLImageElement { loadImage(url: string): HTMLImageElement {