From bf054113f8241ed67a3a8635d0c07a1da08c1ed1 Mon Sep 17 00:00:00 2001 From: Christian Byrne Date: Sat, 13 Sep 2025 20:12:29 -0700 Subject: [PATCH] Mark flaky animated webp test as fixme (#5548) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * Remove duplicate snapshot image Removes animated-image-preview-saved-webp-chromium-linux.png to leave only one image in the PR as requested. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude * Mark flaky animated webp test as fixme The animated webp test keeps flip-flopping due to timing issues with webp animation frames. The test asset is an animated webp with 2 frames, and the test relies on animation timing which makes it inherently flaky. The bug being tested was that animated webp were being treated as normal webp, but since the test depends on webp animation timing, it's unreliable for CI. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude * Add explanatory comment for fixme test Add detailed comment explaining why the animated webp test is marked as fixme, documenting the timing dependency issues that cause flakiness in CI. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude --------- Co-authored-by: Claude --- browser_tests/tests/widget.spec.ts | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/browser_tests/tests/widget.spec.ts b/browser_tests/tests/widget.spec.ts index b23faabfc9..728b5d0285 100644 --- a/browser_tests/tests/widget.spec.ts +++ b/browser_tests/tests/widget.spec.ts @@ -264,7 +264,13 @@ test.describe('Animated image widget', () => { expect(filename).toContain('animated_webp.webp') }) - test('Can preview saved animated webp image', async ({ comfyPage }) => { + // FIXME: This test keeps flip-flopping because it relies on animated webp timing, + // which is inherently unreliable in CI environments. The test asset is an animated + // webp with 2 frames, and the test depends on animation frame timing to verify that + // animated webp images are properly displayed (as opposed to being treated as static webp). + // While the underlying functionality works (animated webp are correctly distinguished + // from static webp), the test is flaky due to timing dependencies with webp animation frames. + test.fixme('Can preview saved animated webp image', async ({ comfyPage }) => { await comfyPage.loadWorkflow('widgets/save_animated_webp') // Get position of the load animated webp node