fix: onNodeRemoved not called when loading new graph (and tearing down previous) (#5407)

* standardize graph cleanup

* test: fix useCoreCommands tests and add regression test

- Fix mocking to properly simulate app.clean() calling graph.clear()
- Add intelligent subgraph detection in mock to match real implementation
- Add regression test for Vue node cleanup bug to prevent future regressions
- Ensures app.clean() properly triggers onNodeRemoved events through graph.clear()

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

* fix unit tests

* move beforeLoadNewGraph to before graph is cleaned

---------

Co-authored-by: Claude <noreply@anthropic.com>
This commit is contained in:
Christian Byrne
2025-09-06 19:35:57 -07:00
committed by GitHub
parent 88809c7006
commit c2eb4f03e9
6 changed files with 75 additions and 14 deletions

View File

@@ -634,7 +634,6 @@ export class ComfyUI {
confirm('Clear workflow?')
) {
app.clean()
app.graph.clear()
useLitegraphService().resetView()
api.dispatchCustomEvent('graphCleared')
}