Comfy-Org/ComfyUI_frontend
1
0
Fork 0
mirror of https://github.com/Comfy-Org/ComfyUI_frontend.git synced 2026-04-30 03:01:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

[ci] Make Chromatic and Playwright comment steps safe to fail (#5156)

Browse Source 
Add continue-on-error: true to all PR comment steps in both chromatic.yaml and test-ui.yaml workflows to prevent GitHub API permission errors (403) from blocking essential CI processes.

Changes:
- chromatic.yaml: Added continue-on-error to 2 comment steps
- test-ui.yaml: Added continue-on-error to 4 comment steps

This ensures that visual testing (Chromatic) and browser testing (Playwright) continue to run even when PR commenting fails due to token permissions.

Fixes #5149

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-authored-by: Claude <noreply@anthropic.com>
This commit is contained in:
snomiao
2025-08-23 13:28:55 +08:00
committed by GitHub
parent 84e7102f70
commit c75255327a
2 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
.github/workflows/chromatic.yaml vendored
View File

@@ -32,6 +32,7 @@ jobs:
- name: Comment PR - Build Started - name: Comment PR - Build Started
if: github.event_name == 'pull_request' if: github.event_name == 'pull_request'
continue-on-error: true
uses: edumserrano/find-create-or-update-comment@v3 uses: edumserrano/find-create-or-update-comment@v3
with: with:
issue-number: ${{ github.event.pull_request.number }} issue-number: ${{ github.event.pull_request.number }}
@@ -68,6 +69,7 @@ jobs:
- name: Comment PR - Build Complete - name: Comment PR - Build Complete
if: github.event_name == 'pull_request' && always() if: github.event_name == 'pull_request' && always()
continue-on-error: true
uses: edumserrano/find-create-or-update-comment@v3 uses: edumserrano/find-create-or-update-comment@v3
with: with:
issue-number: ${{ github.event.pull_request.number }} issue-number: ${{ github.event.pull_request.number }}

4
.github/workflows/test-ui.yaml vendored
View File

@@ -47,6 +47,7 @@ jobs:
- name: Comment PR - Tests Started - name: Comment PR - Tests Started
if: github.event_name == 'pull_request' if: github.event_name == 'pull_request'
continue-on-error: true
uses: edumserrano/find-create-or-update-comment@v3 uses: edumserrano/find-create-or-update-comment@v3
with: with:
issue-number: ${{ github.event.pull_request.number }} issue-number: ${{ github.event.pull_request.number }}
@@ -134,6 +135,7 @@ jobs:
- name: Comment PR - Browser Test Started - name: Comment PR - Browser Test Started
if: github.event_name == 'pull_request' if: github.event_name == 'pull_request'
continue-on-error: true
uses: edumserrano/find-create-or-update-comment@v3 uses: edumserrano/find-create-or-update-comment@v3
with: with:
issue-number: ${{ github.event.pull_request.number }} issue-number: ${{ github.event.pull_request.number }}
@@ -238,6 +240,7 @@ jobs:
- name: Comment PR - Browser Test Complete - name: Comment PR - Browser Test Complete
if: always() && github.event_name == 'pull_request' if: always() && github.event_name == 'pull_request'
continue-on-error: true
uses: edumserrano/find-create-or-update-comment@v3 uses: edumserrano/find-create-or-update-comment@v3
with: with:
issue-number: ${{ github.event.pull_request.number }} issue-number: ${{ github.event.pull_request.number }}
@@ -323,6 +326,7 @@ jobs:
fi fi
- name: Comment PR - Tests Complete - name: Comment PR - Tests Complete
continue-on-error: true
uses: edumserrano/find-create-or-update-comment@v3 uses: edumserrano/find-create-or-update-comment@v3
with: with:
issue-number: ${{ github.event.pull_request.number }} issue-number: ${{ github.event.pull_request.number }}