Comfy-Org/ComfyUI_frontend
1
0
Fork 0
mirror of https://github.com/Comfy-Org/ComfyUI_frontend.git synced 2026-04-30 11:11:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

🤖 More Rules (#7208)

Browse Source 
## Summary

Adding more to the AGENTS.md lists

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-7208-More-Rules-2c16d73d365081d199d0cb07f4051906)
by [Unito](https://www.unito.io)
This commit is contained in:
Alexander Brown
2025-12-08 18:43:56 -08:00
committed by GitHub
parent f385ee8ca2
commit c9d5d5ab3e
1 changed files with 25 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

49
AGENTS.md
View File

@@ -33,18 +33,7 @@
## Monorepo Architecture ## Monorepo Architecture
The project uses **Nx** for build orchestration and task management: The project uses **Nx** for build orchestration and task management
- **Task Orchestration**: Commands like `dev`, `build`, `lint`, and `test:browser` run via Nx
- **Caching**: Nx provides intelligent caching for faster rebuilds
- **Configuration**: Managed through `nx.json` with plugins for ESLint, Storybook, Vite, and Playwright
- **Dependencies**: Nx handles dependency graph analysis and parallel execution
Key Nx features:
- Build target caching and incremental builds
- Parallel task execution across the monorepo
- Plugin-based architecture for different tools
## Build, Test, and Development Commands ## Build, Test, and Development Commands
@@ -145,6 +134,7 @@ Key Nx features:
}>() }>()
``` ```
- Prefer reactive props destructuring to `const props = defineProps<...>`
- Do not use `withDefaults` or runtime props declaration - Do not use `withDefaults` or runtime props declaration
- Do not import Vue macros unnecessarily - Do not import Vue macros unnecessarily
- Prefer `useModel` to separately defining a prop and emit - Prefer `useModel` to separately defining a prop and emit
@@ -158,29 +148,40 @@ Key Nx features:
1. Leverage VueUse functions for performance-enhancing styles 1. Leverage VueUse functions for performance-enhancing styles
2. Use es-toolkit for utility functions 2. Use es-toolkit for utility functions
3. Use TypeScript for type safety 3. Use TypeScript for type safety
4. Implement proper props and emits definitions 4. If a complex type definition is inlined in multiple related places, extract and name it for reuse
5. Utilize Vue 3's Teleport component when needed 5. In Vue Components, implement proper props and emits definitions
6. Use Suspense for async components 6. Utilize Vue 3's Teleport component when needed
7. Implement proper error handling 7. Use Suspense for async components
8. Follow Vue 3 style guide and naming conventions 8. Implement proper error handling
9. Use Vite for fast development and building 9. Follow Vue 3 style guide and naming conventions
10. Use vue-i18n in composition API for any string literals. Place new translation entries in src/locales/en/main.json 10. Use Vite for fast development and building
11. Avoid new usage of PrimeVue components 11. Use vue-i18n in composition API for any string literals. Place new translation entries in src/locales/en/main.json
12. Write tests for all changes, especially bug fixes to catch future regressions 12. Avoid new usage of PrimeVue components
13. Write code that is expressive and self-documenting to the furthest degree possible. This reduces the need for code comments which can get out of sync with the code itself. Try to avoid comments unless absolutely necessary 13. Write tests for all changes, especially bug fixes to catch future regressions
14. Whenever a new piece of code is written, the author should ask themselves 'is there a simpler way to introduce the same functionality?'. If the answer is yes, the simpler course should be chosen 14. Write code that is expressive and self-documenting to the furthest degree possible. This reduces the need for code comments which can get out of sync with the code itself. Try to avoid comments unless absolutely necessary
15. Refactoring should be used to make complex code simpler 15. Do not add or retain redundant comments, clean as you go
16. Whenever a new piece of code is written, the author should ask themselves 'is there a simpler way to introduce the same functionality?'. If the answer is yes, the simpler course should be chosen
17. Refactoring should be used to make complex code simpler
18. Try to minimize the surface area (exported values) of each module and composable
19. Don't use barrel files, e.g. `/some/package/index.ts` to re-export within `/src`
20. Keep functions short and functional
21. Minimize [nesting](https://wiki.c2.com/?ArrowAntiPattern), e.g. `if () { ... }` or `for () { ... }`
22. Avoid mutable state, prefer immutability and assignment at point of declaration
23. Favor pure functions (especially testable ones)
24. Watch out for [Code Smells](https://wiki.c2.com/?CodeSmell) and refactor to avoid them
## External Resources ## External Resources
- Vue: <https://vuejs.org/api/> - Vue: <https://vuejs.org/api/>
- Tailwind: <https://tailwindcss.com/docs/styling-with-utility-classes> - Tailwind: <https://tailwindcss.com/docs/styling-with-utility-classes>
- VueUse: <https://vueuse.org/functions.html>
- shadcn/vue: <https://www.shadcn-vue.com/> - shadcn/vue: <https://www.shadcn-vue.com/>
- Reka UI: <https://reka-ui.com/> - Reka UI: <https://reka-ui.com/>
- PrimeVue: <https://primevue.org> - PrimeVue: <https://primevue.org>
- ComfyUI: <https://docs.comfy.org> - ComfyUI: <https://docs.comfy.org>
- Electron: <https://www.electronjs.org/docs/latest/> - Electron: <https://www.electronjs.org/docs/latest/>
- Wiki: <https://deepwiki.com/Comfy-Org/ComfyUI_frontend/1-overview> - Wiki: <https://deepwiki.com/Comfy-Org/ComfyUI_frontend/1-overview>
- Nx: <https://nx.dev/docs/reference/nx-commands>
## Project Philosophy ## Project Philosophy