Road to No explicit any: Group 8 (part 6) test files (#8344)

## Summary

This PR removes unsafe type assertions ("as unknown as Type") from test
files and improves type safety across the codebase.

### Key Changes

#### Type Safety Improvements
- Removed all instances of "as unknown as" patterns from test files
- Used proper factory functions from litegraphTestUtils instead of
custom mocks
- Made incomplete mocks explicit using Partial<T> types
- Fixed DialogStore mocking with proper interface exports
- Improved type safety with satisfies operator where applicable

#### App Parameter Removal
- **Removed the unused `app` parameter from all ComfyExtension interface
methods**
- The app parameter was always undefined at runtime as it was never
passed from invokeExtensions
- Affected methods: init, setup, addCustomNodeDefs,
beforeRegisterNodeDef, beforeRegisterVueAppNodeDefs,
registerCustomNodes, loadedGraphNode, nodeCreated, beforeConfigureGraph,
afterConfigureGraph

##### Breaking Change Analysis
Verified via Sourcegraph that this is NOT a breaking change:
- Searched all 10 affected methods across GitHub repositories
- Only one external repository
([drawthingsai/draw-things-comfyui](https://github.com/drawthingsai/draw-things-comfyui))
declares the app parameter in their extension methods
- That repository never actually uses the app parameter (just declares
it in the function signature)
- All other repositories already omit the app parameter
- Search queries used:
- [init method
search](https://sourcegraph.com/search?q=context:global+repo:%5Egithub%5C.com/.*+lang:typescript+%22init%28app%22+-repo:Comfy-Org/ComfyUI_frontend&patternType=standard)
- [setup method
search](https://sourcegraph.com/search?q=context:global+repo:%5Egithub%5C.com/.*+lang:typescript+%22setup%28app%22+-repo:Comfy-Org/ComfyUI_frontend&patternType=standard)
  - Similar searches for all 10 methods confirmed no usage

### Files Changed

Test files:
-
src/components/settings/widgets/__tests__/WidgetInputNumberInput.test.ts
- src/services/keybindingService.escape.test.ts  
- src/services/keybindingService.forwarding.test.ts
- src/utils/__tests__/newUserService.test.ts →
src/utils/__tests__/useNewUserService.test.ts
- src/services/jobOutputCache.test.ts
-
src/renderer/extensions/vueNodes/widgets/composables/useRemoteWidget.test.ts
-
src/renderer/extensions/vueNodes/widgets/composables/useIntWidget.test.ts
-
src/renderer/extensions/vueNodes/widgets/composables/useFloatWidget.test.ts

Source files:
- src/types/comfy.ts - Removed app parameter from ComfyExtension
interface
- src/services/extensionService.ts - Improved type safety with
FunctionPropertyNames helper
- src/scripts/metadata/isobmff.ts - Fixed extractJson return type per
review
- src/extensions/core/*.ts - Updated extension implementations
- src/scripts/app.ts - Updated app initialization

### Testing
- All existing tests pass
- Type checking passes  
- ESLint/oxlint checks pass
- No breaking changes for external repositories

Part of the "Road to No Explicit Any" initiative.

### Previous PRs in this series:
- Part 2: #7401
- Part 3: #7935
- Part 4: #7970
- Part 5: #8064
- Part 6: #8083
- Part 7: #8092
- Part 8 Group 1: #8253
- Part 8 Group 2: #8258
- Part 8 Group 3: #8304
- Part 8 Group 4: #8314
- Part 8 Group 5: #8329
- Part 8 Group 6: #8344 (this PR)

src/services/extensionService.ts

@@ -3,7 +3,6 @@ import { useErrorHandling } from '@/composables/useErrorHandling'
 import { legacyMenuCompat } from '@/lib/litegraph/src/contextMenuCompat'
 import { useSettingStore } from '@/platform/settings/settingStore'
 import { api } from '@/scripts/api'
-import { app } from '@/scripts/app'
 import { useCommandStore } from '@/stores/commandStore'
 import { useExtensionStore } from '@/stores/extensionStore'
 import { KeybindingImpl, useKeybindingStore } from '@/stores/keybindingStore'
@@ -12,6 +11,8 @@ import { useWidgetStore } from '@/stores/widgetStore'
 import { useBottomPanelStore } from '@/stores/workspace/bottomPanelStore'
 import type { ComfyExtension } from '@/types/comfy'
 import type { AuthUserInfo } from '@/types/authTypes'
+import { app } from '@/scripts/app'
+import type { ComfyApp } from '@/scripts/app'
 
 export const useExtensionService = () => {
   const extensionStore = useExtensionStore()
@@ -135,14 +136,28 @@ export const useExtensionService = () => {
     }
   }
 
+  type FunctionPropertyNames<T> = {
+    [K in keyof T]: T[K] extends (...args: unknown[]) => unknown ? K : never
+  }[keyof T]
+  type RemoveLastAppParam<T> = T extends (
+    ...args: [...infer Rest, ComfyApp]
+  ) => infer R
+    ? (...args: Rest) => R
+    : T
+
+  type ComfyExtensionParamsWithoutApp<T extends keyof ComfyExtension> =
+    RemoveLastAppParam<ComfyExtension[T]>
   /**
    * Invoke an extension callback
    * @param {keyof ComfyExtension} method The extension callback to execute
-   * @param  {any[]} args Any arguments to pass to the callback
+   * @param  {unknown[]} args Any arguments to pass to the callback
    * @returns
    */
-  const invokeExtensions = (method: keyof ComfyExtension, ...args: any[]) => {
-    const results: any[] = []
+  const invokeExtensions = <T extends FunctionPropertyNames<ComfyExtension>>(
+    method: T,
+    ...args: Parameters<ComfyExtensionParamsWithoutApp<T>>
+  ) => {
+    const results: ReturnType<ComfyExtension[T]>[] = []
     for (const ext of extensionStore.enabledExtensions) {
       if (method in ext) {
         try {
@@ -164,12 +179,14 @@ export const useExtensionService = () => {
    * Invoke an async extension callback
    * Each callback will be invoked concurrently
    * @param {string} method The extension callback to execute
-   * @param  {...any} args Any arguments to pass to the callback
+   * @param  {...unknown} args Any arguments to pass to the callback
    * @returns
    */
-  const invokeExtensionsAsync = async (
-    method: keyof ComfyExtension,
-    ...args: any[]
+  const invokeExtensionsAsync = async <
+    T extends FunctionPropertyNames<ComfyExtension>
+  >(
+    method: T,
+    ...args: Parameters<ComfyExtensionParamsWithoutApp<T>>
   ) => {
     return await Promise.all(
       extensionStore.enabledExtensions.map(async (ext) => {

src/services/gateway/registrySearchGateway.test.ts

@@ -9,8 +9,8 @@ vi.mock('@/services/providers/algoliaSearchProvider')
 vi.mock('@/services/providers/registrySearchProvider')
 
 describe('useRegistrySearchGateway', () => {
-  let consoleWarnSpy: any
-  let consoleInfoSpy: any
+  let consoleWarnSpy: ReturnType<typeof vi.spyOn>
+  let consoleInfoSpy: ReturnType<typeof vi.spyOn>
 
   beforeEach(() => {
     vi.clearAllMocks()

src/services/jobOutputCache.test.ts

@@ -6,6 +6,7 @@ import type {
   JobDetail,
   JobListItem
 } from '@/platform/remote/comfyui/jobs/jobTypes'
+import type { ComfyWorkflowJSON } from '@/platform/workflow/validation/schemas/workflowSchema'
 import {
   findActiveIndex,
   getJobDetail,
@@ -257,10 +258,12 @@ describe('jobOutputCache', () => {
         priority: 0,
         outputs: {}
       }
-      const mockWorkflow = { version: 1 }
+      const mockWorkflow = { version: 1 } as Partial<ComfyWorkflowJSON>
 
       vi.mocked(api.getJobDetail).mockResolvedValue(mockDetail)
-      vi.mocked(extractWorkflow).mockResolvedValue(mockWorkflow as any)
+      vi.mocked(extractWorkflow).mockResolvedValue(
+        mockWorkflow as ComfyWorkflowJSON
+      )
 
       const result = await getJobWorkflow(jobId)
 

src/services/keybindingService.escape.test.ts

@@ -5,6 +5,7 @@ import { beforeEach, describe, expect, it, vi } from 'vitest'
 import { CORE_KEYBINDINGS } from '@/constants/coreKeybindings'
 import { useKeybindingService } from '@/services/keybindingService'
 import { useCommandStore } from '@/stores/commandStore'
+import type { DialogInstance } from '@/stores/dialogStore'
 import { useDialogStore } from '@/stores/dialogStore'
 import {
   KeyComboImpl,
@@ -38,10 +39,13 @@ describe('keybindingService - Escape key handling', () => {
     mockCommandExecute = vi.fn()
     commandStore.execute = mockCommandExecute
 
-    // Reset dialog store mock to empty
+    // Reset dialog store mock to empty - only mock the properties we need for testing
     vi.mocked(useDialogStore).mockReturnValue({
-      dialogStack: []
-    } as any)
+      dialogStack: [],
+      // Add other required properties as undefined/default values to satisfy the type
+      // but they won't be used in these tests
+      ...({} as Omit<ReturnType<typeof useDialogStore>, 'dialogStack'>)
+    })
 
     keybindingService = useKeybindingService()
     keybindingService.registerCoreKeybindings()
@@ -179,8 +183,10 @@ describe('keybindingService - Escape key handling', () => {
   it('should not execute Escape keybinding when dialogs are open', async () => {
     // Mock dialog store to have open dialogs
     vi.mocked(useDialogStore).mockReturnValue({
-      dialogStack: [{ key: 'test-dialog' }]
-    } as any)
+      dialogStack: [{ key: 'test-dialog' } as DialogInstance],
+      // Add other required properties as undefined/default values to satisfy the type
+      ...({} as Omit<ReturnType<typeof useDialogStore>, 'dialogStack'>)
+    })
 
     // Re-create keybinding service to pick up new mock
     keybindingService = useKeybindingService()

src/services/keybindingService.forwarding.test.ts

@@ -78,7 +78,9 @@ describe('keybindingService - Event Forwarding', () => {
     // Reset dialog store mock to empty
     vi.mocked(useDialogStore).mockReturnValue({
       dialogStack: []
-    } as any)
+    } as Partial<ReturnType<typeof useDialogStore>> as ReturnType<
+      typeof useDialogStore
+    >)
 
     keybindingService = useKeybindingService()
     keybindingService.registerCoreKeybindings()
@@ -126,33 +128,35 @@ describe('keybindingService - Event Forwarding', () => {
   })
 
   it('should not forward Delete key when canvas processKey is not available', async () => {
-    // Temporarily replace processKey with undefined
+    // Temporarily replace processKey with undefined - testing edge case
     const originalProcessKey = vi.mocked(app.canvas).processKey
-    vi.mocked(app.canvas).processKey = undefined as any
+    vi.mocked(app.canvas).processKey = undefined!
 
     const event = createTestKeyboardEvent('Delete')
 
-    await keybindingService.keybindHandler(event)
-
-    expect(vi.mocked(useCommandStore().execute)).not.toHaveBeenCalled()
-
-    // Restore processKey for other tests
-    vi.mocked(app.canvas).processKey = originalProcessKey
+    try {
+      await keybindingService.keybindHandler(event)
+      expect(vi.mocked(useCommandStore().execute)).not.toHaveBeenCalled()
+    } finally {
+      // Restore processKey for other tests
+      vi.mocked(app.canvas).processKey = originalProcessKey
+    }
   })
 
   it('should not forward Delete key when canvas is not available', async () => {
     // Temporarily set canvas to null
     const originalCanvas = vi.mocked(app).canvas
-    vi.mocked(app).canvas = null as any
+    vi.mocked(app).canvas = null!
 
     const event = createTestKeyboardEvent('Delete')
 
-    await keybindingService.keybindHandler(event)
-
-    expect(vi.mocked(useCommandStore().execute)).not.toHaveBeenCalled()
-
-    // Restore canvas for other tests
-    vi.mocked(app).canvas = originalCanvas
+    try {
+      await keybindingService.keybindHandler(event)
+      expect(vi.mocked(useCommandStore().execute)).not.toHaveBeenCalled()
+    } finally {
+      // Restore canvas for other tests
+      vi.mocked(app).canvas = originalCanvas
+    }
   })
 
   it('should not forward non-canvas keys', async () => {

src/services/mediaCacheService.test.ts

@@ -7,7 +7,7 @@ global.fetch = vi.fn()
 global.URL = {
   createObjectURL: vi.fn(() => 'blob:mock-url'),
   revokeObjectURL: vi.fn()
-} as any
+} as Partial<typeof URL> as typeof URL
 
 describe('mediaCacheService', () => {
   describe('URL reference counting', () => {