From cb0861edf581cc12c1d61d38a74f90c0d582bd1a Mon Sep 17 00:00:00 2001 From: bymyself Date: Thu, 6 Nov 2025 13:05:27 -0700 Subject: [PATCH] [style] apply review feedback: simplify conditional logic Simplify conditional class logic in FormSelectButton.vue per review suggestion: - Combine cursor classes into single ternary - Combine background classes into nested ternary with !disabled guard --- .../widgets/components/form/FormSelectButton.vue | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/src/renderer/extensions/vueNodes/widgets/components/form/FormSelectButton.vue b/src/renderer/extensions/vueNodes/widgets/components/form/FormSelectButton.vue index 3745bc6029..34aae22875 100644 --- a/src/renderer/extensions/vueNodes/widgets/components/form/FormSelectButton.vue +++ b/src/renderer/extensions/vueNodes/widgets/components/form/FormSelectButton.vue @@ -15,14 +15,11 @@ 'flex-1 h-6 px-5 py-[5px] rounded flex justify-center items-center gap-1 transition-all duration-150 ease-in-out', 'bg-transparent border-none', 'text-center text-xs font-normal', - { - 'bg-interface-menu-component-surface-selected': - isSelected(option) && !disabled, - 'hover:bg-interface-menu-component-surface-hovered': - !isSelected(option) && !disabled, - 'opacity-50 cursor-not-allowed': disabled, - 'cursor-pointer': !disabled - }, + disabled ? 'opacity-50 cursor-not-allowed' : 'cursor-pointer', + !disabled && + (isSelected(option) + ? 'bg-interface-menu-component-surface-selected' + : 'hover:bg-interface-menu-component-surface-hovered'), isSelected(option) && !disabled ? 'text-primary' : 'text-secondary' ) "