From cfdd002b7cc3e14a9ca2a28a5cbd08251dd5d555 Mon Sep 17 00:00:00 2001 From: Johnpaul Chiwetelu <49923152+Myestery@users.noreply.github.com> Date: Mon, 2 Feb 2026 17:16:40 +0100 Subject: [PATCH] Road to No Explicit Any Part 10 (#8499) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ## Summary This PR removes `any` types from UI component files and replaces them with proper TypeScript types. ### Key Changes #### Type Safety Improvements - Replaced `any` with `unknown`, explicit types, or proper interfaces across UI components - Used `ComponentPublicInstance` with explicit method signatures for component refs - Used `Record` for dynamic property access - Added generics for form components with flexible value types - Used `CSSProperties` for style objects ### Files Changed UI Components: - src/components/common/ComfyImage.vue - Used proper class prop type - src/components/common/DeviceInfo.vue - Used `string | number` for formatValue - src/components/common/FormItem.vue - Used `unknown` for model value - src/components/common/FormRadioGroup.vue - Added generic type parameter - src/components/common/TreeExplorer.vue - Used proper async function signature - src/components/custom/widget/WorkflowTemplateSelectorDialog.vue - Fixed duplicate import - src/components/graph/CanvasModeSelector.vue - Used `ComponentPublicInstance` for ref - src/components/node/NodePreview.vue - Changed `any` to `unknown` - src/components/queue/job/JobDetailsPopover.vue - Removed unnecessary casts - src/components/queue/job/JobFiltersBar.vue - Removed `as any` casts - src/platform/assets/components/MediaAssetContextMenu.vue - Added `ContextMenuInstance` type - src/renderer/extensions/minimap/MiniMapPanel.vue - Used `CSSProperties` - src/renderer/extensions/vueNodes/composables/useNodeTooltips.ts - Added `PrimeVueTooltipElement` interface - src/renderer/extensions/vueNodes/widgets/components/form/FormSelectButton.vue - Used `Record` - src/workbench/extensions/manager/components/manager/infoPanel/tabs/DescriptionTabPanel.vue - Added `LicenseObject` interface ### Testing - All TypeScript type checking passes (`pnpm typecheck`) - Linting passes without errors (`pnpm lint`) Part of the "Road to No Explicit Any" initiative. ### Previous PRs in this series: - Part 2: #7401 - Part 3: #7935 - Part 4: #7970 - Part 5: #8064 - Part 6: #8083 - Part 7: #8092 - Part 8 Group 1: #8253 - Part 8 Group 2: #8258 - Part 8 Group 3: #8304 - Part 8 Group 4: #8314 - Part 8 Group 5: #8329 - Part 8 Group 6: #8344 - Part 8 Group 7: #8459 - Part 8 Group 8: #8496 - Part 9: #8498 - Part 10: #8499 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-8499-Road-to-No-Explicit-Any-Part-10-2f86d73d365081aab129f165c7d02434) by [Unito](https://www.unito.io) --- src/components/common/ComfyImage.vue | 5 ++++- src/components/common/DeviceInfo.vue | 8 ++++++-- src/components/common/FormItem.vue | 4 ++-- src/components/common/FormRadioGroup.vue | 6 +++--- src/components/common/TreeExplorer.vue | 2 +- .../widget/WorkflowTemplateSelectorDialog.vue | 4 ++-- src/components/graph/CanvasModeSelector.vue | 5 +++-- src/components/node/NodePreview.vue | 5 ++++- .../queue/job/JobDetailsPopover.vue | 4 ++-- src/components/queue/job/JobFiltersBar.vue | 4 ++-- .../components/MediaAssetContextMenu.vue | 10 ++++++++-- .../extensions/minimap/MiniMapPanel.vue | 3 ++- .../vueNodes/composables/useNodeTooltips.ts | 7 ++++++- .../components/form/FormSelectButton.vue | 20 ++++++++++--------- .../infoPanel/tabs/DescriptionTabPanel.vue | 7 ++++++- 15 files changed, 62 insertions(+), 32 deletions(-) diff --git a/src/components/common/ComfyImage.vue b/src/components/common/ComfyImage.vue index aa6a66c55..351d1cde4 100644 --- a/src/components/common/ComfyImage.vue +++ b/src/components/common/ComfyImage.vue @@ -38,7 +38,10 @@ const { alt = 'Image content' } = defineProps<{ src: string - class?: any + class?: + | string + | Record + | (string | Record)[] contain?: boolean alt?: string }>() diff --git a/src/components/common/DeviceInfo.vue b/src/components/common/DeviceInfo.vue index 8e00fd16b..ab141cfbc 100644 --- a/src/components/common/DeviceInfo.vue +++ b/src/components/common/DeviceInfo.vue @@ -28,13 +28,17 @@ const deviceColumns: { field: keyof DeviceStats; header: string }[] = [ { field: 'torch_vram_free', header: 'Torch VRAM Free' } ] -const formatValue = (value: any, field: string) => { +const formatValue = (value: string | number, field: string) => { if ( ['vram_total', 'vram_free', 'torch_vram_total', 'torch_vram_free'].includes( field ) ) { - return formatSize(value) + const num = Number(value) + if (Number.isFinite(num)) { + return formatSize(num) + } + return value } return value } diff --git a/src/components/common/FormItem.vue b/src/components/common/FormItem.vue index 011f80753..b2161b2e7 100644 --- a/src/components/common/FormItem.vue +++ b/src/components/common/FormItem.vue @@ -47,7 +47,7 @@ import InputSlider from '@/components/common/InputSlider.vue' import UrlInput from '@/components/common/UrlInput.vue' import type { FormItem } from '@/platform/settings/types' -const formValue = defineModel('formValue') +const formValue = defineModel('formValue') const props = defineProps<{ item: FormItem id?: string @@ -61,7 +61,7 @@ function getFormAttrs(item: FormItem) { attrs['renderFunction'] = () => inputType( props.item.name, - (v: any) => (formValue.value = v), + (v: unknown) => (formValue.value = v), formValue.value, item.attrs ) diff --git a/src/components/common/FormRadioGroup.vue b/src/components/common/FormRadioGroup.vue index 6155bed0f..607a3c407 100644 --- a/src/components/common/FormRadioGroup.vue +++ b/src/components/common/FormRadioGroup.vue @@ -20,14 +20,14 @@ -