mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-02-20 14:54:12 +00:00
feat: use object info display_name as fallback before node name (#7622)
## Description Implements fallback to object info display_name before using internal node name when display_name is unavailable. ## Related Issue Related to backend PR: comfyanonymous/ComfyUI#11340 ## Changes - Modified `getNodeDefs()` to use object info `display_name` before falling back to `name` - Added unit tests for display name fallback behavior ## Testing - All existing tests pass - Added 4 new unit tests covering various display_name scenarios ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7622-W-I-P-feat-use-object-info-display_name-as-fallback-before-node-name-2cd6d73d365081deb22fe5ed00e6dc2e) by [Unito](https://www.unito.io)
This commit is contained in:
@@ -953,20 +953,25 @@ export class ComfyApp {
|
||||
}
|
||||
|
||||
async getNodeDefs(): Promise<Record<string, ComfyNodeDefV1>> {
|
||||
const translateNodeDef = (def: ComfyNodeDefV1): ComfyNodeDefV1 => ({
|
||||
...def,
|
||||
display_name: st(
|
||||
`nodeDefs.${def.name}.display_name`,
|
||||
def.display_name ?? def.name
|
||||
),
|
||||
description: def.description
|
||||
? st(`nodeDefs.${def.name}.description`, def.description)
|
||||
: '',
|
||||
category: def.category
|
||||
.split('/')
|
||||
.map((category: string) => st(`nodeCategories.${category}`, category))
|
||||
.join('/')
|
||||
})
|
||||
const translateNodeDef = (def: ComfyNodeDefV1): ComfyNodeDefV1 => {
|
||||
// Use object info display_name as fallback before using name
|
||||
const objectInfoDisplayName = def.display_name || def.name
|
||||
|
||||
return {
|
||||
...def,
|
||||
display_name: st(
|
||||
`nodeDefs.${def.name}.display_name`,
|
||||
objectInfoDisplayName
|
||||
),
|
||||
description: def.description
|
||||
? st(`nodeDefs.${def.name}.description`, def.description)
|
||||
: '',
|
||||
category: def.category
|
||||
.split('/')
|
||||
.map((category: string) => st(`nodeCategories.${category}`, category))
|
||||
.join('/')
|
||||
}
|
||||
}
|
||||
|
||||
return _.mapValues(await api.getNodeDefs(), (def) => translateNodeDef(def))
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user