From d6a5deccd8e9b1267d727ddff30fd03b98421dfd Mon Sep 17 00:00:00 2001
From: Chenlei Hu <huchenlei@proton.me>
Date: Sun, 16 Feb 2025 15:39:58 -0500
Subject: [PATCH] [Refactor] useAbsolutePosition composable (#2589)

---
 src/components/graph/TitleEditor.vue          | 53 ++++++-------------
 .../element/useAbsolutePosition.ts            | 48 +++++++++++++++++
 2 files changed, 65 insertions(+), 36 deletions(-)
 create mode 100644 src/composables/element/useAbsolutePosition.ts

diff --git a/src/components/graph/TitleEditor.vue b/src/components/graph/TitleEditor.vue
index 0ce9dae52..ec0ae2e44 100644
--- a/src/components/graph/TitleEditor.vue
+++ b/src/components/graph/TitleEditor.vue
@@ -16,9 +16,10 @@
 import { LGraphGroup, LGraphNode, LiteGraph } from '@comfyorg/litegraph'
 import type { LiteGraphCanvasEvent } from '@comfyorg/litegraph'
 import { useEventListener } from '@vueuse/core'
-import { CSSProperties, ref, watch } from 'vue'
+import { ref, watch } from 'vue'
 
 import EditableText from '@/components/common/EditableText.vue'
+import { useAbsolutePosition } from '@/composables/element/useAbsolutePosition'
 import { app } from '@/scripts/app'
 import { useCanvasStore, useTitleEditorStore } from '@/stores/graphStore'
 import { useSettingStore } from '@/stores/settingStore'
@@ -27,14 +28,7 @@ const settingStore = useSettingStore()
 
 const showInput = ref(false)
 const editedTitle = ref('')
-const inputStyle = ref<CSSProperties>({
-  position: 'fixed',
-  left: '0px',
-  top: '0px',
-  width: '200px',
-  height: '20px',
-  fontSize: '12px'
-})
+const { style: inputStyle, updatePosition } = useAbsolutePosition()
 
 const titleEditorStore = useTitleEditorStore()
 const canvasStore = useCanvasStore()
@@ -63,36 +57,23 @@ watch(
 
     if (target instanceof LGraphGroup) {
       const group = target
-      const [x, y] = group.pos
-      const [w, h] = group.size
-
-      const [left, top] = app.canvasPosToClientPos([x, y])
-      inputStyle.value.left = `${left}px`
-      inputStyle.value.top = `${top}px`
-
-      const width = w * app.canvas.ds.scale
-      const height = group.titleHeight * app.canvas.ds.scale
-      inputStyle.value.width = `${width}px`
-      inputStyle.value.height = `${height}px`
-
-      const fontSize = group.font_size * app.canvas.ds.scale
-      inputStyle.value.fontSize = `${fontSize}px`
+      updatePosition(
+        {
+          pos: group.pos,
+          size: [group.size[0], group.titleHeight]
+        },
+        { fontSize: group.font_size }
+      )
     } else if (target instanceof LGraphNode) {
       const node = target
       const [x, y] = node.getBounding()
-      const canvasWidth = node.width
-      const canvasHeight = LiteGraph.NODE_TITLE_HEIGHT
-
-      const [left, top] = app.canvasPosToClientPos([x, y])
-      inputStyle.value.left = `${left}px`
-      inputStyle.value.top = `${top}px`
-
-      const width = canvasWidth * app.canvas.ds.scale
-      const height = canvasHeight * app.canvas.ds.scale
-      inputStyle.value.width = `${width}px`
-      inputStyle.value.height = `${height}px`
-      const fontSize = 12 * app.canvas.ds.scale
-      inputStyle.value.fontSize = `${fontSize}px`
+      updatePosition(
+        {
+          pos: [x, y],
+          size: [node.width, LiteGraph.NODE_TITLE_HEIGHT]
+        },
+        { fontSize: 12 }
+      )
     }
   }
 )
diff --git a/src/composables/element/useAbsolutePosition.ts b/src/composables/element/useAbsolutePosition.ts
new file mode 100644
index 000000000..73b156b87
--- /dev/null
+++ b/src/composables/element/useAbsolutePosition.ts
@@ -0,0 +1,48 @@
+import type { Size, Vector2 } from '@comfyorg/litegraph'
+import { CSSProperties, ref } from 'vue'
+
+import { app } from '@/scripts/app'
+import { useCanvasStore } from '@/stores/graphStore'
+
+export interface PositionConfig {
+  /* The position of the element on litegraph canvas */
+  pos: Vector2
+  /* The size of the element on litegraph canvas */
+  size: Size
+  /* The scale factor of the canvas */
+  scale?: number
+}
+
+export function useAbsolutePosition() {
+  const canvasStore = useCanvasStore()
+  const style = ref<CSSProperties>({
+    position: 'fixed',
+    left: '0px',
+    top: '0px',
+    width: '0px',
+    height: '0px'
+  })
+
+  const updatePosition = (
+    config: PositionConfig,
+    extraStyle?: CSSProperties
+  ) => {
+    const { pos, size, scale = canvasStore.canvas?.ds?.scale ?? 1 } = config
+    const [left, top] = app.canvasPosToClientPos(pos)
+    const [width, height] = size
+
+    style.value = {
+      ...style.value,
+      left: `${left}px`,
+      top: `${top}px`,
+      width: `${width * scale}px`,
+      height: `${height * scale}px`,
+      ...extraStyle
+    }
+  }
+
+  return {
+    style,
+    updatePosition
+  }
+}