From d9936fc8d5e22a0219ab9492a5353bb2f48c9d33 Mon Sep 17 00:00:00 2001 From: Jin Yi Date: Sun, 31 Aug 2025 14:01:54 +0900 Subject: [PATCH] refactor: Fix SearchBox v-model binding and rename ModelSelector to SampleModelSelector SearchBox: - Fix defineModel usage to use default 'modelValue' prop name - Remove incorrect empty string parameter that caused Vue warning - Add comment explaining defineModel behavior SampleModelSelector (formerly ModelSelector): - Rename ModelSelector.vue to SampleModelSelector.vue to indicate it's a sample component - Fix v-model syntax error in SearchBox binding (remove extra '=' character) - Add v-model:search-query binding to MultiSelect for search functionality - Add watch handlers for searchText and searchQuery debugging - Import watch from Vue and add searchText ref for MultiSelect search useModelSelectorDialog: - Update import to use renamed SampleModelSelector component These changes fix the v-model binding issues preventing search functionality from working properly in both the header SearchBox and MultiSelect components. Co-Authored-By: Claude --- src/components/input/SearchBox.vue | 3 ++- .../{ModelSelector.vue => SampleModelSelector.vue} | 14 ++++++++++++-- src/composables/useModelSelectorDialog.ts | 4 ++-- 3 files changed, 16 insertions(+), 5 deletions(-) rename src/components/widget/{ModelSelector.vue => SampleModelSelector.vue} (94%) diff --git a/src/components/input/SearchBox.vue b/src/components/input/SearchBox.vue index a28db6a60..dcf9212a0 100644 --- a/src/components/input/SearchBox.vue +++ b/src/components/input/SearchBox.vue @@ -19,7 +19,8 @@ const { placeHolder, showBorder = false } = defineProps<{ placeHolder?: string showBorder?: boolean }>() -const searchQuery = defineModel('') +// defineModel without arguments uses 'modelValue' as the prop name +const searchQuery = defineModel() const wrapperStyle = computed(() => { return showBorder diff --git a/src/components/widget/ModelSelector.vue b/src/components/widget/SampleModelSelector.vue similarity index 94% rename from src/components/widget/ModelSelector.vue rename to src/components/widget/SampleModelSelector.vue index 6cb351a7c..8a5ea674e 100644 --- a/src/components/widget/ModelSelector.vue +++ b/src/components/widget/SampleModelSelector.vue @@ -12,7 +12,7 @@