fix: handle failed global subgraph blueprint loading gracefully (#9063)

## Summary

Fix "Failed to load subgraph blueprints Error: [ASSERT] Workflow content
should be loaded" error occurring on cloud.

## Changes

- **What**: `getGlobalSubgraphData` now throws on API failure instead of
returning empty string, global blueprint data is validated before
loading, and individual global blueprint errors are properly propagated
to the toast/console reporting instead of being silently swallowed.

## Review Focus

Two root causes were fixed:
1. `getGlobalSubgraphData` returned `""` on failure — this empty string
was set as `originalContent`, which is falsy, triggering the assertion
in `ComfyWorkflow.load()`.
2. `loadInstalledBlueprints` used an internal `Promise.allSettled` whose
results were discarded, so individual global blueprint failures never
reached the error reporting in `fetchSubgraphs`.

Fixes COM-15199

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-9063-fix-handle-failed-global-subgraph-blueprint-loading-gracefully-30e6d73d3650818d9cc8ecf81cd0264e)
by [Unito](https://www.unito.io)
This commit is contained in:
Christian Byrne
2026-02-21 16:30:01 -08:00
committed by GitHub
parent 8f48b11f6a
commit d9fdb01d9b
4 changed files with 92 additions and 9 deletions

View File

@@ -225,6 +225,68 @@ describe('useSubgraphStore', () => {
})
})
it('should handle global blueprint with empty data gracefully', async () => {
const consoleSpy = vi.spyOn(console, 'error').mockImplementation(() => {})
await mockFetch(
{},
{
broken_blueprint: {
name: 'Broken Blueprint',
info: { node_pack: 'test_pack' },
data: ''
}
}
)
expect(consoleSpy).toHaveBeenCalledWith(
'Failed to load subgraph blueprint',
expect.any(Error)
)
expect(store.subgraphBlueprints).toHaveLength(0)
consoleSpy.mockRestore()
})
it('should handle global blueprint with rejected data promise gracefully', async () => {
const consoleSpy = vi.spyOn(console, 'error').mockImplementation(() => {})
await mockFetch(
{},
{
failing_blueprint: {
name: 'Failing Blueprint',
info: { node_pack: 'test_pack' },
data: Promise.reject(new Error('Network error')) as unknown as string
}
}
)
expect(consoleSpy).toHaveBeenCalledWith(
'Failed to load subgraph blueprint',
expect.any(Error)
)
expect(store.subgraphBlueprints).toHaveLength(0)
consoleSpy.mockRestore()
})
it('should load valid global blueprints even when others fail', async () => {
const consoleSpy = vi.spyOn(console, 'error').mockImplementation(() => {})
await mockFetch(
{},
{
broken: {
name: 'Broken',
info: { node_pack: 'test_pack' },
data: ''
},
valid: {
name: 'Valid Blueprint',
info: { node_pack: 'test_pack' },
data: JSON.stringify(mockGraph)
}
}
)
expect(consoleSpy).toHaveBeenCalled()
expect(store.subgraphBlueprints).toHaveLength(1)
consoleSpy.mockRestore()
})
describe('search_aliases support', () => {
it('should include search_aliases from workflow extra', async () => {
const mockGraphWithAliases = {