From dcda95d0efc65e27ed7222f6bd8d61747a9afca8 Mon Sep 17 00:00:00 2001
From: Christian Byrne <cbyrne@comfy.org>
Date: Sat, 1 Nov 2025 12:45:29 -0700
Subject: [PATCH] fix: correct subscription credits test values and improve
 test stability (#6519)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

## Summary
- Fix `useSubscriptionCredits` test to use cents (500) instead of
incorrect micros (5000000)
- Despite API field names containing `micros`, the server actually
returns cents (1/100)
- Add clarifying comment to `usdToMicros()` about the cents vs micros
confusion
- Increase performance test threshold from 10ms to 50ms to reduce
flakiness

## Context
The API response fields are named `amount_micros`,
`cloud_credit_balance_micros`, etc., but the server actually sends
**cents** (1/100 of a dollar), not true micros (1/1,000,000).

Verified with real API response:
```json
{
  "amount_micros": 2725.927956,  // = $27.26 when divided by 100
  "currency": "usd"
}
```

## Changes
-
`tests-ui/tests/platform/cloud/subscription/composables/useSubscriptionCredits.test.ts`:
Update test values from micros to cents
- `packages/shared-frontend-utils/src/formatUtil.ts`: Add clarifying
documentation
- `tests-ui/tests/store/modelToNodeStore.test.ts`: Increase performance
test threshold to reduce flakiness

## Test Plan
- ✅ All unit tests pass (3202 passed, 206 skipped)
- ✅ Linting passes
- ✅ Formatting passes

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Claude <noreply@anthropic.com>
---
 packages/shared-frontend-utils/src/formatUtil.ts   |  4 ++++
 .../composables/useSubscriptionCredits.test.ts     | 14 +++++++-------
 tests-ui/tests/store/modelToNodeStore.test.ts      |  3 ++-
 3 files changed, 13 insertions(+), 8 deletions(-)

diff --git a/packages/shared-frontend-utils/src/formatUtil.ts b/packages/shared-frontend-utils/src/formatUtil.ts
index 658498f1f..184651bf1 100644
--- a/packages/shared-frontend-utils/src/formatUtil.ts
+++ b/packages/shared-frontend-utils/src/formatUtil.ts
@@ -370,6 +370,10 @@ export function formatMetronomeCurrency(
  * This conversion is commonly used in financial systems to avoid floating-point precision issues
  * by representing monetary values as integers.
  *
+ * Note: Despite the function name and the field names in the API (e.g., `amount_micros`),
+ * some API responses actually return cents (1/100) instead of true micros (1/1,000,000).
+ * Use `formatMetronomeCurrency` for displaying balance amounts from the API.
+ *
  * @param usd - The amount in US dollars to convert
  * @returns The amount in microdollars (multiplied by 1,000,000)
  * @example
diff --git a/tests-ui/tests/platform/cloud/subscription/composables/useSubscriptionCredits.test.ts b/tests-ui/tests/platform/cloud/subscription/composables/useSubscriptionCredits.test.ts
index 11bd33445..7af7f47ee 100644
--- a/tests-ui/tests/platform/cloud/subscription/composables/useSubscriptionCredits.test.ts
+++ b/tests-ui/tests/platform/cloud/subscription/composables/useSubscriptionCredits.test.ts
@@ -60,9 +60,9 @@ vi.mock('@/stores/apiKeyAuthStore', () => ({
 
 // Mock formatMetronomeCurrency
 vi.mock('@/utils/formatUtil', () => ({
-  formatMetronomeCurrency: vi.fn((micros: number) => {
-    // Simple mock that converts micros to dollars
-    return (micros / 1000000).toFixed(2)
+  formatMetronomeCurrency: vi.fn((amount: number) => {
+    // Converts cents to dollars (despite the field name containing "micros")
+    return (amount / 100).toFixed(2)
   })
 }))
 
@@ -89,7 +89,7 @@ describe('useSubscriptionCredits', () => {
     })
 
     it('should format amount_micros correctly', () => {
-      authStore.balance = { amount_micros: 5000000 } as any
+      authStore.balance = { amount_micros: 500 } as any
       const { totalCredits } = useSubscriptionCredits()
       expect(totalCredits.value).toBe('5.00')
     })
@@ -102,7 +102,7 @@ describe('useSubscriptionCredits', () => {
         throw new Error('Formatting error')
       })
 
-      authStore.balance = { amount_micros: 5000000 } as any
+      authStore.balance = { amount_micros: 500 } as any
       const { totalCredits } = useSubscriptionCredits()
       expect(totalCredits.value).toBe('0.00')
     })
@@ -116,7 +116,7 @@ describe('useSubscriptionCredits', () => {
     })
 
     it('should format cloud_credit_balance_micros correctly', () => {
-      authStore.balance = { cloud_credit_balance_micros: 2500000 } as any
+      authStore.balance = { cloud_credit_balance_micros: 250 } as any
       const { monthlyBonusCredits } = useSubscriptionCredits()
       expect(monthlyBonusCredits.value).toBe('2.50')
     })
@@ -130,7 +130,7 @@ describe('useSubscriptionCredits', () => {
     })
 
     it('should format prepaid_balance_micros correctly', () => {
-      authStore.balance = { prepaid_balance_micros: 7500000 } as any
+      authStore.balance = { prepaid_balance_micros: 750 } as any
       const { prepaidCredits } = useSubscriptionCredits()
       expect(prepaidCredits.value).toBe('7.50')
     })
diff --git a/tests-ui/tests/store/modelToNodeStore.test.ts b/tests-ui/tests/store/modelToNodeStore.test.ts
index c79af19b5..a53e884f4 100644
--- a/tests-ui/tests/store/modelToNodeStore.test.ts
+++ b/tests-ui/tests/store/modelToNodeStore.test.ts
@@ -449,7 +449,8 @@ describe('useModelToNodeStore', () => {
       const end = performance.now()
 
       // Should be fast enough for UI responsiveness
-      expect(end - start).toBeLessThan(10)
+      // Increased threshold to 50ms to account for system variability
+      expect(end - start).toBeLessThan(50)
     })
 
     it('should handle invalid input types gracefully', () => {