From dd192777b79940af6656909358c2dc99eb80be54 Mon Sep 17 00:00:00 2001
From: Chenlei Hu <huchenlei@proton.me>
Date: Thu, 7 Nov 2024 23:34:46 -0500
Subject: [PATCH] Consistently use -1 for temporary file size (#1464)

---
 src/stores/userFileStore.ts                     | 2 +-
 src/stores/workflowStore.ts                     | 2 +-
 tests-ui/tests/fast/store/userFileStore.test.ts | 4 +++-
 tests-ui/tests/fast/store/workflowStore.test.ts | 2 +-
 4 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/src/stores/userFileStore.ts b/src/stores/userFileStore.ts
index d73e07cf3..f0efb9978 100644
--- a/src/stores/userFileStore.ts
+++ b/src/stores/userFileStore.ts
@@ -65,7 +65,7 @@ export class UserFile {
   }
 
   get isTemporary() {
-    return this.size === 0
+    return this.size === -1
   }
 
   get isPersisted() {
diff --git a/src/stores/workflowStore.ts b/src/stores/workflowStore.ts
index e96984ec5..bb393741b 100644
--- a/src/stores/workflowStore.ts
+++ b/src/stores/workflowStore.ts
@@ -215,7 +215,7 @@ export const useWorkflowStore = defineStore('workflow', () => {
     const workflow = new ComfyWorkflow({
       path: fullPath,
       modified: Date.now(),
-      size: 0
+      size: -1
     })
 
     workflow.originalContent = workflow.content = workflowData
diff --git a/tests-ui/tests/fast/store/userFileStore.test.ts b/tests-ui/tests/fast/store/userFileStore.test.ts
index 050a6f728..9829d143b 100644
--- a/tests-ui/tests/fast/store/userFileStore.test.ts
+++ b/tests-ui/tests/fast/store/userFileStore.test.ts
@@ -191,7 +191,9 @@ describe('useUserFileStore', () => {
         expect(api.storeUserData).toHaveBeenCalledWith(
           'newfile.txt',
           'file content',
-          { throwOnError: true, full_info: true, overwrite: true }
+          // SaveAs should create a new temporary file, which will mean
+          // overwrite is false
+          { throwOnError: true, full_info: true, overwrite: false }
         )
         expect(newFile).toBeInstanceOf(UserFile)
         expect(newFile.path).toBe('newfile.txt')
diff --git a/tests-ui/tests/fast/store/workflowStore.test.ts b/tests-ui/tests/fast/store/workflowStore.test.ts
index c6168c57a..4b647f4ca 100644
--- a/tests-ui/tests/fast/store/workflowStore.test.ts
+++ b/tests-ui/tests/fast/store/workflowStore.test.ts
@@ -25,7 +25,7 @@ describe('useWorkflowStore', () => {
       filenames.map((filename) => ({
         path: filename,
         modified: new Date().toISOString(),
-        size: 1 // size !== 0 for remote workflows
+        size: 1 // size !== -1 for remote workflows
       }))
     )
     return await store.syncWorkflows()