Comfy-Org/ComfyUI_frontend
1
0
Fork 0
mirror of https://github.com/Comfy-Org/ComfyUI_frontend.git synced 2026-04-20 14:30:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

[refactor] Remove parentSubgraphNode property from widgets (#1145)

Browse Source
This commit is contained in:
Christian Byrne
2025-07-21 11:26:03 -07:00
committed by GitHub
parent efdb8080ae
commit def6010d72
4 changed files with 4 additions and 55 deletions
Download Patch File Download Diff File Expand all files Collapse all files

39
test/subgraph/SubgraphWidgetPromotion.test.ts
View File

@@ -55,10 +55,9 @@ describe("SubgraphWidgetPromotion", () => {
expect(subgraphNode.widgets[0].name).toBe("value") // Uses subgraph input name
expect(subgraphNode.widgets[0].type).toBe("number")
expect(subgraphNode.widgets[0].value).toBe(42)
expect(subgraphNode.widgets[0].parentSubgraphNode).toBe(subgraphNode)
})
it("should set parentSubgraphNode for all promoted widget types", () => {
it("should promote all widget types", () => {
const subgraph = createTestSubgraph({
inputs: [
{ name: "numberInput", type: "number" },
@@ -83,13 +82,9 @@ describe("SubgraphWidgetPromotion", () => {
const subgraphNode = createTestSubgraphNode(subgraph)
// All widgets should be promoted with parentSubgraphNode set
// All widgets should be promoted
expect(subgraphNode.widgets).toHaveLength(3)
for (const widget of subgraphNode.widgets) {
expect(widget.parentSubgraphNode).toBe(subgraphNode)
}
// Check specific widget values
expect(subgraphNode.widgets[0].value).toBe(100)
expect(subgraphNode.widgets[1].value).toBe("test")
@@ -113,7 +108,6 @@ describe("SubgraphWidgetPromotion", () => {
const promotedEvents = eventCapture.getEventsByType("widget-promoted")
expect(promotedEvents).toHaveLength(1)
expect(promotedEvents[0].detail.widget).toBeDefined()
expect(promotedEvents[0].detail.widget.parentSubgraphNode).toBe(subgraphNode)
expect(promotedEvents[0].detail.subgraphNode).toBe(subgraphNode)
eventCapture.cleanup()
@@ -192,32 +186,26 @@ describe("SubgraphWidgetPromotion", () => {
expect(subgraphNode.widgets).toHaveLength(2)
expect(subgraphNode.widgets[0].name).toBe("input1")
expect(subgraphNode.widgets[0].value).toBe(10)
expect(subgraphNode.widgets[0].parentSubgraphNode).toBe(subgraphNode)
expect(subgraphNode.widgets[1].name).toBe("input2")
expect(subgraphNode.widgets[1].value).toBe("hello")
expect(subgraphNode.widgets[1].parentSubgraphNode).toBe(subgraphNode)
})
it("should clean up parentSubgraphNode on node removal", () => {
it("should fire widget-demoted events when node is removed", () => {
const subgraph = createTestSubgraph({
inputs: [{ name: "input", type: "number" }],
})
const { node } = createNodeWithWidget("Test Node")
const subgraphNode = setupPromotedWidget(subgraph, node)
const promotedWidget = subgraphNode.widgets[0]
expect(promotedWidget.parentSubgraphNode).toBe(subgraphNode)
expect(subgraphNode.widgets).toHaveLength(1)
const eventCapture = createEventCapture(subgraph.events, ["widget-demoted"])
// Remove the subgraph node
subgraphNode.onRemoved()
// parentSubgraphNode should be cleared
expect(promotedWidget.parentSubgraphNode).toBeUndefined()
// Should fire demoted events for all widgets
const demotedEvents = eventCapture.getEventsByType("widget-demoted")
expect(demotedEvents).toHaveLength(1)
@@ -225,25 +213,6 @@ describe("SubgraphWidgetPromotion", () => {
eventCapture.cleanup()
})
it("should handle DOM widgets with parentSubgraphNode", () => {
const subgraph = createTestSubgraph({
inputs: [{ name: "domInput", type: "custom" }],
})
const { node, widget } = createNodeWithWidget("DOM Node", "custom", "custom value", "custom")
// Make it a DOM widget
widget.element = document.createElement("div")
const subgraphNode = setupPromotedWidget(subgraph, node)
// DOM widget should be promoted with parentSubgraphNode
expect(subgraphNode.widgets).toHaveLength(1)
const promotedWidget = subgraphNode.widgets[0]
expect(promotedWidget.parentSubgraphNode).toBe(subgraphNode)
expect(promotedWidget.name).toBe("domInput")
})
it("should not promote widget if input is not connected", () => {
const subgraph = createTestSubgraph({
inputs: [{ name: "input", type: "number" }],