Comfy-Org/ComfyUI_frontend
1
0
Fork 0
mirror of https://github.com/Comfy-Org/ComfyUI_frontend.git synced 2026-05-01 19:51:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

Address review comments and improve workflow

Browse Source 
- Add workflow documentation explaining selective update strategy
- Improve logging with clear output formatting (no emojis)
- Add GitHub Actions workflow summary with file change details
- Fix command injection vulnerability by validating test paths with regex
- Add error handling for JSON.parse with descriptive messages
- Replace non-null assertion with safer null checking pattern
- Add explicit error handling for TypeScript script execution
This commit is contained in:
bymyself
2025-10-12 16:00:38 -07:00
parent 83ff415815
commit df6723415b
3 changed files with 115 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
.github/workflows/tests-ci.yaml vendored
View File

@@ -256,7 +256,11 @@ jobs:
if: ${{ needs.playwright-tests-chromium-sharded.result == 'failure' }}
run: |
set -euo pipefail
pnpm tsx scripts/cicd/build-failed-screenshot-manifest.ts
if ! pnpm tsx scripts/cicd/build-failed-screenshot-manifest.ts; then
echo "ERROR: Failed to generate screenshot manifest"
echo "This may indicate an issue with the Playwright JSON report or the manifest script"
exit 1
fi
working-directory: ComfyUI_frontend
- name: Upload failed screenshot manifest