mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-04-29 10:42:44 +00:00
refactor: use orderBy for queue list sorting (#8228)
Use es-toolkit orderBy for queue list sorting. The queue overlay list already sorts by create time, but the implementation used Array.sort with a custom comparator and mutated the array in place. Switch to es-toolkit's orderBy to make the sort intent explicit, avoid mutation, and align with the utility set we already depend on. Sorting keys and direction remain the same, so behavior is unchanged. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-8228-fix-use-orderBy-for-queue-list-sorting-2f06d73d365081e791fff7d2212537f8) by [Unito](https://www.unito.io) Co-authored-by: Alexander Brown <drjkl@comfy.org>
This commit is contained in:
@@ -1,3 +1,4 @@
|
|||||||
|
import { orderBy } from 'es-toolkit/array'
|
||||||
import { computed, onUnmounted, ref, watch } from 'vue'
|
import { computed, onUnmounted, ref, watch } from 'vue'
|
||||||
import { useI18n } from 'vue-i18n'
|
import { useI18n } from 'vue-i18n'
|
||||||
|
|
||||||
@@ -205,10 +206,7 @@ export function useJobList() {
|
|||||||
...queueStore.runningTasks,
|
...queueStore.runningTasks,
|
||||||
...queueStore.historyTasks
|
...queueStore.historyTasks
|
||||||
]
|
]
|
||||||
return all.sort((a, b) => {
|
return orderBy(all, [mostRecentTimestamp], ['desc'])
|
||||||
const delta = mostRecentTimestamp(b) - mostRecentTimestamp(a)
|
|
||||||
return delta === 0 ? 0 : delta
|
|
||||||
})
|
|
||||||
})
|
})
|
||||||
|
|
||||||
const tasksWithJobState = computed<TaskWithState[]>(() =>
|
const tasksWithJobState = computed<TaskWithState[]>(() =>
|
||||||
|
|||||||
Reference in New Issue
Block a user