From e45e249ed9da3f16b8d36cdab883c371ced5e243 Mon Sep 17 00:00:00 2001 From: Comfy Org PR Bot Date: Fri, 8 May 2026 23:20:10 +0900 Subject: [PATCH] [backport core/1.44] fix: make credits help icon a tooltip button in cloud user popover (FE-617) (#12083) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Backport of #12072 to `core/1.44` Automatically created by backport workflow. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-12083-backport-core-1-44-fix-make-credits-help-icon-a-tooltip-button-in-cloud-user-popover--35a6d73d365081b1a23bd0d78cedcab6) by [Unito](https://www.unito.io) Co-authored-by: Dante --- .../topbar/CurrentUserPopoverLegacy.test.ts | 14 ++++++++++++++ src/components/topbar/CurrentUserPopoverLegacy.vue | 12 +++++++++--- .../components/CurrentUserPopoverWorkspace.vue | 12 +++++++++--- 3 files changed, 32 insertions(+), 6 deletions(-) diff --git a/src/components/topbar/CurrentUserPopoverLegacy.test.ts b/src/components/topbar/CurrentUserPopoverLegacy.test.ts index b07d637788..0a4958b4b3 100644 --- a/src/components/topbar/CurrentUserPopoverLegacy.test.ts +++ b/src/components/topbar/CurrentUserPopoverLegacy.test.ts @@ -252,6 +252,20 @@ describe('CurrentUserPopoverLegacy', () => { expect(screen.getByText('Log Out')).toBeInTheDocument() }) + describe('credits help icon (FE-617)', () => { + it('renders the credits help icon as an interactive button with the unified-credits tooltip as its accessible name', () => { + renderComponent() + + const helpButton = screen.getByTestId('credits-info-button') + expect(helpButton).toBeInTheDocument() + expect(helpButton.tagName).toBe('BUTTON') + expect(helpButton).toHaveAttribute( + 'aria-label', + enMessages.credits.unified.tooltip + ) + }) + }) + it('opens user settings and emits close event when settings item is clicked', async () => { const { user, onClose } = renderComponent() diff --git a/src/components/topbar/CurrentUserPopoverLegacy.vue b/src/components/topbar/CurrentUserPopoverLegacy.vue index 083ba1948c..90f431ae86 100644 --- a/src/components/topbar/CurrentUserPopoverLegacy.vue +++ b/src/components/topbar/CurrentUserPopoverLegacy.vue @@ -41,10 +41,16 @@ {{ formattedBalance }} - + variant="muted-textonly" + size="icon-sm" + class="mr-auto" + :aria-label="$t('credits.unified.tooltip')" + data-testid="credits-info-button" + > + +