fix and enable skipped Vue nodes bypass test (#6290)

This test was failing on main for a few days so it was marked as
`fixme`. The failure was due to interaction with minimap. Just turn off
the minimap for now as it's not really related to what the test is
targeting (arguable). Better to at least have the coverage for now.

Context:

- https://github.com/Comfy-Org/ComfyUI_frontend/pull/6127

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-6290-fix-and-enable-skipped-Vue-nodes-bypass-test-2986d73d3650819faeaaf414ce2b6e61)
by [Unito](https://www.unito.io)

---------

Co-authored-by: github-actions <github-actions@github.com>
This commit is contained in:
Christian Byrne
2025-10-25 23:03:05 -07:00
committed by GitHub
parent 9350c857a2
commit e5d5c042c7
2 changed files with 17 additions and 18 deletions

View File

@@ -9,29 +9,28 @@ const BYPASS_CLASS = /before:bg-bypass\/60/
test.describe('Vue Node Bypass', () => { test.describe('Vue Node Bypass', () => {
test.beforeEach(async ({ comfyPage }) => { test.beforeEach(async ({ comfyPage }) => {
await comfyPage.setSetting('Comfy.VueNodes.Enabled', true) await comfyPage.setSetting('Comfy.VueNodes.Enabled', true)
await comfyPage.setSetting('Comfy.UseNewMenu', 'Top')
await comfyPage.setSetting('Comfy.Minimap.Visible', false)
await comfyPage.setSetting('Comfy.Graph.CanvasMenu', true)
await comfyPage.vueNodes.waitForNodes() await comfyPage.vueNodes.waitForNodes()
}) })
test.fixme( test('should allow toggling bypass on a selected node with hotkey', async ({
'should allow toggling bypass on a selected node with hotkey', comfyPage
async ({ comfyPage }) => { }) => {
await comfyPage.setup() await comfyPage.page.getByText('Load Checkpoint').click()
await comfyPage.page.getByText('Load Checkpoint').click() await comfyPage.page.keyboard.press(BYPASS_HOTKEY)
await comfyPage.page.keyboard.press(BYPASS_HOTKEY)
const checkpointNode = const checkpointNode = comfyPage.vueNodes.getNodeByTitle('Load Checkpoint')
comfyPage.vueNodes.getNodeByTitle('Load Checkpoint') await expect(checkpointNode).toHaveClass(BYPASS_CLASS)
await expect(checkpointNode).toHaveClass(BYPASS_CLASS) await comfyPage.nextFrame()
await comfyPage.page.mouse.click(400, 300) await expect(comfyPage.canvas).toHaveScreenshot(
await comfyPage.page.waitForTimeout(128) 'vue-node-bypassed-state.png'
await expect(comfyPage.canvas).toHaveScreenshot( )
'vue-node-bypassed-state.png'
)
await comfyPage.page.keyboard.press(BYPASS_HOTKEY) await comfyPage.page.keyboard.press(BYPASS_HOTKEY)
await expect(checkpointNode).not.toHaveClass(BYPASS_CLASS) await expect(checkpointNode).not.toHaveClass(BYPASS_CLASS)
} })
)
test('should allow toggling bypass on multiple selected nodes with hotkey', async ({ test('should allow toggling bypass on multiple selected nodes with hotkey', async ({
comfyPage comfyPage

Binary file not shown.

Before

Width:  |  Height:  |  Size: 96 KiB

After

Width:  |  Height:  |  Size: 98 KiB