From e75d2f8940c488dfebd5ee2327d8c3207ac289dd Mon Sep 17 00:00:00 2001
From: Glary-Bot <glary-bot@users.noreply.github.com>
Date: Wed, 20 May 2026 04:36:44 +0000
Subject: [PATCH] feat: instrument personal subscription dialog + dedupe GTM
 event
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Addresses code review:
- Add 'subscription_required_dialog' surface for the personal-tier
  SubscriptionRequiredDialogContent.vue (the dialog reached via
  showSubscriptionDialog() for non-workspace users), which was
  previously uninstrumented despite being a primary paywall path.
- Map trackPaywallViewed() in GtmTelemetryProvider to a distinct
  'paywall_viewed' GA4 event instead of 'view_promotion', which
  trackSubscription('modal_opened') already emits — avoids
  double-counting impressions on the GTM side.
---
 .../components/SubscriptionRequiredDialogContent.vue | 12 ++++++++++--
 .../providers/cloud/GtmTelemetryProvider.ts          |  2 +-
 src/platform/telemetry/types.ts                      |  1 +
 3 files changed, 12 insertions(+), 3 deletions(-)

diff --git a/src/platform/cloud/subscription/components/SubscriptionRequiredDialogContent.vue b/src/platform/cloud/subscription/components/SubscriptionRequiredDialogContent.vue
index 4980137136..11919402d5 100644
--- a/src/platform/cloud/subscription/components/SubscriptionRequiredDialogContent.vue
+++ b/src/platform/cloud/subscription/components/SubscriptionRequiredDialogContent.vue
@@ -145,7 +145,7 @@
 </template>
 
 <script setup lang="ts">
-import { computed, watch } from 'vue'
+import { computed, onMounted, watch } from 'vue'
 
 import CloudBadge from '@/components/topbar/CloudBadge.vue'
 import Button from '@/components/ui/button/Button.vue'
@@ -169,7 +169,7 @@ const emit = defineEmits<{
   close: [subscribed: boolean]
 }>()
 
-const { isActiveSubscription } = useBillingContext()
+const { isActiveSubscription, subscription } = useBillingContext()
 
 const isSubscriptionEnabled = (): boolean =>
   Boolean(isCloud && window.__CONFIG__?.subscription_required)
@@ -199,6 +199,14 @@ watch(
   }
 )
 
+onMounted(() => {
+  telemetry?.trackPaywallViewed({
+    surface: 'subscription_required_dialog',
+    current_tier: subscription.value?.tier?.toLowerCase(),
+    reason
+  })
+})
+
 const handleSubscribed = () => {
   emit('close', true)
 }
diff --git a/src/platform/telemetry/providers/cloud/GtmTelemetryProvider.ts b/src/platform/telemetry/providers/cloud/GtmTelemetryProvider.ts
index a3212dfd01..364d407516 100644
--- a/src/platform/telemetry/providers/cloud/GtmTelemetryProvider.ts
+++ b/src/platform/telemetry/providers/cloud/GtmTelemetryProvider.ts
@@ -166,7 +166,7 @@ export class GtmTelemetryProvider implements TelemetryProvider {
   }
 
   trackPaywallViewed(metadata: PaywallViewedMetadata): void {
-    this.pushEvent('view_promotion', { ...metadata })
+    this.pushEvent('paywall_viewed', { ...metadata })
   }
 
   trackSignupOpened(): void {
diff --git a/src/platform/telemetry/types.ts b/src/platform/telemetry/types.ts
index ebd372b651..e00369ab60 100644
--- a/src/platform/telemetry/types.ts
+++ b/src/platform/telemetry/types.ts
@@ -347,6 +347,7 @@ export interface SubscriptionMetadata {
  */
 export type PaywallSurface =
   | 'free_tier_dialog'
+  | 'subscription_required_dialog'
   | 'subscription_required_dialog_workspace'
   | 'upload_model_upgrade_modal'
   | 'invite_member_upsell'