From e77aaf5da67a7636c288787f1f596be52cf48bae Mon Sep 17 00:00:00 2001 From: bymyself Date: Tue, 17 Mar 2026 07:58:24 +0000 Subject: [PATCH] refactor: rename useSlotContextMenu to slotMenuService MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Not a composable — returns no reactive state and has no lifecycle integration. Addresses review feedback: https://github.com/Comfy-Org/ComfyUI_frontend/pull/9045#discussion_r2925519398 --- src/renderer/extensions/vueNodes/components/InputSlot.vue | 2 +- src/renderer/extensions/vueNodes/components/OutputSlot.vue | 2 +- .../extensions/vueNodes/components/SlotContextMenu.vue | 4 ++-- .../extensions/vueNodes/composables/slotMenuService.test.ts | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/renderer/extensions/vueNodes/components/InputSlot.vue b/src/renderer/extensions/vueNodes/components/InputSlot.vue index e2112f65b4..622e9bcc98 100644 --- a/src/renderer/extensions/vueNodes/components/InputSlot.vue +++ b/src/renderer/extensions/vueNodes/components/InputSlot.vue @@ -67,7 +67,7 @@ import { useNodeTooltips } from '@/renderer/extensions/vueNodes/composables/useN import { hasAnySlotAction, showSlotMenu -} from '@/renderer/extensions/vueNodes/composables/useSlotContextMenu' +} from '@/renderer/extensions/vueNodes/composables/slotMenuService' import { useSlotElementTracking } from '@/renderer/extensions/vueNodes/composables/useSlotElementTracking' import { useSlotLinkInteraction } from '@/renderer/extensions/vueNodes/composables/useSlotLinkInteraction' import { cn } from '@comfyorg/tailwind-utils' diff --git a/src/renderer/extensions/vueNodes/components/OutputSlot.vue b/src/renderer/extensions/vueNodes/components/OutputSlot.vue index 735d50785e..69a495b8ad 100644 --- a/src/renderer/extensions/vueNodes/components/OutputSlot.vue +++ b/src/renderer/extensions/vueNodes/components/OutputSlot.vue @@ -39,7 +39,7 @@ import { useNodeTooltips } from '@/renderer/extensions/vueNodes/composables/useN import { hasAnySlotAction, showSlotMenu -} from '@/renderer/extensions/vueNodes/composables/useSlotContextMenu' +} from '@/renderer/extensions/vueNodes/composables/slotMenuService' import { useSlotElementTracking } from '@/renderer/extensions/vueNodes/composables/useSlotElementTracking' import { useSlotLinkInteraction } from '@/renderer/extensions/vueNodes/composables/useSlotLinkInteraction' import { cn } from '@comfyorg/tailwind-utils' diff --git a/src/renderer/extensions/vueNodes/components/SlotContextMenu.vue b/src/renderer/extensions/vueNodes/components/SlotContextMenu.vue index 536c680c64..f228c03693 100644 --- a/src/renderer/extensions/vueNodes/components/SlotContextMenu.vue +++ b/src/renderer/extensions/vueNodes/components/SlotContextMenu.vue @@ -53,8 +53,8 @@ import { registerSlotMenuInstance, removeSlot, renameSlot -} from '@/renderer/extensions/vueNodes/composables/useSlotContextMenu' -import type { SlotMenuContext } from '@/renderer/extensions/vueNodes/composables/useSlotContextMenu' +} from '@/renderer/extensions/vueNodes/composables/slotMenuService' +import type { SlotMenuContext } from '@/renderer/extensions/vueNodes/composables/slotMenuService' import { useDialogService } from '@/services/dialogService' const { t } = useI18n() diff --git a/src/renderer/extensions/vueNodes/composables/slotMenuService.test.ts b/src/renderer/extensions/vueNodes/composables/slotMenuService.test.ts index 90364f6ada..8063ecc6be 100644 --- a/src/renderer/extensions/vueNodes/composables/slotMenuService.test.ts +++ b/src/renderer/extensions/vueNodes/composables/slotMenuService.test.ts @@ -26,7 +26,7 @@ import { hasAnySlotAction, removeSlot, renameSlot -} from './useSlotContextMenu' +} from './slotMenuService' describe(canRenameSlot, () => { beforeEach(() => {