From e8b9f8f4bc9ecae52a3c4fcd91879971bea1ec53 Mon Sep 17 00:00:00 2001 From: Christian Byrne Date: Sat, 27 Sep 2025 13:53:25 -0700 Subject: [PATCH] enforce test file-naming rule (#5820) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ## Summary Enforced test file naming conventions with ESLint rules and renamed 26 test files from `.spec.ts` to `.test.ts`. ## Changes - **What**: Added ESLint rules to enforce `.spec.ts` files only in `browser_tests/tests/` and `.test.ts` files only in `src/` - **What**: Renamed 26 component/unit test files from `.spec.ts` to `.test.ts` to comply with new convention ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-5820-enforce-test-file-naming-rule-27b6d73d365081269b32ddcc9d3a5048) by [Unito](https://www.unito.io) --- eslint.config.ts | 26 +++++++++++++++++++ ....ts => ColorCustomizationSelector.test.ts} | 0 ...tableText.spec.ts => EditableText.test.ts} | 0 ...ioGroup.spec.ts => FormRadioGroup.test.ts} | 0 ...e.spec.ts => TreeExplorerTreeNode.test.ts} | 0 ...ettingItem.spec.ts => SettingItem.test.ts} | 0 ...gsTable.spec.ts => UsageLogsTable.test.ts} | 0 ...{SignInForm.spec.ts => SignInForm.test.ts} | 0 ...olbox.spec.ts => SelectionToolbox.test.ts} | 0 ...assButton.spec.ts => BypassButton.test.ts} | 0 ...tton.spec.ts => ColorPickerButton.test.ts} | 0 ...teButton.spec.ts => ExecuteButton.test.ts} | 0 ...{InfoButton.spec.ts => InfoButton.test.ts} | 0 ...dget.spec.ts => ChatHistoryWidget.test.ts} | 0 ...odePreview.spec.ts => NodePreview.test.ts} | 0 ...idebarIcon.spec.ts => SidebarIcon.test.ts} | 0 ...tGallery.spec.ts => ResultGallery.test.ts} | 0 ...umbnail.spec.ts => AudioThumbnail.test.ts} | 0 ...humbnail.spec.ts => BaseThumbnail.test.ts} | 0 ...spec.ts => CompareSliderThumbnail.test.ts} | 0 ...bnail.spec.ts => DefaultThumbnail.test.ts} | 0 ...spec.ts => HoverDissolveThumbnail.test.ts} | 0 ...tton.spec.ts => CurrentUserButton.test.ts} | 0 ...ver.spec.ts => CurrentUserPopover.test.ts} | 0 ...formPane.spec.ts => TransformPane.test.ts} | 0 ...{NodeHeader.spec.ts => NodeHeader.test.ts} | 0 .../{NodeSlots.spec.ts => NodeSlots.test.ts} | 0 27 files changed, 26 insertions(+) rename src/components/common/{ColorCustomizationSelector.spec.ts => ColorCustomizationSelector.test.ts} (100%) rename src/components/common/{EditableText.spec.ts => EditableText.test.ts} (100%) rename src/components/common/{FormRadioGroup.spec.ts => FormRadioGroup.test.ts} (100%) rename src/components/common/{TreeExplorerTreeNode.spec.ts => TreeExplorerTreeNode.test.ts} (100%) rename src/components/dialog/content/setting/{SettingItem.spec.ts => SettingItem.test.ts} (100%) rename src/components/dialog/content/setting/{UsageLogsTable.spec.ts => UsageLogsTable.test.ts} (100%) rename src/components/dialog/content/signin/{SignInForm.spec.ts => SignInForm.test.ts} (100%) rename src/components/graph/{SelectionToolbox.spec.ts => SelectionToolbox.test.ts} (100%) rename src/components/graph/selectionToolbox/{BypassButton.spec.ts => BypassButton.test.ts} (100%) rename src/components/graph/selectionToolbox/{ColorPickerButton.spec.ts => ColorPickerButton.test.ts} (100%) rename src/components/graph/selectionToolbox/{ExecuteButton.spec.ts => ExecuteButton.test.ts} (100%) rename src/components/graph/selectionToolbox/{InfoButton.spec.ts => InfoButton.test.ts} (100%) rename src/components/graph/widgets/{ChatHistoryWidget.spec.ts => ChatHistoryWidget.test.ts} (100%) rename src/components/node/{NodePreview.spec.ts => NodePreview.test.ts} (100%) rename src/components/sidebar/{SidebarIcon.spec.ts => SidebarIcon.test.ts} (100%) rename src/components/sidebar/tabs/queue/{ResultGallery.spec.ts => ResultGallery.test.ts} (100%) rename src/components/templates/thumbnails/{AudioThumbnail.spec.ts => AudioThumbnail.test.ts} (100%) rename src/components/templates/thumbnails/{BaseThumbnail.spec.ts => BaseThumbnail.test.ts} (100%) rename src/components/templates/thumbnails/{CompareSliderThumbnail.spec.ts => CompareSliderThumbnail.test.ts} (100%) rename src/components/templates/thumbnails/{DefaultThumbnail.spec.ts => DefaultThumbnail.test.ts} (100%) rename src/components/templates/thumbnails/{HoverDissolveThumbnail.spec.ts => HoverDissolveThumbnail.test.ts} (100%) rename src/components/topbar/{CurrentUserButton.spec.ts => CurrentUserButton.test.ts} (100%) rename src/components/topbar/{CurrentUserPopover.spec.ts => CurrentUserPopover.test.ts} (100%) rename src/renderer/core/layout/__tests__/{TransformPane.spec.ts => TransformPane.test.ts} (100%) rename src/renderer/extensions/vueNodes/components/{NodeHeader.spec.ts => NodeHeader.test.ts} (100%) rename src/renderer/extensions/vueNodes/components/{NodeSlots.spec.ts => NodeSlots.test.ts} (100%) diff --git a/eslint.config.ts b/eslint.config.ts index ab3bf09f5..22251afdb 100644 --- a/eslint.config.ts +++ b/eslint.config.ts @@ -181,5 +181,31 @@ export default defineConfig([ { disallowTypeAnnotations: false } ] } + }, + { + files: ['**/*.spec.ts'], + ignores: ['browser_tests/tests/**/*.spec.ts'], + rules: { + 'no-restricted-syntax': [ + 'error', + { + selector: 'Program', + message: '.spec.ts files are only allowed under browser_tests/tests/' + } + ] + } + }, + { + files: ['browser_tests/tests/**/*.test.ts'], + rules: { + 'no-restricted-syntax': [ + 'error', + { + selector: 'Program', + message: + '.test.ts files are not allowed in browser_tests/tests/; use .spec.ts instead' + } + ] + } } ]) diff --git a/src/components/common/ColorCustomizationSelector.spec.ts b/src/components/common/ColorCustomizationSelector.test.ts similarity index 100% rename from src/components/common/ColorCustomizationSelector.spec.ts rename to src/components/common/ColorCustomizationSelector.test.ts diff --git a/src/components/common/EditableText.spec.ts b/src/components/common/EditableText.test.ts similarity index 100% rename from src/components/common/EditableText.spec.ts rename to src/components/common/EditableText.test.ts diff --git a/src/components/common/FormRadioGroup.spec.ts b/src/components/common/FormRadioGroup.test.ts similarity index 100% rename from src/components/common/FormRadioGroup.spec.ts rename to src/components/common/FormRadioGroup.test.ts diff --git a/src/components/common/TreeExplorerTreeNode.spec.ts b/src/components/common/TreeExplorerTreeNode.test.ts similarity index 100% rename from src/components/common/TreeExplorerTreeNode.spec.ts rename to src/components/common/TreeExplorerTreeNode.test.ts diff --git a/src/components/dialog/content/setting/SettingItem.spec.ts b/src/components/dialog/content/setting/SettingItem.test.ts similarity index 100% rename from src/components/dialog/content/setting/SettingItem.spec.ts rename to src/components/dialog/content/setting/SettingItem.test.ts diff --git a/src/components/dialog/content/setting/UsageLogsTable.spec.ts b/src/components/dialog/content/setting/UsageLogsTable.test.ts similarity index 100% rename from src/components/dialog/content/setting/UsageLogsTable.spec.ts rename to src/components/dialog/content/setting/UsageLogsTable.test.ts diff --git a/src/components/dialog/content/signin/SignInForm.spec.ts b/src/components/dialog/content/signin/SignInForm.test.ts similarity index 100% rename from src/components/dialog/content/signin/SignInForm.spec.ts rename to src/components/dialog/content/signin/SignInForm.test.ts diff --git a/src/components/graph/SelectionToolbox.spec.ts b/src/components/graph/SelectionToolbox.test.ts similarity index 100% rename from src/components/graph/SelectionToolbox.spec.ts rename to src/components/graph/SelectionToolbox.test.ts diff --git a/src/components/graph/selectionToolbox/BypassButton.spec.ts b/src/components/graph/selectionToolbox/BypassButton.test.ts similarity index 100% rename from src/components/graph/selectionToolbox/BypassButton.spec.ts rename to src/components/graph/selectionToolbox/BypassButton.test.ts diff --git a/src/components/graph/selectionToolbox/ColorPickerButton.spec.ts b/src/components/graph/selectionToolbox/ColorPickerButton.test.ts similarity index 100% rename from src/components/graph/selectionToolbox/ColorPickerButton.spec.ts rename to src/components/graph/selectionToolbox/ColorPickerButton.test.ts diff --git a/src/components/graph/selectionToolbox/ExecuteButton.spec.ts b/src/components/graph/selectionToolbox/ExecuteButton.test.ts similarity index 100% rename from src/components/graph/selectionToolbox/ExecuteButton.spec.ts rename to src/components/graph/selectionToolbox/ExecuteButton.test.ts diff --git a/src/components/graph/selectionToolbox/InfoButton.spec.ts b/src/components/graph/selectionToolbox/InfoButton.test.ts similarity index 100% rename from src/components/graph/selectionToolbox/InfoButton.spec.ts rename to src/components/graph/selectionToolbox/InfoButton.test.ts diff --git a/src/components/graph/widgets/ChatHistoryWidget.spec.ts b/src/components/graph/widgets/ChatHistoryWidget.test.ts similarity index 100% rename from src/components/graph/widgets/ChatHistoryWidget.spec.ts rename to src/components/graph/widgets/ChatHistoryWidget.test.ts diff --git a/src/components/node/NodePreview.spec.ts b/src/components/node/NodePreview.test.ts similarity index 100% rename from src/components/node/NodePreview.spec.ts rename to src/components/node/NodePreview.test.ts diff --git a/src/components/sidebar/SidebarIcon.spec.ts b/src/components/sidebar/SidebarIcon.test.ts similarity index 100% rename from src/components/sidebar/SidebarIcon.spec.ts rename to src/components/sidebar/SidebarIcon.test.ts diff --git a/src/components/sidebar/tabs/queue/ResultGallery.spec.ts b/src/components/sidebar/tabs/queue/ResultGallery.test.ts similarity index 100% rename from src/components/sidebar/tabs/queue/ResultGallery.spec.ts rename to src/components/sidebar/tabs/queue/ResultGallery.test.ts diff --git a/src/components/templates/thumbnails/AudioThumbnail.spec.ts b/src/components/templates/thumbnails/AudioThumbnail.test.ts similarity index 100% rename from src/components/templates/thumbnails/AudioThumbnail.spec.ts rename to src/components/templates/thumbnails/AudioThumbnail.test.ts diff --git a/src/components/templates/thumbnails/BaseThumbnail.spec.ts b/src/components/templates/thumbnails/BaseThumbnail.test.ts similarity index 100% rename from src/components/templates/thumbnails/BaseThumbnail.spec.ts rename to src/components/templates/thumbnails/BaseThumbnail.test.ts diff --git a/src/components/templates/thumbnails/CompareSliderThumbnail.spec.ts b/src/components/templates/thumbnails/CompareSliderThumbnail.test.ts similarity index 100% rename from src/components/templates/thumbnails/CompareSliderThumbnail.spec.ts rename to src/components/templates/thumbnails/CompareSliderThumbnail.test.ts diff --git a/src/components/templates/thumbnails/DefaultThumbnail.spec.ts b/src/components/templates/thumbnails/DefaultThumbnail.test.ts similarity index 100% rename from src/components/templates/thumbnails/DefaultThumbnail.spec.ts rename to src/components/templates/thumbnails/DefaultThumbnail.test.ts diff --git a/src/components/templates/thumbnails/HoverDissolveThumbnail.spec.ts b/src/components/templates/thumbnails/HoverDissolveThumbnail.test.ts similarity index 100% rename from src/components/templates/thumbnails/HoverDissolveThumbnail.spec.ts rename to src/components/templates/thumbnails/HoverDissolveThumbnail.test.ts diff --git a/src/components/topbar/CurrentUserButton.spec.ts b/src/components/topbar/CurrentUserButton.test.ts similarity index 100% rename from src/components/topbar/CurrentUserButton.spec.ts rename to src/components/topbar/CurrentUserButton.test.ts diff --git a/src/components/topbar/CurrentUserPopover.spec.ts b/src/components/topbar/CurrentUserPopover.test.ts similarity index 100% rename from src/components/topbar/CurrentUserPopover.spec.ts rename to src/components/topbar/CurrentUserPopover.test.ts diff --git a/src/renderer/core/layout/__tests__/TransformPane.spec.ts b/src/renderer/core/layout/__tests__/TransformPane.test.ts similarity index 100% rename from src/renderer/core/layout/__tests__/TransformPane.spec.ts rename to src/renderer/core/layout/__tests__/TransformPane.test.ts diff --git a/src/renderer/extensions/vueNodes/components/NodeHeader.spec.ts b/src/renderer/extensions/vueNodes/components/NodeHeader.test.ts similarity index 100% rename from src/renderer/extensions/vueNodes/components/NodeHeader.spec.ts rename to src/renderer/extensions/vueNodes/components/NodeHeader.test.ts diff --git a/src/renderer/extensions/vueNodes/components/NodeSlots.spec.ts b/src/renderer/extensions/vueNodes/components/NodeSlots.test.ts similarity index 100% rename from src/renderer/extensions/vueNodes/components/NodeSlots.spec.ts rename to src/renderer/extensions/vueNodes/components/NodeSlots.test.ts