Comfy-Org/ComfyUI_frontend
1
0
Fork 0
mirror of https://github.com/Comfy-Org/ComfyUI_frontend.git synced 2026-02-24 16:54:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

[don't port to main] Fix CI checks for rh-test (by ignoring failing tests and checks) (#6266)

Browse Source 
## Summary

Fixes all CI check failures on rh-test


┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-6266-don-t-port-to-main-Fix-CI-checks-for-rh-test-after-cherry-pick-6257-2976d73d3650812c828fc3fa9aaf345f)
by [Unito](https://www.unito.io)

---------

Co-authored-by: GitHub Action <action@github.com>
This commit is contained in:
Christian Byrne
2025-10-24 19:37:17 -07:00
committed by GitHub
parent c067fcc27f
commit eabc7ec19a
28 changed files with 104 additions and 56 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/components/LiteGraphCanvasSplitterOverlay.vue
View File

@@ -74,7 +74,9 @@ const activeSidebarTabId = computed(
)
const sidebarStateKey = computed(() => {
return unifiedWidth.value ? 'unified-sidebar' : activeSidebarTabId.value ?? ''
return unifiedWidth.value
? 'unified-sidebar'
: (activeSidebarTabId.value ?? '')
})
</script>

2
src/components/graph/widgets/ChatHistoryWidget.vue
View File

@@ -75,7 +75,7 @@ let promptInput = findPromptInput()
const previousPromptInput = ref<string | null>(null)
const getPreviousResponseId = (index: number) =>
index > 0 ? parsedHistory.value[index - 1]?.response_id ?? '' : ''
index > 0 ? (parsedHistory.value[index - 1]?.response_id ?? '') : ''
const storePromptInput = () => {
promptInput ??= widget?.node.widgets?.find((w) => w.name === 'prompt')

2
src/components/input/SingleSelect.vue
View File

@@ -106,7 +106,7 @@ const getLabel = (val: string | null | undefined) => {
if (val == null) return label ?? ''
if (!options) return label ?? ''
const found = options.find((o) => o.value === val)
return found ? found.name : label ?? ''
return found ? found.name : (label ?? '')
}
// Extract complex style logic from template

2
src/components/sidebar/SidebarIcon.vue
View File

@@ -76,7 +76,7 @@ const emit = defineEmits<{
(e: 'click', event: MouseEvent): void
}>()
const overlayValue = computed(() =>
typeof iconBadge === 'function' ? iconBadge() ?? '' : iconBadge
typeof iconBadge === 'function' ? (iconBadge() ?? '') : iconBadge
)
const shouldShowBadge = computed(() => !!overlayValue.value)
const computedTooltip = computed(() => t(tooltip) + tooltipSuffix)

4
src/components/sidebar/tabs/queue/TaskItem.vue
View File

@@ -100,9 +100,9 @@ const coverResult = flatOutputs.length
// Using `==` instead of `===` because NodeId can be a string or a number
const node: ComfyNode | null =
flatOutputs.length && props.task.workflow
? props.task.workflow.nodes.find(
? (props.task.workflow.nodes.find(
(n: ComfyNode) => n.id == coverResult?.nodeId
) ?? null
) ?? null)
: null
const progressPreviewBlobUrl = ref('')

2
src/composables/graph/useWidgetValue.ts
View File

@@ -125,7 +125,7 @@ export function useNumberWidgetValue(
transform: (value: number | number[]) => {
// Handle PrimeVue Slider which can emit number | number[]
if (Array.isArray(value)) {
return value.length > 0 ? value[0] ?? 0 : 0
return value.length > 0 ? (value[0] ?? 0) : 0
}
return Number(value) || 0
}

4
src/composables/node/useNodeBadge.ts
View File

@@ -86,10 +86,10 @@ export const useNodeBadge = () => {
? `#${node.id}`
: '',
badgeTextVisible(nodeDef, nodeLifeCycleBadgeMode.value)
? nodeDef?.nodeLifeCycleBadgeText ?? ''
? (nodeDef?.nodeLifeCycleBadgeText ?? '')
: '',
badgeTextVisible(nodeDef, nodeSourceBadgeMode.value)
? nodeDef?.nodeSource?.badgeText ?? ''
? (nodeDef?.nodeSource?.badgeText ?? '')
: ''
]
.filter((s) => s.length > 0)

2
src/composables/node/useNodePricing.ts
View File

@@ -1641,7 +1641,7 @@ const apiNodeCosts: Record<string, { displayPrice: string | PricingFunction }> =
? '720p'
: resolutionStr.includes('480')
? '480p'
: resolutionStr.match(/^\s*(\d{3,4}p)/)?.[1] ?? ''
: (resolutionStr.match(/^\s*(\d{3,4}p)/)?.[1] ?? '')
const pricePerSecond: Record<string, number> = {
'480p': 0.05,

2
src/extensions/core/groupNode.ts
View File

@@ -542,7 +542,7 @@ export class GroupNodeConfig {
primitiveConfig
)
primitiveConfig[1] =
config?.customConfig ?? inputs[inputName][1]
(config?.customConfig ?? inputs[inputName][1])
? { ...inputs[inputName][1] }
: {}

4
src/extensions/core/groupNodeManage.ts
View File

@@ -553,8 +553,8 @@ export class ManageGroupDialog extends ComfyDialog<HTMLDialogElement> {
this.element.replaceChildren(outer)
this.changeGroup(
type
? groupNodes.find((g) => `${PREFIX}${SEPARATOR}${g}` === type) ??
groupNodes[0]
? (groupNodes.find((g) => `${PREFIX}${SEPARATOR}${g}` === type) ??
groupNodes[0])
: groupNodes[0]
)
this.element.showModal()

2
src/extensions/core/load3d/Load3d.ts
View File

@@ -370,7 +370,7 @@ class Load3d {
await ModelExporter.exportOBJ(model, filename, originalURL)
break
case 'stl':
await ModelExporter.exportSTL(model, filename), originalURL
;(await ModelExporter.exportSTL(model, filename), originalURL)
break
default:
throw new Error(`Unsupported export format: ${format}`)

4
src/lib/litegraph/src/LGraphCanvas.ts
View File

@@ -4873,9 +4873,9 @@ export class LGraphCanvas
/** Get the target snap / highlight point in graph space */
#getHighlightPosition(): Readonly<Point> {
return LiteGraph.snaps_for_comfy
? this.linkConnector.state.snapLinksPos ??
? (this.linkConnector.state.snapLinksPos ??
this._highlight_pos ??
this.graph_mouse
this.graph_mouse)
: this.graph_mouse
}

2
src/lib/litegraph/src/LGraphNode.ts
View File

@@ -2467,7 +2467,7 @@ export class LGraphNode
}
}
return doNotUseOccupied ? -1 : occupiedSlot ?? -1
return doNotUseOccupied ? -1 : (occupiedSlot ?? -1)
}
/**

4
src/lib/litegraph/src/LLink.ts
View File

@@ -312,7 +312,7 @@ export class LLink implements LinkSegment, Serialisable<SerialisableLLink> {
const inputNode =
this.target_id === -1
? undefined
: network.getNodeById(this.target_id) ?? undefined
: (network.getNodeById(this.target_id) ?? undefined)
const input = inputNode?.inputs[this.target_slot]
const subgraphInput = this.originIsIoNode
? network.inputNode?.slots[this.origin_slot]
@@ -324,7 +324,7 @@ export class LLink implements LinkSegment, Serialisable<SerialisableLLink> {
const outputNode =
this.origin_id === -1
? undefined
: network.getNodeById(this.origin_id) ?? undefined
: (network.getNodeById(this.origin_id) ?? undefined)
const output = outputNode?.outputs[this.origin_slot]
const subgraphOutput = this.targetIsIoNode
? network.outputNode?.slots[this.target_slot]

2
src/platform/onboarding/cloud/assets/css/fonts.css
View File

@@ -27,7 +27,7 @@
font-weight: 900;
font-style: italic;
text-transform: uppercase;
text-shadow: 0 4px 4px rgba(0, 0, 0, 0.25);
text-shadow: 0 4px 4px rgb(0 0 0 / 0.25);
/* Figma has leading-trim/text-edge which CSS doesn't support; emulate with tight line-height */
line-height: 1.1;
}

2
src/platform/settings/components/SettingDialogContent.vue
View File

@@ -133,7 +133,7 @@ const searchResults = computed<ISettingGroup[]>(() =>
)
const tabValue = computed<string>(() =>
inSearch.value ? 'Search Results' : activeCategory.value?.label ?? ''
inSearch.value ? 'Search Results' : (activeCategory.value?.label ?? '')
)
// Don't allow null category to be set outside of search.

6
src/renderer/extensions/vueNodes/composables/useSlotLinkInteraction.ts
View File

@@ -309,7 +309,7 @@ export function useSlotLinkInteraction({
hoveredSlotKey = elWithSlot?.dataset['slotKey'] ?? null
hoveredNodeId = hoveredSlotKey
? null
: elWithNode?.dataset['nodeId'] ?? null
: (elWithNode?.dataset['nodeId'] ?? null)
dragContext.lastPointerEventTarget = target
dragContext.lastPointerTargetSlotKey = hoveredSlotKey
dragContext.lastPointerTargetNodeId = hoveredNodeId
@@ -605,8 +605,8 @@ export function useSlotLinkInteraction({
}
const baseDirection = isInputSlot
? inputSlot?.dir ?? LinkDirection.LEFT
: outputSlot?.dir ?? LinkDirection.RIGHT
? (inputSlot?.dir ?? LinkDirection.LEFT)
: (outputSlot?.dir ?? LinkDirection.RIGHT)
const existingAnchor =
isInputSlot && !shouldBreakExistingInputLink

4
src/renderer/extensions/vueNodes/widgets/components/audio/AudioPreviewPlayer.vue
View File

@@ -387,7 +387,7 @@ onUnmounted(() => {
<style scoped>
.audio-player-menu {
--p-tieredmenu-item-focus-background: rgba(255, 255, 255, 0.1);
--p-tieredmenu-item-active-background: rgba(255, 255, 255, 0.1);
--p-tieredmenu-item-focus-background: rgb(255 255 255 / 0.1);
--p-tieredmenu-item-active-background: rgb(255 255 255 / 0.1);
}
</style>

4
src/utils/hostWhitelist.ts
View File

@@ -84,8 +84,8 @@ function isIPv6Loopback(h: string): boolean {
// Count explicit zero groups on each side of '::' to ensure at least one group is compressed.
// (leftCount + rightCount) must be ≤ 6 so that the total expanded groups = 8.
const leftCount = m[1] ? m[1].match(/0{1,4}:/gi)?.length ?? 0 : 0
const rightCount = m[2] ? m[2].match(/0{1,4}:/gi)?.length ?? 0 : 0
const leftCount = m[1] ? (m[1].match(/0{1,4}:/gi)?.length ?? 0) : 0
const rightCount = m[2] ? (m[2].match(/0{1,4}:/gi)?.length ?? 0) : 0
// Require that at least one group was actually compressed: i.e., leftCount + rightCount ≤ 6.
return leftCount + rightCount <= 6

2
src/workbench/extensions/manager/components/manager/PackVersionSelectorPopover.vue
View File

@@ -236,7 +236,7 @@ const handleSubmit = async () => {
// Convert 'latest' to actual version number for installation
const actualVersion =
selectedVersion.value === 'latest'
? nodePack.latest_version?.version ?? 'latest'
? (nodePack.latest_version?.version ?? 'latest')
: selectedVersion.value
await managerStore.installPack.call({

8
src/workbench/extensions/manager/components/manager/button/PackInstallButton.vue
View File

@@ -74,8 +74,8 @@ const createPayload = (installItem: NodePack) => {
const isUnclaimedPack = installItem.publisher?.name === 'Unclaimed'
const versionToInstall = isUnclaimedPack
? ('nightly' as ManagerComponents['schemas']['SelectedVersion'])
: installItem.latest_version?.version ??
('latest' as ManagerComponents['schemas']['SelectedVersion'])
: (installItem.latest_version?.version ??
('latest' as ManagerComponents['schemas']['SelectedVersion']))
return {
id: installItem.id,
@@ -140,7 +140,7 @@ const performInstallation = async (packs: NodePack[]) => {
const computedLabel = computed(() =>
isInstalling.value
? t('g.installing')
: label ??
(nodePacks.length > 1 ? t('manager.installSelected') : t('g.install'))
: (label ??
(nodePacks.length > 1 ? t('manager.installSelected') : t('g.install')))
)
</script>