From edfa5e70f248741733ed0610865242261edb4f06 Mon Sep 17 00:00:00 2001 From: filtered <176114999+webfiltered@users.noreply.github.com> Date: Fri, 11 Oct 2024 12:00:45 +1100 Subject: [PATCH] ES2022 Output & whitespace-only minification (#201) * Change vite output to ES2022 * Add whitespace-only minify using default esbuild Does not work for .es.js output - limitation of vite. Workaround for .es.js involves adding terser & a plugin. * Remove @ts-expect-error from tests * Update vite.config.mts --------- Co-authored-by: Chenlei Hu --- test/LGraph.test.ts | 1 - test/LGraphNode.test.ts | 2 -- vite.config.mts | 8 ++++++-- 3 files changed, 6 insertions(+), 5 deletions(-) diff --git a/test/LGraph.test.ts b/test/LGraph.test.ts index dc3a74b60..bda242b4f 100644 --- a/test/LGraph.test.ts +++ b/test/LGraph.test.ts @@ -21,7 +21,6 @@ describe("LegacyLGraph Compatibility Layer", () => { }); test("LegacyLGraph is correctly assigned to LiteGraph", () => { - // @ts-expect-error Fixed later in the TS conversion process. expect(LiteGraph.LGraph).toBe(LGraph); }); }); diff --git a/test/LGraphNode.test.ts b/test/LGraphNode.test.ts index a8f6f35b0..1543edf86 100644 --- a/test/LGraphNode.test.ts +++ b/test/LGraphNode.test.ts @@ -5,9 +5,7 @@ import { describe("LGraphNode", () => { it("should serialize position correctly", () => { const node = new LGraphNode("TestNode"); - // @ts-expect-error Expected - not a TS class yet. node.pos = [10, 10]; - // @ts-expect-error JS tests in TS format expect(node.pos).toEqual(new Float32Array([10, 10])); expect(node.serialize().pos).toEqual(new Float32Array([10, 10])); }); diff --git a/vite.config.mts b/vite.config.mts index 4988ca631..e0be47887 100644 --- a/vite.config.mts +++ b/vite.config.mts @@ -10,8 +10,12 @@ export default defineConfig({ fileName: (format) => `litegraph.${format}.js`, formats: ['es', 'umd'] }, - minify: false, sourcemap: true, + target: ['es2022'], + }, + esbuild: { + minifyIdentifiers: false, + minifySyntax: false, }, plugins: [ dts({ @@ -26,4 +30,4 @@ export default defineConfig({ '@': '/src' } } -}) \ No newline at end of file +})