Comfy-Org/ComfyUI_frontend
1
0
Fork 0
mirror of https://github.com/Comfy-Org/ComfyUI_frontend.git synced 2026-04-30 03:01:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

docs: explain why type cast is required in error getters

Browse Source 
Address review comment asking why the type isn't inferrable. The messages
array is typed as Array<[string, unknown]>, so TypeScript cannot narrow
the second tuple element based on a runtime string check.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
Richard Yu
2026-01-12 17:02:56 -08:00
parent 6485f871ba
commit f44c0e3842
1 changed files with 8 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/stores/queueStore.ts
View File

@@ -324,6 +324,10 @@ export class TaskItemImpl {
/** /**
* Extracts the execution error message from status messages. * Extracts the execution error message from status messages.
* Used by error reporting UI components. * Used by error reporting UI components.
*
* Note: The type cast is required because `messages` is typed as
* `Array<[string, unknown]>` - TypeScript cannot narrow the second tuple
* element's type based on a runtime string check for 'execution_error'.
*/ */
get errorMessage(): string | undefined { get errorMessage(): string | undefined {
const messages = this.status?.messages const messages = this.status?.messages
@@ -337,6 +341,10 @@ export class TaskItemImpl {
/** /**
* Extracts the full execution error from status messages. * Extracts the full execution error from status messages.
* Returns the ExecutionErrorWsMessage for detailed error dialogs. * Returns the ExecutionErrorWsMessage for detailed error dialogs.
*
* Note: The type cast is required because `messages` is typed as
* `Array<[string, unknown]>` - TypeScript cannot narrow the second tuple
* element's type based on a runtime string check for 'execution_error'.
*/ */
get executionError(): ExecutionErrorWsMessage | undefined { get executionError(): ExecutionErrorWsMessage | undefined {
const messages = this.status?.messages const messages = this.status?.messages