From f5726e5948e77168433c67c7f0b8fb08f4b8711c Mon Sep 17 00:00:00 2001
From: Benjamin Lu <benjaminlu1107@gmail.com>
Date: Tue, 1 Jul 2025 19:21:02 -0400
Subject: [PATCH] [test] Add test to verify targetSelector property deletion

Add a specific test case to ensure the keybinding migration properly
deletes the deprecated 'targetSelector' property after migrating to
'targetElementId'. This test provides additional coverage to verify
the migration doesn't leave behind obsolete properties.

The test verifies:
- The old 'targetSelector' property is removed
- The new 'targetElementId' property is added with correct value
- Other properties remain unchanged
---
 .../utils/migration/settingsMigration.test.ts  | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/tests-ui/tests/utils/migration/settingsMigration.test.ts b/tests-ui/tests/utils/migration/settingsMigration.test.ts
index 57d3f1dd7d..963a91ff7a 100644
--- a/tests-ui/tests/utils/migration/settingsMigration.test.ts
+++ b/tests-ui/tests/utils/migration/settingsMigration.test.ts
@@ -115,6 +115,24 @@ describe('settingsMigration', () => {
       )
     })
 
+    it('should delete targetSelector property after migration', async () => {
+      // Setup with old format
+      store.settingValues = {
+        'Comfy.Keybinding.UnsetBindings': [
+          { targetSelector: '#graph-canvas', key: 'a' }
+        ]
+      }
+
+      // Run migration
+      await SETTING_MIGRATIONS[1].migrate()
+
+      // Verify targetSelector is deleted and targetElementId is added
+      const result = store.settingValues['Comfy.Keybinding.UnsetBindings'][0]
+      expect(result).not.toHaveProperty('targetSelector')
+      expect(result).toHaveProperty('targetElementId', 'graph-canvas')
+      expect(result).toHaveProperty('key', 'a')
+    })
+
     it('should not migrate when all keybindings use new format', () => {
       // Setup with new format
       store.settingValues = {