Merge branch 'main' into clean-tsconfig

This commit is contained in:
Terry Jia
2026-02-10 21:18:27 -05:00
committed by GitHub
1098 changed files with 55765 additions and 20326 deletions

View File

@@ -3,12 +3,15 @@
## Task: Add English translations for all new localized strings ## Task: Add English translations for all new localized strings
### Step 1: Identify new translation keys ### Step 1: Identify new translation keys
Find all translation keys that were added in the current branch's changes. These keys appear as arguments to translation functions: `t()`, `st()`, `$t()`, or similar i18n functions. Find all translation keys that were added in the current branch's changes. These keys appear as arguments to translation functions: `t()`, `st()`, `$t()`, or similar i18n functions.
### Step 2: Add translations to English locale file ### Step 2: Add translations to English locale file
For each new translation key found, add the corresponding English text to the file `src/locales/en/main.json`. For each new translation key found, add the corresponding English text to the file `src/locales/en/main.json`.
### Key-to-JSON mapping rules: ### Key-to-JSON mapping rules:
- Translation keys use dot notation to represent nested JSON structure - Translation keys use dot notation to represent nested JSON structure
- Convert dot notation to nested JSON objects when adding to the locale file - Convert dot notation to nested JSON objects when adding to the locale file
- Example: The key `g.user.name` maps to: - Example: The key `g.user.name` maps to:
@@ -23,6 +26,7 @@ For each new translation key found, add the corresponding English text to the fi
``` ```
### Important notes: ### Important notes:
1. **Only modify the English locale file** (`src/locales/en/main.json`) 1. **Only modify the English locale file** (`src/locales/en/main.json`)
2. **Do not modify other locale files** - translations for other languages are automatically generated by the `i18n.yaml` workflow 2. **Do not modify other locale files** - translations for other languages are automatically generated by the `i18n.yaml` workflow
3. **Exception for manual translations**: Only add translations to non-English locale files if: 3. **Exception for manual translations**: Only add translations to non-English locale files if:
@@ -30,6 +34,7 @@ For each new translation key found, add the corresponding English text to the fi
- The automated translation would likely be incorrect due to technical terminology or context-specific meaning - The automated translation would likely be incorrect due to technical terminology or context-specific meaning
### Example workflow: ### Example workflow:
1. If you added `t('settings.advanced.enable')` in a Vue component 1. If you added `t('settings.advanced.enable')` in a Vue component
2. Add to `src/locales/en/main.json`: 2. Add to `src/locales/en/main.json`:
```json ```json

View File

@@ -15,6 +15,7 @@ To post inline comments, you will use the GitHub API via the `gh` command. Here'
- Run: `gh pr view $PR_NUMBER --json commits --jq '.commits[-1].oid'` to get the latest commit SHA - Run: `gh pr view $PR_NUMBER --json commits --jq '.commits[-1].oid'` to get the latest commit SHA
2. For each issue you find, post an inline comment using this exact command structure (as a single line): 2. For each issue you find, post an inline comment using this exact command structure (as a single line):
``` ```
gh api --method POST -H "Accept: application/vnd.github+json" -H "X-GitHub-Api-Version: 2022-11-28" /repos/OWNER/REPO/pulls/$PR_NUMBER/comments -f body="YOUR_COMMENT_BODY" -f commit_id="COMMIT_SHA" -f path="FILE_PATH" -F line=LINE_NUMBER -f side="RIGHT" gh api --method POST -H "Accept: application/vnd.github+json" -H "X-GitHub-Api-Version: 2022-11-28" /repos/OWNER/REPO/pulls/$PR_NUMBER/comments -f body="YOUR_COMMENT_BODY" -f commit_id="COMMIT_SHA" -f path="FILE_PATH" -F line=LINE_NUMBER -f side="RIGHT"
``` ```
@@ -22,13 +23,15 @@ To post inline comments, you will use the GitHub API via the `gh` command. Here'
3. Format your comment body using actual newlines in the command. Use a heredoc or construct the body with proper line breaks: 3. Format your comment body using actual newlines in the command. Use a heredoc or construct the body with proper line breaks:
``` ```
COMMENT_BODY="**[category] severity Priority** COMMENT_BODY="**[category] severity Priority**
```
**Issue**: Brief description of the problem **Issue**: Brief description of the problem
**Context**: Why this matters **Context**: Why this matters
**Suggestion**: How to fix it" **Suggestion**: How to fix it"
```
```
Then use: `-f body="$COMMENT_BODY"`
Then use: `-f body="$COMMENT_BODY"`
## Phase 1: Environment Setup and PR Context ## Phase 1: Environment Setup and PR Context
@@ -58,10 +61,12 @@ This is critical for better file inspection:
1. Get PR metadata: `gh pr view $PR_NUMBER --json files,title,body,additions,deletions,baseRefName,headRefName > pr_info.json` 1. Get PR metadata: `gh pr view $PR_NUMBER --json files,title,body,additions,deletions,baseRefName,headRefName > pr_info.json`
2. Extract branch names from pr_info.json using jq 2. Extract branch names from pr_info.json using jq
3. Fetch and checkout the PR branch: 3. Fetch and checkout the PR branch:
``` ```
git fetch origin "pull/$PR_NUMBER/head:pr-$PR_NUMBER"
git checkout "pr-$PR_NUMBER" git fetch origin "pull/$PR_NUMBER/head:pr-$PR_NUMBER"
``` git checkout "pr-$PR_NUMBER"
```
### Step 1.4: Get Changed Files and Diffs ### Step 1.4: Get Changed Files and Diffs
@@ -100,9 +105,9 @@ Intelligently load only relevant knowledge:
1. Use GitHub API to discover available knowledge folders: `https://api.github.com/repos/Comfy-Org/comfy-claude-prompt-library/contents/.claude/knowledge` 1. Use GitHub API to discover available knowledge folders: `https://api.github.com/repos/Comfy-Org/comfy-claude-prompt-library/contents/.claude/knowledge`
2. For each knowledge folder, check if it's relevant by searching for the folder name in: 2. For each knowledge folder, check if it's relevant by searching for the folder name in:
- Changed file paths - Changed file paths
- PR title - PR title
- PR body - PR body
3. If relevant, download all files from that knowledge folder 3. If relevant, download all files from that knowledge folder
### Step 2.4: Load Validation Rules ### Step 2.4: Load Validation Rules
@@ -193,12 +198,14 @@ Consider:
For each issue found, create a concise inline comment with this structure: For each issue found, create a concise inline comment with this structure:
``` ```
**[category] severity Priority** **[category] severity Priority**
**Issue**: Brief description of the problem **Issue**: Brief description of the problem
**Context**: Why this matters **Context**: Why this matters
**Suggestion**: How to fix it **Suggestion**: How to fix it
```
````
Categories: architecture/security/performance/quality Categories: architecture/security/performance/quality
Severities: critical/high/medium/low Severities: critical/high/medium/low
@@ -214,7 +221,7 @@ For EACH issue:
```bash ```bash
gh api --method POST -H "Accept: application/vnd.github+json" -H "X-GitHub-Api-Version: 2022-11-28" /repos/OWNER/REPO/pulls/$PR_NUMBER/comments -f body="$COMMENT_BODY" -f commit_id="COMMIT_SHA" -f path="FILE_PATH" -F line=LINE_NUMBER -f side="RIGHT" gh api --method POST -H "Accept: application/vnd.github+json" -H "X-GitHub-Api-Version: 2022-11-28" /repos/OWNER/REPO/pulls/$PR_NUMBER/comments -f body="$COMMENT_BODY" -f commit_id="COMMIT_SHA" -f path="FILE_PATH" -F line=LINE_NUMBER -f side="RIGHT"
``` ````
CRITICAL: The entire command must be on one line. Use actual values, not placeholders. CRITICAL: The entire command must be on one line. Use actual values, not placeholders.
@@ -223,12 +230,14 @@ CRITICAL: The entire command must be on one line. Use actual values, not placeho
Here's an example of how to review a file with a security issue: Here's an example of how to review a file with a security issue:
1. First, get the repository info: 1. First, get the repository info:
```bash ```bash
gh repo view --json owner,name gh repo view --json owner,name
# Output: {"owner":{"login":"Comfy-Org"},"name":"ComfyUI_frontend"} # Output: {"owner":{"login":"Comfy-Org"},"name":"ComfyUI_frontend"}
``` ```
2. Get the commit SHA: 2. Get the commit SHA:
```bash ```bash
gh pr view $PR_NUMBER --json commits --jq '.commits[-1].oid' gh pr view $PR_NUMBER --json commits --jq '.commits[-1].oid'
# Output: abc123def456 # Output: abc123def456
@@ -240,14 +249,17 @@ Here's an example of how to review a file with a security issue:
```bash ```bash
# First, create the comment body with proper newlines # First, create the comment body with proper newlines
COMMENT_BODY="**[security] critical Priority** COMMENT_BODY="**[security] critical Priority**
```
**Issue**: SQL injection vulnerability - user input directly concatenated into query **Issue**: SQL injection vulnerability - user input directly concatenated into query
**Context**: Allows attackers to execute arbitrary SQL commands **Context**: Allows attackers to execute arbitrary SQL commands
**Suggestion**: Use parameterized queries or prepared statements" **Suggestion**: Use parameterized queries or prepared statements"
# Then post the comment (as a single line) # Then post the comment (as a single line)
gh api --method POST -H "Accept: application/vnd.github+json" -H "X-GitHub-Api-Version: 2022-11-28" /repos/Comfy-Org/ComfyUI_frontend/pulls/$PR_NUMBER/comments -f body="$COMMENT_BODY" -f commit_id="abc123def456" -f path="src/db/queries.js" -F line=42 -f side="RIGHT"
``` gh api --method POST -H "Accept: application/vnd.github+json" -H "X-GitHub-Api-Version: 2022-11-28" /repos/Comfy-Org/ComfyUI_frontend/pulls/$PR_NUMBER/comments -f body="$COMMENT_BODY" -f commit_id="abc123def456" -f path="src/db/queries.js" -F line=42 -f side="RIGHT"
```
Repeat this process for every issue you find in the PR. Repeat this process for every issue you find in the PR.
@@ -282,9 +294,9 @@ Analyze the PR to determine its type:
1. Extract PR title and body from pr_info.json 1. Extract PR title and body from pr_info.json
2. Count files, additions, and deletions 2. Count files, additions, and deletions
3. Determine PR type: 3. Determine PR type:
- Feature: Check for tests, documentation, backward compatibility - Feature: Check for tests, documentation, backward compatibility
- Bug fix: Verify root cause addressed, includes regression tests - Bug fix: Verify root cause addressed, includes regression tests
- Refactor: Ensure behavior preservation, tests still pass - Refactor: Ensure behavior preservation, tests still pass
## Phase 7: Generate Comprehensive Summary ## Phase 7: Generate Comprehensive Summary
@@ -292,16 +304,17 @@ After ALL inline comments are posted, create a summary:
1. Calculate total issues by category and severity 1. Calculate total issues by category and severity
2. Use `gh pr review $PR_NUMBER --comment` to post a summary with: 2. Use `gh pr review $PR_NUMBER --comment` to post a summary with:
- Review disclaimer - Review disclaimer
- Issue distribution (counts by severity) - Issue distribution (counts by severity)
- Category breakdown - Category breakdown
- Key findings for each category - Key findings for each category
- Positive observations - Positive observations
- References to guidelines - References to guidelines
- Next steps - Next steps
Include in the summary: Include in the summary:
``` ```
# Comprehensive PR Review # Comprehensive PR Review
This review is generated by Claude. It may not always be accurate, as with human reviewers. If you believe that any of the comments are invalid or incorrect, please state why for each. For others, please implement the changes in one way or another. This review is generated by Claude. It may not always be accurate, as with human reviewers. If you believe that any of the comments are invalid or incorrect, please state why for each. For others, please implement the changes in one way or another.
@@ -312,12 +325,14 @@ This review is generated by Claude. It may not always be accurate, as with human
**Impact**: [X] additions, [Y] deletions across [Z] files **Impact**: [X] additions, [Y] deletions across [Z] files
### Issue Distribution ### Issue Distribution
- Critical: [CRITICAL_COUNT] - Critical: [CRITICAL_COUNT]
- High: [HIGH_COUNT] - High: [HIGH_COUNT]
- Medium: [MEDIUM_COUNT] - Medium: [MEDIUM_COUNT]
- Low: [LOW_COUNT] - Low: [LOW_COUNT]
### Category Breakdown ### Category Breakdown
- Architecture: [ARCHITECTURE_ISSUES] issues - Architecture: [ARCHITECTURE_ISSUES] issues
- Security: [SECURITY_ISSUES] issues - Security: [SECURITY_ISSUES] issues
- Performance: [PERFORMANCE_ISSUES] issues - Performance: [PERFORMANCE_ISSUES] issues
@@ -326,33 +341,42 @@ This review is generated by Claude. It may not always be accurate, as with human
## Key Findings ## Key Findings
### Architecture & Design ### Architecture & Design
[Detailed architectural analysis based on repository patterns] [Detailed architectural analysis based on repository patterns]
### Security Considerations ### Security Considerations
[Security implications beyond basic vulnerabilities] [Security implications beyond basic vulnerabilities]
### Performance Impact ### Performance Impact
[Performance analysis including bundle size, render impact] [Performance analysis including bundle size, render impact]
### Integration Points ### Integration Points
[How this affects other systems, extensions, etc.] [How this affects other systems, extensions, etc.]
## Positive Observations ## Positive Observations
[What was done well, good patterns followed] [What was done well, good patterns followed]
## References ## References
- [Repository Architecture Guide](https://github.com/Comfy-Org/comfy-claude-prompt-library/blob/master/project-summaries-for-agents/ComfyUI_frontend/REPOSITORY_GUIDE.md) - [Repository Architecture Guide](https://github.com/Comfy-Org/comfy-claude-prompt-library/blob/master/project-summaries-for-agents/ComfyUI_frontend/REPOSITORY_GUIDE.md)
- [Frontend Standards](https://github.com/Comfy-Org/comfy-claude-prompt-library/blob/master/.claude/commands/validation/frontend-code-standards.md) - [Frontend Standards](https://github.com/Comfy-Org/comfy-claude-prompt-library/blob/master/.claude/commands/validation/frontend-code-standards.md)
- [Security Guidelines](https://github.com/Comfy-Org/comfy-claude-prompt-library/blob/master/.claude/commands/validation/security-audit.md) - [Security Guidelines](https://github.com/Comfy-Org/comfy-claude-prompt-library/blob/master/.claude/commands/validation/security-audit.md)
## Next Steps ## Next Steps
1. Address critical issues before merge 1. Address critical issues before merge
2. Consider architectural feedback for long-term maintainability 2. Consider architectural feedback for long-term maintainability
3. Add tests for uncovered scenarios 3. Add tests for uncovered scenarios
4. Update documentation if needed 4. Update documentation if needed
--- ---
*This is a comprehensive automated review. For architectural decisions requiring human judgment, please request additional manual review.*
_This is a comprehensive automated review. For architectural decisions requiring human judgment, please request additional manual review._
``` ```
## Important Guidelines ## Important Guidelines
@@ -375,4 +399,5 @@ This is a COMPREHENSIVE review, not a linting pass. Provide the same quality fee
5. Phase 6: Consider PR type for additional checks 5. Phase 6: Consider PR type for additional checks
6. Phase 7: Post comprehensive summary ONLY after all inline comments 6. Phase 7: Post comprehensive summary ONLY after all inline comments
Remember: Individual inline comments for each issue, then one final summary. Never batch issues into a single comment. Remember: Individual inline comments for each issue, then one final summary. Never batch issues into a single comment.
```

View File

@@ -7,8 +7,9 @@ Create a frontend release with version type: $ARGUMENTS
Expected format: Version increment type and optional description Expected format: Version increment type and optional description
Examples: Examples:
- `patch` - Bug fixes only - `patch` - Bug fixes only
- `minor` - New features, backward compatible - `minor` - New features, backward compatible
- `major` - Breaking changes - `major` - Breaking changes
- `prerelease` - Alpha/beta/rc releases - `prerelease` - Alpha/beta/rc releases
- `patch "Critical security fixes"` - With custom description - `patch "Critical security fixes"` - With custom description
@@ -21,8 +22,9 @@ If no arguments provided, the command will always perform prerelease if the curr
## Prerequisites ## Prerequisites
Before starting, ensure: Before starting, ensure:
- You have push access to the repository - You have push access to the repository
- GitHub CLI (`gh`) is authenticated - GitHub CLI (`gh`) is authenticated
- You're on a clean main branch working tree - You're on a clean main branch working tree
- All intended changes are merged to main - All intended changes are merged to main
- You understand the scope of changes being released - You understand the scope of changes being released
@@ -30,6 +32,7 @@ Before starting, ensure:
## Critical Checks Before Starting ## Critical Checks Before Starting
### 1. Check Current Version Status ### 1. Check Current Version Status
```bash ```bash
# Get current version and check if it's a pre-release # Get current version and check if it's a pre-release
CURRENT_VERSION=$(node -p "require('./package.json').version") CURRENT_VERSION=$(node -p "require('./package.json').version")
@@ -40,6 +43,7 @@ fi
``` ```
### 2. Find Last Stable Release ### 2. Find Last Stable Release
```bash ```bash
# Get last stable release tag (no pre-release suffix) # Get last stable release tag (no pre-release suffix)
LAST_STABLE=$(git tag -l "v*" | grep -v "\-" | sort -V | tail -1) LAST_STABLE=$(git tag -l "v*" | grep -v "\-" | sort -V | tail -1)
@@ -49,6 +53,7 @@ echo "Last stable release: $LAST_STABLE"
## Configuration Options ## Configuration Options
**Environment Variables:** **Environment Variables:**
- `RELEASE_SKIP_SECURITY_SCAN=true` - Skip security audit - `RELEASE_SKIP_SECURITY_SCAN=true` - Skip security audit
- `RELEASE_AUTO_APPROVE=true` - Skip some confirmation prompts - `RELEASE_AUTO_APPROVE=true` - Skip some confirmation prompts
- `RELEASE_DRY_RUN=true` - Simulate release without executing - `RELEASE_DRY_RUN=true` - Simulate release without executing
@@ -129,13 +134,14 @@ echo "Last stable release: $LAST_STABLE"
### Step 4: Analyze Dependency Updates ### Step 4: Analyze Dependency Updates
1. **Use pnpm's built-in dependency analysis:** 1. **Use pnpm's built-in dependency analysis:**
```bash ```bash
# Get outdated dependencies with pnpm # Get outdated dependencies with pnpm
pnpm outdated --format table > outdated-deps-${NEW_VERSION}.txt pnpm outdated --format table > outdated-deps-${NEW_VERSION}.txt
# Check for license compliance # Check for license compliance
pnpm licenses ls --json > licenses-${NEW_VERSION}.json pnpm licenses ls --json > licenses-${NEW_VERSION}.json
# Analyze why specific dependencies exist # Analyze why specific dependencies exist
echo "Dependency analysis:" > dep-analysis-${NEW_VERSION}.md echo "Dependency analysis:" > dep-analysis-${NEW_VERSION}.md
MAJOR_DEPS=("vue" "vite" "@vitejs/plugin-vue" "typescript" "pinia") MAJOR_DEPS=("vue" "vite" "@vitejs/plugin-vue" "typescript" "pinia")
@@ -147,22 +153,23 @@ echo "Last stable release: $LAST_STABLE"
``` ```
2. **Check for significant dependency updates:** 2. **Check for significant dependency updates:**
```bash ```bash
# Extract all dependency changes for major version bumps # Extract all dependency changes for major version bumps
OTHER_DEP_CHANGES="" OTHER_DEP_CHANGES=""
# Compare major dependency versions (you can extend this list) # Compare major dependency versions (you can extend this list)
MAJOR_DEPS=("vue" "vite" "@vitejs/plugin-vue" "typescript" "pinia") MAJOR_DEPS=("vue" "vite" "@vitejs/plugin-vue" "typescript" "pinia")
for dep in "${MAJOR_DEPS[@]}"; do for dep in "${MAJOR_DEPS[@]}"; do
PREV_VER=$(echo "$PREV_PACKAGE_JSON" | grep -o "\"$dep\": \"[^\"]*\"" | grep -o '[0-9][^"]*' | head -1 || echo "") PREV_VER=$(echo "$PREV_PACKAGE_JSON" | grep -o "\"$dep\": \"[^\"]*\"" | grep -o '[0-9][^"]*' | head -1 || echo "")
CURR_VER=$(echo "$CURRENT_PACKAGE_JSON" | grep -o "\"$dep\": \"[^\"]*\"" | grep -o '[0-9][^"]*' | head -1 || echo "") CURR_VER=$(echo "$CURRENT_PACKAGE_JSON" | grep -o "\"$dep\": \"[^\"]*\"" | grep -o '[0-9][^"]*' | head -1 || echo "")
if [ "$PREV_VER" != "$CURR_VER" ] && [ -n "$PREV_VER" ] && [ -n "$CURR_VER" ]; then if [ "$PREV_VER" != "$CURR_VER" ] && [ -n "$PREV_VER" ] && [ -n "$CURR_VER" ]; then
# Check if it's a major version change # Check if it's a major version change
PREV_MAJOR=$(echo "$PREV_VER" | cut -d. -f1 | sed 's/[^0-9]//g') PREV_MAJOR=$(echo "$PREV_VER" | cut -d. -f1 | sed 's/[^0-9]//g')
CURR_MAJOR=$(echo "$CURR_VER" | cut -d. -f1 | sed 's/[^0-9]//g') CURR_MAJOR=$(echo "$CURR_VER" | cut -d. -f1 | sed 's/[^0-9]//g')
if [ "$PREV_MAJOR" != "$CURR_MAJOR" ]; then if [ "$PREV_MAJOR" != "$CURR_MAJOR" ]; then
OTHER_DEP_CHANGES="${OTHER_DEP_CHANGES}\n- **${dep}**: ${PREV_VER} → ${CURR_VER} (Major version change)" OTHER_DEP_CHANGES="${OTHER_DEP_CHANGES}\n- **${dep}**: ${PREV_VER} → ${CURR_VER} (Major version change)"
fi fi
@@ -173,11 +180,12 @@ echo "Last stable release: $LAST_STABLE"
### Step 5: Generate GTM Feature Summary ### Step 5: Generate GTM Feature Summary
1. **Collect PR data for analysis:** 1. **Collect PR data for analysis:**
```bash ```bash
# Get list of PR numbers from commits # Get list of PR numbers from commits
PR_NUMBERS=$(git log ${BASE_TAG}..HEAD --oneline --no-merges --first-parent | \ PR_NUMBERS=$(git log ${BASE_TAG}..HEAD --oneline --no-merges --first-parent | \
grep -oE "#[0-9]+" | tr -d '#' | sort -u) grep -oE "#[0-9]+" | tr -d '#' | sort -u)
# Save PR data for each PR # Save PR data for each PR
echo "[" > prs-${NEW_VERSION}.json echo "[" > prs-${NEW_VERSION}.json
first=true first=true
@@ -189,16 +197,17 @@ echo "Last stable release: $LAST_STABLE"
``` ```
2. **Analyze for GTM-worthy features:** 2. **Analyze for GTM-worthy features:**
``` ```
<task> <task>
Review these PRs to identify features worthy of marketing attention. Review these PRs to identify features worthy of marketing attention.
A feature is GTM-worthy if it meets ALL of these criteria: A feature is GTM-worthy if it meets ALL of these criteria:
- Introduces a NEW capability users didn't have before (not just improvements) - Introduces a NEW capability users didn't have before (not just improvements)
- Would be a compelling reason for users to upgrade to this version - Would be a compelling reason for users to upgrade to this version
- Can be demonstrated visually or has clear before/after comparison - Can be demonstrated visually or has clear before/after comparison
- Affects a significant portion of the user base - Affects a significant portion of the user base
NOT GTM-worthy: NOT GTM-worthy:
- Bug fixes (even important ones) - Bug fixes (even important ones)
- Minor UI tweaks or color changes - Minor UI tweaks or color changes
@@ -206,19 +215,20 @@ echo "Last stable release: $LAST_STABLE"
- Internal refactoring - Internal refactoring
- Small convenience features - Small convenience features
- Features that only improve existing functionality marginally - Features that only improve existing functionality marginally
For each GTM-worthy feature, note: For each GTM-worthy feature, note:
- PR number, title, and author - PR number, title, and author
- Media links from the PR description - Media links from the PR description
- One compelling sentence on why users should care - One compelling sentence on why users should care
If there are no GTM-worthy features, just say "No marketing-worthy features in this release." If there are no GTM-worthy features, just say "No marketing-worthy features in this release."
</task> </task>
PR data: [contents of prs-${NEW_VERSION}.json] PR data: [contents of prs-${NEW_VERSION}.json]
``` ```
3. **Generate GTM notification using this EXACT Slack-compatible format:** 3. **Generate GTM notification using this EXACT Slack-compatible format:**
```bash ```bash
# Only create file if GTM-worthy features exist: # Only create file if GTM-worthy features exist:
if [ "$GTM_FEATURES_FOUND" = "true" ]; then if [ "$GTM_FEATURES_FOUND" = "true" ]; then
@@ -252,8 +262,8 @@ echo "Last stable release: $LAST_STABLE"
``` ```
**CRITICAL Formatting Requirements:** **CRITICAL Formatting Requirements:**
- Use single asterisk (*) for emphasis, NOT double (**) - Use single asterisk (\*) for emphasis, NOT double (\*\*)
- Use underscore (_) for italics - Use underscore (\_) for italics
- Use 4 spaces for indentation (not tabs) - Use 4 spaces for indentation (not tabs)
- Convert author names to @username format (e.g., "John Smith" → "@john") - Convert author names to @username format (e.g., "John Smith" → "@john")
- No section headers (#), no code language specifications - No section headers (#), no code language specifications
@@ -263,6 +273,7 @@ echo "Last stable release: $LAST_STABLE"
### Step 6: Version Preview ### Step 6: Version Preview
**Version Preview:** **Version Preview:**
- Current: `${CURRENT_VERSION}` - Current: `${CURRENT_VERSION}`
- Proposed: Show exact version number based on analysis: - Proposed: Show exact version number based on analysis:
- Major version if breaking changes detected - Major version if breaking changes detected
@@ -326,6 +337,7 @@ echo "Last stable release: $LAST_STABLE"
done done
``` ```
3. Create standardized release notes using this exact template: 3. Create standardized release notes using this exact template:
```bash ```bash
cat > release-notes-${NEW_VERSION}.md << 'EOF' cat > release-notes-${NEW_VERSION}.md << 'EOF'
## ⚠️ Breaking Changes ## ⚠️ Breaking Changes
@@ -359,6 +371,7 @@ echo "Last stable release: $LAST_STABLE"
**Full Changelog**: https://github.com/Comfy-Org/ComfyUI_frontend/compare/${BASE_TAG}...v${NEW_VERSION} **Full Changelog**: https://github.com/Comfy-Org/ComfyUI_frontend/compare/${BASE_TAG}...v${NEW_VERSION}
EOF EOF
``` ```
4. **Parse commits and populate template:** 4. **Parse commits and populate template:**
- Group commits by conventional commit type (feat:, fix:, chore:, etc.) - Group commits by conventional commit type (feat:, fix:, chore:, etc.)
- Extract PR numbers from commit messages - Extract PR numbers from commit messages
@@ -375,16 +388,19 @@ echo "Last stable release: $LAST_STABLE"
### Step 10: Create Version Bump PR ### Step 10: Create Version Bump PR
**For standard version bumps (patch/minor/major):** **For standard version bumps (patch/minor/major):**
```bash ```bash
# Trigger the workflow # Trigger the workflow
gh workflow run version-bump.yaml -f version_type=${VERSION_TYPE} gh workflow run release-version-bump.yaml -f version_type=${VERSION_TYPE}
# Workflow runs quickly - usually creates PR within 30 seconds # Workflow runs quickly - usually creates PR within 30 seconds
echo "Workflow triggered. Waiting for PR creation..." echo "Workflow triggered. Waiting for PR creation..."
``` ```
**For releasing a stable version:** **For releasing a stable version:**
1. Must manually create branch and update version: 1. Must manually create branch and update version:
```bash ```bash
git checkout -b version-bump-${NEW_VERSION} git checkout -b version-bump-${NEW_VERSION}
# Edit package.json to remove pre-release suffix # Edit package.json to remove pre-release suffix
@@ -394,23 +410,25 @@ echo "Workflow triggered. Waiting for PR creation..."
``` ```
2. Wait for PR creation (if using workflow) or create manually: 2. Wait for PR creation (if using workflow) or create manually:
```bash ```bash
# For workflow-created PRs - wait and find it # For workflow-created PRs - wait and find it
sleep 30 sleep 30
# Look for PR from comfy-pr-bot (not github-actions) # Look for PR from comfy-pr-bot (not github-actions)
PR_NUMBER=$(gh pr list --author comfy-pr-bot --limit 1 --json number --jq '.[0].number') PR_NUMBER=$(gh pr list --author comfy-pr-bot --limit 1 --json number --jq '.[0].number')
# Verify we got the PR # Verify we got the PR
if [ -z "$PR_NUMBER" ]; then if [ -z "$PR_NUMBER" ]; then
echo "PR not found yet. Checking recent PRs..." echo "PR not found yet. Checking recent PRs..."
gh pr list --limit 5 --json number,title,author gh pr list --limit 5 --json number,title,author
fi fi
# For manual PRs # For manual PRs
gh pr create --title "${NEW_VERSION}" \ gh pr create --title "${NEW_VERSION}" \
--body-file release-notes-${NEW_VERSION}.md \ --body-file release-notes-${NEW_VERSION}.md \
--label "Release" --label "Release"
``` ```
3. **Update PR with release notes:** 3. **Update PR with release notes:**
```bash ```bash
# For workflow-created PRs, update the body with our release notes # For workflow-created PRs, update the body with our release notes
@@ -425,28 +443,21 @@ echo "Workflow triggered. Waiting for PR creation..."
gh pr view ${PR_NUMBER} --json labels | jq -r '.labels[].name' | grep -q "Release" || \ gh pr view ${PR_NUMBER} --json labels | jq -r '.labels[].name' | grep -q "Release" || \
echo "ERROR: Release label missing! Add it immediately!" echo "ERROR: Release label missing! Add it immediately!"
``` ```
2. Check for update-locales commits: 2. Verify version number in package.json
```bash 3. Review all changed files
# WARNING: update-locales may add [skip ci] which blocks release workflow! 4. Ensure no unintended changes included
gh pr view ${PR_NUMBER} --json commits | grep -q "skip ci" && \ 5. Wait for required PR checks:
echo "WARNING: [skip ci] detected - release workflow may not trigger!"
```
3. Verify version number in package.json
4. Review all changed files
5. Ensure no unintended changes included
6. Wait for required PR checks:
```bash ```bash
gh pr checks ${PR_NUMBER} --watch gh pr checks ${PR_NUMBER} --watch
``` ```
7. **FINAL CODE REVIEW**: Release label present and no [skip ci]? 6. **FINAL CODE REVIEW**: Release label present and no [skip ci]?
### Step 12: Pre-Merge Validation ### Step 12: Pre-Merge Validation
1. **Review Requirements**: Release PRs require approval 1. **Review Requirements**: Release PRs require approval
2. Monitor CI checks - watch for update-locales 2. Monitor CI checks
3. **CRITICAL WARNING**: If update-locales adds [skip ci], the release workflow won't trigger! 3. Check no new commits to main since PR creation
4. Check no new commits to main since PR creation 4. **DEPLOYMENT READINESS**: Ready to merge?
5. **DEPLOYMENT READINESS**: Ready to merge?
### Step 13: Execute Release ### Step 13: Execute Release
@@ -468,14 +479,14 @@ echo "Workflow triggered. Waiting for PR creation..."
# Monitor branch creation (for minor/major releases) # Monitor branch creation (for minor/major releases)
gh run list --workflow=release-branch-create.yaml --limit=1 gh run list --workflow=release-branch-create.yaml --limit=1
``` ```
4. If workflow didn't trigger due to [skip ci]: 5. If workflow didn't trigger due to [skip ci]:
```bash ```bash
echo "ERROR: Release workflow didn't trigger!" echo "ERROR: Release workflow didn't trigger!"
echo "Options:" echo "Options:"
echo "1. Create patch release (e.g., 1.24.1) to trigger workflow" echo "1. Create patch release (e.g., 1.24.1) to trigger workflow"
echo "2. Investigate manual release options" echo "2. Investigate manual release options"
``` ```
5. If workflow triggered, monitor execution: 6. If workflow triggered, monitor execution:
```bash ```bash
WORKFLOW_RUN_ID=$(gh run list --workflow=release-draft-create.yaml --limit=1 --json databaseId --jq '.[0].databaseId') WORKFLOW_RUN_ID=$(gh run list --workflow=release-draft-create.yaml --limit=1 --json databaseId --jq '.[0].databaseId')
gh run watch ${WORKFLOW_RUN_ID} gh run watch ${WORKFLOW_RUN_ID}
@@ -484,6 +495,7 @@ echo "Workflow triggered. Waiting for PR creation..."
### Step 14: Enhance GitHub Release ### Step 14: Enhance GitHub Release
1. Wait for automatic release creation: 1. Wait for automatic release creation:
```bash ```bash
# Wait for release to be created # Wait for release to be created
while ! gh release view v${NEW_VERSION} >/dev/null 2>&1; do while ! gh release view v${NEW_VERSION} >/dev/null 2>&1; do
@@ -493,13 +505,14 @@ echo "Workflow triggered. Waiting for PR creation..."
``` ```
2. **Enhance the GitHub release:** 2. **Enhance the GitHub release:**
```bash ```bash
# Update release with our release notes # Update release with our release notes
gh release edit v${NEW_VERSION} \ gh release edit v${NEW_VERSION} \
--title "🚀 ComfyUI Frontend v${NEW_VERSION}" \ --title "🚀 ComfyUI Frontend v${NEW_VERSION}" \
--notes-file release-notes-${NEW_VERSION}.md \ --notes-file release-notes-${NEW_VERSION}.md \
--latest --latest
# Add any additional assets if needed # Add any additional assets if needed
# gh release upload v${NEW_VERSION} additional-assets.zip # gh release upload v${NEW_VERSION} additional-assets.zip
``` ```
@@ -512,14 +525,17 @@ echo "Workflow triggered. Waiting for PR creation..."
### Step 15: Verify Multi-Channel Distribution ### Step 15: Verify Multi-Channel Distribution
1. **GitHub Release:** 1. **GitHub Release:**
```bash ```bash
gh release view v${NEW_VERSION} --json assets,body,createdAt,tagName gh release view v${NEW_VERSION} --json assets,body,createdAt,tagName
``` ```
- ✅ Check release notes - ✅ Check release notes
- ✅ Verify dist.zip attachment - ✅ Verify dist.zip attachment
- ✅ Confirm release marked as latest (for main branch) - ✅ Confirm release marked as latest (for main branch)
2. **PyPI Package:** 2. **PyPI Package:**
```bash ```bash
# Check PyPI availability (may take a few minutes) # Check PyPI availability (may take a few minutes)
for i in {1..10}; do for i in {1..10}; do
@@ -533,6 +549,7 @@ echo "Workflow triggered. Waiting for PR creation..."
``` ```
3. **npm Package:** 3. **npm Package:**
```bash ```bash
# Check npm availability # Check npm availability
for i in {1..10}; do for i in {1..10}; do
@@ -550,15 +567,17 @@ echo "Workflow triggered. Waiting for PR creation..."
### Step 16: Post-Release Monitoring Setup ### Step 16: Post-Release Monitoring Setup
1. **Monitor immediate release health:** 1. **Monitor immediate release health:**
```bash ```bash
# Check for immediate issues # Check for immediate issues
gh issue list --label "bug" --state open --limit 5 --json title,number,createdAt gh issue list --label "bug" --state open --limit 5 --json title,number,createdAt
# Monitor download metrics (if accessible) # Monitor download metrics (if accessible)
gh release view v${NEW_VERSION} --json assets --jq '.assets[].downloadCount' gh release view v${NEW_VERSION} --json assets --jq '.assets[].downloadCount'
``` ```
2. **Update documentation tracking:** 2. **Update documentation tracking:**
```bash ```bash
cat > post-release-checklist.md << EOF cat > post-release-checklist.md << EOF
# Post-Release Checklist for v${NEW_VERSION} # Post-Release Checklist for v${NEW_VERSION}
@@ -589,6 +608,7 @@ echo "Workflow triggered. Waiting for PR creation..."
``` ```
3. **Create release summary:** 3. **Create release summary:**
```bash ```bash
cat > release-summary-${NEW_VERSION}.md << EOF cat > release-summary-${NEW_VERSION}.md << EOF
# Release Summary: ComfyUI Frontend v${NEW_VERSION} # Release Summary: ComfyUI Frontend v${NEW_VERSION}
@@ -626,6 +646,7 @@ echo "Workflow triggered. Waiting for PR creation..."
### Step 17: Create Release Summary ### Step 17: Create Release Summary
1. **Create comprehensive release summary:** 1. **Create comprehensive release summary:**
```bash ```bash
cat > release-summary-${NEW_VERSION}.md << EOF cat > release-summary-${NEW_VERSION}.md << EOF
# Release Summary: ComfyUI Frontend v${NEW_VERSION} # Release Summary: ComfyUI Frontend v${NEW_VERSION}
@@ -665,6 +686,7 @@ echo "Workflow triggered. Waiting for PR creation..."
### Rollback Procedures ### Rollback Procedures
**Pre-Merge Rollback:** **Pre-Merge Rollback:**
```bash ```bash
# Close version bump PR and reset # Close version bump PR and reset
gh pr close ${PR_NUMBER} gh pr close ${PR_NUMBER}
@@ -673,6 +695,7 @@ git clean -fd
``` ```
**Post-Merge Rollback:** **Post-Merge Rollback:**
```bash ```bash
# Create immediate patch release with reverts # Create immediate patch release with reverts
git revert ${RELEASE_COMMIT} git revert ${RELEASE_COMMIT}
@@ -680,6 +703,7 @@ git revert ${RELEASE_COMMIT}
``` ```
**Emergency Procedures:** **Emergency Procedures:**
```bash ```bash
# Document incident # Document incident
cat > release-incident-${NEW_VERSION}.md << EOF cat > release-incident-${NEW_VERSION}.md << EOF
@@ -713,31 +737,39 @@ The command implements multiple quality gates:
## Common Scenarios ## Common Scenarios
### Scenario 1: Regular Feature Release ### Scenario 1: Regular Feature Release
```bash ```bash
/project:create-frontend-release minor /project:create-frontend-release minor
``` ```
- Analyzes features since last release - Analyzes features since last release
- Generates changelog automatically - Generates changelog automatically
- Creates comprehensive release notes - Creates comprehensive release notes
### Scenario 2: Critical Security Patch ### Scenario 2: Critical Security Patch
```bash ```bash
/project:create-frontend-release patch "Security fixes for CVE-2024-XXXX" /project:create-frontend-release patch "Security fixes for CVE-2024-XXXX"
``` ```
- Expedited security scanning - Expedited security scanning
- Enhanced monitoring setup - Enhanced monitoring setup
### Scenario 3: Major Version with Breaking Changes ### Scenario 3: Major Version with Breaking Changes
```bash ```bash
/project:create-frontend-release major /project:create-frontend-release major
``` ```
- Comprehensive breaking change analysis - Comprehensive breaking change analysis
- Migration guide generation - Migration guide generation
### Scenario 4: Pre-release Testing ### Scenario 4: Pre-release Testing
```bash ```bash
/project:create-frontend-release prerelease /project:create-frontend-release prerelease
``` ```
- Creates alpha/beta/rc versions - Creates alpha/beta/rc versions
- Draft release status - Draft release status
- Python package specs require that prereleases use alpha/beta/rc as the preid - Python package specs require that prereleases use alpha/beta/rc as the preid
@@ -747,10 +779,12 @@ The command implements multiple quality gates:
When executing this release process, pay attention to these key aspects: When executing this release process, pay attention to these key aspects:
### Version Handling ### Version Handling
- For pre-release versions (e.g., 1.24.0-rc.1), the next stable release should be the same version without the suffix (1.24.0) - For pre-release versions (e.g., 1.24.0-rc.1), the next stable release should be the same version without the suffix (1.24.0)
- Never skip version numbers - follow semantic versioning strictly - Never skip version numbers - follow semantic versioning strictly
### Commit History Analysis ### Commit History Analysis
- **ALWAYS** use `--first-parent` flag with git log to avoid including commits from merged feature branches - **ALWAYS** use `--first-parent` flag with git log to avoid including commits from merged feature branches
- Verify PR merge targets before including them in changelogs: - Verify PR merge targets before including them in changelogs:
```bash ```bash
@@ -758,6 +792,7 @@ When executing this release process, pay attention to these key aspects:
``` ```
### Release Workflow Triggers ### Release Workflow Triggers
- The "Release" label on the PR is **CRITICAL** - without it, PyPI/npm publishing won't occur - The "Release" label on the PR is **CRITICAL** - without it, PyPI/npm publishing won't occur
- Check for `[skip ci]` in commit messages before merging - this blocks the release workflow - Check for `[skip ci]` in commit messages before merging - this blocks the release workflow
- If you encounter `[skip ci]`, push an empty commit to override it: - If you encounter `[skip ci]`, push an empty commit to override it:
@@ -766,11 +801,13 @@ When executing this release process, pay attention to these key aspects:
``` ```
### PR Creation Details ### PR Creation Details
- Version bump PRs come from `comfy-pr-bot`, not `github-actions` - Version bump PRs come from `comfy-pr-bot`, not `github-actions`
- The workflow typically completes in 20-30 seconds - The workflow typically completes in 20-30 seconds
- Always wait for the PR to be created before trying to edit it - Always wait for the PR to be created before trying to edit it
### Breaking Changes Detection ### Breaking Changes Detection
- Analyze changes to public-facing APIs: - Analyze changes to public-facing APIs:
- The `app` object and its methods - The `app` object and its methods
- The `api` module exports - The `api` module exports
@@ -779,9 +816,10 @@ When executing this release process, pay attention to these key aspects:
- Any modifications to these require marking as breaking changes - Any modifications to these require marking as breaking changes
### Recovery Procedures ### Recovery Procedures
If the release workflow fails to trigger: If the release workflow fails to trigger:
1. Create a revert PR to restore the previous version 1. Create a revert PR to restore the previous version
2. Merge the revert 2. Merge the revert
3. Re-run the version bump workflow 3. Re-run the version bump workflow
4. This approach is cleaner than creating extra version numbers 4. This approach is cleaner than creating extra version numbers

View File

@@ -3,10 +3,11 @@
This command creates patch/hotfix releases for ComfyUI Frontend by backporting fixes to stable core branches. It handles both automated backports (preferred) and manual cherry-picking (fallback). This command creates patch/hotfix releases for ComfyUI Frontend by backporting fixes to stable core branches. It handles both automated backports (preferred) and manual cherry-picking (fallback).
**Process Overview:** **Process Overview:**
1. **Check automated backports first** (via labels) 1. **Check automated backports first** (via labels)
2. **Skip to version bump** if backports already merged 2. **Skip to version bump** if backports already merged
3. **Manual cherry-picking** if automation failed 3. **Manual cherry-picking** if automation failed
4. **Create patch release** with version bump 4. **Create patch release** with version bump
5. **Publish GitHub release** (manually uncheck "latest") 5. **Publish GitHub release** (manually uncheck "latest")
6. **Update ComfyUI requirements.txt** via PR 6. **Update ComfyUI requirements.txt** via PR
@@ -14,7 +15,8 @@ This command creates patch/hotfix releases for ComfyUI Frontend by backporting f
Create a hotfix release by backporting commits/PRs from main to a core branch: $ARGUMENTS Create a hotfix release by backporting commits/PRs from main to a core branch: $ARGUMENTS
Expected format: Comma-separated list of commits or PR numbers Expected format: Comma-separated list of commits or PR numbers
Examples: Examples:
- `#1234,#5678` (PRs - preferred) - `#1234,#5678` (PRs - preferred)
- `abc123,def456` (commit hashes) - `abc123,def456` (commit hashes)
- `#1234,abc123` (mixed) - `#1234,abc123` (mixed)
@@ -25,7 +27,7 @@ If no arguments provided, the command will guide you through identifying commits
## Prerequisites ## Prerequisites
- Push access to repository - Push access to repository
- GitHub CLI (`gh`) authenticated - GitHub CLI (`gh`) authenticated
- Clean working tree - Clean working tree
- Understanding of what fixes need backporting - Understanding of what fixes need backporting
@@ -36,11 +38,13 @@ If no arguments provided, the command will guide you through identifying commits
**Check if automated backports were attempted:** **Check if automated backports were attempted:**
1. **For each PR, check existing backport labels:** 1. **For each PR, check existing backport labels:**
```bash ```bash
gh pr view #1234 --json labels | jq -r '.labels[].name' gh pr view #1234 --json labels | jq -r '.labels[].name'
``` ```
2. **If no backport labels exist, add them now:** 2. **If no backport labels exist, add them now:**
```bash ```bash
# Add backport labels (this triggers automated backports) # Add backport labels (this triggers automated backports)
gh pr edit #1234 --add-label "needs-backport" gh pr edit #1234 --add-label "needs-backport"
@@ -48,6 +52,7 @@ If no arguments provided, the command will guide you through identifying commits
``` ```
3. **Check for existing backport PRs:** 3. **Check for existing backport PRs:**
```bash ```bash
# Check for backport PRs created by automation # Check for backport PRs created by automation
PR_NUMBER=${ARGUMENTS%%,*} # Extract first PR number from arguments PR_NUMBER=${ARGUMENTS%%,*} # Extract first PR number from arguments
@@ -58,18 +63,22 @@ If no arguments provided, the command will guide you through identifying commits
4. **Handle existing backport scenarios:** 4. **Handle existing backport scenarios:**
**Scenario A: Automated backports already merged** **Scenario A: Automated backports already merged**
```bash ```bash
# Check if backport PRs were merged to core branches # Check if backport PRs were merged to core branches
gh pr list --search "backport-${PR_NUMBER}-to" --state merged gh pr list --search "backport-${PR_NUMBER}-to" --state merged
``` ```
- If backport PRs are merged → Skip to Step 10 (Version Bump) - If backport PRs are merged → Skip to Step 10 (Version Bump)
- **CONFIRMATION**: Automated backports completed, proceeding to version bump? - **CONFIRMATION**: Automated backports completed, proceeding to version bump?
**Scenario B: Automated backport PRs exist but not merged** **Scenario B: Automated backport PRs exist but not merged**
```bash ```bash
# Show open backport PRs that need merging # Show open backport PRs that need merging
gh pr list --search "backport-${PR_NUMBER}-to" --state open gh pr list --search "backport-${PR_NUMBER}-to" --state open
``` ```
- **ACTION REQUIRED**: Merge the existing backport PRs first - **ACTION REQUIRED**: Merge the existing backport PRs first
- Use: `gh pr merge [PR_NUMBER] --merge` for each backport PR - Use: `gh pr merge [PR_NUMBER] --merge` for each backport PR
- After merging, return to this command and skip to Step 10 (Version Bump) - After merging, return to this command and skip to Step 10 (Version Bump)
@@ -127,6 +136,7 @@ If no arguments provided, the command will guide you through identifying commits
### Step 6: Cherry-pick Changes ### Step 6: Cherry-pick Changes
For each commit: For each commit:
1. Attempt cherry-pick: `git cherry-pick <commit>` 1. Attempt cherry-pick: `git cherry-pick <commit>`
2. If conflicts occur: 2. If conflicts occur:
- Display conflict details - Display conflict details
@@ -198,6 +208,7 @@ For each commit:
``` ```
3. **CRITICAL**: Verify "Release" label is added 3. **CRITICAL**: Verify "Release" label is added
4. Create standardized release notes: 4. Create standardized release notes:
```bash ```bash
cat > release-notes-${NEW_VERSION}.md << 'EOF' cat > release-notes-${NEW_VERSION}.md << 'EOF'
## ⚠️ Breaking Changes ## ⚠️ Breaking Changes
@@ -231,12 +242,14 @@ For each commit:
**Full Changelog**: https://github.com/Comfy-Org/ComfyUI_frontend/compare/v${CURRENT_VERSION}...v${NEW_VERSION} **Full Changelog**: https://github.com/Comfy-Org/ComfyUI_frontend/compare/v${CURRENT_VERSION}...v${NEW_VERSION}
EOF EOF
``` ```
- For hotfixes, typically only populate the "Bug Fixes" section - For hotfixes, typically only populate the "Bug Fixes" section
- Include links to the cherry-picked PRs/commits - Include links to the cherry-picked PRs/commits
- Update the PR body with the release notes: - Update the PR body with the release notes:
```bash ```bash
gh pr edit ${PR_NUMBER} --body-file release-notes-${NEW_VERSION}.md gh pr edit ${PR_NUMBER} --body-file release-notes-${NEW_VERSION}.md
``` ```
5. **CONFIRMATION REQUIRED**: Release PR has "Release" label? 5. **CONFIRMATION REQUIRED**: Release PR has "Release" label?
### Step 12: Monitor Release Process ### Step 12: Monitor Release Process
@@ -262,7 +275,7 @@ For each commit:
2. **Find the DRAFT release** (e.g., "v1.23.5 Draft") 2. **Find the DRAFT release** (e.g., "v1.23.5 Draft")
3. **Click "Edit release"** 3. **Click "Edit release"**
4. **UNCHECK "Set as the latest release"** ⚠️ **CRITICAL** 4. **UNCHECK "Set as the latest release"** ⚠️ **CRITICAL**
- This prevents the hotfix from showing as "latest" - This prevents the hotfix from showing as "latest"
- Main branch should always be "latest release" - Main branch should always be "latest release"
5. **Click "Publish release"** 5. **Click "Publish release"**
6. **CONFIRMATION REQUIRED**: Draft release published with "latest" unchecked? 6. **CONFIRMATION REQUIRED**: Draft release published with "latest" unchecked?
@@ -272,6 +285,7 @@ For each commit:
**IMPORTANT**: Create PR to update ComfyUI's requirements.txt via fork: **IMPORTANT**: Create PR to update ComfyUI's requirements.txt via fork:
1. **Setup fork (if needed):** 1. **Setup fork (if needed):**
```bash ```bash
# Check if fork already exists # Check if fork already exists
if gh repo view ComfyUI --json owner | jq -r '.owner.login' | grep -q "$(gh api user --jq .login)"; then if gh repo view ComfyUI --json owner | jq -r '.owner.login' | grep -q "$(gh api user --jq .login)"; then
@@ -284,30 +298,32 @@ For each commit:
``` ```
2. **Clone fork and create branch:** 2. **Clone fork and create branch:**
```bash ```bash
# Clone your fork (or use existing clone) # Clone your fork (or use existing clone)
GITHUB_USER=$(gh api user --jq .login) GITHUB_USER=$(gh api user --jq .login)
if [ ! -d "ComfyUI-fork" ]; then if [ ! -d "ComfyUI-fork" ]; then
gh repo clone ${GITHUB_USER}/ComfyUI ComfyUI-fork gh repo clone ${GITHUB_USER}/ComfyUI ComfyUI-fork
fi fi
cd ComfyUI-fork cd ComfyUI-fork
git checkout master git checkout master
git pull origin master git pull origin master
# Create update branch # Create update branch
BRANCH_NAME="update-frontend-${NEW_VERSION}" BRANCH_NAME="update-frontend-${NEW_VERSION}"
git checkout -b ${BRANCH_NAME} git checkout -b ${BRANCH_NAME}
``` ```
3. **Update requirements.txt:** 3. **Update requirements.txt:**
```bash ```bash
# Update the version in requirements.txt # Update the version in requirements.txt
sed -i "s/comfyui-frontend-package==[0-9].*$/comfyui-frontend-package==${NEW_VERSION}/" requirements.txt sed -i "s/comfyui-frontend-package==[0-9].*$/comfyui-frontend-package==${NEW_VERSION}/" requirements.txt
# Verify the change # Verify the change
grep "comfyui-frontend-package" requirements.txt grep "comfyui-frontend-package" requirements.txt
# Commit the change # Commit the change
git add requirements.txt git add requirements.txt
git commit -m "Bump frontend to ${NEW_VERSION}" git commit -m "Bump frontend to ${NEW_VERSION}"
@@ -321,7 +337,8 @@ For each commit:
--repo comfyanonymous/ComfyUI \ --repo comfyanonymous/ComfyUI \
--title "Bump frontend to ${NEW_VERSION}" \ --title "Bump frontend to ${NEW_VERSION}" \
--body "$(cat <<EOF --body "$(cat <<EOF
Bump frontend to ${NEW_VERSION} Bump frontend to ${NEW_VERSION}
```
\`\`\` \`\`\`
python main.py --front-end-version Comfy-Org/ComfyUI_frontend@${NEW_VERSION} python main.py --front-end-version Comfy-Org/ComfyUI_frontend@${NEW_VERSION}
@@ -334,15 +351,19 @@ python main.py --front-end-version Comfy-Org/ComfyUI_frontend@${NEW_VERSION}
## Changes ## Changes
- Fix: [Brief description of hotfixes included] - Fix: [Brief description of hotfixes included]
EOF EOF
)" )"
```
```
```
5. **Clean up:** 5. **Clean up:**
```bash ```bash
# Return to original directory # Return to original directory
cd .. cd ..
# Keep fork directory for future updates # Keep fork directory for future updates
echo "Fork directory 'ComfyUI-fork' kept for future use" echo "Fork directory 'ComfyUI-fork' kept for future use"
``` ```
@@ -375,6 +396,7 @@ EOF
## Safety Checks ## Safety Checks
Throughout the process: Throughout the process:
- Always verify core branch matches ComfyUI's requirements.txt - Always verify core branch matches ComfyUI's requirements.txt
- For PRs: Ensure using correct commits (merge vs individual) - For PRs: Ensure using correct commits (merge vs individual)
- Check version numbers follow semantic versioning - Check version numbers follow semantic versioning
@@ -385,6 +407,7 @@ Throughout the process:
## Rollback Procedures ## Rollback Procedures
If something goes wrong: If something goes wrong:
- Before push: `git reset --hard origin/core/X.Y` - Before push: `git reset --hard origin/core/X.Y`
- After PR creation: Close PR and start over - After PR creation: Close PR and start over
- After failed release: Create new patch version with fixes - After failed release: Create new patch version with fixes
@@ -404,16 +427,16 @@ If something goes wrong:
## Modern Workflow Context ## Modern Workflow Context
**Primary Backport Method:** Automated via `needs-backport` + `X.YY` labels **Primary Backport Method:** Automated via `needs-backport` + `X.YY` labels
**This Command Usage:** **This Command Usage:**
- Smart path detection - skip to version bump if backports already merged - Smart path detection - skip to version bump if backports already merged
- Fallback to manual cherry-picking only when automation fails/has conflicts - Fallback to manual cherry-picking only when automation fails/has conflicts
**Complete Hotfix:** Includes GitHub release publishing + ComfyUI requirements.txt integration **Complete Hotfix:** Includes GitHub release publishing + ComfyUI requirements.txt integration
## Workflow Paths ## Workflow Paths
- **Path A:** Backports already merged → Skip to Step 10 (Version Bump) - **Path A:** Backports already merged → Skip to Step 10 (Version Bump)
- **Path B:** Backport PRs need merging → Merge them → Skip to Step 10 (Version Bump) - **Path B:** Backport PRs need merging → Merge them → Skip to Step 10 (Version Bump)
- **Path C:** No/failed backports → Manual cherry-picking (Steps 2-9) → Version Bump (Step 10) - **Path C:** No/failed backports → Manual cherry-picking (Steps 2-9) → Version Bump (Step 10)
This process ensures a complete hotfix release with proper GitHub publishing, ComfyUI integration, and multiple safety checkpoints.
This process ensures a complete hotfix release with proper GitHub publishing, ComfyUI integration, and multiple safety checkpoints.

View File

@@ -5,6 +5,7 @@ Bootstrap the ComfyUI Frontend monorepo with all necessary dependencies and veri
## Overview ## Overview
This command will: This command will:
1. Install pnpm package manager (if not present) 1. Install pnpm package manager (if not present)
2. Install all project dependencies 2. Install all project dependencies
3. Verify the project builds successfully 3. Verify the project builds successfully
@@ -93,7 +94,7 @@ sleep 10
# Check if server is running # Check if server is running
if curl -s http://localhost:5173 > /dev/null 2>&1; then if curl -s http://localhost:5173 > /dev/null 2>&1; then
echo "✅ Development server started successfully at http://localhost:5173" echo "✅ Development server started successfully at http://localhost:5173"
# Kill the background server # Kill the background server
kill $SERVER_PID kill $SERVER_PID
wait $SERVER_PID 2>/dev/null wait $SERVER_PID 2>/dev/null
@@ -154,4 +155,4 @@ After running the setup, manually verify:
- Node.js >= 24 - Node.js >= 24
- Git repository - Git repository
- Internet connection for package downloads - Internet connection for package downloads
- Available ports (typically 5173 for dev server) - Available ports (typically 5173 for dev server)

View File

@@ -12,10 +12,10 @@ Follow these steps systematically to verify our changes:
2. **Visual Testing Process** 2. **Visual Testing Process**
- Navigate to http://localhost:5173/ - Navigate to http://localhost:5173/
- For each target page (specified in arguments or recently changed files): - For each target page (specified in arguments or recently changed files):
* Navigate to the page using direct URL or site navigation - Navigate to the page using direct URL or site navigation
* Take a high-quality screenshot - Take a high-quality screenshot
* Analyze the screenshot for the specific changes we implemented - Analyze the screenshot for the specific changes we implemented
* Document any visual issues or improvements needed - Document any visual issues or improvements needed
3. **Quality Verification** 3. **Quality Verification**
Check each page for: Check each page for:
@@ -27,7 +27,7 @@ Follow these steps systematically to verify our changes:
- Typography and readability - Typography and readability
- Color scheme consistency - Color scheme consistency
- Interactive elements (buttons, links, forms) - Interactive elements (buttons, links, forms)
</instructions> </instructions>
<examples> <examples>
Common issues to watch for: Common issues to watch for:
@@ -48,10 +48,11 @@ For each page tested, provide:
4. Overall assessment of visual quality 4. Overall assessment of visual quality
If you find issues, be specific about: If you find issues, be specific about:
- Exact location of the problem - Exact location of the problem
- Expected vs actual behavior - Expected vs actual behavior
- Severity level (critical, important, minor) - Severity level (critical, important, minor)
- Suggested fix if obvious - Suggested fix if obvious
</reporting> </reporting>
Remember: Take your time with each screenshot and analysis. Visual quality directly impacts user experience and our project's professional appearance. Remember: Take your time with each screenshot and analysis. Visual quality directly impacts user experience and our project's professional appearance.

View File

@@ -0,0 +1,200 @@
---
name: writing-playwright-tests
description: 'Writes Playwright e2e tests for ComfyUI_frontend. Use when creating, modifying, or debugging browser tests. Triggers on: playwright, e2e test, browser test, spec file.'
---
# Writing Playwright Tests for ComfyUI_frontend
## Golden Rules
1. **ALWAYS look at existing tests first.** Search `browser_tests/tests/` for similar patterns before writing new tests.
2. **ALWAYS read the fixture code.** The APIs are in `browser_tests/fixtures/` - read them directly instead of guessing.
3. **Use premade JSON workflow assets** instead of building workflows programmatically.
- Assets live in `browser_tests/assets/`
- Load with `await comfyPage.workflow.loadWorkflow('feature/my_workflow')`
- Create new assets by starting with `browser_tests/assets/default.json` and manually editing the JSON to match your desired graph state
## Vue Nodes vs LiteGraph: Decision Guide
Choose based on **what you're testing**, not personal preference:
| Testing... | Use | Why |
| ---------------------------------------------- | -------------------------------- | ---------------------------------------- |
| Vue-rendered node UI, DOM widgets, CSS states | `comfyPage.vueNodes.*` | Nodes are DOM elements, use locators |
| Canvas interactions, connections, legacy nodes | `comfyPage.nodeOps.*` | Canvas-based, use coordinates/references |
| Both in same test | Pick primary, minimize switching | Avoid confusion |
**Vue Nodes requires explicit opt-in:**
```typescript
await comfyPage.settings.setSetting('Comfy.VueNodes.Enabled', true)
await comfyPage.vueNodes.waitForNodes()
```
**Vue Node state uses CSS classes:**
```typescript
const BYPASS_CLASS = /before:bg-bypass\/60/
await expect(node).toHaveClass(BYPASS_CLASS)
```
## Common Issues
These are frequent causes of flaky tests - check them first, but investigate if they don't apply:
| Symptom | Common Cause | Typical Fix |
| ---------------------------------- | ------------------------- | -------------------------------------------------------------------------------------- |
| Test passes locally, fails in CI | Missing nextFrame() | Add `await comfyPage.nextFrame()` after canvas ops (not needed after `loadWorkflow()`) |
| Keyboard shortcuts don't work | Missing focus | Add `await comfyPage.canvas.click()` first |
| Double-click doesn't trigger | Timing too fast | Add `{ delay: 5 }` option |
| Elements end up in wrong position | Drag animation incomplete | Use `{ steps: 10 }` not `{ steps: 1 }` |
| Widget value wrong after drag-drop | Upload incomplete | Add `{ waitForUpload: true }` |
| Test fails when run with others | Test pollution | Add `afterEach` with `resetView()` |
| Local screenshots don't match CI | Platform differences | Screenshots are Linux-only, use PR label |
## Test Tags
Add appropriate tags to every test:
| Tag | When to Use |
| ------------- | ----------------------------------------- |
| `@smoke` | Quick essential tests |
| `@slow` | Tests > 10 seconds |
| `@screenshot` | Visual regression tests |
| `@canvas` | Canvas interactions |
| `@node` | Node-related |
| `@widget` | Widget-related |
| `@mobile` | Mobile viewport (runs on Pixel 5 project) |
| `@2x` | HiDPI tests (runs on 2x scale project) |
```typescript
test.describe('Feature', { tag: ['@screenshot', '@canvas'] }, () => {
```
## Retry Patterns
**Never use `waitForTimeout`** - it's always wrong.
| Pattern | Use Case |
| ------------------------ | ---------------------------------------------------- |
| Auto-retrying assertions | `toBeVisible()`, `toHaveText()`, etc. (prefer these) |
| `expect.poll()` | Single value polling |
| `expect().toPass()` | Multiple assertions that must all pass |
```typescript
// Prefer auto-retrying assertions when possible
await expect(node).toBeVisible()
// Single value polling
await expect.poll(() => widget.getValue(), { timeout: 2000 }).toBe(100)
// Multiple conditions
await expect(async () => {
expect(await node1.getValue()).toBe('foo')
expect(await node2.getValue()).toBe('bar')
}).toPass({ timeout: 2000 })
```
## Screenshot Baselines
- **Screenshots are Linux-only.** Don't commit local screenshots.
- **To update baselines:** Add PR label `New Browser Test Expectations`
- **Mask dynamic content:**
```typescript
await expect(comfyPage.canvas).toHaveScreenshot('page.png', {
mask: [page.locator('.timestamp')]
})
```
## CI Debugging
1. Download artifacts from failed CI run
2. Extract and view trace: `npx playwright show-trace trace.zip`
3. CI deploys HTML report to Cloudflare Pages (link in PR comment)
4. Reproduce CI: `CI=true pnpm test:browser`
5. Local runs: `pnpm test:browser:local`
## Anti-Patterns
Avoid these common mistakes:
1. **Arbitrary waits** - Use retrying assertions instead
```typescript
// ❌ await page.waitForTimeout(500)
// ✅ await expect(element).toBeVisible()
```
2. **Implementation-tied selectors** - Use test IDs or semantic selectors
```typescript
// ❌ page.locator('div.container > button.btn-primary')
// ✅ page.getByTestId('submit-button')
```
3. **Missing nextFrame after canvas ops** - Canvas needs sync time
```typescript
await node.drag({ x: 50, y: 50 })
await comfyPage.nextFrame() // Required
```
4. **Shared state between tests** - Tests must be independent
```typescript
// ❌ let sharedData // Outside test
// ✅ Define state inside each test
```
## Quick Start Template
```typescript
// Path depends on test file location - adjust '../' segments accordingly
import {
comfyPageFixture as test,
comfyExpect as expect
} from '../fixtures/ComfyPage'
test.describe('FeatureName', { tag: ['@canvas'] }, () => {
test.afterEach(async ({ comfyPage }) => {
await comfyPage.canvasOps.resetView()
})
test('should do something', async ({ comfyPage }) => {
await comfyPage.workflow.loadWorkflow('myWorkflow')
const node = (await comfyPage.nodeOps.getNodeRefsByTitle('KSampler'))[0]
// ... test logic
await expect(comfyPage.canvas).toHaveScreenshot('expected.png')
})
})
```
## Finding Patterns
```bash
# Find similar tests
grep -r "KSampler" browser_tests/tests/
# Find usage of a fixture method
grep -r "loadWorkflow" browser_tests/tests/
# Find tests with specific tag
grep -r '@screenshot' browser_tests/tests/
```
## Key Files to Read
| Purpose | Path |
| ----------------- | ------------------------------------------ |
| Main fixture | `browser_tests/fixtures/ComfyPage.ts` |
| Helper classes | `browser_tests/fixtures/helpers/` |
| Component objects | `browser_tests/fixtures/components/` |
| Test selectors | `browser_tests/fixtures/selectors.ts` |
| Vue Node helpers | `browser_tests/fixtures/VueNodeHelpers.ts` |
| Test assets | `browser_tests/assets/` |
| Existing tests | `browser_tests/tests/` |
**Read the fixture code directly** - it's the source of truth for available methods.

7
.coderabbit.yaml Normal file
View File

@@ -0,0 +1,7 @@
issue_enrichment:
auto_enrich:
enabled: true
reviews:
high_level_summary: false
auto_review:
drafts: true

15
.gitattributes vendored
View File

@@ -1,16 +1,5 @@
# Default # Force all text files to use LF line endings
* text=auto * text=auto eol=lf
# Force TS to LF to make the unixy scripts not break on Windows
*.cjs text eol=lf
*.js text eol=lf
*.json text eol=lf
*.mjs text eol=lf
*.mts text eol=lf
*.snap text eol=lf
*.ts text eol=lf
*.vue text eol=lf
*.yaml text eol=lf
# Generated files # Generated files
packages/registry-types/src/comfyRegistryTypes.ts linguist-generated=true packages/registry-types/src/comfyRegistryTypes.ts linguist-generated=true

1
.github/AGENTS.md vendored
View File

@@ -5,6 +5,7 @@ Context for automated PR review system.
## Review Scope ## Review Scope
This automated review performs comprehensive analysis: This automated review performs comprehensive analysis:
- Architecture and design patterns - Architecture and design patterns
- Security vulnerabilities - Security vulnerabilities
- Performance implications - Performance implications

1
.github/CLAUDE.md vendored
View File

@@ -1,3 +1,4 @@
<!-- A rose by any other name would smell as sweet, <!-- A rose by any other name would smell as sweet,
But Claude insists on files named for its own conceit. --> But Claude insists on files named for its own conceit. -->
@AGENTS.md @AGENTS.md

View File

@@ -10,10 +10,7 @@ body:
options: options:
- label: I am running the latest version of ComfyUI - label: I am running the latest version of ComfyUI
required: true required: true
- label: I have searched existing issues to make sure this isn't a duplicate - label: I have custom nodes enabled
required: true
- label: I have tested with all custom nodes disabled ([see how](https://docs.comfy.org/troubleshooting/custom-node-issues#step-1%3A-test-with-all-custom-nodes-disabled))
required: true
- type: textarea - type: textarea
id: description id: description
@@ -60,7 +57,7 @@ body:
attributes: attributes:
label: ComfyUI Frontend Version label: ComfyUI Frontend Version
description: Found in Settings > About (e.g., "1.3.45") description: Found in Settings > About (e.g., "1.3.45")
placeholder: "1.3.45" placeholder: '1.3.45'
validations: validations:
required: true required: true

View File

@@ -4,13 +4,6 @@ labels: []
type: Feature type: Feature
body: body:
- type: checkboxes
attributes:
label: Is there an existing issue for this?
description: Please search to see if an issue already exists for the problem you're experiencing, and that it's not addressed in a recent build/commit.
options:
- label: I have searched the existing issues and checked the recent builds/commits
required: true
- type: markdown - type: markdown
attributes: attributes:
value: | value: |

View File

@@ -104,14 +104,14 @@ runs:
- name: Find existing comment - name: Find existing comment
id: find id: find
uses: peter-evans/find-comment@b30e6a3c0ed37e7c023ccd3f1db5c6c0b0c23aad uses: peter-evans/find-comment@b30e6a3c0ed37e7c023ccd3f1db5c6c0b0c23aad # v4.0.0
with: with:
issue-number: ${{ inputs.issue-number || github.event.pull_request.number }} issue-number: ${{ inputs.issue-number || github.event.pull_request.number }}
comment-author: github-actions[bot] comment-author: github-actions[bot]
body-includes: ${{ steps.build.outputs.marker_search }} body-includes: ${{ steps.build.outputs.marker_search }}
- name: Post or update comment - name: Post or update comment
uses: peter-evans/create-or-update-comment@e8674b075228eee787fea43ef493e45ece1004c9 uses: peter-evans/create-or-update-comment@e8674b075228eee787fea43ef493e45ece1004c9 # v5.0.0
with: with:
issue-number: ${{ inputs.issue-number || github.event.pull_request.number }} issue-number: ${{ inputs.issue-number || github.event.pull_request.number }}
comment-id: ${{ steps.find.outputs.comment-id }} comment-id: ${{ steps.find.outputs.comment-id }}

View File

@@ -16,7 +16,7 @@ runs:
# Checkout ComfyUI repo, install the dev_tools node and start server # Checkout ComfyUI repo, install the dev_tools node and start server
- name: Checkout ComfyUI - name: Checkout ComfyUI
uses: actions/checkout@v5 uses: actions/checkout@v6
with: with:
repository: 'comfyanonymous/ComfyUI' repository: 'comfyanonymous/ComfyUI'
path: 'ComfyUI' path: 'ComfyUI'
@@ -33,7 +33,7 @@ runs:
fi fi
- name: Setup Python - name: Setup Python
uses: actions/setup-python@v4 uses: actions/setup-python@v6
with: with:
python-version: '3.10' python-version: '3.10'

View File

@@ -12,29 +12,17 @@ runs:
# Install pnpm, Node.js, build frontend # Install pnpm, Node.js, build frontend
- name: Install pnpm - name: Install pnpm
uses: pnpm/action-setup@v4 uses: pnpm/action-setup@41ff72655975bd51cab0327fa583b6e92b6d3061 # v4.2.0
with: with:
version: 10 version: 10
- name: Setup Node.js - name: Setup Node.js
uses: actions/setup-node@v4 uses: actions/setup-node@v6
with: with:
node-version: 'lts/*' node-version: 'lts/*'
cache: 'pnpm' cache: 'pnpm'
cache-dependency-path: './pnpm-lock.yaml' cache-dependency-path: './pnpm-lock.yaml'
# Restore tool caches before running any build/lint operations
- name: Restore tool output cache
uses: actions/cache/restore@v4
with:
path: |
./.cache
./tsconfig.tsbuildinfo
key: tool-cache-${{ runner.os }}-${{ hashFiles('./pnpm-lock.yaml') }}-${{ hashFiles('./src/**/*.{ts,vue,js,mts}', './*.config.*') }}
restore-keys: |
tool-cache-${{ runner.os }}-${{ hashFiles('./pnpm-lock.yaml') }}-
tool-cache-${{ runner.os }}-
- name: Install dependencies - name: Install dependencies
shell: bash shell: bash
run: pnpm install --frozen-lockfile run: pnpm install --frozen-lockfile

View File

@@ -11,7 +11,7 @@ runs:
echo "playwright-version=$PLAYWRIGHT_VERSION" >> $GITHUB_OUTPUT echo "playwright-version=$PLAYWRIGHT_VERSION" >> $GITHUB_OUTPUT
- name: Cache Playwright Browsers - name: Cache Playwright Browsers
uses: actions/cache@v4 uses: actions/cache@v5 # v5.0.2
id: cache-playwright-browsers id: cache-playwright-browsers
with: with:
path: '~/.cache/ms-playwright' path: '~/.cache/ms-playwright'

View File

@@ -34,4 +34,4 @@ Follow Vue 3 style guide and naming conventions
Use Vite for fast development and building Use Vite for fast development and building
Use vue-i18n in composition API for any string literals. Place new translation entries in src/locales/en/main.json. Use vue-i18n in composition API for any string literals. Place new translation entries in src/locales/en/main.json.

View File

@@ -13,15 +13,15 @@ jobs:
steps: steps:
- name: Checkout repository - name: Checkout repository
uses: actions/checkout@v5 uses: actions/checkout@v6
- name: Install pnpm - name: Install pnpm
uses: pnpm/action-setup@v4 uses: pnpm/action-setup@41ff72655975bd51cab0327fa583b6e92b6d3061 # v4.2.0
with: with:
version: 10 version: 10
- name: Setup Node.js - name: Setup Node.js
uses: actions/setup-node@v4 uses: actions/setup-node@v6
with: with:
node-version: lts/* node-version: lts/*
cache: 'pnpm' cache: 'pnpm'
@@ -36,7 +36,7 @@ jobs:
echo "NEW_VERSION=$NEW_VERSION" >> $GITHUB_OUTPUT echo "NEW_VERSION=$NEW_VERSION" >> $GITHUB_OUTPUT
- name: Create Pull Request - name: Create Pull Request
uses: peter-evans/create-pull-request@271a8d0340265f705b14b6d32b9829c1cb33d45e uses: peter-evans/create-pull-request@c0f553fe549906ede9cf27b5156039d195d2ece0 # v8.1.0
with: with:
token: ${{ secrets.PR_GH_TOKEN }} token: ${{ secrets.PR_GH_TOKEN }}
commit-message: '[chore] Update electron-types to ${{ steps.get-version.outputs.NEW_VERSION }}' commit-message: '[chore] Update electron-types to ${{ steps.get-version.outputs.NEW_VERSION }}'

View File

@@ -18,15 +18,15 @@ jobs:
pull-requests: write pull-requests: write
steps: steps:
- name: Checkout repository - name: Checkout repository
uses: actions/checkout@v5 uses: actions/checkout@v6
- name: Install pnpm - name: Install pnpm
uses: pnpm/action-setup@v4 uses: pnpm/action-setup@41ff72655975bd51cab0327fa583b6e92b6d3061 # v4.2.0
with: with:
version: 10 version: 10
- name: Setup Node.js - name: Setup Node.js
uses: actions/setup-node@v4 uses: actions/setup-node@v6
with: with:
node-version: lts/* node-version: lts/*
cache: 'pnpm' cache: 'pnpm'
@@ -35,7 +35,7 @@ jobs:
run: pnpm install --frozen-lockfile run: pnpm install --frozen-lockfile
- name: Checkout ComfyUI-Manager repository - name: Checkout ComfyUI-Manager repository
uses: actions/checkout@v5 uses: actions/checkout@v6
with: with:
repository: Comfy-Org/ComfyUI-Manager repository: Comfy-Org/ComfyUI-Manager
path: ComfyUI-Manager path: ComfyUI-Manager
@@ -86,7 +86,7 @@ jobs:
- name: Create Pull Request - name: Create Pull Request
if: steps.check-changes.outputs.changed == 'true' if: steps.check-changes.outputs.changed == 'true'
uses: peter-evans/create-pull-request@271a8d0340265f705b14b6d32b9829c1cb33d45e uses: peter-evans/create-pull-request@c0f553fe549906ede9cf27b5156039d195d2ece0 # v8.1.0
with: with:
token: ${{ secrets.PR_GH_TOKEN }} token: ${{ secrets.PR_GH_TOKEN }}
commit-message: '[chore] Update ComfyUI-Manager API types from ComfyUI-Manager@${{ steps.manager-info.outputs.commit }}' commit-message: '[chore] Update ComfyUI-Manager API types from ComfyUI-Manager@${{ steps.manager-info.outputs.commit }}'

View File

@@ -17,15 +17,15 @@ jobs:
pull-requests: write pull-requests: write
steps: steps:
- name: Checkout repository - name: Checkout repository
uses: actions/checkout@v5 uses: actions/checkout@v6
- name: Install pnpm - name: Install pnpm
uses: pnpm/action-setup@v4 uses: pnpm/action-setup@41ff72655975bd51cab0327fa583b6e92b6d3061 # v4.2.0
with: with:
version: 10 version: 10
- name: Setup Node.js - name: Setup Node.js
uses: actions/setup-node@v4 uses: actions/setup-node@v6
with: with:
node-version: lts/* node-version: lts/*
cache: 'pnpm' cache: 'pnpm'
@@ -34,7 +34,7 @@ jobs:
run: pnpm install --frozen-lockfile run: pnpm install --frozen-lockfile
- name: Checkout comfy-api repository - name: Checkout comfy-api repository
uses: actions/checkout@v5 uses: actions/checkout@v6
with: with:
repository: Comfy-Org/comfy-api repository: Comfy-Org/comfy-api
path: comfy-api path: comfy-api
@@ -87,7 +87,7 @@ jobs:
- name: Create Pull Request - name: Create Pull Request
if: steps.check-changes.outputs.changed == 'true' if: steps.check-changes.outputs.changed == 'true'
uses: peter-evans/create-pull-request@271a8d0340265f705b14b6d32b9829c1cb33d45e uses: peter-evans/create-pull-request@c0f553fe549906ede9cf27b5156039d195d2ece0 # v8.1.0
with: with:
token: ${{ secrets.PR_GH_TOKEN }} token: ${{ secrets.PR_GH_TOKEN }}
commit-message: '[chore] Update Comfy Registry API types from comfy-api@${{ steps.api-info.outputs.commit }}' commit-message: '[chore] Update Comfy Registry API types from comfy-api@${{ steps.api-info.outputs.commit }}'

View File

@@ -0,0 +1,52 @@
name: 'CI: Dist Telemetry Scan'
on:
pull_request:
branches-ignore: [wip/*, draft/*, temp/*]
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true
permissions:
contents: read
jobs:
scan:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
- name: Install pnpm
uses: pnpm/action-setup@41ff72655975bd51cab0327fa583b6e92b6d3061 # v4.2.0
with:
version: 10
- name: Use Node.js
uses: actions/setup-node@6044e13b5dc448c55e2357c09f80417699197238 # v6.2.0
with:
node-version: 'lts/*'
cache: 'pnpm'
- name: Install dependencies
run: pnpm install --frozen-lockfile
- name: Build project
run: pnpm build
- name: Scan dist for telemetry references
run: |
set -euo pipefail
if rg --no-ignore -n \
-g '*.html' \
-g '*.js' \
-e 'Google Tag Manager' \
-e '(?i)\bgtm\.js\b' \
-e '(?i)googletagmanager\.com/gtm\.js\\?id=' \
-e '(?i)googletagmanager\.com/ns\.html\\?id=' \
dist; then
echo 'Telemetry references found in dist assets.'
exit 1
fi
echo 'No telemetry references found in dist assets.'

View File

@@ -1,5 +1,5 @@
# Description: Validates JSON syntax in all tracked .json files (excluding tsconfig*.json) using jq # Description: Validates JSON syntax in all tracked .json files (excluding tsconfig*.json) using jq
name: "CI: JSON Validation" name: 'CI: JSON Validation'
on: on:
push: push:
@@ -13,6 +13,6 @@ jobs:
json-lint: json-lint:
runs-on: ubuntu-latest runs-on: ubuntu-latest
steps: steps:
- uses: actions/checkout@v5 - uses: actions/checkout@v6
- name: Validate JSON syntax - name: Validate JSON syntax
run: ./scripts/cicd/check-json.sh run: ./scripts/cicd/check-json.sh

View File

@@ -1,5 +1,5 @@
# Description: Linting and code formatting validation for pull requests # Description: Linting and code formatting validation for pull requests
name: "CI: Lint Format" name: 'CI: Lint Format'
on: on:
pull_request: pull_request:
@@ -18,23 +18,13 @@ jobs:
runs-on: ubuntu-latest runs-on: ubuntu-latest
steps: steps:
- name: Checkout PR - name: Checkout PR
uses: actions/checkout@v5 uses: actions/checkout@v6
with: with:
ref: ${{ !github.event.pull_request.head.repo.fork && github.head_ref || github.ref }} ref: ${{ !github.event.pull_request.head.repo.fork && github.head_ref || github.ref }}
token: ${{ secrets.PR_GH_TOKEN }}
- name: Install pnpm - name: Setup frontend
uses: pnpm/action-setup@v4 uses: ./.github/actions/setup-frontend
with:
version: 10
- name: Use Node.js
uses: actions/setup-node@v4
with:
node-version: 'lts/*'
cache: 'pnpm'
- name: Install dependencies
run: pnpm install --frozen-lockfile
- name: Run ESLint with auto-fix - name: Run ESLint with auto-fix
run: pnpm lint:fix run: pnpm lint:fix
@@ -73,7 +63,7 @@ jobs:
- name: Comment on PR about auto-fix - name: Comment on PR about auto-fix
if: steps.verify-changed-files.outputs.changed == 'true' && github.event.pull_request.head.repo.full_name == github.repository if: steps.verify-changed-files.outputs.changed == 'true' && github.event.pull_request.head.repo.full_name == github.repository
continue-on-error: true continue-on-error: true
uses: actions/github-script@v7 uses: actions/github-script@v8
with: with:
script: | script: |
github.rest.issues.createComment({ github.rest.issues.createComment({
@@ -86,7 +76,7 @@ jobs:
- name: Comment on PR about manual fix needed - name: Comment on PR about manual fix needed
if: steps.verify-changed-files.outputs.changed == 'true' && github.event.pull_request.head.repo.full_name != github.repository if: steps.verify-changed-files.outputs.changed == 'true' && github.event.pull_request.head.repo.full_name != github.repository
continue-on-error: true continue-on-error: true
uses: actions/github-script@v7 uses: actions/github-script@v8
with: with:
script: | script: |
github.rest.issues.createComment({ github.rest.issues.createComment({

View File

@@ -1,5 +1,5 @@
# Description: Validates Python code in tools/devtools directory # Description: Validates Python code in tools/devtools directory
name: "CI: Python Validation" name: 'CI: Python Validation'
on: on:
pull_request: pull_request:
@@ -16,10 +16,10 @@ jobs:
steps: steps:
- name: Checkout repository - name: Checkout repository
uses: actions/checkout@v5 uses: actions/checkout@v6
- name: Set up Python - name: Set up Python
uses: actions/setup-python@v5 uses: actions/setup-python@v6
with: with:
python-version: '3.11' python-version: '3.11'

View File

@@ -1,5 +1,5 @@
# Description: Runs shellcheck on tracked shell scripts when they change # Description: Runs shellcheck on tracked shell scripts when they change
name: "CI: Shell Validation" name: 'CI: Shell Validation'
on: on:
push: push:

View File

@@ -1,4 +1,4 @@
name: "CI: Size Data" name: 'CI: Size Data'
on: on:
push: push:
@@ -17,21 +17,10 @@ jobs:
runs-on: ubuntu-latest runs-on: ubuntu-latest
steps: steps:
- uses: actions/checkout@v5 - uses: actions/checkout@v6
- name: Install pnpm - name: Setup frontend
uses: pnpm/action-setup@v4.1.0 uses: ./.github/actions/setup-frontend
with:
version: 10
- name: Install Node.js
uses: actions/setup-node@v5
with:
node-version: '24.x'
cache: pnpm
- name: Install dependencies
run: pnpm install
- name: Build project - name: Build project
run: pnpm build run: pnpm build
@@ -46,7 +35,7 @@ jobs:
echo ${{ github.base_ref }} > ./temp/size/base.txt echo ${{ github.base_ref }} > ./temp/size/base.txt
- name: Upload size data - name: Upload size data
uses: actions/upload-artifact@v4 uses: actions/upload-artifact@v6
with: with:
name: size-data name: size-data
path: temp/size path: temp/size

View File

@@ -31,11 +31,11 @@ jobs:
echo "Is forked: ${{ github.event.workflow_run.head_repository.full_name != github.event.workflow_run.repository.full_name }}" echo "Is forked: ${{ github.event.workflow_run.head_repository.full_name != github.event.workflow_run.repository.full_name }}"
- name: Checkout repository - name: Checkout repository
uses: actions/checkout@v5 uses: actions/checkout@v6
- name: Get PR Number - name: Get PR Number
id: pr id: pr
uses: actions/github-script@v7 uses: actions/github-script@v8
with: with:
script: | script: |
const { data: prs } = await github.rest.pulls.list({ const { data: prs } = await github.rest.pulls.list({
@@ -68,7 +68,7 @@ jobs:
- name: Download and Deploy Reports - name: Download and Deploy Reports
if: steps.pr.outputs.result != 'null' && github.event.action == 'completed' if: steps.pr.outputs.result != 'null' && github.event.action == 'completed'
uses: actions/download-artifact@v4 uses: actions/download-artifact@v7
with: with:
github-token: ${{ secrets.GITHUB_TOKEN }} github-token: ${{ secrets.GITHUB_TOKEN }}
run-id: ${{ github.event.workflow_run.id }} run-id: ${{ github.event.workflow_run.id }}

View File

@@ -5,8 +5,8 @@ on:
push: push:
branches: [main, master, core/*, desktop/*] branches: [main, master, core/*, desktop/*]
pull_request: pull_request:
branches-ignore: branches-ignore: [wip/*, draft/*, temp/*]
[wip/*, draft/*, temp/*, vue-nodes-migration, sno-playwright-*] workflow_dispatch:
concurrency: concurrency:
group: ${{ github.workflow }}-${{ github.ref }} group: ${{ github.workflow }}-${{ github.ref }}
@@ -17,7 +17,7 @@ jobs:
runs-on: ubuntu-latest runs-on: ubuntu-latest
steps: steps:
- name: Checkout repository - name: Checkout repository
uses: actions/checkout@v5 uses: actions/checkout@v6
- name: Setup frontend - name: Setup frontend
uses: ./.github/actions/setup-frontend uses: ./.github/actions/setup-frontend
with: with:
@@ -25,7 +25,7 @@ jobs:
# Upload only built dist/ (containerized test jobs will pnpm install without cache) # Upload only built dist/ (containerized test jobs will pnpm install without cache)
- name: Upload built frontend - name: Upload built frontend
uses: actions/upload-artifact@v4 uses: actions/upload-artifact@v6
with: with:
name: frontend-dist name: frontend-dist
path: dist/ path: dist/
@@ -37,7 +37,7 @@ jobs:
runs-on: ubuntu-latest runs-on: ubuntu-latest
timeout-minutes: 60 timeout-minutes: 60
container: container:
image: ghcr.io/comfy-org/comfyui-ci-container:0.0.10 image: ghcr.io/comfy-org/comfyui-ci-container:0.0.12
credentials: credentials:
username: ${{ github.actor }} username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }} password: ${{ secrets.GITHUB_TOKEN }}
@@ -51,9 +51,9 @@ jobs:
shardTotal: [8] shardTotal: [8]
steps: steps:
- name: Checkout repository - name: Checkout repository
uses: actions/checkout@v5 uses: actions/checkout@v6
- name: Download built frontend - name: Download built frontend
uses: actions/download-artifact@v4 uses: actions/download-artifact@v7
with: with:
name: frontend-dist name: frontend-dist
path: dist/ path: dist/
@@ -72,7 +72,7 @@ jobs:
PLAYWRIGHT_BLOB_OUTPUT_DIR: ./blob-report PLAYWRIGHT_BLOB_OUTPUT_DIR: ./blob-report
- name: Upload blob report - name: Upload blob report
uses: actions/upload-artifact@v4 uses: actions/upload-artifact@v6
if: ${{ !cancelled() }} if: ${{ !cancelled() }}
with: with:
name: blob-report-chromium-${{ matrix.shardIndex }} name: blob-report-chromium-${{ matrix.shardIndex }}
@@ -85,7 +85,7 @@ jobs:
needs: setup needs: setup
runs-on: ubuntu-latest runs-on: ubuntu-latest
container: container:
image: ghcr.io/comfy-org/comfyui-ci-container:0.0.10 image: ghcr.io/comfy-org/comfyui-ci-container:0.0.12
credentials: credentials:
username: ${{ github.actor }} username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }} password: ${{ secrets.GITHUB_TOKEN }}
@@ -98,9 +98,9 @@ jobs:
browser: [chromium-2x, chromium-0.5x, mobile-chrome] browser: [chromium-2x, chromium-0.5x, mobile-chrome]
steps: steps:
- name: Checkout repository - name: Checkout repository
uses: actions/checkout@v5 uses: actions/checkout@v6
- name: Download built frontend - name: Download built frontend
uses: actions/download-artifact@v4 uses: actions/download-artifact@v7
with: with:
name: frontend-dist name: frontend-dist
path: dist/ path: dist/
@@ -128,7 +128,7 @@ jobs:
pnpm exec playwright merge-reports --reporter=json ./blob-report pnpm exec playwright merge-reports --reporter=json ./blob-report
- name: Upload Playwright report - name: Upload Playwright report
uses: actions/upload-artifact@v4 uses: actions/upload-artifact@v6
if: always() if: always()
with: with:
name: playwright-report-${{ matrix.browser }} name: playwright-report-${{ matrix.browser }}
@@ -141,16 +141,13 @@ jobs:
runs-on: ubuntu-latest runs-on: ubuntu-latest
if: ${{ !cancelled() }} if: ${{ !cancelled() }}
steps: steps:
- name: Checkout repository
uses: actions/checkout@v5
- name: Install pnpm - name: Install pnpm
uses: pnpm/action-setup@v4 uses: pnpm/action-setup@41ff72655975bd51cab0327fa583b6e92b6d3061 # v4.2.0
with: with:
version: 10 version: 10
- name: Download blob reports - name: Download blob reports
uses: actions/download-artifact@v4 uses: actions/download-artifact@v7
with: with:
path: ./all-blob-reports path: ./all-blob-reports
pattern: blob-report-chromium-* pattern: blob-report-chromium-*
@@ -165,7 +162,7 @@ jobs:
pnpm dlx @playwright/test merge-reports --reporter=json ./all-blob-reports pnpm dlx @playwright/test merge-reports --reporter=json ./all-blob-reports
- name: Upload HTML report - name: Upload HTML report
uses: actions/upload-artifact@v4 uses: actions/upload-artifact@v6
with: with:
name: playwright-report-chromium name: playwright-report-chromium
path: ./playwright-report/ path: ./playwright-report/
@@ -183,7 +180,7 @@ jobs:
pull-requests: write pull-requests: write
steps: steps:
- name: Checkout repository - name: Checkout repository
uses: actions/checkout@v5 uses: actions/checkout@v6
- name: Get start time - name: Get start time
id: start-time id: start-time
@@ -210,10 +207,10 @@ jobs:
contents: read contents: read
steps: steps:
- name: Checkout repository - name: Checkout repository
uses: actions/checkout@v5 uses: actions/checkout@v6
- name: Download all playwright reports - name: Download all playwright reports
uses: actions/download-artifact@v4 uses: actions/download-artifact@v7
with: with:
pattern: playwright-report-* pattern: playwright-report-*
path: reports path: reports

View File

@@ -1,9 +1,9 @@
# Description: Deploys Storybook previews from forked PRs (forks can't access deployment secrets) # Description: Deploys Storybook previews from forked PRs (forks can't access deployment secrets)
name: "CI: Tests Storybook (Deploy for Forks)" name: 'CI: Tests Storybook (Deploy for Forks)'
on: on:
workflow_run: workflow_run:
workflows: ["CI: Tests Storybook"] workflows: ['CI: Tests Storybook']
types: [requested, completed] types: [requested, completed]
env: env:
@@ -31,11 +31,11 @@ jobs:
echo "Is forked: ${{ github.event.workflow_run.head_repository.full_name != github.event.workflow_run.repository.full_name }}" echo "Is forked: ${{ github.event.workflow_run.head_repository.full_name != github.event.workflow_run.repository.full_name }}"
- name: Checkout repository - name: Checkout repository
uses: actions/checkout@v5 uses: actions/checkout@v6
- name: Get PR Number - name: Get PR Number
id: pr id: pr
uses: actions/github-script@v7 uses: actions/github-script@v8
with: with:
script: | script: |
const { data: prs } = await github.rest.pulls.list({ const { data: prs } = await github.rest.pulls.list({
@@ -68,7 +68,7 @@ jobs:
- name: Download and Deploy Storybook - name: Download and Deploy Storybook
if: steps.pr.outputs.result != 'null' && github.event.action == 'completed' && github.event.workflow_run.conclusion == 'success' if: steps.pr.outputs.result != 'null' && github.event.action == 'completed' && github.event.workflow_run.conclusion == 'success'
uses: actions/download-artifact@v4 uses: actions/download-artifact@v7
with: with:
github-token: ${{ secrets.GITHUB_TOKEN }} github-token: ${{ secrets.GITHUB_TOKEN }}
run-id: ${{ github.event.workflow_run.id }} run-id: ${{ github.event.workflow_run.id }}

View File

@@ -1,8 +1,8 @@
# Description: Builds Storybook and runs visual regression testing via Chromatic, deploys previews to Cloudflare Pages # Description: Builds Storybook and runs visual regression testing via Chromatic, deploys previews to Cloudflare Pages
name: "CI: Tests Storybook" name: 'CI: Tests Storybook'
on: on:
workflow_dispatch: # Allow manual triggering workflow_dispatch: # Allow manual triggering
pull_request: pull_request:
jobs: jobs:
@@ -14,7 +14,7 @@ jobs:
pull-requests: write pull-requests: write
steps: steps:
- name: Checkout repository - name: Checkout repository
uses: actions/checkout@v5 uses: actions/checkout@v6
- name: Post starting comment - name: Post starting comment
env: env:
@@ -36,21 +36,10 @@ jobs:
workflow-url: ${{ steps.workflow-url.outputs.url }} workflow-url: ${{ steps.workflow-url.outputs.url }}
steps: steps:
- name: Checkout code - name: Checkout code
uses: actions/checkout@v5 uses: actions/checkout@v6
- name: Install pnpm - name: Setup frontend
uses: pnpm/action-setup@v4 uses: ./.github/actions/setup-frontend
with:
version: 10
- name: Setup Node.js
uses: actions/setup-node@v4
with:
node-version: '20'
cache: 'pnpm'
- name: Install dependencies
run: pnpm install --frozen-lockfile
- name: Build Storybook - name: Build Storybook
run: pnpm build-storybook run: pnpm build-storybook
@@ -69,7 +58,7 @@ jobs:
- name: Upload Storybook build - name: Upload Storybook build
if: success() && github.event.pull_request.head.repo.fork == false if: success() && github.event.pull_request.head.repo.fork == false
uses: actions/upload-artifact@v4 uses: actions/upload-artifact@v6
with: with:
name: storybook-static name: storybook-static
path: storybook-static/ path: storybook-static/
@@ -86,33 +75,22 @@ jobs:
chromatic-storybook-url: ${{ steps.chromatic.outputs.storybookUrl }} chromatic-storybook-url: ${{ steps.chromatic.outputs.storybookUrl }}
steps: steps:
- name: Checkout code - name: Checkout code
uses: actions/checkout@v5 uses: actions/checkout@v6
with: with:
fetch-depth: 0 # Required for Chromatic baseline fetch-depth: 0 # Required for Chromatic baseline
- name: Install pnpm - name: Setup frontend
uses: pnpm/action-setup@v4 uses: ./.github/actions/setup-frontend
with:
version: 10
- name: Setup Node.js
uses: actions/setup-node@v4
with:
node-version: '20'
cache: 'pnpm'
- name: Install dependencies
run: pnpm install --frozen-lockfile
- name: Build Storybook and run Chromatic - name: Build Storybook and run Chromatic
id: chromatic id: chromatic
uses: chromaui/action@latest uses: chromaui/action@07791f8243f4cb2698bf4d00426baf4b2d1cb7e0 # v13.3.5
with: with:
projectToken: ${{ secrets.CHROMATIC_PROJECT_TOKEN }} projectToken: ${{ secrets.CHROMATIC_PROJECT_TOKEN }}
buildScriptName: build-storybook buildScriptName: build-storybook
autoAcceptChanges: 'main' # Auto-accept changes on main branch autoAcceptChanges: 'main' # Auto-accept changes on main branch
exitOnceUploaded: true # Don't wait for UI tests to complete exitOnceUploaded: true # Don't wait for UI tests to complete
onlyChanged: true # Only capture changed stories onlyChanged: true # Only capture changed stories
- name: Set job status - name: Set job status
id: job-status id: job-status
@@ -136,11 +114,11 @@ jobs:
contents: read contents: read
steps: steps:
- name: Checkout repository - name: Checkout repository
uses: actions/checkout@v5 uses: actions/checkout@v6
- name: Download Storybook build - name: Download Storybook build
if: needs.storybook-build.outputs.conclusion == 'success' if: needs.storybook-build.outputs.conclusion == 'success'
uses: actions/download-artifact@v4 uses: actions/download-artifact@v7
with: with:
name: storybook-static name: storybook-static
path: storybook-static path: storybook-static
@@ -170,7 +148,7 @@ jobs:
pull-requests: write pull-requests: write
steps: steps:
- name: Update comment with Chromatic URLs - name: Update comment with Chromatic URLs
uses: actions/github-script@v7 uses: actions/github-script@v8
with: with:
script: | script: |
const buildUrl = '${{ needs.chromatic-deployment.outputs.chromatic-build-url }}'; const buildUrl = '${{ needs.chromatic-deployment.outputs.chromatic-build-url }}';

View File

@@ -1,5 +1,5 @@
# Description: Unit and component testing with Vitest # Description: Unit and component testing with Vitest
name: "CI: Tests Unit" name: 'CI: Tests Unit'
on: on:
push: push:
@@ -16,21 +16,10 @@ jobs:
runs-on: ubuntu-latest runs-on: ubuntu-latest
steps: steps:
- uses: actions/checkout@v5 - uses: actions/checkout@v6
- name: Install pnpm - name: Setup frontend
uses: pnpm/action-setup@v4 uses: ./.github/actions/setup-frontend
with:
version: 10
- name: Use Node.js
uses: actions/setup-node@v4
with:
node-version: "lts/*"
cache: "pnpm"
- name: Install dependencies
run: pnpm install --frozen-lockfile
- name: Run Vitest tests - name: Run Vitest tests
run: pnpm test:unit run: pnpm test:unit

View File

@@ -0,0 +1,21 @@
name: Validate Action SHA Pins
on:
pull_request:
paths:
- '.github/workflows/**'
- '.github/actions/**'
- '.pinact.yaml'
permissions:
contents: read
jobs:
validate-pins:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v6
- uses: suzuki-shunsuke/pinact-action@3d49c6412901042473ffa78becddab1aea46bbea # v1.3.1
with:
skip_push: 'true'

View File

@@ -1,5 +1,5 @@
# Description: Validates YAML syntax and style using yamllint with relaxed rules # Description: Validates YAML syntax and style using yamllint with relaxed rules
name: "CI: YAML Validation" name: 'CI: YAML Validation'
on: on:
push: push:
@@ -17,10 +17,10 @@ jobs:
yaml-lint: yaml-lint:
runs-on: ubuntu-latest runs-on: ubuntu-latest
steps: steps:
- uses: actions/checkout@v5 - uses: actions/checkout@v6
- name: Set up Python - name: Set up Python
uses: actions/setup-python@v5 uses: actions/setup-python@v6
with: with:
python-version: '3.x' python-version: '3.x'

View File

@@ -18,12 +18,12 @@ jobs:
steps: steps:
- name: Checkout merge commit - name: Checkout merge commit
uses: actions/checkout@v5 uses: actions/checkout@v6
with: with:
ref: ${{ github.event.pull_request.merge_commit_sha }} ref: ${{ github.event.pull_request.merge_commit_sha }}
- name: Setup Node.js - name: Setup Node.js
uses: actions/setup-node@v5 uses: actions/setup-node@v6
with: with:
node-version-file: '.nvmrc' node-version-file: '.nvmrc'

View File

@@ -1,5 +1,5 @@
# Description: Generates and updates translations for core ComfyUI components using OpenAI # Description: Generates and updates translations for core ComfyUI components using OpenAI
name: "i18n: Update Core" name: 'i18n: Update Core'
on: on:
# Manual dispatch for urgent translation updates # Manual dispatch for urgent translation updates
@@ -16,7 +16,9 @@ jobs:
runs-on: ubuntu-latest runs-on: ubuntu-latest
steps: steps:
- name: Checkout repository - name: Checkout repository
uses: actions/checkout@v5 uses: actions/checkout@v6
with:
token: ${{ secrets.PR_GH_TOKEN }}
# Setup playwright environment # Setup playwright environment
- name: Setup ComfyUI Frontend - name: Setup ComfyUI Frontend
@@ -41,7 +43,7 @@ jobs:
env: env:
PLAYWRIGHT_TEST_URL: http://localhost:5173 PLAYWRIGHT_TEST_URL: http://localhost:5173
- name: Update translations - name: Update translations
run: pnpm locale run: pnpm locale && pnpm format
env: env:
OPENAI_API_KEY: ${{ secrets.OPENAI_API_KEY }} OPENAI_API_KEY: ${{ secrets.OPENAI_API_KEY }}
- name: Commit updated locales - name: Commit updated locales

View File

@@ -22,7 +22,7 @@ jobs:
runs-on: ubuntu-latest runs-on: ubuntu-latest
steps: steps:
- name: Checkout repository - name: Checkout repository
uses: actions/checkout@v5 uses: actions/checkout@v6
# Setup playwright environment with custom node repository # Setup playwright environment with custom node repository
- name: Setup ComfyUI Server (without launching) - name: Setup ComfyUI Server (without launching)
@@ -36,7 +36,7 @@ jobs:
# Install the custom node repository # Install the custom node repository
- name: Checkout custom node repository - name: Checkout custom node repository
uses: actions/checkout@v5 uses: actions/checkout@v6
with: with:
repository: ${{ inputs.owner }}/${{ inputs.repository }} repository: ${{ inputs.owner }}/${{ inputs.repository }}
path: 'ComfyUI/custom_nodes/${{ inputs.repository }}' path: 'ComfyUI/custom_nodes/${{ inputs.repository }}'
@@ -113,7 +113,7 @@ jobs:
git commit -m "Update locales" git commit -m "Update locales"
- name: Install SSH key For PUSH - name: Install SSH key For PUSH
uses: shimataro/ssh-key-action@d4fffb50872869abe2d9a9098a6d9c5aa7d16be4 uses: shimataro/ssh-key-action@d4fffb50872869abe2d9a9098a6d9c5aa7d16be4 # v2.7.0
with: with:
# PR private key from action server # PR private key from action server
key: ${{ secrets.PR_SSH_PRIVATE_KEY }} key: ${{ secrets.PR_SSH_PRIVATE_KEY }}

View File

@@ -14,7 +14,7 @@ jobs:
runs-on: ubuntu-latest runs-on: ubuntu-latest
steps: steps:
- name: Checkout repository - name: Checkout repository
uses: actions/checkout@v5 uses: actions/checkout@v6
# Setup playwright environment # Setup playwright environment
- name: Setup ComfyUI Server (and start) - name: Setup ComfyUI Server (and start)
uses: ./.github/actions/setup-comfyui-server uses: ./.github/actions/setup-comfyui-server
@@ -40,11 +40,11 @@ jobs:
env: env:
OPENAI_API_KEY: ${{ secrets.OPENAI_API_KEY }} OPENAI_API_KEY: ${{ secrets.OPENAI_API_KEY }}
- name: Create Pull Request - name: Create Pull Request
uses: peter-evans/create-pull-request@271a8d0340265f705b14b6d32b9829c1cb33d45e uses: peter-evans/create-pull-request@c0f553fe549906ede9cf27b5156039d195d2ece0 # v8.1.0
with: with:
token: ${{ secrets.PR_GH_TOKEN }} token: ${{ secrets.PR_GH_TOKEN }}
commit-message: "Update locales for node definitions" commit-message: 'Update locales for node definitions'
title: "Update locales for node definitions" title: 'Update locales for node definitions'
body: | body: |
Automated PR to update locales for node definitions Automated PR to update locales for node definitions

View File

@@ -64,7 +64,7 @@ jobs:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: Checkout repository - name: Checkout repository
uses: actions/checkout@v5 uses: actions/checkout@v6
with: with:
fetch-depth: 0 fetch-depth: 0
@@ -462,7 +462,6 @@ jobs:
fi fi
done < "$FILE" done < "$FILE"
- name: Remove needs-backport label - name: Remove needs-backport label
if: steps.filter-targets.outputs.skip != 'true' && success() if: steps.filter-targets.outputs.skip != 'true' && success()
run: gh pr edit ${{ github.event_name == 'workflow_dispatch' && inputs.pr_number || github.event.pull_request.number }} --remove-label "needs-backport" run: gh pr edit ${{ github.event_name == 'workflow_dispatch' && inputs.pr_number || github.event.pull_request.number }} --remove-label "needs-backport"

View File

@@ -1,5 +1,5 @@
# Description: AI-powered code review triggered by adding the 'claude-review' label to a PR # Description: AI-powered code review triggered by adding the 'claude-review' label to a PR
name: "PR: Claude Review" name: 'PR: Claude Review'
permissions: permissions:
contents: read contents: read
@@ -23,18 +23,18 @@ jobs:
timeout-minutes: 30 timeout-minutes: 30
steps: steps:
- name: Checkout repository - name: Checkout repository
uses: actions/checkout@v5 uses: actions/checkout@v6
with: with:
fetch-depth: 0 fetch-depth: 0
ref: refs/pull/${{ github.event.pull_request.number }}/head ref: refs/pull/${{ github.event.pull_request.number }}/head
- name: Install pnpm - name: Install pnpm
uses: pnpm/action-setup@v4 uses: pnpm/action-setup@41ff72655975bd51cab0327fa583b6e92b6d3061 # v4.2.0
with: with:
version: 10 version: 10
- name: Setup Node.js - name: Setup Node.js
uses: actions/setup-node@v4 uses: actions/setup-node@v6
with: with:
node-version: '20' node-version: '20'
cache: 'pnpm' cache: 'pnpm'
@@ -44,9 +44,9 @@ jobs:
pnpm install -g typescript @vue/compiler-sfc pnpm install -g typescript @vue/compiler-sfc
- name: Run Claude PR Review - name: Run Claude PR Review
uses: anthropics/claude-code-action@v1.0.6 uses: anthropics/claude-code-action@ff34ce0ff04a470bd3fa56c1ef391c8f1c19f8e9 # v1.0.38
with: with:
label_trigger: "claude-review" label_trigger: 'claude-review'
prompt: | prompt: |
Read the file .claude/commands/comprehensive-pr-review.md and follow ALL the instructions exactly. Read the file .claude/commands/comprehensive-pr-review.md and follow ALL the instructions exactly.

View File

@@ -1,4 +1,4 @@
name: "PR: Size Report" name: 'PR: Size Report'
on: on:
workflow_run: workflow_run:
@@ -33,24 +33,13 @@ jobs:
github.event_name == 'workflow_dispatch' github.event_name == 'workflow_dispatch'
) )
steps: steps:
- uses: actions/checkout@v5 - uses: actions/checkout@v6
- name: Install pnpm - name: Setup frontend
uses: pnpm/action-setup@v4.1.0 uses: ./.github/actions/setup-frontend
with:
version: 10
- name: Install Node.js
uses: actions/setup-node@v5
with:
node-version: '24.x'
cache: pnpm
- name: Install dependencies
run: pnpm install
- name: Download size data - name: Download size data
uses: dawidd6/action-download-artifact@v11 uses: dawidd6/action-download-artifact@0bd50d53a6d7fb5cb921e607957e9cc12b4ce392 # v12
with: with:
name: size-data name: size-data
run_id: ${{ github.event_name == 'workflow_dispatch' && inputs.run_id || github.event.workflow_run.id }} run_id: ${{ github.event_name == 'workflow_dispatch' && inputs.run_id || github.event.workflow_run.id }}
@@ -75,7 +64,7 @@ jobs:
fi fi
- name: Download previous size data - name: Download previous size data
uses: dawidd6/action-download-artifact@v11 uses: dawidd6/action-download-artifact@0bd50d53a6d7fb5cb921e607957e9cc12b4ce392 # v12
with: with:
branch: ${{ steps.pr-base.outputs.content }} branch: ${{ steps.pr-base.outputs.content }}
workflow: ci-size-data.yaml workflow: ci-size-data.yaml
@@ -89,12 +78,12 @@ jobs:
- name: Read size report - name: Read size report
id: size-report id: size-report
uses: juliangruber/read-file-action@v1 uses: juliangruber/read-file-action@b549046febe0fe86f8cb4f93c24e284433f9ab58 # v1.1.7
with: with:
path: ./size-report.md path: ./size-report.md
- name: Create or update PR comment - name: Create or update PR comment
uses: actions-cool/maintain-one-comment@v3 uses: actions-cool/maintain-one-comment@4b2dbf086015f892dcb5e8c1106f5fccd6c1476b # v3.2.0
with: with:
token: ${{ secrets.GITHUB_TOKEN }} token: ${{ secrets.GITHUB_TOKEN }}
number: ${{ steps.pr-number.outputs.content }} number: ${{ steps.pr-number.outputs.content }}

View File

@@ -1,5 +1,5 @@
# Setting test expectation screenshots for Playwright # Setting test expectation screenshots for Playwright
name: "PR: Update Playwright Expectations" name: 'PR: Update Playwright Expectations'
on: on:
pull_request: pull_request:
@@ -38,15 +38,15 @@ jobs:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: Find Update Comment - name: Find Update Comment
uses: peter-evans/find-comment@b30e6a3c0ed37e7c023ccd3f1db5c6c0b0c23aad uses: peter-evans/find-comment@b30e6a3c0ed37e7c023ccd3f1db5c6c0b0c23aad # v4.0.0
id: "find-update-comment" id: 'find-update-comment'
with: with:
issue-number: ${{ steps.pr-info.outputs.pr-number }} issue-number: ${{ steps.pr-info.outputs.pr-number }}
comment-author: "github-actions[bot]" comment-author: 'github-actions[bot]'
body-includes: "Updating Playwright Expectations" body-includes: 'Updating Playwright Expectations'
- name: Add Starting Reaction - name: Add Starting Reaction
uses: peter-evans/create-or-update-comment@e8674b075228eee787fea43ef493e45ece1004c9 uses: peter-evans/create-or-update-comment@e8674b075228eee787fea43ef493e45ece1004c9 # v5.0.0
with: with:
comment-id: ${{ steps.find-update-comment.outputs.comment-id }} comment-id: ${{ steps.find-update-comment.outputs.comment-id }}
issue-number: ${{ steps.pr-info.outputs.pr-number }} issue-number: ${{ steps.pr-info.outputs.pr-number }}
@@ -56,7 +56,7 @@ jobs:
reactions: eyes reactions: eyes
- name: Checkout repository - name: Checkout repository
uses: actions/checkout@v5 uses: actions/checkout@v6
with: with:
ref: ${{ steps.pr-info.outputs.branch }} ref: ${{ steps.pr-info.outputs.branch }}
- name: Setup frontend - name: Setup frontend
@@ -66,7 +66,7 @@ jobs:
# Upload built dist/ (containerized test jobs will pnpm install without cache) # Upload built dist/ (containerized test jobs will pnpm install without cache)
- name: Upload built frontend - name: Upload built frontend
uses: actions/upload-artifact@v4 uses: actions/upload-artifact@v6
with: with:
name: frontend-dist name: frontend-dist
path: dist/ path: dist/
@@ -77,7 +77,7 @@ jobs:
needs: setup needs: setup
runs-on: ubuntu-latest runs-on: ubuntu-latest
container: container:
image: ghcr.io/comfy-org/comfyui-ci-container:0.0.10 image: ghcr.io/comfy-org/comfyui-ci-container:0.0.12
credentials: credentials:
username: ${{ github.actor }} username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }} password: ${{ secrets.GITHUB_TOKEN }}
@@ -91,11 +91,11 @@ jobs:
shardTotal: [4] shardTotal: [4]
steps: steps:
- name: Checkout repository - name: Checkout repository
uses: actions/checkout@v5 uses: actions/checkout@v6
with: with:
ref: ${{ needs.setup.outputs.branch }} ref: ${{ needs.setup.outputs.branch }}
- name: Download built frontend - name: Download built frontend
uses: actions/download-artifact@v4 uses: actions/download-artifact@v7
with: with:
name: frontend-dist name: frontend-dist
path: dist/ path: dist/
@@ -109,7 +109,7 @@ jobs:
# Run sharded tests with snapshot updates (browsers pre-installed in container) # Run sharded tests with snapshot updates (browsers pre-installed in container)
- name: Update snapshots (Shard ${{ matrix.shardIndex }}/${{ matrix.shardTotal }}) - name: Update snapshots (Shard ${{ matrix.shardIndex }}/${{ matrix.shardTotal }})
id: playwright-tests id: playwright-tests
run: pnpm exec playwright test --update-snapshots --shard=${{ matrix.shardIndex }}/${{ matrix.shardTotal }} run: pnpm exec playwright test --update-snapshots --grep @screenshot --shard=${{ matrix.shardIndex }}/${{ matrix.shardTotal }}
continue-on-error: true continue-on-error: true
- name: Stage changed snapshot files - name: Stage changed snapshot files
@@ -149,7 +149,7 @@ jobs:
# Upload ONLY the changed files from this shard # Upload ONLY the changed files from this shard
- name: Upload changed snapshots - name: Upload changed snapshots
uses: actions/upload-artifact@v4 uses: actions/upload-artifact@v6
if: steps.changed-snapshots.outputs.has-changes == 'true' if: steps.changed-snapshots.outputs.has-changes == 'true'
with: with:
name: snapshots-shard-${{ matrix.shardIndex }} name: snapshots-shard-${{ matrix.shardIndex }}
@@ -157,7 +157,7 @@ jobs:
retention-days: 1 retention-days: 1
- name: Upload test report - name: Upload test report
uses: actions/upload-artifact@v4 uses: actions/upload-artifact@v6
if: always() if: always()
with: with:
name: playwright-report-shard-${{ matrix.shardIndex }} name: playwright-report-shard-${{ matrix.shardIndex }}
@@ -170,17 +170,18 @@ jobs:
runs-on: ubuntu-latest runs-on: ubuntu-latest
steps: steps:
- name: Checkout repository - name: Checkout repository
uses: actions/checkout@v5 uses: actions/checkout@v6
with: with:
ref: ${{ needs.setup.outputs.branch }} ref: ${{ needs.setup.outputs.branch }}
token: ${{ secrets.PR_GH_TOKEN }}
# Download all changed snapshot files from shards # Download all changed snapshot files from shards
- name: Download snapshot artifacts - name: Download snapshot artifacts
uses: actions/download-artifact@v4 uses: actions/download-artifact@v7
with: with:
pattern: snapshots-shard-* pattern: snapshots-shard-*
path: ./downloaded-snapshots path: ./downloaded-snapshots
merge-multiple: false merge-multiple: true
- name: List downloaded files - name: List downloaded files
run: | run: |
@@ -206,13 +207,13 @@ jobs:
echo "MERGING CHANGED SNAPSHOTS" echo "MERGING CHANGED SNAPSHOTS"
echo "==========================================" echo "=========================================="
# Check if any artifacts were downloaded # Check if any artifacts were downloaded (merge-multiple puts files directly in path)
if [ ! -d "./downloaded-snapshots" ]; then if [ ! -d "./downloaded-snapshots" ]; then
echo "No snapshot artifacts to merge" echo "No snapshot artifacts to merge"
echo "==========================================" echo "=========================================="
echo "MERGE COMPLETE" echo "MERGE COMPLETE"
echo "==========================================" echo "=========================================="
echo "Shards merged: 0" echo "Files merged: 0"
exit 0 exit 0
fi fi
@@ -222,37 +223,29 @@ jobs:
exit 1 exit 1
fi fi
merged_count=0 # Count files to merge
file_count=$(find ./downloaded-snapshots -type f | wc -l)
# For each shard's changed files, copy them directly if [ "$file_count" -eq 0 ]; then
for shard_dir in ./downloaded-snapshots/snapshots-shard-*/; do echo "No snapshot files found in downloaded artifacts"
if [ ! -d "$shard_dir" ]; then echo "=========================================="
continue echo "MERGE COMPLETE"
fi echo "=========================================="
echo "Files merged: 0"
exit 0
fi
shard_name=$(basename "$shard_dir") echo "Merging $file_count snapshot file(s)..."
file_count=$(find "$shard_dir" -type f | wc -l)
if [ "$file_count" -eq 0 ]; then # Copy all files directly, preserving directory structure
echo " $shard_name: no files" # With merge-multiple: true, files are directly in ./downloaded-snapshots/ without shard subdirs
continue cp -v -r ./downloaded-snapshots/* browser_tests/ 2>&1 | sed 's/^/ /'
fi
echo "Processing $shard_name ($file_count file(s))..."
# Copy files directly, preserving directory structure
# Since files are already in correct structure (no browser_tests/ prefix), just copy them all
cp -v -r "$shard_dir"* browser_tests/ 2>&1 | sed 's/^/ /'
merged_count=$((merged_count + 1))
echo " ✓ Merged"
echo ""
done
echo ""
echo "==========================================" echo "=========================================="
echo "MERGE COMPLETE" echo "MERGE COMPLETE"
echo "==========================================" echo "=========================================="
echo "Shards merged: $merged_count" echo "Files merged: $file_count"
- name: Show changes - name: Show changes
run: | run: |
@@ -301,7 +294,7 @@ jobs:
echo "✓ Commit and push successful" echo "✓ Commit and push successful"
- name: Add Done Reaction - name: Add Done Reaction
uses: peter-evans/create-or-update-comment@e8674b075228eee787fea43ef493e45ece1004c9 uses: peter-evans/create-or-update-comment@e8674b075228eee787fea43ef493e45ece1004c9 # v5.0.0
if: github.event_name == 'issue_comment' && steps.commit.outputs.has-changes == 'true' if: github.event_name == 'issue_comment' && steps.commit.outputs.has-changes == 'true'
with: with:
comment-id: ${{ needs.setup.outputs.comment-id }} comment-id: ${{ needs.setup.outputs.comment-id }}

View File

@@ -20,13 +20,13 @@ jobs:
dist_tag: ${{ steps.dist.outputs.dist_tag }} dist_tag: ${{ steps.dist.outputs.dist_tag }}
steps: steps:
- name: Checkout code - name: Checkout code
uses: actions/checkout@v5 uses: actions/checkout@v6
with: with:
ref: ${{ github.event.pull_request.merge_commit_sha }} ref: ${{ github.event.pull_request.merge_commit_sha }}
persist-credentials: false persist-credentials: false
- name: Setup Node.js - name: Setup Node.js
uses: actions/setup-node@v5 uses: actions/setup-node@v6
with: with:
node-version: '24.x' node-version: '24.x'
@@ -71,7 +71,7 @@ jobs:
pull-requests: write pull-requests: write
steps: steps:
- name: Checkout merge commit - name: Checkout merge commit
uses: actions/checkout@v5 uses: actions/checkout@v6
with: with:
ref: ${{ github.event.pull_request.merge_commit_sha }} ref: ${{ github.event.pull_request.merge_commit_sha }}
fetch-depth: 2 fetch-depth: 2

View File

@@ -77,19 +77,19 @@ jobs:
fi fi
- name: Checkout repository - name: Checkout repository
uses: actions/checkout@v5 uses: actions/checkout@v6
with: with:
ref: ${{ steps.resolve_ref.outputs.ref }} ref: ${{ steps.resolve_ref.outputs.ref }}
fetch-depth: 1 fetch-depth: 1
persist-credentials: false persist-credentials: false
- name: Install pnpm - name: Install pnpm
uses: pnpm/action-setup@v4 uses: pnpm/action-setup@41ff72655975bd51cab0327fa583b6e92b6d3061 # v4.2.0
with: with:
version: 10 version: 10
- name: Setup Node.js - name: Setup Node.js
uses: actions/setup-node@v5 uses: actions/setup-node@v6
with: with:
node-version: '24.x' node-version: '24.x'
cache: 'pnpm' cache: 'pnpm'

View File

@@ -1,5 +1,5 @@
# Automated bi-weekly workflow to bump ComfyUI frontend RC releases # Automated bi-weekly workflow to bump ComfyUI frontend RC releases
name: "Release: Bi-weekly ComfyUI" name: 'Release: Bi-weekly ComfyUI'
on: on:
# Schedule for Monday at 12:00 PM PST (20:00 UTC) # Schedule for Monday at 12:00 PM PST (20:00 UTC)
@@ -61,13 +61,13 @@ jobs:
steps: steps:
- name: Checkout ComfyUI_frontend - name: Checkout ComfyUI_frontend
uses: actions/checkout@v5 uses: actions/checkout@v6
with: with:
fetch-depth: 0 fetch-depth: 0
path: frontend path: frontend
- name: Checkout ComfyUI (sparse) - name: Checkout ComfyUI (sparse)
uses: actions/checkout@v5 uses: actions/checkout@v6
with: with:
repository: Comfy-Org/ComfyUI repository: Comfy-Org/ComfyUI
sparse-checkout: | sparse-checkout: |
@@ -75,12 +75,12 @@ jobs:
path: comfyui path: comfyui
- name: Install pnpm - name: Install pnpm
uses: pnpm/action-setup@v4 uses: pnpm/action-setup@41ff72655975bd51cab0327fa583b6e92b6d3061 # v4.2.0
with: with:
version: 10 version: 10
- name: Setup Node.js - name: Setup Node.js
uses: actions/setup-node@v4 uses: actions/setup-node@v6
with: with:
node-version: lts/* node-version: lts/*
@@ -169,7 +169,7 @@ jobs:
steps: steps:
- name: Checkout ComfyUI fork - name: Checkout ComfyUI fork
uses: actions/checkout@v5 uses: actions/checkout@v6
with: with:
repository: ${{ inputs.comfyui_fork || 'Comfy-Org/ComfyUI' }} repository: ${{ inputs.comfyui_fork || 'Comfy-Org/ComfyUI' }}
token: ${{ secrets.PR_GH_TOKEN }} token: ${{ secrets.PR_GH_TOKEN }}

View File

@@ -18,13 +18,13 @@ jobs:
steps: steps:
- name: Checkout repository - name: Checkout repository
uses: actions/checkout@v5 uses: actions/checkout@v6
with: with:
fetch-depth: 0 fetch-depth: 0
token: ${{ secrets.PR_GH_TOKEN || secrets.GITHUB_TOKEN }} token: ${{ secrets.PR_GH_TOKEN || secrets.GITHUB_TOKEN }}
- name: Setup Node.js - name: Setup Node.js
uses: actions/setup-node@v4 uses: actions/setup-node@v6
with: with:
node-version: 'lts/*' node-version: 'lts/*'

View File

@@ -19,12 +19,12 @@ jobs:
is_prerelease: ${{ steps.check_prerelease.outputs.is_prerelease }} is_prerelease: ${{ steps.check_prerelease.outputs.is_prerelease }}
steps: steps:
- name: Checkout code - name: Checkout code
uses: actions/checkout@v5 uses: actions/checkout@v6
- name: Install pnpm - name: Install pnpm
uses: pnpm/action-setup@v4 uses: pnpm/action-setup@41ff72655975bd51cab0327fa583b6e92b6d3061 # v4.2.0
with: with:
version: 10 version: 10
- uses: actions/setup-node@v4 - uses: actions/setup-node@v6
with: with:
node-version: 'lts/*' node-version: 'lts/*'
cache: 'pnpm' cache: 'pnpm'
@@ -50,12 +50,13 @@ jobs:
ALGOLIA_API_KEY: ${{ secrets.ALGOLIA_API_KEY }} ALGOLIA_API_KEY: ${{ secrets.ALGOLIA_API_KEY }}
ENABLE_MINIFY: 'true' ENABLE_MINIFY: 'true'
USE_PROD_CONFIG: 'true' USE_PROD_CONFIG: 'true'
IS_NIGHTLY: ${{ case(github.ref == 'refs/heads/main', 'true', 'false') }}
run: | run: |
pnpm install --frozen-lockfile pnpm install --frozen-lockfile
pnpm build pnpm build
pnpm zipdist pnpm zipdist
- name: Upload dist artifact - name: Upload dist artifact
uses: actions/upload-artifact@v4 uses: actions/upload-artifact@v6
with: with:
name: dist-files name: dist-files
path: | path: |
@@ -66,16 +67,13 @@ jobs:
needs: build needs: build
runs-on: ubuntu-latest runs-on: ubuntu-latest
steps: steps:
- name: Checkout code
uses: actions/checkout@v5
- name: Download dist artifact - name: Download dist artifact
uses: actions/download-artifact@v4 uses: actions/download-artifact@v7
with: with:
name: dist-files name: dist-files
- name: Create release - name: Create release
id: create_release id: create_release
uses: >- uses: softprops/action-gh-release@a06a81a03ee405af7f2048a818ed3f03bbf83c7b # v2.5.0
softprops/action-gh-release@da05d552573ad5aba039eaac05058a918a7bf631
env: env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with: with:
@@ -98,13 +96,13 @@ jobs:
runs-on: ubuntu-latest runs-on: ubuntu-latest
steps: steps:
- name: Checkout code - name: Checkout code
uses: actions/checkout@v5 uses: actions/checkout@v6
- name: Download dist artifact - name: Download dist artifact
uses: actions/download-artifact@v4 uses: actions/download-artifact@v7
with: with:
name: dist-files name: dist-files
- name: Set up Python - name: Set up Python
uses: actions/setup-python@v4 uses: actions/setup-python@v6
with: with:
python-version: '3.x' python-version: '3.x'
- name: Install build dependencies - name: Install build dependencies
@@ -119,8 +117,7 @@ jobs:
env: env:
COMFYUI_FRONTEND_VERSION: ${{ needs.build.outputs.version }} COMFYUI_FRONTEND_VERSION: ${{ needs.build.outputs.version }}
- name: Publish pypi package - name: Publish pypi package
uses: >- uses: pypa/gh-action-pypi-publish@ed0c53931b1dc9bd32cbe73a98c7f6766f8a527e # v1.13.0
pypa/gh-action-pypi-publish@76f52bc884231f62b9a034ebfe128415bbaabdfc
with: with:
password: ${{ secrets.PYPI_TOKEN }} password: ${{ secrets.PYPI_TOKEN }}
packages-dir: comfyui_frontend_package/dist packages-dir: comfyui_frontend_package/dist
@@ -147,7 +144,7 @@ jobs:
pull-requests: write pull-requests: write
steps: steps:
- name: Checkout merge commit - name: Checkout merge commit
uses: actions/checkout@v5 uses: actions/checkout@v6
with: with:
ref: ${{ github.event.pull_request.merge_commit_sha }} ref: ${{ github.event.pull_request.merge_commit_sha }}
fetch-depth: 2 fetch-depth: 2

View File

@@ -69,18 +69,18 @@ jobs:
fi fi
- name: Checkout repository - name: Checkout repository
uses: actions/checkout@v5 uses: actions/checkout@v6
with: with:
ref: ${{ steps.resolve_ref.outputs.ref }} ref: ${{ steps.resolve_ref.outputs.ref }}
fetch-depth: 1 fetch-depth: 1
- name: Install pnpm - name: Install pnpm
uses: pnpm/action-setup@v4 uses: pnpm/action-setup@41ff72655975bd51cab0327fa583b6e92b6d3061 # v4.2.0
with: with:
version: 10 version: 10
- name: Setup Node.js - name: Setup Node.js
uses: actions/setup-node@v5 uses: actions/setup-node@v6
with: with:
node-version: 'lts/*' node-version: 'lts/*'
cache: 'pnpm' cache: 'pnpm'

View File

@@ -15,12 +15,12 @@ jobs:
version: ${{ steps.current_version.outputs.version }} version: ${{ steps.current_version.outputs.version }}
steps: steps:
- name: Checkout code - name: Checkout code
uses: actions/checkout@v5 uses: actions/checkout@v6
- name: Install pnpm - name: Install pnpm
uses: pnpm/action-setup@v4 uses: pnpm/action-setup@41ff72655975bd51cab0327fa583b6e92b6d3061 # v4.2.0
with: with:
version: 10 version: 10
- uses: actions/setup-node@v4 - uses: actions/setup-node@v6
with: with:
node-version: 'lts/*' node-version: 'lts/*'
cache: 'pnpm' cache: 'pnpm'
@@ -40,7 +40,7 @@ jobs:
pnpm build pnpm build
pnpm zipdist pnpm zipdist
- name: Upload dist artifact - name: Upload dist artifact
uses: actions/upload-artifact@v4 uses: actions/upload-artifact@v6
with: with:
name: dist-files name: dist-files
path: | path: |
@@ -52,13 +52,13 @@ jobs:
runs-on: ubuntu-latest runs-on: ubuntu-latest
steps: steps:
- name: Checkout code - name: Checkout code
uses: actions/checkout@v5 uses: actions/checkout@v6
- name: Download dist artifact - name: Download dist artifact
uses: actions/download-artifact@v4 uses: actions/download-artifact@v7
with: with:
name: dist-files name: dist-files
- name: Set up Python - name: Set up Python
uses: actions/setup-python@v4 uses: actions/setup-python@v6
with: with:
python-version: '3.x' python-version: '3.x'
- name: Install build dependencies - name: Install build dependencies
@@ -73,7 +73,7 @@ jobs:
env: env:
COMFYUI_FRONTEND_VERSION: ${{ format('{0}.dev{1}', needs.build.outputs.version, inputs.devVersion) }} COMFYUI_FRONTEND_VERSION: ${{ format('{0}.dev{1}', needs.build.outputs.version, inputs.devVersion) }}
- name: Publish pypi package - name: Publish pypi package
uses: pypa/gh-action-pypi-publish@76f52bc884231f62b9a034ebfe128415bbaabdfc uses: pypa/gh-action-pypi-publish@ed0c53931b1dc9bd32cbe73a98c7f6766f8a527e # v1.13.0
with: with:
password: ${{ secrets.PYPI_TOKEN }} password: ${{ secrets.PYPI_TOKEN }}
packages-dir: comfyui_frontend_package/dist packages-dir: comfyui_frontend_package/dist

View File

@@ -1,5 +1,5 @@
# Description: Manual workflow to increment package version with semantic versioning support # Description: Manual workflow to increment package version with semantic versioning support
name: "Release: Version Bump" name: 'Release: Version Bump'
on: on:
workflow_dispatch: workflow_dispatch:
@@ -65,7 +65,7 @@ jobs:
- name: Close stale nightly version bump PRs - name: Close stale nightly version bump PRs
if: github.event_name == 'schedule' if: github.event_name == 'schedule'
uses: actions/github-script@v7 uses: actions/github-script@v8
with: with:
github-token: ${{ github.token }} github-token: ${{ github.token }}
script: | script: |
@@ -118,7 +118,7 @@ jobs:
core.info(`Closed ${closed.length} stale PR(s).`) core.info(`Closed ${closed.length} stale PR(s).`)
- name: Checkout repository - name: Checkout repository
uses: actions/checkout@v5 uses: actions/checkout@v6
with: with:
ref: ${{ steps.prepared-inputs.outputs.branch }} ref: ${{ steps.prepared-inputs.outputs.branch }}
fetch-depth: 0 fetch-depth: 0
@@ -142,12 +142,12 @@ jobs:
echo "✅ Branch '$BRANCH' exists" echo "✅ Branch '$BRANCH' exists"
- name: Install pnpm - name: Install pnpm
uses: pnpm/action-setup@41ff72655975bd51cab0327fa583b6e92b6d3061 uses: pnpm/action-setup@41ff72655975bd51cab0327fa583b6e92b6d3061 # v4.2.0
with: with:
version: 10 version: 10
- name: Setup Node.js - name: Setup Node.js
uses: actions/setup-node@v4 uses: actions/setup-node@v6
with: with:
node-version: lts/* node-version: lts/*
@@ -180,7 +180,7 @@ jobs:
echo "capitalised=${CAPITALISED_TYPE@u}" >> "$GITHUB_OUTPUT" echo "capitalised=${CAPITALISED_TYPE@u}" >> "$GITHUB_OUTPUT"
- name: Create Pull Request - name: Create Pull Request
uses: peter-evans/create-pull-request@271a8d0340265f705b14b6d32b9829c1cb33d45e uses: peter-evans/create-pull-request@c0f553fe549906ede9cf27b5156039d195d2ece0 # v8.1.0
with: with:
token: ${{ secrets.PR_GH_TOKEN }} token: ${{ secrets.PR_GH_TOKEN }}
commit-message: '[release] Increment version to ${{ steps.bump-version.outputs.NEW_VERSION }}' commit-message: '[release] Increment version to ${{ steps.bump-version.outputs.NEW_VERSION }}'

View File

@@ -29,7 +29,7 @@ jobs:
steps: steps:
- name: Checkout repository - name: Checkout repository
uses: actions/checkout@v5 uses: actions/checkout@v6
with: with:
ref: ${{ github.event.inputs.branch }} ref: ${{ github.event.inputs.branch }}
fetch-depth: 0 fetch-depth: 0
@@ -51,12 +51,12 @@ jobs:
echo "✅ Branch '$BRANCH' exists" echo "✅ Branch '$BRANCH' exists"
- name: Install pnpm - name: Install pnpm
uses: pnpm/action-setup@v4 uses: pnpm/action-setup@41ff72655975bd51cab0327fa583b6e92b6d3061 # v4.2.0
with: with:
version: 10 version: 10
- name: Setup Node.js - name: Setup Node.js
uses: actions/setup-node@v5 uses: actions/setup-node@v6
with: with:
node-version: '24.x' node-version: '24.x'
cache: 'pnpm' cache: 'pnpm'
@@ -79,7 +79,7 @@ jobs:
echo "capitalised=${VERSION_TYPE@u}" >> $GITHUB_OUTPUT echo "capitalised=${VERSION_TYPE@u}" >> $GITHUB_OUTPUT
- name: Create Pull Request - name: Create Pull Request
uses: peter-evans/create-pull-request@271a8d0340265f705b14b6d32b9829c1cb33d45e uses: peter-evans/create-pull-request@c0f553fe549906ede9cf27b5156039d195d2ece0 # v8.1.0
with: with:
token: ${{ secrets.PR_GH_TOKEN }} token: ${{ secrets.PR_GH_TOKEN }}
commit-message: '[release] Increment desktop-ui to ${{ steps.bump-version.outputs.NEW_VERSION }}' commit-message: '[release] Increment desktop-ui to ${{ steps.bump-version.outputs.NEW_VERSION }}'

View File

@@ -1,5 +1,5 @@
# Description: Automated weekly documentation accuracy check and update via Claude # Description: Automated weekly documentation accuracy check and update via Claude
name: "Weekly Documentation Check" name: 'Weekly Documentation Check'
permissions: permissions:
contents: write contents: write
@@ -22,18 +22,18 @@ jobs:
timeout-minutes: 45 timeout-minutes: 45
steps: steps:
- name: Checkout repository - name: Checkout repository
uses: actions/checkout@v5 uses: actions/checkout@v6
with: with:
fetch-depth: 0 fetch-depth: 50
ref: main ref: main
- name: Install pnpm - name: Install pnpm
uses: pnpm/action-setup@v4 uses: pnpm/action-setup@41ff72655975bd51cab0327fa583b6e92b6d3061 # v4.2.0
with: with:
version: 10 version: 10
- name: Setup Node.js - name: Setup Node.js
uses: actions/setup-node@v4 uses: actions/setup-node@v6
with: with:
node-version: '20' node-version: '20'
cache: 'pnpm' cache: 'pnpm'
@@ -49,7 +49,7 @@ jobs:
fi fi
- name: Run Claude Documentation Review - name: Run Claude Documentation Review
uses: anthropics/claude-code-action@v1.0.6 uses: anthropics/claude-code-action@ff34ce0ff04a470bd3fa56c1ef391c8f1c19f8e9 # v1.0.38
with: with:
prompt: | prompt: |
Is all documentation still 100% accurate? Is all documentation still 100% accurate?
@@ -130,7 +130,7 @@ jobs:
- name: Create or Update Pull Request - name: Create or Update Pull Request
if: steps.check_changes.outputs.has_changes == 'true' if: steps.check_changes.outputs.has_changes == 'true'
uses: peter-evans/create-pull-request@v7 uses: peter-evans/create-pull-request@c0f553fe549906ede9cf27b5156039d195d2ece0 # v8.1.0
with: with:
token: ${{ secrets.PR_GH_TOKEN }} token: ${{ secrets.PR_GH_TOKEN }}
commit-message: 'docs: weekly documentation accuracy update' commit-message: 'docs: weekly documentation accuracy update'

2
.gitignore vendored
View File

@@ -96,3 +96,5 @@ vitest.config.*.timestamp*
# Weekly docs check output # Weekly docs check output
/output.txt /output.txt
.amp

View File

@@ -7,14 +7,8 @@
"printWidth": 80, "printWidth": 80,
"ignorePatterns": [ "ignorePatterns": [
"packages/registry-types/src/comfyRegistryTypes.ts", "packages/registry-types/src/comfyRegistryTypes.ts",
"public/materialdesignicons.min.css",
"src/types/generatedManagerTypes.ts", "src/types/generatedManagerTypes.ts",
"**/*.md", "**/__fixtures__/**/*.json"
"**/*.json",
"**/*.css",
"**/*.yaml",
"**/*.yml",
"**/*.html",
"**/*.svg",
"**/*.xml"
] ]
} }

View File

@@ -31,10 +31,7 @@
"no-console": [ "no-console": [
"error", "error",
{ {
"allow": [ "allow": ["warn", "error"]
"warn",
"error"
]
} }
], ],
"no-control-regex": "off", "no-control-regex": "off",
@@ -63,16 +60,6 @@
{ {
"name": "primevue/sidebar", "name": "primevue/sidebar",
"message": "Sidebar is deprecated in PrimeVue 4+. Use Drawer instead: import Drawer from 'primevue/drawer'" "message": "Sidebar is deprecated in PrimeVue 4+. Use Drawer instead: import Drawer from 'primevue/drawer'"
},
{
"name": "@/i18n--to-enable",
"importNames": [
"st",
"t",
"te",
"d"
],
"message": "Don't import `@/i18n` directly, prefer `useI18n()`"
} }
] ]
} }
@@ -85,10 +72,7 @@
"import/export": "error", "import/export": "error",
"import/namespace": "error", "import/namespace": "error",
"import/no-duplicates": "error", "import/no-duplicates": "error",
"import/consistent-type-specifier-style": [ "import/consistent-type-specifier-style": ["error", "prefer-top-level"],
"error",
"prefer-top-level"
],
"jest/expect-expect": "off", "jest/expect-expect": "off",
"jest/no-conditional-expect": "off", "jest/no-conditional-expect": "off",
"jest/no-disabled-tests": "off", "jest/no-disabled-tests": "off",
@@ -117,13 +101,21 @@
}, },
"overrides": [ "overrides": [
{ {
"files": [ "files": ["**/*.{stories,test,spec}.ts", "**/*.stories.vue"],
"**/*.{stories,test,spec}.ts",
"**/*.stories.vue"
],
"rules": { "rules": {
"no-console": "allow" "no-console": "allow"
} }
},
{
"files": ["browser_tests/**/*.ts"],
"rules": {
"typescript/no-explicit-any": "error",
"no-async-promise-executor": "error",
"no-control-regex": "error",
"no-useless-rename": "error",
"no-unused-private-class-members": "error",
"unicorn/no-empty-file": "error"
}
} }
] ]
} }

24
.pinact.yaml Normal file
View File

@@ -0,0 +1,24 @@
# pinact configuration
# https://github.com/suzuki-shunsuke/pinact
version: 3
files:
- pattern: .github/workflows/*.yaml
- pattern: .github/actions/**/*.yaml
# Actions that don't need SHA pinning (official GitHub actions are trusted)
ignore_actions:
- name: actions/cache
ref: v5
- name: actions/checkout
ref: v6
- name: actions/setup-node
ref: v6
- name: actions/setup-python
ref: v6
- name: actions/upload-artifact
ref: v6
- name: actions/download-artifact
ref: v7
- name: actions/github-script
ref: v8

View File

@@ -5,6 +5,7 @@ See `@docs/guidance/storybook.md` for story patterns (auto-loaded for `*.stories
## Available Context ## Available Context
Stories have access to: Stories have access to:
- All ComfyUI stores - All ComfyUI stores
- PrimeVue with ComfyUI theming - PrimeVue with ComfyUI theming
- i18n system - i18n system

View File

@@ -1,3 +1,4 @@
<!-- Though standards bloom in open fields so wide, <!-- Though standards bloom in open fields so wide,
Anthropic walks a path of lonely pride. --> Anthropic walks a path of lonely pride. -->
@AGENTS.md @AGENTS.md

View File

@@ -12,16 +12,17 @@ Storybook is a frontend workshop for building UI components and pages in isolati
## Storybook vs Other Testing Tools ## Storybook vs Other Testing Tools
| Tool | Purpose | Use Case | | Tool | Purpose | Use Case |
|------|---------|----------| | ----------------------- | ----------------------------------- | ------------------------------------------------------------ |
| **Storybook** | Component isolation & documentation | Developing, testing, and showcasing individual UI components | | **Storybook** | Component isolation & documentation | Developing, testing, and showcasing individual UI components |
| **Playwright** | End-to-end testing | Full user workflow testing across multiple pages | | **Playwright** | End-to-end testing | Full user workflow testing across multiple pages |
| **Vitest** | Unit testing | Testing business logic, utilities, and component behavior | | **Vitest** | Unit testing | Testing business logic, utilities, and component behavior |
| **Vue Testing Library** | Component testing | Testing component interactions and DOM output | | **Vue Testing Library** | Component testing | Testing component interactions and DOM output |
### When to Use Storybook ### When to Use Storybook
**✅ Use Storybook for:** **✅ Use Storybook for:**
- Developing new UI components in isolation - Developing new UI components in isolation
- Creating component documentation and examples - Creating component documentation and examples
- Testing different component states and props - Testing different component states and props
@@ -30,6 +31,7 @@ Storybook is a frontend workshop for building UI components and pages in isolati
- Building a component library or design system - Building a component library or design system
**❌ Don't use Storybook for:** **❌ Don't use Storybook for:**
- Testing complex user workflows (use Playwright) - Testing complex user workflows (use Playwright)
- Testing business logic (use Vitest) - Testing business logic (use Vitest)
- Integration testing between components (use Vue Testing Library) - Integration testing between components (use Vue Testing Library)
@@ -96,6 +98,7 @@ export const WithVariant: Story = {
## ComfyUI Storybook Guidelines ## ComfyUI Storybook Guidelines
### Scope When to Create Stories ### Scope When to Create Stories
- **PrimeVue components**: - **PrimeVue components**:
No need to create stories. Just refer to the official PrimeVue documentation. No need to create stories. Just refer to the official PrimeVue documentation.
- **Custom shared components (design system components)**: - **Custom shared components (design system components)**:
@@ -104,6 +107,7 @@ export const WithVariant: Story = {
Do not create stories. Only the underlying pure UI components should be included in Storybook. Do not create stories. Only the underlying pure UI components should be included in Storybook.
### Maintenance Philosophy ### Maintenance Philosophy
- Stories are lightweight and generally stable. - Stories are lightweight and generally stable.
Once created, they rarely need updates unless: Once created, they rarely need updates unless:
- The design changes - The design changes
@@ -111,10 +115,12 @@ export const WithVariant: Story = {
- For existing usage patterns, simply copy real code examples into Storybook to create stories. - For existing usage patterns, simply copy real code examples into Storybook to create stories.
### File Placement ### File Placement
- Keep `*.stories.ts` files at the **same level as the component** (similar to test files).
- Keep `*.stories.ts` files at the **same level as the component** (similar to test files).
- This makes it easier to check usage examples without navigating to another directory. - This makes it easier to check usage examples without navigating to another directory.
### Developer/Designer Workflow ### Developer/Designer Workflow
- **UI vs Container**: Separate pure UI components from container components. - **UI vs Container**: Separate pure UI components from container components.
Only UI components should live in Storybook. Only UI components should live in Storybook.
- **Communication Tool**: Storybook is not just about code quality—it enables designers and developers to see: - **Communication Tool**: Storybook is not just about code quality—it enables designers and developers to see:
@@ -126,9 +132,10 @@ export const WithVariant: Story = {
→ Only create a story for the base UI button, not for the wrapper. → Only create a story for the base UI button, not for the wrapper.
### Suggested Workflow ### Suggested Workflow
1. Use PrimeVue docs for standard components
2. Use Storybook for **shared/custom components** that define our design system 1. Use PrimeVue docs for standard components
3. Keep story files alongside components 2. Use Storybook for **shared/custom components** that define our design system
3. Keep story files alongside components
4. When in doubt, focus on components reused across the app or those that need to be showcased to designers 4. When in doubt, focus on components reused across the app or those that need to be showcased to designers
### Best Practices ### Best Practices
@@ -211,13 +218,12 @@ This Storybook setup includes:
## Icon Usage in Storybook ## Icon Usage in Storybook
In this project, only the `<i class="icon-[lucide--folder]" />` syntax from unplugin-icons is supported in Storybook. In this project, only the `<i class="icon-[lucide--folder]" />` syntax from unplugin-icons is supported in Storybook.
**Example:** **Example:**
```vue ```vue
<script setup lang="ts"> <script setup lang="ts"></script>
</script>
<template> <template>
<i class="icon-[lucide--trophy] text-neutral size-4" /> <i class="icon-[lucide--trophy] text-neutral size-4" />
@@ -226,4 +232,3 @@ In this project, only the `<i class="icon-[lucide--folder]" />` syntax from unpl
``` ```
This approach ensures icons render correctly in Storybook and remain consistent with the rest of the app. This approach ensures icons render correctly in Storybook and remain consistent with the rest of the app.

View File

@@ -1,7 +1,9 @@
<style> <style>
body { body {
overflow-y: auto !important; overflow-y: auto !important;
transition: background-color 0.3s ease, color 0.3s ease; transition:
background-color 0.3s ease,
color 0.3s ease;
} }
/* Light theme default - with explicit color to override media queries */ /* Light theme default - with explicit color to override media queries */
@@ -57,8 +59,8 @@
/* Override Storybook's problematic & selector styles */ /* Override Storybook's problematic & selector styles */
/* Reset only the specific properties that Storybook injects */ /* Reset only the specific properties that Storybook injects */
li+li { li + li {
margin: 0; margin: 0;
padding: revert-layer; padding: revert-layer;
} }
</style> </style>

View File

@@ -59,7 +59,7 @@
"function-no-unknown": [ "function-no-unknown": [
true, true,
{ {
"ignoreFunctions": ["theme", "v-bind"] "ignoreFunctions": ["theme", "v-bind", "from-folder", "from-json"]
} }
] ]
}, },

View File

@@ -47,4 +47,4 @@
"status": "obsolete" "status": "obsolete"
} }
] ]
} }

View File

@@ -8,3 +8,6 @@ rules:
line-length: disable line-length: disable
document-start: disable document-start: disable
truthy: disable truthy: disable
comments:
min-spaces-from-content: 1

View File

@@ -1,6 +1,6 @@
# Repository Guidelines # Repository Guidelines
See @docs/guidance/*.md for file-type-specific conventions (auto-loaded by glob). See @docs/guidance/\*.md for file-type-specific conventions (auto-loaded by glob).
## Project Structure & Module Organization ## Project Structure & Module Organization
@@ -21,7 +21,7 @@ See @docs/guidance/*.md for file-type-specific conventions (auto-loaded by glob)
- i18n: `src/i18n.ts`, - i18n: `src/i18n.ts`,
- Entry Point: `src/main.ts`. - Entry Point: `src/main.ts`.
- Tests: - Tests:
- unit/component in `tests-ui/` and `src/**/*.test.ts` - unit/component in `src/**/*.test.ts`
- E2E (Playwright) in `browser_tests/**/*.spec.ts` - E2E (Playwright) in `browser_tests/**/*.spec.ts`
- Public assets: `public/` - Public assets: `public/`
- Build output: `dist/` - Build output: `dist/`
@@ -44,7 +44,7 @@ The project uses **Nx** for build orchestration and task management
- `pnpm build`: Type-check then production build to `dist/` - `pnpm build`: Type-check then production build to `dist/`
- `pnpm preview`: Preview the production build locally - `pnpm preview`: Preview the production build locally
- `pnpm test:unit`: Run Vitest unit tests - `pnpm test:unit`: Run Vitest unit tests
- `pnpm test:browser`: Run Playwright E2E tests (`browser_tests/`) - `pnpm test:browser:local`: Run Playwright E2E tests (`browser_tests/`)
- `pnpm lint` / `pnpm lint:fix`: Lint (ESLint) - `pnpm lint` / `pnpm lint:fix`: Lint (ESLint)
- `pnpm format` / `pnpm format:check`: oxfmt - `pnpm format` / `pnpm format:check`: oxfmt
- `pnpm typecheck`: Vue TSC type checking - `pnpm typecheck`: Vue TSC type checking
@@ -93,7 +93,6 @@ The project uses **Nx** for build orchestration and task management
- composables `useXyz.ts` - composables `useXyz.ts`
- Pinia stores `*Store.ts` - Pinia stores `*Store.ts`
## Commit & Pull Request Guidelines ## Commit & Pull Request Guidelines
- PRs: - PRs:
@@ -131,8 +130,8 @@ The project uses **Nx** for build orchestration and task management
```typescript ```typescript
const { nodes, showTotal = true } = defineProps<{ const { nodes, showTotal = true } = defineProps<{
nodes: ApiNodeCost[] nodes: ApiNodeCost[]
showTotal?: boolean showTotal?: boolean
}>() }>()
``` ```
@@ -178,7 +177,7 @@ The project uses **Nx** for build orchestration and task management
## Testing Guidelines ## Testing Guidelines
See @docs/testing/*.md for detailed patterns. See @docs/testing/\*.md for detailed patterns.
- Frameworks: - Frameworks:
- Vitest (unit/component, happy-dom) - Vitest (unit/component, happy-dom)
@@ -265,7 +264,7 @@ A particular type of complexity is over-engineering, where developers have made
## Repository Navigation ## Repository Navigation
- Check README files in key folders (tests-ui, browser_tests, composables, etc.) - Check README files in key folders (browser_tests, composables, etc.)
- Prefer running single tests for performance - Prefer running single tests for performance
- Use --help for unfamiliar CLI tools - Use --help for unfamiliar CLI tools
@@ -300,6 +299,13 @@ When referencing Comfy-Org repos:
Rules for agent-based coding tasks. Rules for agent-based coding tasks.
### Chrome DevTools MCP
When using `take_snapshot` to inspect dropdowns, listboxes, or other components with dynamic options:
- Use `verbose: true` to see the full accessibility tree including list items
- Non-verbose snapshots often omit nested options in comboboxes/listboxes
### Temporary Files ### Temporary Files
- Put planning documents under `/temp/plans/` - Put planning documents under `/temp/plans/`

View File

@@ -2,57 +2,57 @@
* @Comfy-org/comfy_frontend_devs * @Comfy-org/comfy_frontend_devs
# Desktop/Electron # Desktop/Electron
/apps/desktop-ui/ @benceruleanlu /apps/desktop-ui/ @benceruleanlu @Comfy-org/comfy_frontend_devs
/src/stores/electronDownloadStore.ts @benceruleanlu /src/stores/electronDownloadStore.ts @benceruleanlu @Comfy-org/comfy_frontend_devs
/src/extensions/core/electronAdapter.ts @benceruleanlu /src/extensions/core/electronAdapter.ts @benceruleanlu @Comfy-org/comfy_frontend_devs
/vite.electron.config.mts @benceruleanlu /vite.electron.config.mts @benceruleanlu @Comfy-org/comfy_frontend_devs
# Common UI Components # Common UI Components
/src/components/chip/ @viva-jinyi /src/components/chip/ @viva-jinyi @Comfy-org/comfy_frontend_devs
/src/components/card/ @viva-jinyi /src/components/card/ @viva-jinyi @Comfy-org/comfy_frontend_devs
/src/components/button/ @viva-jinyi /src/components/button/ @viva-jinyi @Comfy-org/comfy_frontend_devs
/src/components/input/ @viva-jinyi /src/components/input/ @viva-jinyi @Comfy-org/comfy_frontend_devs
# Topbar # Topbar
/src/components/topbar/ @pythongosssss /src/components/topbar/ @pythongosssss @Comfy-org/comfy_frontend_devs
# Thumbnail # Thumbnail
/src/renderer/core/thumbnail/ @pythongosssss /src/renderer/core/thumbnail/ @pythongosssss @Comfy-org/comfy_frontend_devs
# Legacy UI # Legacy UI
/scripts/ui/ @pythongosssss /scripts/ui/ @pythongosssss @Comfy-org/comfy_frontend_devs
# Link rendering # Link rendering
/src/renderer/core/canvas/links/ @benceruleanlu /src/renderer/core/canvas/links/ @benceruleanlu @Comfy-org/comfy_frontend_devs
# Partner Nodes # Partner Nodes
/src/composables/node/useNodePricing.ts @jojodecayz @bigcat88 /src/composables/node/useNodePricing.ts @jojodecayz @bigcat88 @Comfy-org/comfy_frontend_devs
# Node help system # Node help system
/src/utils/nodeHelpUtil.ts @benceruleanlu /src/utils/nodeHelpUtil.ts @benceruleanlu @Comfy-org/comfy_frontend_devs
/src/stores/workspace/nodeHelpStore.ts @benceruleanlu /src/stores/workspace/nodeHelpStore.ts @benceruleanlu @Comfy-org/comfy_frontend_devs
/src/services/nodeHelpService.ts @benceruleanlu /src/services/nodeHelpService.ts @benceruleanlu @Comfy-org/comfy_frontend_devs
# Selection toolbox # Selection toolbox
/src/components/graph/selectionToolbox/ @Myestery /src/components/graph/selectionToolbox/ @Myestery @Comfy-org/comfy_frontend_devs
# Minimap # Minimap
/src/renderer/extensions/minimap/ @jtydhr88 @Myestery /src/renderer/extensions/minimap/ @jtydhr88 @Myestery @Comfy-org/comfy_frontend_devs
# Workflow Templates # Workflow Templates
/src/platform/workflow/templates/ @Myestery @christian-byrne @comfyui-wiki /src/platform/workflow/templates/ @Myestery @christian-byrne @comfyui-wiki @Comfy-org/comfy_frontend_devs
/src/components/templates/ @Myestery @christian-byrne @comfyui-wiki /src/components/templates/ @Myestery @christian-byrne @comfyui-wiki @Comfy-org/comfy_frontend_devs
# Mask Editor # Mask Editor
/src/extensions/core/maskeditor.ts @trsommer @brucew4yn3rp /src/extensions/core/maskeditor.ts @trsommer @brucew4yn3rp @Comfy-org/comfy_frontend_devs
/src/extensions/core/maskEditorLayerFilenames.ts @trsommer @brucew4yn3rp /src/extensions/core/maskEditorLayerFilenames.ts @trsommer @brucew4yn3rp @Comfy-org/comfy_frontend_devs
# 3D # 3D
/src/extensions/core/load3d.ts @jtydhr88 /src/extensions/core/load3d.ts @jtydhr88 @Comfy-org/comfy_frontend_devs
/src/components/load3d/ @jtydhr88 /src/components/load3d/ @jtydhr88 @Comfy-org/comfy_frontend_devs
# Manager # Manager
/src/workbench/extensions/manager/ @viva-jinyi @christian-byrne @ltdrdata /src/workbench/extensions/manager/ @viva-jinyi @christian-byrne @ltdrdata @Comfy-org/comfy_frontend_devs
# Translations # Translations
/src/locales/ @Comfy-Org/comfy_maintainer @Comfy-org/comfy_frontend_devs /src/locales/ @Comfy-Org/comfy_maintainer @Comfy-org/comfy_frontend_devs

View File

@@ -24,12 +24,14 @@ Have another idea? Drop into Discord or open an issue, and let's chat!
### Initial Setup ### Initial Setup
1. Clone the repository: 1. Clone the repository:
```bash ```bash
git clone https://github.com/Comfy-Org/ComfyUI_frontend.git git clone https://github.com/Comfy-Org/ComfyUI_frontend.git
cd ComfyUI_frontend cd ComfyUI_frontend
``` ```
2. Install dependencies: 2. Install dependencies:
```bash ```bash
pnpm install pnpm install
``` ```
@@ -83,8 +85,7 @@ Make sure your desktop machine and touch device are on the same network. On your
navigate to `http://<server_ip>:5173` (e.g. `http://192.168.2.20:5173` here), to access the ComfyUI frontend. navigate to `http://<server_ip>:5173` (e.g. `http://192.168.2.20:5173` here), to access the ComfyUI frontend.
> ⚠️ IMPORTANT: > ⚠️ IMPORTANT:
The dev server will NOT load JavaScript extensions from custom nodes. Only core extensions (built into the frontend) will be loaded. This is because the shim system that allows custom node JavaScript to import frontend modules only works in production builds. Python custom nodes still function normally. See [Extension Development Guide](docs/extensions/development.md) for details and workarounds. And See [Extension Overview](docs/extensions/README.md) for extensions overview. > The dev server will NOT load JavaScript extensions from custom nodes. Only core extensions (built into the frontend) will be loaded. This is because the shim system that allows custom node JavaScript to import frontend modules only works in production builds. Python custom nodes still function normally. See [Extension Development Guide](docs/extensions/development.md) for details and workarounds. And See [Extension Overview](docs/extensions/README.md) for extensions overview.
## Development Workflow ## Development Workflow
@@ -109,7 +110,6 @@ When you fix a bug that affects a version in feature freeze, we use an automated
2. Before merging, add these labels to your PR: 2. Before merging, add these labels to your PR:
- `needs-backport` - triggers the automated backport workflow - `needs-backport` - triggers the automated backport workflow
- `core/1.24` - targets the `core/1.24` release candidate branch - `core/1.24` - targets the `core/1.24` release candidate branch
3. Merge your PR normally 3. Merge your PR normally
4. The automated workflow will: 4. The automated workflow will:
- Create a new branch from `core/1.24` - Create a new branch from `core/1.24`
@@ -127,6 +127,7 @@ When you fix a bug that affects a version in feature freeze, we use an automated
#### Handling Conflicts #### Handling Conflicts
If the automated cherry-pick fails due to conflicts, the workflow will comment on your PR with: If the automated cherry-pick fails due to conflicts, the workflow will comment on your PR with:
- The list of conflicting files - The list of conflicting files
- Instructions to manually cherry-pick to the release candidate branch - Instructions to manually cherry-pick to the release candidate branch
@@ -200,7 +201,7 @@ The project supports three types of icons, all with automatic imports (no manual
2. **Iconify Icons** - 200,000+ icons from various libraries: `<i class="icon-[lucide--settings]" />`, `<i class="icon-[mdi--folder]" />` 2. **Iconify Icons** - 200,000+ icons from various libraries: `<i class="icon-[lucide--settings]" />`, `<i class="icon-[mdi--folder]" />`
3. **Custom Icons** - Your own SVG icons: `<i-comfy:workflow />` 3. **Custom Icons** - Your own SVG icons: `<i-comfy:workflow />`
Icons are powered by the unplugin-icons system, which automatically discovers and imports icons as Vue components. Custom icons are stored in `packages/design-system/src/icons/` and processed by `packages/design-system/src/iconCollection.ts` with automatic validation. Icons are powered by the unplugin-icons system, which automatically discovers and imports icons as Vue components. Tailwind CSS icon classes (`icon-[comfy--template]`) are provided by `@iconify/tailwind4`, configured in `packages/design-system/src/css/style.css`. Custom icons are stored in `packages/design-system/src/icons/` and loaded via `from-folder` at build time.
For detailed instructions and code examples, see [packages/design-system/src/icons/README.md](packages/design-system/src/icons/README.md). For detailed instructions and code examples, see [packages/design-system/src/icons/README.md](packages/design-system/src/icons/README.md).
@@ -241,6 +242,7 @@ The original litegraph repository (https://github.com/Comfy-Org/litegraph.js) is
## Questions? ## Questions?
If you have questions about contributing: If you have questions about contributing:
- Check existing issues and discussions - Check existing issues and discussions
- Ask in our [Discord](https://discord.com/invite/comfyorg) - Ask in our [Discord](https://discord.com/invite/comfyorg)
- Open a new issue for clarification - Open a new issue for clarification

189
README.md
View File

@@ -13,7 +13,6 @@
[![][github-downloads-shield]][github-downloads-link] [![][github-downloads-shield]][github-downloads-link]
[![][github-downloads-latest-shield]][github-downloads-link] [![][github-downloads-latest-shield]][github-downloads-link]
[github-release-shield]: https://img.shields.io/github/v/release/Comfy-Org/ComfyUI_frontend?style=flat&sort=semver [github-release-shield]: https://img.shields.io/github/v/release/Comfy-Org/ComfyUI_frontend?style=flat&sort=semver
[github-release-link]: https://github.com/Comfy-Org/ComfyUI_frontend/releases [github-release-link]: https://github.com/Comfy-Org/ComfyUI_frontend/releases
[github-release-date-shield]: https://img.shields.io/github/release-date/Comfy-Org/ComfyUI_frontend?style=flat [github-release-date-shield]: https://img.shields.io/github/release-date/Comfy-Org/ComfyUI_frontend?style=flat
@@ -47,6 +46,7 @@ The project follows a structured release process for each minor version, consist
- Version is finalized and made available to all users - Version is finalized and made available to all users
### Nightly Releases ### Nightly Releases
Nightly releases are published daily at [https://github.com/Comfy-Org/ComfyUI_frontend/releases](https://github.com/Comfy-Org/ComfyUI_frontend/releases). Nightly releases are published daily at [https://github.com/Comfy-Org/ComfyUI_frontend/releases](https://github.com/Comfy-Org/ComfyUI_frontend/releases).
To use the latest nightly release, add the following command line argument to your ComfyUI launch script: To use the latest nightly release, add the following command line argument to your ComfyUI launch script:
@@ -56,16 +56,17 @@ To use the latest nightly release, add the following command line argument to yo
``` ```
## Overlapping Release Cycles ## Overlapping Release Cycles
The development of successive minor versions overlaps. For example, while version 1.1 is in feature freeze, development for version 1.2 begins simultaneously. Each feature has approximately 4 weeks from merge to ComfyUI stable release (2 weeks on main, 2 weeks frozen on RC). The development of successive minor versions overlaps. For example, while version 1.1 is in feature freeze, development for version 1.2 begins simultaneously. Each feature has approximately 4 weeks from merge to ComfyUI stable release (2 weeks on main, 2 weeks frozen on RC).
### Example Release Cycle ### Example Release Cycle
| Week | Date Range | Version 1.1 | Version 1.2 | Version 1.3 | Patch Releases | | Week | Date Range | Version 1.1 | Version 1.2 | Version 1.3 | Patch Releases |
|------|------------|-------------|-------------|-------------|----------------| | ---- | ------------- | -------------- | -------------- | -------------- | ----------------------------------------------- |
| 1-2 | Mar 1-14 | Development | - | - | - | | 1-2 | Mar 1-14 | Development | - | - | - |
| 3-4 | Mar 15-28 | Feature Freeze | Development | - | 1.1.0 through 1.1.13 (daily) | | 3-4 | Mar 15-28 | Feature Freeze | Development | - | 1.1.0 through 1.1.13 (daily) |
| 5-6 | Mar 29-Apr 11 | Released | Feature Freeze | Development | 1.1.14+ (daily)<br>1.2.0 through 1.2.13 (daily) | | 5-6 | Mar 29-Apr 11 | Released | Feature Freeze | Development | 1.1.14+ (daily)<br>1.2.0 through 1.2.13 (daily) |
| 7-8 | Apr 12-25 | - | Released | Feature Freeze | 1.2.14+ (daily)<br>1.3.0 through 1.3.13 (daily) | | 7-8 | Apr 12-25 | - | Released | Feature Freeze | 1.2.14+ (daily)<br>1.3.0 through 1.3.13 (daily) |
## Release Summary ## Release Summary
@@ -74,19 +75,21 @@ The development of successive minor versions overlaps. For example, while versio
<details id='feature-native-translation'> <details id='feature-native-translation'>
<summary>v1.5: Native translation (i18n)</summary> <summary>v1.5: Native translation (i18n)</summary>
ComfyUI now includes built-in translation support, replacing the need for third-party translation extensions. Select your language ComfyUI now includes built-in translation support, replacing the need for third-party translation extensions. Select your language
in `Comfy > Locale > Language` to translate the interface into English, Chinese (Simplified), Russian, Japanese, Korean, or Arabic. This native in `Comfy > Locale > Language` to translate the interface into English, Chinese (Simplified), Russian, Japanese, Korean, or Arabic. This native
implementation offers better performance, reliability, and maintainability compared to previous solutions.<br> implementation offers better performance, reliability, and maintainability compared to previous solutions.<br>
More details available here: https://blog.comfy.org/p/native-localization-support-i18n
More details available here: https://blog.comfy.org/p/native-localization-support-i18n
</details> </details>
<details id='feature-mask-editor'> <details id='feature-mask-editor'>
<summary>v1.4: New mask editor</summary> <summary>v1.4: New mask editor</summary>
https://github.com/Comfy-Org/ComfyUI_frontend/pull/1284 implements a new mask editor. https://github.com/Comfy-Org/ComfyUI_frontend/pull/1284 implements a new mask editor.
![image](https://github.com/user-attachments/assets/f0ea6ee5-00ee-4e5d-a09c-6938e86a1f17)
![image](https://github.com/user-attachments/assets/f0ea6ee5-00ee-4e5d-a09c-6938e86a1f17)
</details> </details>
<details id='feature-integrated-server-terminal'> <details id='feature-integrated-server-terminal'>
@@ -95,18 +98,22 @@ The development of successive minor versions overlaps. For example, while versio
Press Ctrl + ` to toggle integrated terminal. Press Ctrl + ` to toggle integrated terminal.
https://github.com/user-attachments/assets/eddedc6a-07a3-4a83-9475-63b3977f6d94 https://github.com/user-attachments/assets/eddedc6a-07a3-4a83-9475-63b3977f6d94
</details> </details>
<details id='feature-keybinding-customization'> <details id='feature-keybinding-customization'>
<summary>v1.3.7: Keybinding customization</summary> <summary>v1.3.7: Keybinding customization</summary>
## Basic UI ## Basic UI
![image](https://github.com/user-attachments/assets/c84a1609-3880-48e0-a746-011f36beda68) ![image](https://github.com/user-attachments/assets/c84a1609-3880-48e0-a746-011f36beda68)
## Reset button ## Reset button
![image](https://github.com/user-attachments/assets/4d2922da-bb4f-4f90-8017-a8e4a0db07c7) ![image](https://github.com/user-attachments/assets/4d2922da-bb4f-4f90-8017-a8e4a0db07c7)
## Edit Keybinding ## Edit Keybinding
![image](https://github.com/user-attachments/assets/77626b7a-cb46-48f8-9465-e03120aac66a) ![image](https://github.com/user-attachments/assets/77626b7a-cb46-48f8-9465-e03120aac66a)
![image](https://github.com/user-attachments/assets/79131a4e-75c6-4715-bd11-c6aaed887779) ![image](https://github.com/user-attachments/assets/79131a4e-75c6-4715-bd11-c6aaed887779)
@@ -117,27 +124,34 @@ https://github.com/user-attachments/assets/eddedc6a-07a3-4a83-9475-63b3977f6d94
<details id='feature-node-library-sidebar'> <details id='feature-node-library-sidebar'>
<summary>v1.2.4: Node library sidebar tab</summary> <summary>v1.2.4: Node library sidebar tab</summary>
#### Drag & Drop #### Drag & Drop
https://github.com/user-attachments/assets/853e20b7-bc0e-49c9-bbce-a2ba7566f92f https://github.com/user-attachments/assets/853e20b7-bc0e-49c9-bbce-a2ba7566f92f
#### Filter #### Filter
https://github.com/user-attachments/assets/4bbca3ee-318f-4cf0-be32-a5a5541066cf https://github.com/user-attachments/assets/4bbca3ee-318f-4cf0-be32-a5a5541066cf
</details> </details>
<details id='feature-queue-sidebar'> <details id='feature-queue-sidebar'>
<summary>v1.2.0: Queue/History sidebar tab</summary> <summary>v1.2.0: Queue/History sidebar tab</summary>
https://github.com/user-attachments/assets/86e264fe-4d26-4f07-aa9a-83bdd2d02b8f https://github.com/user-attachments/assets/86e264fe-4d26-4f07-aa9a-83bdd2d02b8f
</details> </details>
<details id='feature-node-search'> <details id='feature-node-search'>
<summary>v1.1.0: Node search box</summary> <summary>v1.1.0: Node search box</summary>
#### Fuzzy search & Node preview #### Fuzzy search & Node preview
![image](https://github.com/user-attachments/assets/94733e32-ea4e-4a9c-b321-c1a05db48709)
![image](https://github.com/user-attachments/assets/94733e32-ea4e-4a9c-b321-c1a05db48709)
#### Release link with shift
https://github.com/user-attachments/assets/a1b2b5c3-10d1-4256-b620-345de6858f25
#### Release link with shift
https://github.com/user-attachments/assets/a1b2b5c3-10d1-4256-b620-345de6858f25
</details> </details>
### QoL changes ### QoL changes
@@ -146,12 +160,14 @@ https://github.com/user-attachments/assets/4bbca3ee-318f-4cf0-be32-a5a5541066cf
<summary>v1.3.32: **Litegraph** Nested group</summary> <summary>v1.3.32: **Litegraph** Nested group</summary>
https://github.com/user-attachments/assets/f51adeb1-028e-40af-81e4-0ac13075198a https://github.com/user-attachments/assets/f51adeb1-028e-40af-81e4-0ac13075198a
</details> </details>
<details id='feature-group-selection'> <details id='feature-group-selection'>
<summary>v1.3.24: **Litegraph** Group selection</summary> <summary>v1.3.24: **Litegraph** Group selection</summary>
https://github.com/user-attachments/assets/e6230a94-411e-4fba-90cb-6c694200adaa https://github.com/user-attachments/assets/e6230a94-411e-4fba-90cb-6c694200adaa
</details> </details>
<details id='feature-toggle-link-visibility'> <details id='feature-toggle-link-visibility'>
@@ -227,17 +243,21 @@ https://github.com/user-attachments/assets/c142c43f-2fe9-4030-8196-b3bfd4c6977d
<details id='feature-auto-connect-link'> <details id='feature-auto-connect-link'>
<summary>v1.2.2: **Litegraph** auto connects to correct slot</summary> <summary>v1.2.2: **Litegraph** auto connects to correct slot</summary>
#### Before #### Before
https://github.com/user-attachments/assets/c253f778-82d5-4e6f-aec0-ea2ccf421651
https://github.com/user-attachments/assets/c253f778-82d5-4e6f-aec0-ea2ccf421651
#### After
https://github.com/user-attachments/assets/b6360ac0-f0d2-447c-9daa-8a2e20c0dc1d
#### After
https://github.com/user-attachments/assets/b6360ac0-f0d2-447c-9daa-8a2e20c0dc1d
</details> </details>
<details id='feature-hide-text-overflow'> <details id='feature-hide-text-overflow'>
<summary>v1.1.8: **Litegraph** hides text overflow on widget value</summary> <summary>v1.1.8: **Litegraph** hides text overflow on widget value</summary>
https://github.com/user-attachments/assets/5696a89d-4a47-4fcc-9e8c-71e1264943f2 https://github.com/user-attachments/assets/5696a89d-4a47-4fcc-9e8c-71e1264943f2
</details> </details>
### Developer APIs ### Developer APIs
@@ -283,8 +303,7 @@ window['app'].extensionManager.dialog
```js ```js
// window.alert // window.alert
window['app'].extensionManager.toast window['app'].extensionManager.toast.addAlert('Test Alert')
.addAlert("Test Alert")
``` ```
![image](https://github.com/user-attachments/assets/9b18bdca-76ef-4432-95de-5cd2369684f2) ![image](https://github.com/user-attachments/assets/9b18bdca-76ef-4432-95de-5cd2369684f2)
@@ -383,28 +402,28 @@ app.extensionManager.setting.set('TestSetting', 'Hello, universe!')
<details id='extension-api-commands-keybindings'> <details id='extension-api-commands-keybindings'>
<summary>v1.3.7: Register commands and keybindings</summary> <summary>v1.3.7: Register commands and keybindings</summary>
Extensions can call the following API to register commands and keybindings. Do Extensions can call the following API to register commands and keybindings. Do
note that keybindings defined in core cannot be overwritten, and some keybindings note that keybindings defined in core cannot be overwritten, and some keybindings
are reserved by the browser. are reserved by the browser.
```js ```js
app.registerExtension({ app.registerExtension({
name: 'TestExtension1', name: 'TestExtension1',
commands: [ commands: [
{ {
id: 'TestCommand', id: 'TestCommand',
function: () => { function: () => {
alert('TestCommand') alert('TestCommand')
}
} }
], }
keybindings: [ ],
{ keybindings: [
combo: { key: 'k' }, {
commandId: 'TestCommand' combo: { key: 'k' },
} commandId: 'TestCommand'
] }
}) ]
})
``` ```
</details> </details>
@@ -412,66 +431,69 @@ app.extensionManager.setting.set('TestSetting', 'Hello, universe!')
<details id='extension-api-topbar-menu'> <details id='extension-api-topbar-menu'>
<summary>v1.3.1: Extension API to register custom topbar menu items</summary> <summary>v1.3.1: Extension API to register custom topbar menu items</summary>
Extensions can call the following API to register custom topbar menu items. Extensions can call the following API to register custom topbar menu items.
```js ```js
app.registerExtension({ app.registerExtension({
name: 'TestExtension1', name: 'TestExtension1',
commands: [ commands: [
{ {
id: 'foo-id', id: 'foo-id',
label: 'foo', label: 'foo',
function: () => { function: () => {
alert(1) alert(1)
}
} }
], }
menuCommands: [ ],
{ menuCommands: [
path: ['ext', 'ext2'], {
commands: ['foo-id'] path: ['ext', 'ext2'],
} commands: ['foo-id']
] }
}) ]
})
``` ```
![image](https://github.com/user-attachments/assets/ae7b082f-7ce9-4549-a446-4563567102fe) ![image](https://github.com/user-attachments/assets/ae7b082f-7ce9-4549-a446-4563567102fe)
</details> </details>
<details id='extension-api-toast'> <details id='extension-api-toast'>
<summary>v1.2.27: Extension API to add toast message</summary>i <summary>v1.2.27: Extension API to add toast message</summary>i
Extensions can call the following API to add toast messages. Extensions can call the following API to add toast messages.
```js ```js
app.extensionManager.toast.add({ app.extensionManager.toast.add({
severity: 'info', severity: 'info',
summary: 'Loaded!', summary: 'Loaded!',
detail: 'Extension loaded!', detail: 'Extension loaded!',
life: 3000 life: 3000
}) })
``` ```
Documentation of all supported options can be found here: <https://primevue.org/toast/#api.toast.interfaces.ToastMessageOptions> Documentation of all supported options can be found here: <https://primevue.org/toast/#api.toast.interfaces.ToastMessageOptions>
![image](https://github.com/user-attachments/assets/de02cd7e-cd81-43d1-a0b0-bccef92ff487) ![image](https://github.com/user-attachments/assets/de02cd7e-cd81-43d1-a0b0-bccef92ff487)
</details> </details>
<details id='extension-api-sidebar-tab'> <details id='extension-api-sidebar-tab'>
<summary>v1.2.4: Extension API to register custom sidebar tab</summary> <summary>v1.2.4: Extension API to register custom sidebar tab</summary>
Extensions now can call the following API to register a sidebar tab. Extensions now can call the following API to register a sidebar tab.
```js ```js
app.extensionManager.registerSidebarTab({ app.extensionManager.registerSidebarTab({
id: "search", id: 'search',
icon: "pi pi-search", icon: 'pi pi-search',
title: "search", title: 'search',
tooltip: "search", tooltip: 'search',
type: "custom", type: 'custom',
render: (el) => { render: (el) => {
el.innerHTML = "<div>Custom search tab</div>"; el.innerHTML = '<div>Custom search tab</div>'
}, }
}); })
``` ```
The list of supported icons can be found here: <https://primevue.org/icons/#list> The list of supported icons can be found here: <https://primevue.org/icons/#list>
@@ -479,6 +501,7 @@ The list of supported icons can be found here: <https://primevue.org/icons/#list
We will support custom icons later. We will support custom icons later.
![image](https://github.com/user-attachments/assets/7bff028a-bf91-4cab-bf97-55c243b3f5e0) ![image](https://github.com/user-attachments/assets/7bff028a-bf91-4cab-bf97-55c243b3f5e0)
</details> </details>
<details id='extension-api-selection-toolbox'> <details id='extension-api-selection-toolbox'>
@@ -539,4 +562,4 @@ For comprehensive troubleshooting and technical support, please refer to our off
- **[General Troubleshooting Guide](https://docs.comfy.org/troubleshooting/overview)** - Common issues, performance optimization, and reporting bugs - **[General Troubleshooting Guide](https://docs.comfy.org/troubleshooting/overview)** - Common issues, performance optimization, and reporting bugs
- **[Custom Node Issues](https://docs.comfy.org/troubleshooting/custom-node-issues)** - Debugging custom node problems and conflicts - **[Custom Node Issues](https://docs.comfy.org/troubleshooting/custom-node-issues)** - Debugging custom node problems and conflicts
- **[Desktop Installation Guide](https://docs.comfy.org/installation/desktop/windows)** - Desktop-specific installation and troubleshooting - **[Desktop Installation Guide](https://docs.comfy.org/installation/desktop/windows)** - Desktop-specific installation and troubleshooting

View File

@@ -1 +1 @@
AMD and the AMD Arrow logo are trademarks of Advanced Micro Devices, Inc. AMD and the AMD Arrow logo are trademarks of Advanced Micro Devices, Inc.

View File

@@ -1,9 +1,12 @@
<!DOCTYPE html> <!doctype html>
<html lang="en"> <html lang="en">
<head> <head>
<meta charset="UTF-8" /> <meta charset="UTF-8" />
<title>ComfyUI</title> <title>ComfyUI</title>
<meta name="viewport" content="width=device-width, initial-scale=1.0, user-scalable=no" /> <meta
name="viewport"
content="width=device-width, initial-scale=1.0, user-scalable=no"
/>
</head> </head>
<body> <body>
<div id="desktop-app"></div> <div id="desktop-app"></div>

View File

@@ -2,6 +2,36 @@
"name": "@comfyorg/desktop-ui", "name": "@comfyorg/desktop-ui",
"version": "0.0.6", "version": "0.0.6",
"type": "module", "type": "module",
"scripts": {
"lint": "nx run @comfyorg/desktop-ui:lint",
"typecheck": "nx run @comfyorg/desktop-ui:typecheck",
"storybook": "storybook dev -p 6007",
"build-storybook": "storybook build -o dist/storybook"
},
"dependencies": {
"@comfyorg/comfyui-electron-types": "catalog:",
"@comfyorg/shared-frontend-utils": "workspace:*",
"@primevue/core": "catalog:",
"@primevue/themes": "catalog:",
"@vueuse/core": "catalog:",
"pinia": "catalog:",
"primeicons": "catalog:",
"primevue": "catalog:",
"vue": "catalog:",
"vue-i18n": "catalog:",
"vue-router": "catalog:"
},
"devDependencies": {
"@tailwindcss/vite": "catalog:",
"@vitejs/plugin-vue": "catalog:",
"dotenv": "catalog:",
"unplugin-icons": "catalog:",
"unplugin-vue-components": "catalog:",
"vite": "catalog:",
"vite-plugin-html": "catalog:",
"vite-plugin-vue-devtools": "catalog:",
"vue-tsc": "catalog:"
},
"nx": { "nx": {
"tags": [ "tags": [
"scope:desktop", "scope:desktop",
@@ -85,35 +115,5 @@
} }
} }
} }
},
"scripts": {
"lint": "nx run @comfyorg/desktop-ui:lint",
"typecheck": "nx run @comfyorg/desktop-ui:typecheck",
"storybook": "storybook dev -p 6007",
"build-storybook": "storybook build -o dist/storybook"
},
"dependencies": {
"@comfyorg/comfyui-electron-types": "catalog:",
"@comfyorg/shared-frontend-utils": "workspace:*",
"@primevue/core": "catalog:",
"@primevue/themes": "catalog:",
"@vueuse/core": "catalog:",
"pinia": "catalog:",
"primeicons": "catalog:",
"primevue": "catalog:",
"vue": "catalog:",
"vue-i18n": "catalog:",
"vue-router": "catalog:"
},
"devDependencies": {
"@tailwindcss/vite": "catalog:",
"@vitejs/plugin-vue": "catalog:",
"dotenv": "catalog:",
"unplugin-icons": "catalog:",
"unplugin-vue-components": "catalog:",
"vite": "catalog:",
"vite-plugin-html": "catalog:",
"vite-plugin-vue-devtools": "catalog:",
"vue-tsc": "catalog:"
} }
} }

View File

@@ -1,6 +1,8 @@
// eslint-disable-next-line storybook/no-renderer-packages // eslint-disable-next-line storybook/no-renderer-packages
import type { Meta, StoryObj } from '@storybook/vue3' import type { Meta, StoryObj } from '@storybook/vue3'
import type { ElectronAPI } from '@comfyorg/comfyui-electron-types'
import { nextTick, provide } from 'vue' import { nextTick, provide } from 'vue'
import type { ElectronWindow } from '@/utils/envUtil'
import { createMemoryHistory, createRouter } from 'vue-router' import { createMemoryHistory, createRouter } from 'vue-router'
import InstallView from './InstallView.vue' import InstallView from './InstallView.vue'
@@ -42,16 +44,21 @@ const meta: Meta<typeof InstallView> = {
const router = createMockRouter() const router = createMockRouter()
// Mock electron API // Mock electron API
;(window as any).electronAPI = { ;(window as ElectronWindow).electronAPI = {
getPlatform: () => 'darwin', getPlatform: () => 'darwin',
Config: { Config: {
getDetectedGpu: () => Promise.resolve('mps') getDetectedGpu: () => Promise.resolve('mps')
}, },
Events: { Events: {
trackEvent: (_eventName: string, _data?: any) => {} trackEvent: (
_eventName: string,
_data?: Record<string, unknown>
) => {}
}, },
installComfyUI: (_options: any) => {}, installComfyUI: (
changeTheme: (_theme: any) => {}, _options: Parameters<ElectronAPI['installComfyUI']>[0]
) => {},
changeTheme: (_theme: Parameters<ElectronAPI['changeTheme']>[0]) => {},
getSystemPaths: () => getSystemPaths: () =>
Promise.resolve({ Promise.resolve({
defaultInstallPath: '/Users/username/ComfyUI' defaultInstallPath: '/Users/username/ComfyUI'
@@ -240,8 +247,8 @@ export const DesktopSettings: Story = {
export const WindowsPlatform: Story = { export const WindowsPlatform: Story = {
render: () => { render: () => {
// Override the platform to Windows // Override the platform to Windows
;(window as any).electronAPI.getPlatform = () => 'win32' ;(window as ElectronWindow).electronAPI.getPlatform = () => 'win32'
;(window as any).electronAPI.Config.getDetectedGpu = () => ;(window as ElectronWindow).electronAPI.Config.getDetectedGpu = () =>
Promise.resolve('nvidia') Promise.resolve('nvidia')
return { return {
@@ -259,8 +266,8 @@ export const MacOSPlatform: Story = {
name: 'macOS Platform', name: 'macOS Platform',
render: () => { render: () => {
// Override the platform to macOS // Override the platform to macOS
;(window as any).electronAPI.getPlatform = () => 'darwin' ;(window as ElectronWindow).electronAPI.getPlatform = () => 'darwin'
;(window as any).electronAPI.Config.getDetectedGpu = () => ;(window as ElectronWindow).electronAPI.Config.getDetectedGpu = () =>
Promise.resolve('mps') Promise.resolve('mps')
return { return {
@@ -327,7 +334,7 @@ export const ManualInstall: Story = {
export const ErrorState: Story = { export const ErrorState: Story = {
render: () => { render: () => {
// Override validation to return an error // Override validation to return an error
;(window as any).electronAPI.validateInstallPath = () => ;(window as ElectronWindow).electronAPI.validateInstallPath = () =>
Promise.resolve({ Promise.resolve({
isValid: false, isValid: false,
exists: false, exists: false,
@@ -375,7 +382,7 @@ export const ErrorState: Story = {
export const WarningState: Story = { export const WarningState: Story = {
render: () => { render: () => {
// Override validation to return a warning about non-default drive // Override validation to return a warning about non-default drive
;(window as any).electronAPI.validateInstallPath = () => ;(window as ElectronWindow).electronAPI.validateInstallPath = () =>
Promise.resolve({ Promise.resolve({
isValid: true, isValid: true,
exists: false, exists: false,

View File

@@ -4,5 +4,40 @@ See `@docs/guidance/playwright.md` for Playwright best practices (auto-loaded fo
## Directory Structure ## Directory Structure
- `assets/` - Test data (JSON workflows, fixtures) ```text
- Tests use premade JSON workflows to load desired graph state browser_tests/
├── assets/ - Test data (JSON workflows, images)
├── fixtures/
│ ├── ComfyPage.ts - Main fixture (delegates to helpers)
│ ├── ComfyMouse.ts - Mouse interaction helper
│ ├── VueNodeHelpers.ts - Vue Nodes 2.0 helpers
│ ├── selectors.ts - Centralized TestIds
│ ├── components/ - Page object components
│ │ ├── ContextMenu.ts
│ │ ├── SettingDialog.ts
│ │ ├── SidebarTab.ts
│ │ └── Topbar.ts
│ ├── helpers/ - Focused helper classes
│ │ ├── CanvasHelper.ts
│ │ ├── CommandHelper.ts
│ │ ├── KeyboardHelper.ts
│ │ ├── NodeOperationsHelper.ts
│ │ ├── SettingsHelper.ts
│ │ ├── WorkflowHelper.ts
│ │ └── ...
│ └── utils/ - Utility functions
├── helpers/ - Test-specific utilities
└── tests/ - Test files (*.spec.ts)
```
## After Making Changes
- Run `pnpm typecheck:browser` after modifying TypeScript files in this directory
- Run `pnpm exec eslint browser_tests/path/to/file.ts` to lint specific files
- Run `pnpm exec oxlint browser_tests/path/to/file.ts` to check with oxlint
## Skill Documentation
A Playwright test-writing skill exists at `.claude/skills/writing-playwright-tests/SKILL.md`.
The skill documents **meta-level guidance only** (gotchas, anti-patterns, decision guides). It does **not** duplicate fixture APIs - agents should read the fixture code directly in `browser_tests/fixtures/`.

View File

@@ -1,3 +1,4 @@
<!-- In gardens where the agents freely play, <!-- In gardens where the agents freely play,
One stubborn flower turns the other way. --> One stubborn flower turns the other way. -->
@AGENTS.md @AGENTS.md

View File

@@ -17,9 +17,10 @@ Without this flag, parallel tests will conflict and fail randomly.
### ComfyUI devtools ### ComfyUI devtools
ComfyUI_devtools is included in this repository under `tools/devtools/`. During CI/CD, these files are automatically copied to the `custom_nodes` directory. ComfyUI_devtools is included in this repository under `tools/devtools/`. During CI/CD, these files are automatically copied to the `custom_nodes` directory.
_ComfyUI_devtools adds additional API endpoints and nodes to ComfyUI for browser testing._ ComfyUI_devtools adds additional API endpoints and nodes to ComfyUI for browser testing.
For local development, copy the devtools files to your ComfyUI installation: For local development, copy the devtools files to your ComfyUI installation:
```bash ```bash
cp -r tools/devtools/* /path/to/your/ComfyUI/custom_nodes/ComfyUI_devtools/ cp -r tools/devtools/* /path/to/your/ComfyUI/custom_nodes/ComfyUI_devtools/
``` ```
@@ -119,13 +120,11 @@ export default defineConfig({
Browser tests in this project follow a specific organization pattern: Browser tests in this project follow a specific organization pattern:
- **Fixtures**: Located in `fixtures/` - These provide test setup and utilities - **Fixtures**: Located in `fixtures/` - These provide test setup and utilities
- `ComfyPage.ts` - The main fixture for interacting with ComfyUI - `ComfyPage.ts` - The main fixture for interacting with ComfyUI
- `ComfyMouse.ts` - Utility for mouse interactions with the canvas - `ComfyMouse.ts` - Utility for mouse interactions with the canvas
- Components fixtures in `fixtures/components/` - Page object models for UI components - Components fixtures in `fixtures/components/` - Page object models for UI components
- **Tests**: Located in `tests/` - The actual test specifications - **Tests**: Located in `tests/` - The actual test specifications
- Organized by functionality (e.g., `widget.spec.ts`, `interaction.spec.ts`) - Organized by functionality (e.g., `widget.spec.ts`, `interaction.spec.ts`)
- Snapshot directories (e.g., `widget.spec.ts-snapshots/`) contain reference screenshots - Snapshot directories (e.g., `widget.spec.ts-snapshots/`) contain reference screenshots
@@ -263,7 +262,6 @@ Most common testing needs are already addressed by these helpers, which will mak
``` ```
Available debug methods: Available debug methods:
- `debugAddMarker(position)` - Red circle at position - `debugAddMarker(position)` - Red circle at position
- `debugAttachScreenshot(testInfo, name)` - Attach to test report - `debugAttachScreenshot(testInfo, name)` - Attach to test report
- `debugShowCanvasOverlay()` - Show canvas as overlay - `debugShowCanvasOverlay()` - Show canvas as overlay

View File

@@ -52,7 +52,9 @@
"flags": {}, "flags": {},
"order": 1, "order": 1,
"mode": 0, "mode": 0,
"outputs": [{ "name": "LATENT", "type": "LATENT", "links": [2], "slot_index": 0 }], "outputs": [
{ "name": "LATENT", "type": "LATENT", "links": [2], "slot_index": 0 }
],
"properties": {}, "properties": {},
"widgets_values": [512, 512, 1] "widgets_values": [512, 512, 1]
}, },
@@ -70,7 +72,9 @@
{ "name": "negative", "type": "CONDITIONING", "link": 6 }, { "name": "negative", "type": "CONDITIONING", "link": 6 },
{ "name": "latent_image", "type": "LATENT", "link": 2 } { "name": "latent_image", "type": "LATENT", "link": 2 }
], ],
"outputs": [{ "name": "LATENT", "type": "LATENT", "links": [7], "slot_index": 0 }], "outputs": [
{ "name": "LATENT", "type": "LATENT", "links": [7], "slot_index": 0 }
],
"properties": {}, "properties": {},
"widgets_values": [156680208700286, true, 20, 8, "euler", "normal", 1] "widgets_values": [156680208700286, true, 20, 8, "euler", "normal", 1]
}, },
@@ -86,7 +90,9 @@
{ "name": "samples", "type": "LATENT", "link": 7 }, { "name": "samples", "type": "LATENT", "link": 7 },
{ "name": "vae", "type": "VAE", "link": 8 } { "name": "vae", "type": "VAE", "link": 8 }
], ],
"outputs": [{ "name": "IMAGE", "type": "IMAGE", "links": [9], "slot_index": 0 }], "outputs": [
{ "name": "IMAGE", "type": "IMAGE", "links": [9], "slot_index": 0 }
],
"properties": {} "properties": {}
}, },
{ {

View File

@@ -5,14 +5,8 @@
{ {
"id": 19, "id": 19,
"type": "workflow>two_VAE_decode", "type": "workflow>two_VAE_decode",
"pos": [ "pos": [1368.800048828125, 768.7999877929688],
1368.800048828125, "size": [418.1999816894531, 86],
768.7999877929688
],
"size": [
418.1999816894531,
86
],
"flags": {}, "flags": {},
"order": 0, "order": 0,
"mode": 0, "mode": 0,
@@ -49,10 +43,7 @@
"extra": { "extra": {
"ds": { "ds": {
"scale": 1, "scale": 1,
"offset": [ "offset": [0, 0]
0,
0
]
}, },
"node_versions": {}, "node_versions": {},
"ue_links": [], "ue_links": [],
@@ -62,14 +53,8 @@
{ {
"id": -1, "id": -1,
"type": "VAEDecode", "type": "VAEDecode",
"pos": [ "pos": [1368.800048828125, 768.7999877929688],
1368.800048828125, "size": [210, 46],
768.7999877929688
],
"size": [
210,
46
],
"flags": {}, "flags": {},
"order": 0, "order": 0,
"mode": 0, "mode": 0,
@@ -103,14 +88,8 @@
{ {
"id": -1, "id": -1,
"type": "VAEDecode", "type": "VAEDecode",
"pos": [ "pos": [1368.800048828125, 873.7999877929688],
1368.800048828125, "size": [210, 46],
873.7999877929688
],
"size": [
210,
46
],
"flags": {}, "flags": {},
"order": 1, "order": 1,
"mode": 0, "mode": 0,

View File

@@ -76,11 +76,7 @@
"properties": { "properties": {
"Node name for S&R": "EmptyLatentImage" "Node name for S&R": "EmptyLatentImage"
}, },
"widgets_values": [ "widgets_values": [512, 512, 1],
512,
512,
1
],
"index": 0 "index": 0
}, },
{ {
@@ -121,9 +117,7 @@
"properties": { "properties": {
"Node name for S&R": "CheckpointLoaderSimple" "Node name for S&R": "CheckpointLoaderSimple"
}, },
"widgets_values": [ "widgets_values": ["v1-5-pruned-emaonly.ckpt"],
"v1-5-pruned-emaonly.ckpt"
],
"index": 1 "index": 1
}, },
{ {
@@ -195,9 +189,7 @@
"properties": { "properties": {
"Node name for S&R": "CLIPTextEncode" "Node name for S&R": "CLIPTextEncode"
}, },
"widgets_values": [ "widgets_values": ["text, watermark"],
"text, watermark"
],
"index": 3 "index": 3
}, },
{ {
@@ -320,85 +312,20 @@
], ],
"outputs": [], "outputs": [],
"properties": {}, "properties": {},
"widgets_values": [ "widgets_values": ["ComfyUI"],
"ComfyUI"
],
"index": 6 "index": 6
} }
], ],
"links": [ "links": [
[ [1, 1, 2, 0, 4, "CLIP"],
1, [1, 1, 3, 0, 4, "CLIP"],
1, [1, 0, 4, 0, 4, "MODEL"],
2, [2, 0, 4, 1, 6, "CONDITIONING"],
0, [3, 0, 4, 2, 7, "CONDITIONING"],
4, [0, 0, 4, 3, 5, "LATENT"],
"CLIP" [4, 0, 5, 0, 3, "LATENT"],
], [1, 2, 5, 1, 4, "VAE"],
[ [5, 0, 6, 0, 8, "IMAGE"]
1,
1,
3,
0,
4,
"CLIP"
],
[
1,
0,
4,
0,
4,
"MODEL"
],
[
2,
0,
4,
1,
6,
"CONDITIONING"
],
[
3,
0,
4,
2,
7,
"CONDITIONING"
],
[
0,
0,
4,
3,
5,
"LATENT"
],
[
4,
0,
5,
0,
3,
"LATENT"
],
[
1,
2,
5,
1,
4,
"VAE"
],
[
5,
0,
6,
0,
8,
"IMAGE"
]
], ],
"external": [] "external": []
} }

View File

@@ -235,15 +235,7 @@
"properties": { "properties": {
"Node name for S&R": "KSampler" "Node name for S&R": "KSampler"
}, },
"widgets_values": [ "widgets_values": [0, "randomize", 20, 8, "euler", "normal", 1],
0,
"randomize",
20,
8,
"euler",
"normal",
1
],
"index": 1 "index": 1
} }
], ],

View File

@@ -48,15 +48,7 @@
"properties": { "properties": {
"Node name for S&R": "KSampler" "Node name for S&R": "KSampler"
}, },
"widgets_values": [ "widgets_values": [0, "randomize", 20, 8, "euler", "normal", 1]
0,
"randomize",
20,
8,
"euler",
"normal",
1
]
}, },
{ {
"id": 3, "id": 3,
@@ -104,15 +96,7 @@
"properties": { "properties": {
"Node name for S&R": "KSampler" "Node name for S&R": "KSampler"
}, },
"widgets_values": [ "widgets_values": [0, "randomize", 20, 8, "euler", "normal", 1]
0,
"randomize",
20,
8,
"euler",
"normal",
1
]
}, },
{ {
"id": 1, "id": 1,
@@ -160,15 +144,7 @@
"properties": { "properties": {
"Node name for S&R": "KSampler" "Node name for S&R": "KSampler"
}, },
"widgets_values": [ "widgets_values": [0, "randomize", 20, 8, "euler", "normal", 1]
0,
"randomize",
20,
8,
"euler",
"normal",
1
]
} }
], ],
"links": [], "links": [],
@@ -177,10 +153,7 @@
"id": 0, "id": 0,
"title": "Group", "title": "Group",
"bounding": [ "bounding": [
406.9701232910156, 406.9701232910156, 59.079444885253906, 335, 345.6000061035156
59.079444885253906,
335,
345.6000061035156
], ],
"color": "#3f789e", "color": "#3f789e",
"font_size": 24, "font_size": 24,
@@ -190,10 +163,7 @@
"id": 3, "id": 3,
"title": "Group Parent", "title": "Group Parent",
"bounding": [ "bounding": [
796.9703979492188, 796.9703979492188, 14.796443939208984, 355, 399.20001220703125
14.796443939208984,
355,
399.20001220703125
], ],
"color": "#3f789e", "color": "#3f789e",
"font_size": 24, "font_size": 24,
@@ -203,10 +173,7 @@
"id": 2, "id": 2,
"title": "Group Child", "title": "Group Child",
"bounding": [ "bounding": [
806.9703979492188, 806.9703979492188, 58.39643096923828, 335, 345.6000061035156
58.39643096923828,
335,
345.6000061035156
], ],
"color": "#3f789e", "color": "#3f789e",
"font_size": 24, "font_size": 24,
@@ -217,11 +184,8 @@
"extra": { "extra": {
"ds": { "ds": {
"scale": 1, "scale": 1,
"offset": [ "offset": [0, 0]
0,
0
]
} }
}, },
"version": 0.4 "version": 0.4
} }

View File

@@ -7,14 +7,8 @@
{ {
"id": 17, "id": 17,
"type": "VAEDecode", "type": "VAEDecode",
"pos": [ "pos": [318.8446183157076, 355.3961392345528],
318.8446183157076, "size": [225, 102],
355.3961392345528
],
"size": [
225,
102
],
"flags": {}, "flags": {},
"order": 0, "order": 0,
"mode": 0, "mode": 0,
@@ -49,9 +43,7 @@
"id": 4, "id": 4,
"title": "Outer Group", "title": "Outer Group",
"bounding": [ "bounding": [
-46.25245366331014, -46.25245366331014, -150.82497138023245, 1034.4034361963616,
-150.82497138023245,
1034.4034361963616,
1007.338460439933 1007.338460439933
], ],
"color": "#3f789e", "color": "#3f789e",
@@ -62,9 +54,7 @@
"id": 3, "id": 3,
"title": "Inner Group", "title": "Inner Group",
"bounding": [ "bounding": [
80.96059074101554, 80.96059074101554, 28.123757436778178, 718.286373661183,
28.123757436778178,
718.286373661183,
691.2397164539732 691.2397164539732
], ],
"color": "#3f789e", "color": "#3f789e",
@@ -76,10 +66,7 @@
"extra": { "extra": {
"ds": { "ds": {
"scale": 0.7121393732101533, "scale": 0.7121393732101533,
"offset": [ "offset": [289.18242848011835, 367.0747755524199]
289.18242848011835,
367.0747755524199
]
}, },
"frontendVersion": "1.35.5", "frontendVersion": "1.35.5",
"VHS_latentpreview": false, "VHS_latentpreview": false,
@@ -89,4 +76,4 @@
"workflowRendererVersion": "Vue" "workflowRendererVersion": "Vue"
}, },
"version": 0.4 "version": 0.4
} }

View File

@@ -5,14 +5,8 @@
{ {
"id": 3, "id": 3,
"type": "KSampler", "type": "KSampler",
"pos": [ "pos": [37, 98],
37, "size": [315, 262],
98
],
"size": [
315,
262
],
"flags": {}, "flags": {},
"order": 0, "order": 0,
"mode": 0, "mode": 0,
@@ -65,12 +59,7 @@
{ {
"id": 1, "id": 1,
"title": "Group", "title": "Group",
"bounding": [ "bounding": [23, 23, 900, 825],
23,
23,
900,
825
],
"color": "#3f789e", "color": "#3f789e",
"font_size": 24, "font_size": 24,
"flags": {} "flags": {}
@@ -80,11 +69,8 @@
"extra": { "extra": {
"ds": { "ds": {
"scale": 1, "scale": 1,
"offset": [ "offset": [0, 0]
0,
0
]
} }
}, },
"version": 0.4 "version": 0.4
} }

View File

@@ -64,12 +64,7 @@
"groups": [ "groups": [
{ {
"title": "Group", "title": "Group",
"bounding": [ "bounding": [0, 0, 335, 346],
0,
0,
335,
346
],
"color": "#3f789e", "color": "#3f789e",
"font_size": 24 "font_size": 24
} }
@@ -78,11 +73,8 @@
"extra": { "extra": {
"ds": { "ds": {
"scale": 1, "scale": 1,
"offset": [ "offset": [0, 0]
0,
0
]
} }
}, },
"version": 0.4 "version": 0.4
} }

View File

@@ -6,12 +6,7 @@
"groups": [ "groups": [
{ {
"title": "Group", "title": "Group",
"bounding": [ "bounding": [0, 0, 335, 346],
0,
0,
335,
346
],
"color": "#3f789e", "color": "#3f789e",
"font_size": 24 "font_size": 24
} }
@@ -20,11 +15,8 @@
"extra": { "extra": {
"ds": { "ds": {
"scale": 1.2100000000000006, "scale": 1.2100000000000006,
"offset": [ "offset": [104.34159172650945, 241.35965953210126]
104.34159172650945,
241.35965953210126
]
} }
}, },
"version": 0.4 "version": 0.4
} }

View File

@@ -7,14 +7,8 @@
{ {
"id": 6, "id": 6,
"type": "DevToolsNodeWithDefaultInput", "type": "DevToolsNodeWithDefaultInput",
"pos": [ "pos": [8.39722728729248, 29.727279663085938],
8.39722728729248, "size": [315, 82],
29.727279663085938
],
"size": [
315,
82
],
"flags": {}, "flags": {},
"order": 0, "order": 0,
"mode": 0, "mode": 0,
@@ -30,11 +24,7 @@
"properties": { "properties": {
"Node name for S&R": "DevToolsNodeWithDefaultInput" "Node name for S&R": "DevToolsNodeWithDefaultInput"
}, },
"widgets_values": [ "widgets_values": [0, 1, 0]
0,
1,
0
]
} }
], ],
"links": [], "links": [],
@@ -43,10 +33,7 @@
"extra": { "extra": {
"ds": { "ds": {
"scale": 1, "scale": 1,
"offset": [ "offset": [0, 0]
0,
0
]
} }
}, },
"version": 0.4 "version": 0.4

View File

@@ -5,10 +5,7 @@
{ {
"id": 3, "id": 3,
"type": "KSampler", "type": "KSampler",
"pos": [ "pos": [0, 30],
0,
30
],
"size": { "size": {
"0": 315, "0": 315,
"1": 262 "1": 262
@@ -36,7 +33,7 @@
"name": "latent_image", "name": "latent_image",
"type": "LATENT", "type": "LATENT",
"link": null "link": null
} , },
{ {
"name": "dynamic_input", "name": "dynamic_input",
"type": "FLOAT", "type": "FLOAT",
@@ -72,11 +69,8 @@
"extra": { "extra": {
"ds": { "ds": {
"scale": 1, "scale": 1,
"offset": [ "offset": [0, 0]
0,
0
]
} }
}, },
"version": 0.4 "version": 0.4
} }

View File

@@ -39,11 +39,7 @@
"properties": { "properties": {
"Node name for S&R": "DevToolsNodeWithForceInput" "Node name for S&R": "DevToolsNodeWithForceInput"
}, },
"widgets_values": [ "widgets_values": [0, 1, 0]
0,
1,
0
]
} }
], ],
"links": [], "links": [],
@@ -52,11 +48,8 @@
"extra": { "extra": {
"ds": { "ds": {
"scale": 1, "scale": 1,
"offset": [ "offset": [0, 0]
0,
0
]
} }
}, },
"version": 0.4 "version": 0.4
} }

View File

@@ -9,10 +9,7 @@
"0": 449, "0": 449,
"1": 204 "1": 204
}, },
"size": [ "size": [340.20001220703125, 166],
340.20001220703125,
166
],
"flags": {}, "flags": {},
"order": 1, "order": 1,
"mode": 0, "mode": 0,
@@ -61,11 +58,7 @@
"properties": { "properties": {
"Node name for S&R": "ControlNetApplyAdvanced" "Node name for S&R": "ControlNetApplyAdvanced"
}, },
"widgets_values": [ "widgets_values": [1, 0, 1]
1,
0,
1
]
}, },
{ {
"id": 2, "id": 2,
@@ -74,10 +67,7 @@
"0": 177, "0": 177,
"1": 265 "1": 265
}, },
"size": [ "size": [210, 82],
210,
82
],
"flags": {}, "flags": {},
"order": 0, "order": 0,
"mode": 0, "mode": 0,
@@ -86,9 +76,7 @@
{ {
"name": "FLOAT", "name": "FLOAT",
"type": "FLOAT", "type": "FLOAT",
"links": [ "links": [1],
1
],
"widget": { "widget": {
"name": "strength" "name": "strength"
} }
@@ -97,22 +85,10 @@
"properties": { "properties": {
"Run widget replace on values": false "Run widget replace on values": false
}, },
"widgets_values": [ "widgets_values": [1, "fixed"]
1,
"fixed"
]
} }
], ],
"links": [ "links": [[1, 2, 0, 1, 4, "FLOAT"]],
[
1,
2,
0,
1,
4,
"FLOAT"
]
],
"groups": [], "groups": [],
"config": {}, "config": {},
"extra": { "extra": {
@@ -125,4 +101,4 @@
} }
}, },
"version": 0.4 "version": 0.4
} }

View File

@@ -29,9 +29,7 @@
"properties": { "properties": {
"Node name for S&R": "DevToolsNodeWithOnlyOptionalInput" "Node name for S&R": "DevToolsNodeWithOnlyOptionalInput"
}, },
"widgets_values": [ "widgets_values": [""]
""
]
} }
], ],
"links": [], "links": [],

View File

@@ -47,11 +47,8 @@
"extra": { "extra": {
"ds": { "ds": {
"scale": 1, "scale": 1,
"offset": [ "offset": [0, 0]
0,
0
]
} }
}, },
"version": 0.4 "version": 0.4
} }

View File

@@ -46,11 +46,8 @@
"extra": { "extra": {
"ds": { "ds": {
"scale": 1, "scale": 1,
"offset": [ "offset": [0, 0]
0,
0
]
} }
}, },
"version": 0.4 "version": 0.4
} }

View File

@@ -47,11 +47,8 @@
"extra": { "extra": {
"ds": { "ds": {
"scale": 1, "scale": 1,
"offset": [ "offset": [0, 0]
0,
0
]
} }
}, },
"version": 0.4 "version": 0.4
} }

View File

@@ -5,14 +5,8 @@
{ {
"id": 15, "id": 15,
"type": "DevToolsRemoteWidgetNode", "type": "DevToolsRemoteWidgetNode",
"pos": [ "pos": [495, 735],
495, "size": [315, 58],
735
],
"size": [
315,
58
],
"flags": {}, "flags": {},
"order": 0, "order": 0,
"mode": 0, "mode": 0,
@@ -27,9 +21,7 @@
"properties": { "properties": {
"Node name for S&R": "DevToolsRemoteWidgetNode" "Node name for S&R": "DevToolsRemoteWidgetNode"
}, },
"widgets_values": [ "widgets_values": ["v1-5-pruned-emaonly-fp16.safetensors"]
"v1-5-pruned-emaonly-fp16.safetensors"
]
} }
], ],
"links": [], "links": [],
@@ -38,11 +30,8 @@
"extra": { "extra": {
"ds": { "ds": {
"scale": 0.8008869919566275, "scale": 0.8008869919566275,
"offset": [ "offset": [538.9801226576359, -55.24554581806672]
538.9801226576359,
-55.24554581806672
]
} }
}, },
"version": 0.4 "version": 0.4
} }

View File

@@ -5,14 +5,8 @@
{ {
"id": 3, "id": 3,
"type": "EmptyLatentImage", "type": "EmptyLatentImage",
"pos": [ "pos": [380.51641845703125, 191.39659118652344],
380.51641845703125, "size": [315, 106],
191.39659118652344
],
"size": [
315,
106
],
"flags": {}, "flags": {},
"order": 1, "order": 1,
"mode": 0, "mode": 0,
@@ -36,23 +30,13 @@
"properties": { "properties": {
"Node name for S&R": "EmptyLatentImage" "Node name for S&R": "EmptyLatentImage"
}, },
"widgets_values": [ "widgets_values": [512, 512, 1]
512,
512,
1
]
}, },
{ {
"id": 4, "id": 4,
"type": "PrimitiveNode", "type": "PrimitiveNode",
"pos": [ "pos": [73.6164321899414, 197.9966278076172],
73.6164321899414, "size": [210, 82],
197.9966278076172
],
"size": [
210,
82
],
"flags": {}, "flags": {},
"order": 0, "order": 0,
"mode": 0, "mode": 0,
@@ -64,31 +48,17 @@
"widget": { "widget": {
"name": "bredth" "name": "bredth"
}, },
"links": [ "links": [2]
2
]
} }
], ],
"title": "breadth", "title": "breadth",
"properties": { "properties": {
"Run widget replace on values": false "Run widget replace on values": false
}, },
"widgets_values": [ "widgets_values": [512, "fixed"]
512,
"fixed"
]
} }
], ],
"links": [ "links": [[2, 4, 0, 3, 0, "INT"]],
[
2,
4,
0,
3,
0,
"INT"
]
],
"groups": [], "groups": [],
"config": {}, "config": {},
"extra": { "extra": {

View File

@@ -5,14 +5,8 @@
{ {
"id": 12, "id": 12,
"type": "DevToolsSimpleSlider", "type": "DevToolsSimpleSlider",
"pos": [ "pos": [50, 50],
50, "size": [315, 58],
50
],
"size": [
315,
58
],
"flags": {}, "flags": {},
"order": 0, "order": 0,
"mode": 0, "mode": 0,
@@ -28,9 +22,7 @@
"properties": { "properties": {
"Node name for S&R": "DevToolsSimpleSlider" "Node name for S&R": "DevToolsSimpleSlider"
}, },
"widgets_values": [ "widgets_values": [0.5]
0.5
]
} }
], ],
"links": [], "links": [],
@@ -39,11 +31,8 @@
"extra": { "extra": {
"ds": { "ds": {
"scale": 1, "scale": 1,
"offset": [ "offset": [0, 0]
0,
0
]
} }
}, },
"version": 0.4 "version": 0.4
} }

View File

@@ -5,14 +5,8 @@
{ {
"id": 1, "id": 1,
"type": "DevToolsNodeWithStringInput", "type": "DevToolsNodeWithStringInput",
"pos": [ "pos": [15, 48],
15, "size": [315, 58],
48
],
"size": [
315,
58
],
"flags": {}, "flags": {},
"order": 0, "order": 0,
"mode": 0, "mode": 0,
@@ -21,9 +15,7 @@
"properties": { "properties": {
"Node name for S&R": "DevToolsNodeWithStringInput" "Node name for S&R": "DevToolsNodeWithStringInput"
}, },
"widgets_values": [ "widgets_values": [""]
""
]
} }
], ],
"links": [], "links": [],
@@ -32,11 +24,8 @@
"extra": { "extra": {
"ds": { "ds": {
"scale": 1, "scale": 1,
"offset": [ "offset": [0, 0]
0,
0
]
} }
}, },
"version": 0.4 "version": 0.4
} }

View File

@@ -7,14 +7,8 @@
{ {
"id": 4, "id": 4,
"type": "KSampler", "type": "KSampler",
"pos": [ "pos": [867.4669799804688, 347.22369384765625],
867.4669799804688, "size": [315, 262],
347.22369384765625
],
"size": [
315,
262
],
"flags": {}, "flags": {},
"order": 1, "order": 1,
"mode": 0, "mode": 0,
@@ -58,27 +52,13 @@
"properties": { "properties": {
"Node name for S&R": "KSampler" "Node name for S&R": "KSampler"
}, },
"widgets_values": [ "widgets_values": [0, "randomize", 20, 8, "euler", "normal", 1]
0,
"randomize",
20,
8,
"euler",
"normal",
1
]
}, },
{ {
"id": 5, "id": 5,
"type": "PrimitiveInt", "type": "PrimitiveInt",
"pos": [ "pos": [443.0852355957031, 441.131591796875],
443.0852355957031, "size": [315, 82],
441.131591796875
],
"size": [
315,
82
],
"flags": {}, "flags": {},
"order": 0, "order": 0,
"mode": 0, "mode": 0,
@@ -87,40 +67,23 @@
{ {
"name": "INT", "name": "INT",
"type": "INT", "type": "INT",
"links": [ "links": [3]
3
]
} }
], ],
"properties": { "properties": {
"Node name for S&R": "PrimitiveInt" "Node name for S&R": "PrimitiveInt"
}, },
"widgets_values": [ "widgets_values": [0, "randomize"]
0,
"randomize"
]
} }
], ],
"links": [ "links": [[3, 5, 0, 4, 5, "INT"]],
[
3,
5,
0,
4,
5,
"INT"
]
],
"groups": [], "groups": [],
"config": {}, "config": {},
"extra": { "extra": {
"ds": { "ds": {
"scale": 1.9487171000000016, "scale": 1.9487171000000016,
"offset": [ "offset": [-325.57196748514497, -168.13150517966463]
-325.57196748514497,
-168.13150517966463
]
} }
}, },
"version": 0.4 "version": 0.4
} }

View File

@@ -5,10 +5,7 @@
{ {
"id": 4, "id": 4,
"type": "CheckpointLoaderSimple", "type": "CheckpointLoaderSimple",
"pos": [ "pos": [0, 92],
0,
92
],
"size": { "size": {
"0": 315, "0": 315,
"1": 98 "1": 98
@@ -26,10 +23,7 @@
{ {
"name": "CLIP", "name": "CLIP",
"type": "CLIP", "type": "CLIP",
"links": [ "links": [3, 5],
3,
5
],
"slot_index": 1 "slot_index": 1
}, },
{ {
@@ -42,17 +36,12 @@
"properties": { "properties": {
"Node name for S&R": "CheckpointLoaderSimple" "Node name for S&R": "CheckpointLoaderSimple"
}, },
"widgets_values": [ "widgets_values": ["3Guofeng3_v32Light.safetensors"]
"3Guofeng3_v32Light.safetensors"
]
}, },
{ {
"id": 6, "id": 6,
"type": "CLIPTextEncode", "type": "CLIPTextEncode",
"pos": [ "pos": [460, 92],
460,
92
],
"size": { "size": {
"0": 422.84503173828125, "0": 422.84503173828125,
"1": 164.31304931640625 "1": 164.31304931640625
@@ -85,10 +74,7 @@
{ {
"id": 7, "id": 7,
"type": "CLIPTextEncode", "type": "CLIPTextEncode",
"pos": [ "pos": [460, 368],
460,
368
],
"size": { "size": {
"0": 425.27801513671875, "0": 425.27801513671875,
"1": 180.6060791015625 "1": 180.6060791015625
@@ -114,17 +100,12 @@
"properties": { "properties": {
"Node name for S&R": "CLIPTextEncode" "Node name for S&R": "CLIPTextEncode"
}, },
"widgets_values": [ "widgets_values": ["text, watermark"]
"text, watermark"
]
}, },
{ {
"id": 10, "id": 10,
"type": "CheckpointLoaderSimple", "type": "CheckpointLoaderSimple",
"pos": [ "pos": [0, 276],
0,
276
],
"size": { "size": {
"0": 315, "0": 315,
"1": 98 "1": 98
@@ -155,39 +136,20 @@
"properties": { "properties": {
"Node name for S&R": "CheckpointLoaderSimple" "Node name for S&R": "CheckpointLoaderSimple"
}, },
"widgets_values": [ "widgets_values": ["3Guofeng3_v32Light.safetensors"]
"3Guofeng3_v32Light.safetensors"
]
} }
], ],
"links": [ "links": [
[ [3, 4, 1, 6, 0, "CLIP"],
3, [5, 4, 1, 7, 0, "CLIP"]
4,
1,
6,
0,
"CLIP"
],
[
5,
4,
1,
7,
0,
"CLIP"
]
], ],
"groups": [], "groups": [],
"config": {}, "config": {},
"extra": { "extra": {
"ds": { "ds": {
"scale": 1, "scale": 1,
"offset": [ "offset": [0, 0]
0,
0
]
} }
}, },
"version": 0.4 "version": 0.4
} }

View File

@@ -5,10 +5,7 @@
{ {
"id": 1, "id": 1,
"type": "KSampler", "type": "KSampler",
"pos": [ "pos": [590, 40],
590,
40
],
"size": { "size": {
"0": 315, "0": 315,
"1": 262 "1": 262
@@ -53,23 +50,12 @@
"properties": { "properties": {
"Node name for S&R": "KSampler" "Node name for S&R": "KSampler"
}, },
"widgets_values": [ "widgets_values": [0, "randomize", 20, 8, "euler", "normal", 1]
0,
"randomize",
20,
8,
"euler",
"normal",
1
]
}, },
{ {
"id": 4, "id": 4,
"type": "CLIPTextEncode", "type": "CLIPTextEncode",
"pos": [ "pos": [20, 50],
20,
50
],
"size": { "size": {
"0": 400, "0": 400,
"1": 200 "1": 200
@@ -88,26 +74,19 @@
{ {
"name": "CONDITIONING", "name": "CONDITIONING",
"type": "CONDITIONING", "type": "CONDITIONING",
"links": [ "links": [3],
3
],
"shape": 3 "shape": 3
} }
], ],
"properties": { "properties": {
"Node name for S&R": "CLIPTextEncode" "Node name for S&R": "CLIPTextEncode"
}, },
"widgets_values": [ "widgets_values": [""]
""
]
}, },
{ {
"id": 5, "id": 5,
"type": "CLIPTextEncode", "type": "CLIPTextEncode",
"pos": [ "pos": [20, 320],
20,
320
],
"size": { "size": {
"0": 400, "0": 400,
"1": 200 "1": 200
@@ -134,31 +113,17 @@
"properties": { "properties": {
"Node name for S&R": "CLIPTextEncode" "Node name for S&R": "CLIPTextEncode"
}, },
"widgets_values": [ "widgets_values": [""]
""
]
} }
], ],
"links": [ "links": [[3, 4, 0, 1, 1, "CONDITIONING"]],
[
3,
4,
0,
1,
1,
"CONDITIONING"
]
],
"groups": [], "groups": [],
"config": {}, "config": {},
"extra": { "extra": {
"ds": { "ds": {
"scale": 1, "scale": 1,
"offset": [ "offset": [0, 0]
0,
0
]
} }
}, },
"version": 0.4 "version": 0.4
} }

View File

@@ -8,10 +8,7 @@
"extra": { "extra": {
"ds": { "ds": {
"scale": 1, "scale": 1,
"offset": [ "offset": [0, 0]
0,
0
]
} }
}, },
"models": [ "models": [
@@ -22,4 +19,4 @@
} }
], ],
"version": 0.4 "version": 0.4
} }

Some files were not shown because too many files have changed in this diff Show More