From f6466d7062b15f335cc6813498e0ec9c876e7fc3 Mon Sep 17 00:00:00 2001
From: Chenlei Hu <huchenlei@proton.me>
Date: Wed, 9 Oct 2024 16:02:14 -0400
Subject: [PATCH] Avoid calling settingStore.set when there is no legacy node
 bookmark (#1191)

* Avoid calling settingStore.set when there is no legacy node bookmark

* nit
---
 src/stores/nodeBookmarkStore.ts | 31 +++++++++++++++++--------------
 1 file changed, 17 insertions(+), 14 deletions(-)

diff --git a/src/stores/nodeBookmarkStore.ts b/src/stores/nodeBookmarkStore.ts
index 091b5cb57..15047375f 100644
--- a/src/stores/nodeBookmarkStore.ts
+++ b/src/stores/nodeBookmarkStore.ts
@@ -15,21 +15,24 @@ export const useNodeBookmarkStore = defineStore('nodeBookmark', () => {
   const nodeDefStore = useNodeDefStore()
 
   const migrateLegacyBookmarks = () => {
-    settingStore
-      .get('Comfy.NodeLibrary.Bookmarks')
-      .forEach((bookmark: string) => {
-        // If the bookmark is a folder, add it as a bookmark
-        if (bookmark.endsWith('/')) {
-          addBookmark(bookmark)
-          return
-        }
-        const category = bookmark.split('/').slice(0, -1).join('/')
-        const displayName = bookmark.split('/').pop()
-        const nodeDef = nodeDefStore.nodeDefsByDisplayName[displayName]
+    const legacyBookmarks = settingStore.get('Comfy.NodeLibrary.Bookmarks')
+    if (!legacyBookmarks.length) {
+      return
+    }
 
-        if (!nodeDef) return
-        addBookmark(`${category === '' ? '' : category + '/'}${nodeDef.name}`)
-      })
+    legacyBookmarks.forEach((bookmark: string) => {
+      // If the bookmark is a folder, add it as a bookmark
+      if (bookmark.endsWith('/')) {
+        addBookmark(bookmark)
+        return
+      }
+      const category = bookmark.split('/').slice(0, -1).join('/')
+      const displayName = bookmark.split('/').pop()
+      const nodeDef = nodeDefStore.nodeDefsByDisplayName[displayName]
+
+      if (!nodeDef) return
+      addBookmark(`${category === '' ? '' : category + '/'}${nodeDef.name}`)
+    })
     settingStore.set('Comfy.NodeLibrary.Bookmarks', [])
   }