From f7bfb6ec574c655a2ef374dd2936d8bbbde2691b Mon Sep 17 00:00:00 2001 From: Christian Byrne Date: Fri, 21 Mar 2025 08:04:06 -0700 Subject: [PATCH] Fix Workflow Validation error when node pack 'unknown' version (#3179) --- src/schemas/comfyWorkflowSchema.ts | 7 ++++--- tests-ui/tests/comfyWorkflow.test.ts | 4 +++- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/src/schemas/comfyWorkflowSchema.ts b/src/schemas/comfyWorkflowSchema.ts index 1b9e0766b..b5ee16cb4 100644 --- a/src/schemas/comfyWorkflowSchema.ts +++ b/src/schemas/comfyWorkflowSchema.ts @@ -155,9 +155,10 @@ const zAuxId = z ) .transform(([username, repo]) => `${username}/${repo}`) -const zSemVer = z - .string() - .regex(semverPattern, 'Invalid semantic version (x.y.z)') +const zSemVer = z.union([ + z.string().regex(semverPattern, 'Invalid semantic version (x.y.z)'), + z.literal('unknown') +]) const zGitHash = z.string().regex(gitHashPattern, 'Invalid Git commit hash') const zVersion = z.union([zSemVer, zGitHash]) diff --git a/tests-ui/tests/comfyWorkflow.test.ts b/tests-ui/tests/comfyWorkflow.test.ts index a33d94501..dd17d14ae 100644 --- a/tests-ui/tests/comfyWorkflow.test.ts +++ b/tests-ui/tests/comfyWorkflow.test.ts @@ -176,7 +176,9 @@ describe('parseComfyWorkflow', () => { '0.1.0-alpha.1', '1.3.321', // Git hash - '080e6d4af809a46852d1c4b7ed85f06e8a3a72be' + '080e6d4af809a46852d1c4b7ed85f06e8a3a72be', + // Special case + 'unknown' ] it.each(validVersionStrings)('valid version: %s', async (ver) => { const workflow = JSON.parse(JSON.stringify(defaultGraph))