App mode - discard slow preview messages to prevent overwriting output image (#9261)

## Summary

Prevent latent previews received after the job/node has already finished
processing overwriting the actual output display

## Changes

- **What**: 
- updates job preview store to also track which node the preview was for
- updates linear progress tracking to store executed nodes enabling
skipping previews of these

## Review Focus

<!-- Critical design decisions or edge cases that need attention -->

<!-- If this PR fixes an issue, uncomment and update the line below -->
<!-- Fixes #ISSUE_NUMBER -->

## Screenshots (if applicable)

<!-- Add screenshots or video recording to help explain your changes -->

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-9261-App-mode-discard-slow-preview-messages-to-prevent-overwriting-output-image-3136d73d3650817884c2ce2ff5993b9e)
by [Unito](https://www.unito.io)
This commit is contained in:
pythongosssss
2026-02-27 18:58:41 +00:00
committed by GitHub
parent c090d189f0
commit f83daa6f3b
5 changed files with 265 additions and 29 deletions

View File

@@ -7,7 +7,7 @@ import type { ExecutedWsMessage } from '@/schemas/apiSchema'
import { ResultItemImpl } from '@/stores/queueStore'
const activeJobIdRef = ref<string | null>(null)
const previewsRef = ref<Record<string, string>>({})
const previewsRef = ref<Record<string, { url: string; nodeId?: string }>>({})
const isAppModeRef = ref(true)
const { apiTarget } = vi.hoisted(() => ({
@@ -30,7 +30,7 @@ vi.mock('@/stores/executionStore', () => ({
vi.mock('@/stores/jobPreviewStore', () => ({
useJobPreviewStore: () => ({
get previewsByPromptId() {
get nodePreviewsByPromptId() {
return previewsRef.value
}
})
@@ -63,12 +63,13 @@ function makeExecutedDetail(
promptId: string,
images: Array<Record<string, string>> = [
{ filename: 'out.png', subfolder: '', type: 'output' }
]
],
nodeId = '1'
): ExecutedWsMessage {
return {
prompt_id: promptId,
node: '1',
display_node: '1',
node: nodeId,
display_node: nodeId,
output: { images }
} as ExecutedWsMessage
}
@@ -329,7 +330,7 @@ describe('linearOutputStore', () => {
expect(store.selectedId).toBeNull()
})
it('transitions to latent via previewsByPromptId watcher', async () => {
it('transitions to latent via previews watcher', async () => {
vi.useFakeTimers()
const { nextTick } = await import('vue')
const store = useLinearOutputStore()
@@ -341,7 +342,9 @@ describe('linearOutputStore', () => {
expect(store.inProgressItems[0].state).toBe('skeleton')
// Simulate jobPreviewStore update
previewsRef.value = { 'job-1': 'blob:preview-1' }
previewsRef.value = {
'job-1': { url: 'blob:preview-1', nodeId: 'node-1' }
}
await nextTick()
vi.advanceTimersByTime(16)
@@ -487,6 +490,104 @@ describe('linearOutputStore', () => {
expect(store.inProgressItems).toHaveLength(0)
})
it('discards latent previews for already-executed nodes', () => {
vi.useFakeTimers()
const store = useLinearOutputStore()
store.onJobStart('job-1')
// Node 1 sends latent then executes
store.onLatentPreview('job-1', 'blob:node1-latent', '1')
vi.advanceTimersByTime(16)
store.onNodeExecuted('job-1', makeExecutedDetail('job-1', undefined, '1'))
// Stale latent for node 1 arrives after it already executed
store.onLatentPreview('job-1', 'blob:node1-stale', '1')
vi.advanceTimersByTime(16)
// Should not create a new latent item for the executed node
expect(
store.inProgressItems.filter((i) => i.state === 'latent')
).toHaveLength(0)
vi.useRealTimers()
})
it('accepts latent previews for new nodes after prior node executed', () => {
vi.useFakeTimers()
const store = useLinearOutputStore()
store.onJobStart('job-1')
// Node 1 executes
store.onNodeExecuted('job-1', makeExecutedDetail('job-1', undefined, '1'))
// Node 2 sends latent preview — should be accepted
store.onLatentPreview('job-1', 'blob:node2-latent', '2')
vi.advanceTimersByTime(16)
expect(
store.inProgressItems.filter((i) => i.state === 'latent')
).toHaveLength(1)
expect(store.inProgressItems[0].latentPreviewUrl).toBe('blob:node2-latent')
vi.useRealTimers()
})
it('cancels pending RAF when a node executes', () => {
vi.useFakeTimers()
const store = useLinearOutputStore()
store.onJobStart('job-1')
// Latent preview scheduled in RAF
store.onLatentPreview('job-1', 'blob:node1-latent')
// Node executes before RAF fires — should cancel it
store.onNodeExecuted('job-1', makeExecutedDetail('job-1', undefined, '1'))
vi.advanceTimersByTime(16)
// Only the image item, no latent
expect(
store.inProgressItems.filter((i) => i.state === 'latent')
).toHaveLength(0)
expect(
store.inProgressItems.filter((i) => i.state === 'image')
).toHaveLength(1)
vi.useRealTimers()
})
it('discards latent previews arriving after job completion', () => {
vi.useFakeTimers()
const store = useLinearOutputStore()
store.onJobStart('job-1')
store.onNodeExecuted('job-1', makeExecutedDetail('job-1'))
// Latent preview scheduled in RAF before job completes
store.onLatentPreview('job-1', 'blob:late')
store.onJobComplete('job-1')
// RAF fires after completion — should be cancelled
vi.advanceTimersByTime(16)
// No new latent items should have been created
expect(
store.inProgressItems.filter((i) => i.state === 'latent')
).toHaveLength(0)
vi.useRealTimers()
})
it('discards latent previews for completed job after RAF', () => {
vi.useFakeTimers()
const store = useLinearOutputStore()
store.onJobStart('job-1')
store.onNodeExecuted('job-1', makeExecutedDetail('job-1'))
store.onJobComplete('job-1')
// Late preview arrives after job already completed
store.onLatentPreview('job-1', 'blob:very-late')
vi.advanceTimersByTime(16)
expect(
store.inProgressItems.filter((i) => i.state === 'latent')
).toHaveLength(0)
vi.useRealTimers()
})
it('ignores executed events for other jobs', () => {
const store = useLinearOutputStore()
store.onJobStart('job-1')

View File

@@ -19,6 +19,7 @@ export const useLinearOutputStore = defineStore('linearOutput', () => {
const isFollowing = ref(true)
const trackedJobId = ref<string | null>(null)
const pendingResolve = ref(new Set<string>())
const executedNodeIds = new Set<string>()
let nextSeq = 0
@@ -40,6 +41,7 @@ export const useLinearOutputStore = defineStore('linearOutput', () => {
const currentSkeletonId = shallowRef<string | null>(null)
function onJobStart(jobId: string) {
executedNodeIds.clear()
const item: InProgressItem = {
id: makeItemId(jobId),
jobId,
@@ -53,7 +55,9 @@ export const useLinearOutputStore = defineStore('linearOutput', () => {
}
let raf: number | null = null
function onLatentPreview(jobId: string, url: string) {
function onLatentPreview(jobId: string, url: string, nodeId?: string) {
if (nodeId && executedNodeIds.has(nodeId)) return
// Issue in Firefox where it doesnt seem to always re-render, wrapping in RAF fixes it
if (raf) cancelAnimationFrame(raf)
raf = requestAnimationFrame(() => {
@@ -89,6 +93,11 @@ export const useLinearOutputStore = defineStore('linearOutput', () => {
function onNodeExecuted(jobId: string, detail: ExecutedWsMessage) {
const nodeId = String(detail.display_node || detail.node)
executedNodeIds.add(nodeId)
if (raf) {
cancelAnimationFrame(raf)
raf = null
}
const newOutputs = flattenNodeOutput([nodeId, detail.output])
if (newOutputs.length === 0) return
@@ -134,7 +143,14 @@ export const useLinearOutputStore = defineStore('linearOutput', () => {
}
function onJobComplete(jobId: string) {
if (raf) {
cancelAnimationFrame(raf)
raf = null
}
currentSkeletonId.value = null
if (trackedJobId.value === jobId) {
trackedJobId.value = null
}
const hasImages = inProgressItems.value.some(
(i) => i.jobId === jobId && i.state === 'image'
@@ -209,6 +225,7 @@ export const useLinearOutputStore = defineStore('linearOutput', () => {
cancelAnimationFrame(raf)
raf = null
}
executedNodeIds.clear()
inProgressItems.value = []
selectedId.value = null
isFollowing.value = true
@@ -231,13 +248,13 @@ export const useLinearOutputStore = defineStore('linearOutput', () => {
)
watch(
() => jobPreviewStore.previewsByPromptId,
() => jobPreviewStore.nodePreviewsByPromptId,
(previews) => {
if (!isAppMode.value) return
const jobId = executionStore.activeJobId
if (!jobId) return
const url = previews[jobId]
if (url) onLatentPreview(jobId, url)
const preview = previews[jobId]
if (preview) onLatentPreview(jobId, preview.url, preview.nodeId)
},
{ deep: true }
)