3 Commits

Author	SHA1	Message	Date
Christian Byrne	3cded2c45f	[fix] Remove unreliable CI wait logic from Claude review workflow (#6548) ... Removes the wait-for-ci job that has been causing random workflow skips and reliability issues due to race conditions with CI check creation. Multiple attempts to fix timing issues have resulted in ongoing edge cases, so this simplifies the workflow to run immediately when the claude-review label is added. Reviews can now run in parallel with CI checks, and while they may occasionally run on PRs with failing CI, the review feedback is often valuable regardless of CI status. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-6548-fix-Remove-unreliable-CI-wait-logic-from-Claude-review-workflow-29f6d73d36508125910ef4feba5abdf4) by [Unito](https://www.unito.io)	2025-11-02 13:41:36 -08:00
Christian Byrne	b3eee54abb	fix: claude-review bails on cancelled and skipped checks (#6316) ... ## Summary Expands the wait step in `pr-claude-review.yaml` so the `lewagon/wait-on-check-action` accepts every terminal GitHub conclusion instead of failing on outcomes like cancelled or failure. After the wait completes, the `check-status` script still inspects those check runs and only marks `should-proceed=true` when the tracked jobs finished successfully. Fixes what happened here: https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/18828179272/job/53714488799?pr=6298	2025-10-26 20:39:18 -07:00
snomiao	8cc5b52c64	refactor: reorganize GitHub workflows with consistent naming convention (#5891) ... ## Summary This PR implements a systematic naming convention for all GitHub workflows to improve organization and discoverability. All 22 workflows have been renamed and grouped by logical categories with consistent prefixes. ## Changes ### Naming Convention - **`ci-*`**: Continuous Integration workflows (testing, linting, validation) - **`pr-*`**: PR-specific automation triggered by labels - **`release-*`**: Release management workflows - **`types-*`**: TypeScript type generation workflows - **`i18n-*`**: Internationalization workflows ### Key Renames - `tests-ci.yaml` → `ci-tests-e2e.yaml` - `vitest-tests.yaml` → `ci-tests-unit.yaml` - `storybook-and-chromatic-ci.yaml` → `ci-tests-storybook.yaml` - `auto-backport.yaml` → `pr-backport.yaml` - `claude-pr-review.yml` → `pr-claude-review.yaml` - `version-bump.yaml` → `release-version-bump.yaml` - `publish-frontend-types.yaml` → `release-npm-types.yaml` - `create-dev-pypi-package.yaml` → `release-pypi-dev.yaml` ### Test Workflow Improvements - Grouped all test workflows under `ci-tests-*` pattern - Fork-safe deployment workflows: `ci-tests-e2e-forks.yaml`, `ci-tests-storybook-forks.yaml` - Added comments explaining fork deployment security workarounds ### Documentation - Added comprehensive `.github/workflows/README.md` - Documents naming conventions, best practices, and workflow organization - Includes trigger patterns and external dependencies ## Benefits 1. **Better Organization**: Workflows are now grouped logically by prefix 2. **Improved Discoverability**: Easy to find related workflows 3. **Consistent Naming**: All workflows follow the same pattern 4. **Clear Purpose**: Workflow names immediately indicate their function 5. **Maintainable**: README provides guidelines for future workflows ## Test Plan - [x] All workflow cross-references updated - [x] Display names match new file names - [x] Fork deployment workflows properly reference main workflows - [x] Release workflows reference correct npm types workflow - [x] All workflows retain original functionality 🤖 Generated with [Claude Code](https://claude.ai/code) ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-5891-refactor-reorganize-GitHub-workflows-with-consistent-naming-convention-2806d73d365081febe47c7511bf0507e) by [Unito](https://www.unito.io) --------- Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Alexander Brown <drjkl@comfy.org>	2025-10-17 08:32:33 +09:00