Comfy-Org/ComfyUI_frontend
1
0
Fork 0
mirror of https://github.com/Comfy-Org/ComfyUI_frontend.git synced 2026-02-07 08:30:06 +00:00
Code Issues Packages Projects Releases Wiki Activity
6,459 Commits 600 Branches 536 Tags
drjkl/debug/nodeDefs
Commit Graph

6459 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
bymyself
0910d485fd [Test] Fix flaky optional combo test (#2755) 2025-02-27 11:13:38 -07:00
Chenlei Hu
cdf42d5ad7 [Refactor] Move zod schemas to schemas/ folder (#2753) 2025-02-27 13:05:01 -05:00
filtered
fab386275c [Refactor] Clean up LGraphNode ahead of TS strict (#641) 
Preparation for TS strict conversion. Simplifies code & improves
readability.
 2025-02-27 17:55:11 +00:00
Chenlei Hu
96f02dbf80 [Refactor] Use util.clone in mergeIfValid (#2752) 2025-02-27 11:47:56 -05:00
filtered
38dd7b7089 [Refactor] Prefer for..of to incremental for loops (#640) 
- Converts incremental for loops to for..of loops
- Improves readability
 2025-02-27 16:28:10 +00:00
bymyself
f9157ee05f Update workflow schema to include node pack ID and version (#2751) 2025-02-27 11:15:31 -05:00
filtered
be8dc6867e [Refactor] Prefer event listeners to callback props (#637) 
N.B.: `onerror` replacement is not a `window` or `Element` instance.
 2025-02-27 14:50:39 +00:00
Terry Jia
cb6f2e4398 [3d] fix preview camera not sync up issue (#2747) 2025-02-27 08:42:07 -05:00
bymyself
71f3f720bf Lower floor on max history items setting (#2748) 2025-02-27 08:41:50 -05:00
filtered
97bf9de83a [Refactor] Standardise code style - modern JS (#636) 
Uses unicorn rules to auto-refactor code.  All verified.
 2025-02-27 13:13:32 +00:00
filtered
6737828a2b Lint module entry point (#635) 
- Adds module entry point tests
- Manually resolved lint rules for module entry point imports / exports
(autofix could not resolve without causing issues)
 2025-02-27 12:02:03 +00:00
filtered
984bd8696c [Dev] Reverse unicorn lint config - on by default (#633) 
Sets unicorn linter recommended rules on by default, with individual
rules disabled.

- Issue to track removal of these rules: #629
 2025-02-27 10:50:10 +00:00
filtered
2d9c811aa9 [Cleanup] Remove downstream type (#632) 
Removes group node type. Now exists downstream where it is used.
 2025-02-27 10:38:24 +00:00
filtered
0d8e0fce17 [Refactor] Fix assignment of this to const (#631) 
Refactors using arrows funcs or storing the once-off requirement as an
action, removing the need to dereference this inside the function.
 2025-02-27 10:32:53 +00:00
filtered
2104f2a8a9 [Refactor] Prefer textContent over innerText (#630) 
Only setters are used, so getter differences aren't involved. This may
result in a runtime change to consumers passing a Node that isn't
actually a HTMLElement.
 2025-02-27 10:11:07 +00:00
filtered
1e8938ceff Add unicorn lint rules - DOM built-in functions (#628) 
- Prefer append(), remove(), replaceAll()
- Wrap nested ternaries in parenthesis
 2025-02-27 09:18:25 +00:00
filtered
6f51767451 Add ESLint unicorn plugin (#627) 
Rules disabled by default to allow incremental integration.
 2025-02-27 08:41:51 +00:00
Chenlei Hu
d1fead298f [Revert] Restrict applyToGraph to PrimitiveNode (#2746) 2025-02-26 22:29:13 -05:00
Chenlei Hu
0bc66965f0 [Cleanup] Remove LiteGraph global type declarations (#2745) 2025-02-26 21:50:41 -05:00
Terry Jia
e843f53799 [3d] temp fix preview camera not sync up (#2743) 2025-02-26 21:39:19 -05:00
Chenlei Hu
0259befcdd 1.11.4 (#2744) v1.11.4 2025-02-26 20:20:53 -05:00
Chenlei Hu
3662938080 Update litegraph 0.8.98 (#2742) 2025-02-26 20:10:10 -05:00
Chenlei Hu
9c8cc571e2 0.8.98 (#626) 
Automated version bump to 0.8.98
 2025-02-26 19:58:05 -05:00
Chenlei Hu
ab9c65f28b Type widgetInputs (#2741) 2025-02-26 18:01:56 -05:00
Chenlei Hu
e8c238b70e Update serialisation.ts (#624) 
Update ISerialisedNodeInputSlot.widget type. Overwrite original widget
prop type.
 2025-02-26 16:40:36 -05:00
Chenlei Hu
bdfa2efa50 [BugFix] Remove outputs.animated in queueStore (#2740) 2025-02-26 16:04:01 -05:00
Miguel C
fbcc396880 Knob (#600) 
Resolved issues with history due to merges, opened a new pull request.
A more visual widget that the usual number/slider. Differentiates itself
from the functionality of a slider by not setting the value on click,
only stepping, emulating an actual knob.

- Left/Right takes 1 step at a time
- Up/Down moves 1% or 1 step, whichever is larger
- Move + Shift moves by 10% or 1 step, whichever is larger

This also includes a fixes to some size logic.
- [x] ~~Still missing being able to drag the knob itself, as the
clicking of the widget is not recognized if it's outside of where a
normal height widget would be.~~

![knob-node](https://github.com/user-attachments/assets/9d0ce70d-a220-49d0-987f-8dcef2b1d299)
 2025-02-26 15:07:32 -05:00
Chenlei Hu
963e4b0904 [Type] Mark name as required prop for IBaseWidget (#623) 2025-02-26 15:03:31 -05:00
Chenlei Hu
d20aab757c Serialize NodeInputSlot.widget (#622) 
Serialize linked widget on node input slot properly according to current
save format in
76818b54e6/src/extensions/core/widgetInputs.ts
 2025-02-26 14:15:31 -05:00
Silver
1c408d2f6a replace colorSelect.png cursor (#2738) 2025-02-26 14:13:50 -05:00
bymyself
76818b54e6 Fix widget label extraction (#2737) 2025-02-26 13:44:05 -05:00
Chenlei Hu
2d41aed051 [BugFix] Properly update color button color on first selection (#2736) 2025-02-26 13:43:09 -05:00
filtered
c166a34fd8 Add ESLint rules to enforce existing lib style (#621) 
Adds a few rules that enforce consistency across the repo.

Only change is one top-level const arrow function is now a function
definition.
 2025-02-26 18:12:26 +00:00
Miguel C
7e6b64f216 Fix widget sizing logic in LGraphCanvas and LGraphNode (#609) 
This fixes an issue with widget heights not coinciding with actual
computed heights.
<img
src="https://github.com/user-attachments/assets/50b4b86c-8de8-4844-9a17-6f18d32e7f5e"
height="128" alt="old">old
<img
src="https://github.com/user-attachments/assets/c34e432a-6941-469e-99cd-df15c0a527de"
height="256" alt="new">new
 2025-02-26 10:56:30 -05:00
Chenlei Hu
939e9c0a2f Update devtools ref (#620) 
Sync https://github.com/Comfy-Org/ComfyUI_frontend/pull/2733
 2025-02-26 10:56:19 -05:00
bymyself
237b895e8b Add thumbnails for workflow templates (#2729) 
Co-authored-by: github-actions <github-actions@github.com>
 2025-02-26 10:39:27 -05:00
bymyself
e2087d2a7b Add node to default/tutorial workflow with link to getting started page of docs (#2734) 2025-02-26 10:35:40 -05:00
bymyself
74e8852958 Fix combo values from optional inputs not changed when refreshing (#2733) 2025-02-26 10:35:22 -05:00
filtered
0e9b8b03b7 Enforce curly braces in multi-line if statements (#619) 
Removes formatters' ability to print code that goes to a new line, but
uses no braces to delineate.

It becomes more difficult to follow when using JS-style indents (two
spaces).

No effort required - braces added by auto-fixer.
 2025-02-26 15:08:23 +00:00
filtered
a43109d58a [TS] Use strict mode in ContextMenu (#618) 
- Adds minor type coercions to resolve type errors
- Uses the same type-coercion behaviour of the target DOM object
properties
- Resolves a long-standing type issue in context menu interfaces
(converts to generic - `unknown` by default)
- Fixes several incorrect types
- Adds ts-ignore that must be removed later
 2025-02-26 14:29:45 +00:00
filtered
3040924d76 [TS] Use strict mode in CanvasPointer, measure, and polyfills (#617) 
- Adds runtime type guard
- Adds ts-ignore that must be removed later
  * [ ] #578
 2025-02-26 13:05:40 +00:00
filtered
0b59c00597 [API] Remove deprecated: DragAndScale mouse (#615) 
Removed unused public methods (unmaintained, non-functional):
- bindEvents
- onMouse

`onredraw` is in use by extension authors.

This file now passes TS strict checks.
 2025-02-26 11:59:12 +00:00
filtered
6224d2dc06 [Cleanup] Update ESLint rules with stricter auto-fixes (#614) 
Stylistic plugin falls short in a few areas when it comes to consistent
lists and chaining. Replaced some key rules with antfu's personal
variants.

`eslint` can now be run repo-wide without params.
 2025-02-26 11:12:03 +00:00
filtered
867b9ed316 [nit] Add consistent method chaining linter (#613) 
Enforces that chained accessed should **either** all be on one line, or
all on individual lines (same as imports).
 2025-02-26 10:11:11 +00:00
filtered
5cdd0581fa Add import / export sort rules (#612) 
- Adds ESLint package
- Applies import/export rules to all files
- Uses newline delineated grouping, with type-only imports first
 2025-02-26 09:21:33 +00:00
filtered
9ded97d189 [Doc] Add JSDoc linter & general comment clean up (#611) 
- Prefer comments above lines over end-of-line comments
  - Makes auto-formatting easier
  - Subjective, but it is generally easier to read in JS
- Standardises JSdoc format
- Auto-fixes for many issues (applies on save w/ESLint extension)
 2025-02-26 08:54:18 +00:00
filtered
d849fcd00c [Dev] Make it easier to toggle strict mode (#610) 
nit: Allows uncomment instead of typing true every time.
 2025-02-26 06:16:56 +00:00
Chenlei Hu
3c196f8f97 1.11.3 (#2731) v1.11.3 2025-02-25 21:40:17 -05:00
Chenlei Hu
6dbdde6491 Update litegraph 0.8.97 (#2730) 2025-02-25 21:40:07 -05:00
Chenlei Hu
7fab99b362 0.8.97 (#608) 
Automated version bump to 0.8.97
 2025-02-25 21:26:49 -05:00